Re: Bogus struct page layout on 32-bit

2021-04-09 Thread Jesper Dangaard Brouer
On Sat, 10 Apr 2021 03:43:13 +0100 Matthew Wilcox wrote: > On Sat, Apr 10, 2021 at 06:45:35AM +0800, kernel test robot wrote: > > >> include/linux/mm_types.h:274:1: error: static_assert failed due to > > >> requirement '__builtin_offsetof(struct page, lru) == > > >> __builtin_offsetof(struct fo

Re: [PATCH net-next] net: dsa: mt7530: Add support for EEE features

2021-04-09 Thread DENG Qingfang
Hi René, On Sat, Apr 10, 2021 at 6:54 AM René van Dorst wrote: > --- a/drivers/net/dsa/mt7530.c > +++ b/drivers/net/dsa/mt7530.c > @@ -2568,6 +2568,11 @@ static void mt753x_phylink_mac_link_up(struct > dsa_switch *ds, int port, > mcr |= PMCR_TX_FC_EN; > if

Re: [PATCH net-next 0/7] net: ipa: a few small fixes

2021-04-09 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Fri, 9 Apr 2021 13:07:15 -0500 you wrote: > This series implements some minor bug fixes or improvements. > > The first patch removes an apparently unnecessary restriction, which > results in an error on a 32-bit ARM b

[PATCH -next] Bluetooth: use flexible-array member instead of zero-length array

2021-04-09 Thread Qiheng Lin
Fix the following coccicheck warning: net/bluetooth/msft.c:37:6-13: WARNING use flexible-array member instead net/bluetooth/msft.c:42:6-10: WARNING use flexible-array member instead net/bluetooth/msft.c:52:6-10: WARNING use flexible-array member instead Signed-off-by: Qiheng Lin --- net/bluetoo

Re: [PATCH net-next] enetc: Use generic rule to map Tx rings to interrupt vectors

2021-04-09 Thread Jakub Kicinski
On Fri, 9 Apr 2021 13:19:52 +0300 Vladimir Oltean wrote: > On Fri, Apr 09, 2021 at 10:16:13AM +0300, Claudiu Manoil wrote: > > Even if the current mapping is correct for the 1 CPU and 2 CPU cases > > (currently enetc is included in SoCs with up to 2 CPUs only), better > > use a generic rule for the

Re: [PATCH net-next] net: enetc: fix TX ring interrupt storm

2021-04-09 Thread Jakub Kicinski
On Sat, 10 Apr 2021 00:29:23 +0300 Claudiu Manoil wrote: > On 09.04.2021 22:27, Vladimir Oltean wrote: > > From: Vladimir Oltean > > > > The blamed commit introduced a bit in the TX software buffer descriptor > > structure for determining whether a BD is final or not; we rearm the TX > > interrup

Re: [pull-request][net-next][rdma-next] mlx5-next 2021-04-09

2021-04-09 Thread Jakub Kicinski
On Fri, 9 Apr 2021 13:07:04 -0700 Saeed Mahameed wrote: > Hi Dave, Jakub, Jason, > > This pr contains changes from mlx5-next branch, > already reviewed on netdev and rdma mailing lists, links below. > > 1) From Leon, Dynamically assign MSI-X vectors count > Already Acked by Bjorn Helgaas. > htt

Re: [PATCH net-next 0/3] net: make PHY PM ops a no-op if MAC driver manages PHY PM

2021-04-09 Thread Jakub Kicinski
On Wed, 7 Apr 2021 17:50:46 +0200 Heiner Kallweit wrote: > Resume callback of the PHY driver is called after the one for the MAC > driver. The PHY driver resume callback calls phy_init_hw(), and this is > potentially problematic if the MAC driver calls phy_start() in its resume > callback. One issu

Re: [PATCH net-next 2/4] ixgbe: aggregate of all receive errors through netdev's rx_errors

2021-04-09 Thread Jakub Kicinski
On Fri, 9 Apr 2021 12:03:12 -0700 Tony Nguyen wrote: > From: Radoslaw Tyl > > The global rx error does not take into account all the error counters > that are counted by device. > > Extend rx error with the following counters: > - illegal byte error > - number of receive fragment errors > - rec

Re: [PATCH net-next 2/3] net: use skb_for_each_frag() helper where possible

2021-04-09 Thread Matteo Croce
On Fri, Apr 9, 2021 at 11:28 PM Jakub Kicinski wrote: > > On Fri, 9 Apr 2021 22:44:50 +0200 Matteo Croce wrote: > > > What pops to mind (although quite nit picky) is the question if the > > > assembly changes much between driver which used to cache nr_frags and > > > now always going skb_shinfo(sk

Re: [PATCH net-next v2 1/1] net: stmmac: Add support for external trigger timestamping

2021-04-09 Thread Jakub Kicinski
Other than the minor nit below LGTM. Let's give Richard one more day. On Thu, 8 Apr 2021 01:04:42 +0800 Wong Vee Khee wrote: > +static void timestamp_interrupt(struct stmmac_priv *priv) > +{ > + struct ptp_clock_event event; > + unsigned long flags; > + u32 num_snapshot; > + u32 t

Re: [PATCH net-next] cxgb4: remove unneeded if-null-free check

2021-04-09 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 9 Apr 2021 19:53:39 +0800 you wrote: > Eliminate the following coccicheck warning: > > drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32.c:529:3-9: WARNING: > NULL check before some freeing functions is not needed.

Re: [PATCH net-next] Revert "tcp: Reset tcp connections in SYN-SENT state"

2021-04-09 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 9 Apr 2021 10:02:37 -0700 you wrote: > From: Eric Dumazet > > This reverts commit e880f8b3a24a73704731a7227ed5fee14bd90192. > > 1) Patch has not been properly tested, and is wrong [1] > 2) Patch submission did n

Re: [PATCH net-next] net: dccp: use net_generic storage

2021-04-09 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Thu, 8 Apr 2021 19:45:02 +0200 you wrote: > DCCP is virtually never used, so no need to use space in struct net for it. > > Put the pernet ipv4/v6 socket in the dccp ipv4/ipv6 modules instead. > > Signed-off-by: Flori

Re: [PATCH net-next] net: enetc: fix array underflow in error handling code

2021-04-09 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 9 Apr 2021 15:24:28 +0300 you wrote: > This loop will try to unmap enetc_unmap_tx_buff[-1] and crash. > > Fixes: 9d2b68cc108d ("net: enetc: add support for XDP_REDIRECT") > Signed-off-by: Dan Carpenter > --- > dr

Re: [PATCH net-next v3 3/5] page_pool: Allow drivers to hint on SKB recycling

2021-04-09 Thread Matteo Croce
On Sat, Apr 10, 2021 at 2:11 AM Ilias Apalodimas wrote: > > Hi Matteo, > > [...] > > +bool page_pool_return_skb_page(void *data); > > + > > struct page_pool *page_pool_create(const struct page_pool_params *params); > > > > #ifdef CONFIG_PAGE_POOL > > @@ -243,4 +247,13 @@ static inline void page_

Re: [PATCH net-next 8/9] igc: Enable RX via AF_XDP zero-copy

2021-04-09 Thread Jakub Kicinski
On Fri, 9 Apr 2021 09:43:50 -0700 Tony Nguyen wrote: > From: Andre Guedes > > Add support for receiving packets via AF_XDP zero-copy mechanism. > > Add a new flag to 'enum igc_ring_flags_t' to indicate the ring has > AF_XDP zero-copy enabled so proper ring setup is carried out during ring > con

Re: [PATCH net-next 2/3] net: use skb_for_each_frag() helper where possible

2021-04-09 Thread kernel test robot
Hi Matteo, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Matteo-Croce/introduce-skb_for_each_frag/20210410-020828 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 44

Re: [PATCH net-next v3 3/5] page_pool: Allow drivers to hint on SKB recycling

2021-04-09 Thread Ilias Apalodimas
Hi Matteo, [...] > +bool page_pool_return_skb_page(void *data); > + > struct page_pool *page_pool_create(const struct page_pool_params *params); > > #ifdef CONFIG_PAGE_POOL > @@ -243,4 +247,13 @@ static inline void page_pool_ring_unlock(struct > page_pool *pool) > spin_unlock_b

Re: [PATCH] nfc: pn533: remove redundant assignment

2021-04-09 Thread Jakub Kicinski
On Fri, 9 Apr 2021 19:50:09 +0800 samirweng1979 wrote: > From: wengjianfeng > > In many places,first assign a value to a variable and then return > the variable. which is redundant, we should directly return the value. > in pn533_rf_field funciton,return statement in the if statement is > redund

UX: ip netns, ip route del [...] is tedious

2021-04-09 Thread deliciouslytyped
Hello list, 1) `ip netns` requires network namespaces to be symlinked in /var/run/netns to be recognized. Several containerization tools seem to omit that, and besides, the system appears to have no obligation to maintain those symlinks. This means `ip netns` is not useful at best, misleading

[PATCH net-next] net: dsa: mt7530: Add support for EEE features

2021-04-09 Thread René van Dorst
This patch adds EEE support. Signed-off-by: René van Dorst --- drivers/net/dsa/mt7530.c | 50 drivers/net/dsa/mt7530.h | 16 - 2 files changed, 65 insertions(+), 1 deletion(-) diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c i

Re: [PATCH v2 1/1] kernel.h: Split out panic and oops helpers

2021-04-09 Thread Thomas Bogendoerfer
On Fri, Apr 09, 2021 at 01:02:50PM +0300, Andy Shevchenko wrote: > kernel.h is being used as a dump for all kinds of stuff for a long time. > Here is the attempt to start cleaning it up by splitting out panic and > oops helpers. > > There are several purposes of doing this: > - dropping dependency

[PATCH net-next v3 5/5] mvneta: recycle buffers

2021-04-09 Thread Matteo Croce
From: Matteo Croce Use the new recycling API for page_pool. In a drop rate test, the packet rate increased di 10%, from 269 Kpps to 296 Kpps. perf top on a stock system shows: Overhead Shared Object Symbol 21.78% [kernel] [k] __pi___inval_dcache_area 21.66% [mvneta]

[PATCH net-next v3 3/5] page_pool: Allow drivers to hint on SKB recycling

2021-04-09 Thread Matteo Croce
From: Ilias Apalodimas Up to now several high speed NICs have custom mechanisms of recycling the allocated memory they use for their payloads. Our page_pool API already has recycling capabilities that are always used when we are running in 'XDP mode'. So let's tweak the API and the kernel networ

[PATCH net-next v3 4/5] mvpp2: recycle buffers

2021-04-09 Thread Matteo Croce
From: Matteo Croce Use the new recycling API for page_pool. In a drop rate test, the packet rate is more than doubled, from 962 Kpps to 2047 Kpps. perf top on a stock system shows: Overhead Shared Object Symbol 30.67% [kernel] [k] page_pool_release_page 8.37% [kernel]

[PATCH net-next v3 2/5] mm: add a signature in struct page

2021-04-09 Thread Matteo Croce
From: Matteo Croce This is needed by the page_pool to avoid recycling a page not allocated via page_pool. Signed-off-by: Matteo Croce --- include/linux/mm_types.h | 1 + include/net/page_pool.h | 2 ++ net/core/page_pool.c | 4 3 files changed, 7 insertions(+) diff --git a/include/l

[PATCH net-next v3 1/5] xdp: reduce size of struct xdp_mem_info

2021-04-09 Thread Matteo Croce
From: Jesper Dangaard Brouer It is possible to compress/reduce the size of struct xdp_mem_info. This change reduce struct xdp_mem_info from 8 bytes to 4 bytes. The member xdp_mem_info.id can be reduced to u16, as the mem_id_ht rhashtable in net/core/xdp.c is already limited by MEM_ID_MAX=0xFFFE

[PATCH net-next v3 0/5] page_pool: recycle buffers

2021-04-09 Thread Matteo Croce
From: Matteo Croce This is a respin of [1] This patchset shows the plans for allowing page_pool to handle and maintain DMA map/unmap of the pages it serves to the driver. For this to work a return hook in the network core is introduced. The overall purpose is to simplify drivers, by providing

Re: [GIT PULL] Networking for 5.12-rc7

2021-04-09 Thread pr-tracker-bot
The pull request you sent on Fri, 9 Apr 2021 14:48:03 -0700: > git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git tags/net-5.12-rc7 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/4e04e7513b0fa2fe8966a1c83fb473f1667e2810 Thank you! -- Deet-doot-dot, I am a

[GIT PULL] Networking for 5.12-rc7

2021-04-09 Thread Jakub Kicinski
The following changes since commit 002322402dafd846c424ffa9240a937f49b48c42: Merge branch 'akpm' (patches from Andrew) (2021-03-25 11:43:43 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git tags/net-5.12-rc7 for you to fetch changes

Re: [PATCH net-next] net: enetc: fix TX ring interrupt storm

2021-04-09 Thread Claudiu Manoil
On 09.04.2021 22:27, Vladimir Oltean wrote: From: Vladimir Oltean The blamed commit introduced a bit in the TX software buffer descriptor structure for determining whether a BD is final or not; we rearm the TX interrupt vector for every frame (hence final BD) transmitted. But there is a proble

Re: [PATCH net-next 2/3] net: use skb_for_each_frag() helper where possible

2021-04-09 Thread Jakub Kicinski
On Fri, 9 Apr 2021 22:44:50 +0200 Matteo Croce wrote: > > What pops to mind (although quite nit picky) is the question if the > > assembly changes much between driver which used to cache nr_frags and > > now always going skb_shinfo(skb)->nr_frags? It's a relatively common > > pattern. > > Since

Re: [PATCH net-next 2/3] net: use skb_for_each_frag() helper where possible

2021-04-09 Thread kernel test robot
Hi Matteo, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Matteo-Croce/introduce-skb_for_each_frag/20210410-020828 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 44

Re: 5.?? regression: strace testsuite OOpses kernel on ia64

2021-04-09 Thread Sergei Trofimovich
On Tue, 23 Feb 2021 18:53:21 + Sergei Trofimovich wrote: > The crash seems to be related to sock_filter-v test from strace: > https://github.com/strace/strace/blob/master/tests/seccomp-filter-v.c > > Here is an OOps: > > [ 818.089904] BUG: Bad page map in process sock_filter-v pte:000

Re: [PATCH net-next 2/3] net: use skb_for_each_frag() helper where possible

2021-04-09 Thread Matteo Croce
On Fri, Apr 9, 2021 at 8:54 PM Jakub Kicinski wrote: > > On Fri, 9 Apr 2021 20:06:04 +0200 Matteo Croce wrote: > > From: Matteo Croce > > > > use the new helper macro skb_for_each_frag() which allows to iterate > > through all the SKB fragments. > > > > The patch was created with Coccinelle, thi

[PATCH net-next 4/4] net: ipa: add IPA v4.11 configuration data

2021-04-09 Thread Alex Elder
Add support for the SC7280 SoC, which includes IPA version 4.11. Signed-off-by: Alex Elder --- drivers/net/ipa/Makefile | 2 +- drivers/net/ipa/ipa_data-v4.11.c | 382 +++ drivers/net/ipa/ipa_data.h | 1 + drivers/net/ipa/ipa_main.c | 4 + 4

[PATCH net-next 3/4] net: ipa: add IPA v4.5 configuration data

2021-04-09 Thread Alex Elder
Add support for the SDX55 SoC, which includes IPA version 4.5. Starting with IPA v4.5, a few of the memory regions have a different number of "canary" values; update comments in the where the region identifers are defined to accurately reflect that. I'll note three differences in SDX55 versus the

[PATCH net-next 2/4] net: ipa: disable checksum offload for IPA v4.5+

2021-04-09 Thread Alex Elder
Checksum offload for IPA v4.5+ is implemented differently, using "inline" offload (which uses a common header format for both upload and download offload). The IPA hardware must be programmed to enable MAP checksum offload, but the RMNet driver is responsible for interpreting checksum metadata sup

[PATCH net-next 1/4] dt-bindings: net: qcom,ipa: add some compatible strings

2021-04-09 Thread Alex Elder
Add existing supported platform "qcom,sc7180-ipa" to the set of IPA compatible strings. Also add newly-supported "qcom,sdx55-ipa", "qcom,sc7280-ipa". Signed-off-by: Alex Elder --- Documentation/devicetree/bindings/net/qcom,ipa.yaml | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) dif

[PATCH net-next 0/4] net: ipa: support two more platforms

2021-04-09 Thread Alex Elder
This series adds IPA support for two more Qualcomm SoCs. The first patch updates the DT binding to add compatible strings. The second temporarily disables checksum offload support for IPA version 4.5 and above. Changes are required to the RMNet driver to support the "inline" checksum offload use

Re: [PATCH net-next v2 3/5] page_pool: Allow drivers to hint on SKB recycling

2021-04-09 Thread Jesper Dangaard Brouer
On Fri, 9 Apr 2021 22:01:51 +0300 Ilias Apalodimas wrote: > On Fri, Apr 09, 2021 at 11:56:48AM -0700, Jakub Kicinski wrote: > > On Fri, 2 Apr 2021 20:17:31 +0200 Matteo Croce wrote: > > > Co-developed-by: Jesper Dangaard Brouer > > > Co-developed-by: Matteo Croce > > > Signed-off-by: Ilias A

Re: [PATCH net-next v2 3/5] page_pool: Allow drivers to hint on SKB recycling

2021-04-09 Thread Ilias Apalodimas
On Fri, Apr 09, 2021 at 12:29:29PM -0700, Jakub Kicinski wrote: > On Fri, 9 Apr 2021 22:01:51 +0300 Ilias Apalodimas wrote: > > On Fri, Apr 09, 2021 at 11:56:48AM -0700, Jakub Kicinski wrote: > > > On Fri, 2 Apr 2021 20:17:31 +0200 Matteo Croce wrote: > > > > Co-developed-by: Jesper Dangaard Bro

Re: [PATCH v8 bpf-next 00/14] mvneta: introduce XDP multi-buffer support

2021-04-09 Thread Lorenzo Bianconi
> Lorenzo Bianconi wrote: [...] > > I just read the commit messages for v8 so far. But, I'm still wondering how > to handle use cases where we want to put extra bytes at the end of the > packet, or really anywhere in the general case. We can extend tail with above > is there anyway to then write

Re: [RFC PATCH 0/2] MIIM regmap and RTL8231 GPIO expander support

2021-04-09 Thread Andrew Lunn
On Fri, Apr 09, 2021 at 07:42:32AM +0200, Sander Vanheule wrote: > Hi Andrew, > > Thank you for the feedback. You can find a (leaked) datasheet at: > https://github.com/libc0607/Realtek_switch_hacking/blob/files/RTL8231_Datasheet_1.2.pdf So this is not really an MFD. It has different ways of maki

[pull-request][net-next][rdma-next] mlx5-next 2021-04-09

2021-04-09 Thread Saeed Mahameed
Hi Dave, Jakub, Jason, This pr contains changes from mlx5-next branch, already reviewed on netdev and rdma mailing lists, links below. 1) From Leon, Dynamically assign MSI-X vectors count Already Acked by Bjorn Helgaas. https://patchwork.kernel.org/project/netdevbpf/cover/20210314124256.70253-1-

Re: [PATCH net v1] lan743x: fix ethernet frame cutoff issue

2021-04-09 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Thu, 8 Apr 2021 20:39:04 -0400 you wrote: > From: Sven Van Asbroeck > > The ethernet frame length is calculated incorrectly. Depending on > the value of RX_HEAD_PADDING, this may result in ethernet frames > that are too sh

Re: [PATCH net] net: hns3: Trivial spell fix in hns3 driver

2021-04-09 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Fri, 9 Apr 2021 08:42:23 +0100 you wrote: > Some trivial spelling mistakes which caught my eye during the > review of the code. > > Signed-off-by: Salil Mehta > --- > drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c

Re: [PATCH net v2] net: fix hangup on napi_disable for threaded napi

2021-04-09 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Fri, 9 Apr 2021 17:24:17 +0200 you wrote: > napi_disable() is subject to an hangup, when the threaded > mode is enabled and the napi is under heavy traffic. > > If the relevant napi has been scheduled and the napi_disable()

Re: [GIT PULL] vdpa/mlx5: last minute fixes

2021-04-09 Thread pr-tracker-bot
The pull request you sent on Fri, 9 Apr 2021 12:48:16 -0400: > https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/189fefc7a4f0401d0f799de96b772319a6541fc1 Thank you! -- Deet-doot-dot, I am a bo

RE: [PATCH net] ixgbe: fix unbalanced device enable/disable in suspend/resume

2021-04-09 Thread Switzer, David
>-Original Message- >From: Yongxin Liu >Sent: Monday, March 22, 2021 12:15 AM >To: vaibhavgupt...@gmail.com; andrewx.bow...@intel.com; Nguyen, Anthony >L >Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org; >da...@davemloft.net; Brandeburg, Jesse ; intel- >wired-...@lists.osuosl.o

Re: [PATCH v2 1/1] kernel.h: Split out panic and oops helpers

2021-04-09 Thread Helge Deller
On 4/9/21 12:02 PM, Andy Shevchenko wrote: kernel.h is being used as a dump for all kinds of stuff for a long time. Here is the attempt to start cleaning it up by splitting out panic and oops helpers. There are several purposes of doing this: - dropping dependency in bug.h - dropping a loop by m

RE: [syzbot] WARNING: refcount bug in sk_psock_get

2021-04-09 Thread John Fastabend
syzbot wrote: > Hello, > > syzbot found the following issue on: > > HEAD commit:9c54130c Add linux-next specific files for 20210406 > git tree: linux-next > console output: https://syzkaller.appspot.com/x/log.txt?x=17d8d7aad0 > kernel config: https://syzkaller.appspot.com/x/.config

Re: [RFC PATCH 1/2] regmap: add miim bus support

2021-04-09 Thread Andrew Lunn
On Fri, Apr 09, 2021 at 07:16:42PM +0100, Mark Brown wrote: > On Fri, Apr 09, 2021 at 08:14:22PM +0200, Sander Vanheule wrote: > > > The kernel has the mii_bus struct to describe the bus master, but like > > you noted the bus is generaly refered to as an MDIO interface. I'm fine > > with naming it

Re: [net-next, v2, 2/2] enetc: support PTP Sync packet one-step timestamping

2021-04-09 Thread Jakub Kicinski
On Fri, 9 Apr 2021 22:32:49 +0300 Claudiu Manoil wrote: > On 09.04.2021 19:09, Jakub Kicinski wrote: > > On Fri, 9 Apr 2021 06:37:53 + Claudiu Manoil wrote: > >> Please try test_and_set_bit_lock()/ clear_bit_unlock() based on Jakub's > >> suggestion, and see if it works for you / whether it c

Re: [PATCH net v2 1/2] net: dsa: lantiq_gswip: Don't use PHY auto polling

2021-04-09 Thread Martin Blumenstingl
Hello Vladimir, On Fri, Apr 9, 2021 at 12:46 AM Vladimir Oltean wrote: > > On Thu, Apr 08, 2021 at 08:38:27PM +0200, Martin Blumenstingl wrote: > > PHY auto polling on the GSWIP hardware can be used so link changes > > (speed, link up/down, etc.) can be detected automatically. Internally > > GSWI

Re: [Patch bpf-next] sock_map: fix a potential use-after-free in sock_map_close()

2021-04-09 Thread John Fastabend
Cong Wang wrote: > On Thu, Apr 8, 2021 at 5:26 PM John Fastabend > wrote: > > > > Cong Wang wrote: > > > From: Cong Wang > > > > > > The last refcnt of the psock can be gone right after > > > sock_map_remove_links(), so sk_psock_stop() could trigger a UAF. > > > The reason why I placed sk_psock_

RE: [net PATCH] ixgbe: Fix NULL pointer dereference in ethtool loopback test

2021-04-09 Thread Switzer, David
>-Original Message- >From: Alexander Duyck >Sent: Monday, March 8, 2021 12:42 PM >To: intel-wired-...@lists.osuosl.org >Cc: Brandeburg, Jesse ; Nguyen, Anthony L >; netdev@vger.kernel.org >Subject: [net PATCH] ixgbe: Fix NULL pointer dereference in ethtool loopback >test > >From: Alexand

Re: [PATCH] phy: nxp-c45: add driver for tja1103

2021-04-09 Thread Andrew Lunn
On Fri, Apr 09, 2021 at 09:41:06PM +0300, Radu Pirea (NXP OSS) wrote: > Add driver for tja1103 driver and for future NXP C45 PHYs. So apart from c45 vs c22, how does this differ to nxp-tja11xx.c? Do we really want two different drivers for the same hardware? Can we combine them somehow? > +conf

Re: [net-next, v2, 2/2] enetc: support PTP Sync packet one-step timestamping

2021-04-09 Thread Claudiu Manoil
On 09.04.2021 19:09, Jakub Kicinski wrote: On Fri, 9 Apr 2021 06:37:53 + Claudiu Manoil wrote: On Thu, 8 Apr 2021 09:02:50 -0700 Jakub Kicinski wrote: if (priv->flags & ONESTEP_BUSY) { skb_queue_tail(&priv->tx_skbs, skb); re

Re: [PATCH] phy: nxp-c45: add driver for tja1103

2021-04-09 Thread Jakub Kicinski
On Fri, 9 Apr 2021 21:41:06 +0300 Radu Pirea (NXP OSS) wrote: > Add driver for tja1103 driver and for future NXP C45 PHYs. > > Signed-off-by: Radu Pirea (NXP OSS) drivers/net/phy/nxp-c45: struct mdio_device_id is 8 bytes. The last of 1 is: 0x10 0xb0 0x1b 0x00 0xf0 0xff 0xff 0xff FATAL: modpos

Re: [PATCH net-next v2 3/5] page_pool: Allow drivers to hint on SKB recycling

2021-04-09 Thread Jakub Kicinski
On Fri, 9 Apr 2021 22:01:51 +0300 Ilias Apalodimas wrote: > On Fri, Apr 09, 2021 at 11:56:48AM -0700, Jakub Kicinski wrote: > > On Fri, 2 Apr 2021 20:17:31 +0200 Matteo Croce wrote: > > > Co-developed-by: Jesper Dangaard Brouer > > > Co-developed-by: Matteo Croce > > > Signed-off-by: Ilias Apa

[PATCH net-next] net: enetc: fix TX ring interrupt storm

2021-04-09 Thread Vladimir Oltean
From: Vladimir Oltean The blamed commit introduced a bit in the TX software buffer descriptor structure for determining whether a BD is final or not; we rearm the TX interrupt vector for every frame (hence final BD) transmitted. But there is a problem with the patch: it replaced a condition whos

Re: [RFC] net: core: devlink: add port_params_ops for devlink port parameters altering

2021-04-09 Thread Samudrala, Sridhar
On 4/9/2021 11:37 AM, Jakub Kicinski wrote: On Fri, 9 Apr 2021 20:01:14 +0300 Vadym Kochan wrote: On Fri, Apr 09, 2021 at 09:51:13AM -0700, Samudrala, Sridhar wrote: On 4/9/2021 9:22 AM, Oleksandr Mazur wrote: I'd like to discuss a possibility of handling devlink port parameters with devlink p

Re: [PATCH] phy: nxp-c45: add driver for tja1103

2021-04-09 Thread Heiner Kallweit
On 09.04.2021 20:41, Radu Pirea (NXP OSS) wrote: > Add driver for tja1103 driver and for future NXP C45 PHYs. > > Signed-off-by: Radu Pirea (NXP OSS) > --- > MAINTAINERS | 6 + > drivers/net/phy/Kconfig | 6 + > drivers/net/phy/Makefile | 1 + > drivers/net/phy/nxp-c45.c |

Re: Problem in pfmemalloc skb handling in net/core/dev.c

2021-04-09 Thread Xie He
On Fri, Apr 9, 2021 at 4:50 AM Eric Dumazet wrote: > > On 4/9/21 12:14 PM, Xie He wrote: > > Then simply copy the needed logic. No, there's no such thing as "sockets" in some of the protocols. There is simply no way to copy "the needed logic". > > Also, I think this is a problem in net/core/dev.

Re: [PATCH net-next v2 3/5] page_pool: Allow drivers to hint on SKB recycling

2021-04-09 Thread Ilias Apalodimas
On Fri, Apr 09, 2021 at 11:56:48AM -0700, Jakub Kicinski wrote: > On Fri, 2 Apr 2021 20:17:31 +0200 Matteo Croce wrote: > > Co-developed-by: Jesper Dangaard Brouer > > Co-developed-by: Matteo Croce > > Signed-off-by: Ilias Apalodimas > > Checkpatch says we need sign-offs from all authors. > Es

[PATCH net-next 3/4] net: intel: Remove unused function pointer typedef ixgbe_mc_addr_itr

2021-04-09 Thread Tony Nguyen
From: Chen Lin Remove the 'ixgbe_mc_addr_itr' typedef as it is not used. Signed-off-by: Chen Lin Tested-by: Dave Switzer Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ixgbe/ixgbe_type.h | 4 drivers/net/ethernet/intel/ixgbevf/vf.h | 3 --- 2 files changed, 7 deletions(

[PATCH net-next 4/4] net: ethernet: intel: Fix a typo in the file ixgbe_dcb_nl.c

2021-04-09 Thread Tony Nguyen
From: Bhaskar Chowdhury s/Reprogam/Reprogram/ Signed-off-by: Bhaskar Chowdhury Reviewed-by: Jesse Brandeburg Acked-by: Randy Dunlap Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ixgbe/ixgbe_dcb_nl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/

[PATCH net-next 2/4] ixgbe: aggregate of all receive errors through netdev's rx_errors

2021-04-09 Thread Tony Nguyen
From: Radoslaw Tyl The global rx error does not take into account all the error counters that are counted by device. Extend rx error with the following counters: - illegal byte error - number of receive fragment errors - receive jabber - receive oversize error - receive undersize error - frames

[PATCH net-next 1/4] ixgbe: Support external GBE SerDes PHY BCM54616s

2021-04-09 Thread Tony Nguyen
From: Jostar Yang The Broadcom PHY is used in switches, so add the ID, and hook it up. This upstreams the Linux kernel patch from the network operating system SONiC from February 2020 [1]. [1]: https://github.com/Azure/sonic-linux-kernel/pull/122 Signed-off-by: Jostar Yang Signed-off-by: Guoh

[PATCH net-next 0/4][pull request] 10GbE Intel Wired LAN Driver Updates 2021-04-09

2021-04-09 Thread Tony Nguyen
This series contains updates to ixgbe and ixgbevf driver. Jostar Yang adds support for BCM54616s PHY for ixgbe. Radoslaw aggregates additional Rx errors to be reported to netdev on ixgbe. Chen Lin removes an unused function pointer for ixgbe and ixgbevf. Bhaskar Chowdhury fixes a typo in ixgbe.

Re: [PATCH net-next v2 3/5] page_pool: Allow drivers to hint on SKB recycling

2021-04-09 Thread Jakub Kicinski
On Fri, 2 Apr 2021 20:17:31 +0200 Matteo Croce wrote: > Co-developed-by: Jesper Dangaard Brouer > Co-developed-by: Matteo Croce > Signed-off-by: Ilias Apalodimas Checkpatch says we need sign-offs from all authors. Especially you since you're posting.

Re: [PATCH net-next] [RESEND] wireguard: disable in FIPS mode

2021-04-09 Thread Simo Sorce
On Fri, 2021-04-09 at 12:36 -0600, Jason A. Donenfeld wrote: > On Fri, Apr 9, 2021 at 6:47 AM Simo Sorce wrote: > > > depends on m || !CRYPTO_FIPS > > > > > > but I am a bit concerned that the rather intricate kconfig > > > dependencies between the generic and arch-optimized versions of those >

Re: [PATCH net-next 2/3] net: use skb_for_each_frag() helper where possible

2021-04-09 Thread Jakub Kicinski
On Fri, 9 Apr 2021 20:06:04 +0200 Matteo Croce wrote: > From: Matteo Croce > > use the new helper macro skb_for_each_frag() which allows to iterate > through all the SKB fragments. > > The patch was created with Coccinelle, this was the semantic patch: Bunch of set but not used warnings here.

Re: [PATCH] net: multipath routing: configurable seed

2021-04-09 Thread Jakub Kicinski
On Fri, 9 Apr 2021 16:52:05 +0300 Balaev Pavel wrote: > Hello, this patch adds ability for user to set seed value for nit: please drop the 'Hello' and use imperative form to describe the commit. > multipath routing hashes. Now kernel uses random seed value: > this is done to prevent hash-floodin

Re: [PATCH 1/2] dt-binding: bcm43xx-fmac: add optional brcm,ccode-map

2021-04-09 Thread Rob Herring
On Thu, Apr 08, 2021 at 07:30:21PM +0800, Shawn Guo wrote: > Add optional brcm,ccode-map property to support translation from ISO3166 > country code to brcmfmac firmware country code and revision. > > Signed-off-by: Shawn Guo > --- > .../devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt | 7

Re: [PATCH net-next 0/3] net: add new properties for of_get_mac_address from nvmem

2021-04-09 Thread Jakub Kicinski
On Fri, 9 Apr 2021 17:07:08 +0800 Joakim Zhang wrote: > This patch set adds new properties for of_get_mac_address from nvmem. Apart from addressing Rob's (and potentially other comments to come) please also make sure to rebase before posting. This series doesn't seem to apply to net-next.

[PATCH] phy: nxp-c45: add driver for tja1103

2021-04-09 Thread Radu Pirea (NXP OSS)
Add driver for tja1103 driver and for future NXP C45 PHYs. Signed-off-by: Radu Pirea (NXP OSS) --- MAINTAINERS | 6 + drivers/net/phy/Kconfig | 6 + drivers/net/phy/Makefile | 1 + drivers/net/phy/nxp-c45.c | 622 ++ 4 files changed, 635

Re: [PATCH net-next] [RESEND] wireguard: disable in FIPS mode

2021-04-09 Thread Jason A. Donenfeld
On Fri, Apr 9, 2021 at 6:47 AM Simo Sorce wrote: > > depends on m || !CRYPTO_FIPS > > > > but I am a bit concerned that the rather intricate kconfig > > dependencies between the generic and arch-optimized versions of those > > drivers get complicated even further. > > Actually this is the opposi

Re: [RFC] net: core: devlink: add port_params_ops for devlink port parameters altering

2021-04-09 Thread Jakub Kicinski
On Fri, 9 Apr 2021 20:01:14 +0300 Vadym Kochan wrote: > On Fri, Apr 09, 2021 at 09:51:13AM -0700, Samudrala, Sridhar wrote: > > On 4/9/2021 9:22 AM, Oleksandr Mazur wrote: > > > I'd like to discuss a possibility of handling devlink port parameters > > > with devlink port pointer supplied. > > >

Re: [PATCH v2 2/2] drivers: net: dsa: qca8k: add support for multiple cpu port

2021-04-09 Thread Ansuel Smith
On Fri, Apr 09, 2021 at 11:15:37AM -0700, Florian Fainelli wrote: > > > On 4/5/2021 10:16 PM, Ansuel Smith wrote: > > On Wed, Apr 07, 2021 at 02:41:02AM +0200, Andrew Lunn wrote: > >> On Tue, Apr 06, 2021 at 06:50:40AM +0200, Ansuel Smith wrote: > >>> qca8k 83xx switch have 2 cpu ports. Rework th

Re: [PATCH net-next] [RESEND] wireguard: disable in FIPS mode

2021-04-09 Thread Jason A. Donenfeld
On Fri, Apr 9, 2021 at 2:08 AM Hangbin Liu wrote: > After offline discussion with Herbert, here is > what he said: > > """ > This is not a problem in RHEL8 because the Crypto API RNG replaces /dev/random > in FIPS mode. > """ So far as I can see, this isn't the case in the kernel sources I'm read

Re: [PATCH v8 bpf-next 09/14] bpd: add multi-buffer support to xdp copy helpers

2021-04-09 Thread Lorenzo Bianconi
> On Thu, Apr 08, 2021 at 02:51:01PM +0200, Lorenzo Bianconi wrote: > > From: Eelco Chaudron > > > > This patch adds support for multi-buffer for the following helpers: > > - bpf_xdp_output() > > - bpf_perf_event_output() > > > > Signed-off-by: Eelco Chaudron > > Signed-off-by: Lorenzo Bian

Re: [RFC PATCH 1/2] regmap: add miim bus support

2021-04-09 Thread Mark Brown
On Fri, Apr 09, 2021 at 08:14:22PM +0200, Sander Vanheule wrote: > The kernel has the mii_bus struct to describe the bus master, but like > you noted the bus is generaly refered to as an MDIO interface. I'm fine > with naming it MDIO to make it easier to spot. Either mii_bus or mdio seem like an

Re: [PATCH v2 2/2] drivers: net: dsa: qca8k: add support for multiple cpu port

2021-04-09 Thread Florian Fainelli
On 4/5/2021 10:16 PM, Ansuel Smith wrote: > On Wed, Apr 07, 2021 at 02:41:02AM +0200, Andrew Lunn wrote: >> On Tue, Apr 06, 2021 at 06:50:40AM +0200, Ansuel Smith wrote: >>> qca8k 83xx switch have 2 cpu ports. Rework the driver to support >>> multiple cpu port. All ports can access both cpu port

Re: [RFC PATCH 1/2] regmap: add miim bus support

2021-04-09 Thread Sander Vanheule
Hi Mark, On Fri, 2021-04-09 at 17:07 +0100, Mark Brown wrote: > On Thu, Apr 08, 2021 at 10:52:34PM +0200, Sander Vanheule wrote: > > Basic support for MIIM bus access. Support only includes clause-22 > > register access, with 5-bit addresses, and 16-bit wide registers. > > What is "MIIM"?  A quic

[RFC PATCH 3/3] net: axienet: Introduce dmaengine support

2021-04-09 Thread Radhey Shyam Pandey
The axiethernet driver have in-built dma programming. The aim is to remove axiethernet axidma programming and instead use the dmaengine framework to communicate with existing xilinx DMAengine controller(xilinx_dma) driver. This initial version is a proof of concept and validated with ping test. Th

[RFC PATCH 1/3] dt-bindings: net: xilinx_axienet: convert bindings document to yaml

2021-04-09 Thread Radhey Shyam Pandey
Convert the bindings document for Xilinx AXI Ethernet Subsystem from txt to yaml. No changes to existing binding description. Signed-off-by: Radhey Shyam Pandey --- Pending: Fix below remaining dt_binding_check warning: ethernet@40c0: 'device_type' does not match any of the regexes: 'pinctrl

[RFC PATCH 2/3] dt-bindings: net: xilinx_axienet: Introduce dmaengine binding support

2021-04-09 Thread Radhey Shyam Pandey
The axiethernet driver will now use dmaengine framework to communicate with dma controller IP instead of built-in dma programming sequence. To request dma transmit and receive channels the axiethernet driver uses generic dmas, dma-names properties. It deprecates axistream-connected property, remov

[RFC PATCH 0/3] net: axienet: Introduce dmaengine support

2021-04-09 Thread Radhey Shyam Pandey
The axiethernet driver now uses the dmaengine framework to communicate with the xilinx DMAengine driver(AXIDMA, MCDMA). The inspiration behind this dmaengine adoption is to reuse the in-kernel xilinx dma engine driver[1] and remove redundant dma programming sequence[2] from the ethernet driver. T

Re: [PATCH v8 bpf-next 08/14] bpf: add multi-buff support to the bpf_xdp_adjust_tail() API

2021-04-09 Thread Lorenzo Bianconi
> On Thu, Apr 08, 2021 at 10:15:47PM +0300, Vladimir Oltean wrote: > > > + if (unlikely(offset > ((int)(xdp->data_end - xdp->data) + > > > +xdp_sinfo->data_length - > > > +ETH_HLEN))) > > > > Also: should we have some sort of

RE: [Intel-wired-lan] [PATCH] i40e: The state of phy may not be correct during power-on

2021-04-09 Thread Kubalewski, Arkadiusz
>-Original Message- >From: Intel-wired-lan On Behalf Of >xiao33...@qq.com >Sent: piątek, 9 kwietnia 2021 11:18 >To: Brandeburg, Jesse ; Nguyen, Anthony L > >Cc: netdev@vger.kernel.org; xiaolinkui ; >linux-ker...@vger.kernel.org; intel-wired-...@lists.osuosl.org; >k...@kernel.org; da...

[PATCH net-next 6/7] net: ipa: get rid of empty GSI functions

2021-04-09 Thread Alex Elder
There are place holder functions in the GSI code that do nothing. Remove these, knowing we can add something back in their place if they're really needed someday. Some of these are inverse functions (such as teardown to match setup). Explicitly comment that there is no inverse in these cases. Sig

[PATCH net-next 5/7] net: ipa: get rid of empty IPA functions

2021-04-09 Thread Alex Elder
There are place holder functions in the IPA code that do nothing. For the most part these are inverse functions, for example, once the routing or filter tables are set up there is no need to perform any matching teardown activity at shutdown, or in the case of an error. These can be safely removed

[PATCH net-next 7/7] net: ipa: three small fixes

2021-04-09 Thread Alex Elder
Some time ago changes were made to stop referring to clearing the hardware pipeline as a "tag process." Fix a comment to use the newer terminology. Get rid of a pointless double-negation of the Boolean toward_ipa flag in ipa_endpoint_config(). make ipa_endpoint_exit_one() private; it's only refe

[PATCH net-next 4/7] net: ipa: ipa_stop() does not return an error

2021-04-09 Thread Alex Elder
In ipa_modem_stop(), if the modem netdev pointer is non-null we call ipa_stop(). We check for an error and if one is returned we handle it. But ipa_stop() never returns an error, so this extra handling is unnecessary. Simplify the code in ipa_modem_stop() based on the knowledge no error handling

[PATCH net-next 3/7] net: ipa: only set endpoint netdev pointer when in use

2021-04-09 Thread Alex Elder
In ipa_modem_start(), we set endpoint netdev pointers before the network device is registered. If registration fails, we don't undo those assignments. Instead, wait to assign the netdev pointer until after registration succeeds. Set these endpoint netdev pointers to NULL in ipa_modem_stop() befo

[PATCH net-next 0/7] net: ipa: a few small fixes

2021-04-09 Thread Alex Elder
This series implements some minor bug fixes or improvements. The first patch removes an apparently unnecessary restriction, which results in an error on a 32-bit ARM build. The second makes a definition used for SDM845 match what is used in the downstream code. The third just ensures two netdev

[PATCH net-next 2/7] net: ipa: update sequence type for modem TX endpoint

2021-04-09 Thread Alex Elder
On IPA v3.5.1, the sequencer type for the modem TX endpoint does not define the replication portion in the same way the downstream code does. This difference doesn't affect the behavior of the upstream code, but I'd prefer the two code bases use the same configuration value here. Signed-off-by: A

  1   2   3   >