Function __team_compute_features() is protected by team->lock
mutex when it is called from team_compute_features() used when
features of an underlying device is changed. This causes
a deadlock when NETDEV_FEAT_CHANGE notifier for underlying device
is fired due to change propagated from team driver
From: Vasundhara Volam
If firmware is in reset or in bad state, it won't be able to return
VPD data. Move bnxt_vpd_read_info() until after bnxt_fw_init_one_p1()
successfully returns. By then we would have established proper
communications with the firmware.
Reviewed-by: Edwin Peer
Signed-off-
From: Vasundhara Volam
Firmware may be in the middle of reset when the driver tries to do ifup.
In that case, firmware will return a special error code and the driver
will retry 10 times with 50 msecs delay after each retry.
Signed-off-by: Vasundhara Volam
Signed-off-by: Michael Chan
---
driv
In the event of a fatal firmware error, firmware will notify the host
and then it will proceed to do core reset when it sees that all functions
have disabled Bus Master. To prevent Master Aborts and other hard
errors, we need to quiesce all activities in addition to disabling Bus
Master before the
This code to check if we have reached the maximum wait time after
firmware reset is used multiple times. Add a helper function to
do this.
Reviewed-by: Edwin Peer
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 15 +--
1 file changed, 9 insertions(+), 6
From: Edwin Peer
Add missing support for handling NO_MASTER crashes while ports are
administratively down (ifdown). On some SoC platforms, the driver
needs to assist the firmware to recover from a crash via OP-TEE.
This is performed in a similar fashion to what is done during driver
probe.
Signe
Pass through mode is to allow packets in MAP format to be passed
on to the stack. rmnet driver can be used to process and demultiplex
these packets.
Pass through mode can be enabled when the device is in raw ip mode only.
Conversely, raw ip mode cannot be disabled when pass through mode is
enabled
Combine the three netdev_warn() calls into a single call, printed at
the NETIF_MSG_HW log level.
Reviewed-by: Vasundhara Volam
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 17 ++---
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/drivers
Once the firmware fatal condition is detected, we should cease
comminication with the firmware and hardware quickly even if there
are many completion entries in the completion rings. This will
speed up the recovery process and prevent further I/Os that may
cause further exceptions.
Do not proceed
Define macros to check for the various states in the lower 16 bits of
the health register. Replace the C code that checks for these values
with the newly defined macros.
Reviewed-by: Edwin Peer
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 10 ++
d
The first HWRM_VER_GET message to firmware during probe may timeout if
firmware is under reset. This can happen during hot-plug for example.
On P5 and newer chips, we can check if firmware is in the boot stage by
reading a status register. Retry 5 times if the status register shows
that firmware
In the event of a fatal firmware error, we want to disable IRQ early
in the recovery sequence. This change will allow it to be called
safely again as part of the normal shutdown sequence.
Reviewed-by: Edwin Peer
Reviewed-by: Vasundhara Volam
Signed-off-by: Michael Chan
---
drivers/net/etherne
Up until now, we don't need to keep track of this state because NAPI
is always enabled once and disabled once during bring up and shutdown.
For better error recovery in subsequent patches, we want to quiesce
the device earlier during fatal error conditions. The normal shutdown
sequence will disabl
From: Edwin Peer
Drawing a hard line on aborted resets prevents a NIC open in
some scenarios that may otherwise be recoverable. For example,
if a firmware recovery happened while a PF was down and an
attempt was made to bring up an associated VF in this state,
then it was impossible to ever bring
From: Edwin Peer
Firmware is capable of generating asynchronous debug notifications.
The event data is opaque to the driver and is simply logged. Debug
notifications can be enabled by turning on hardware status messages
using the ethtool msglvl interface.
Reviewed-by: Pavan Chebbi
Signed-off-by
From: Vasundhara Volam
The timeout period for firmware messages is passed to the driver
from the firmware in the response of the first command. This
timeout period is multiplied by a factor for certain long
running commands such as NVRAM commands. In some cases, the
timeout period can become re
czw., 21 sty 2021 o 23:45 Vladimir Oltean napisał(a):
>
> Hi Pawel,
>
Hi Vladimir,
Thank You for Your answer.
> On Wed, Jan 20, 2021 at 07:30:18AM +0100, Pawel Dembicki wrote:
> > This patch adds support for vlan filtering in vsc73xx driver.
> >
> > After vlan filtering enable, CPU_PORT is confi
> > We cannot access PPv2 register space before enabling clocks(done in
> mvpp2_probe) , PP21 and PP22/23 have different sets of clocks.
>
> > So diff between PP21 and PP22/23 should be stored in device tree(in
> > of_device_id), with MVPP22 and MVPP21 stored as .data
>
> Hi Stefan
>
> As far as
Fix the following coccicheck warnings:
./net/ipv4/esp4_offload.c:288:32-34: WARNING !A || A && B is
equivalent to !A || B.
Reported-by: Abaci Robot
Signed-off-by: Jiapeng Zhong
---
Changes in v2:
-Drop the parenthesis around !skb_is_gso(skb) now.
net/ipv4/esp4_offload.c | 2 +-
1 file chan
On 2021-01-24 05:45, Jakub Kicinski wrote:
On Fri, 22 Jan 2021 10:07:05 +0100 Martin Schiller wrote:
On 2021-01-21 01:21, Xie He wrote:
> In the lapb module, the timers may run concurrently with other code in
> this module, and there is currently no locking to prevent the code from
> racing on "
On Sun, Jan 24, 2021 at 12:00:27PM -0800, Alan Perry wrote:
> Add a description section with basic info about the rdma command for users
> unfamiliar with it.
>
> Signed-off-by: Alan Perry
> Acked-by: Leon Romanovsky
>
> ---
> man/man8/rdma.8 | 9 -
> 1 file changed, 8 insertions(+), 1 d
On Fri, Jan 22, 2021 at 10:55:45PM -0700, David Ahern wrote:
> On 1/22/21 9:07 PM, Jakub Kicinski wrote:
> > On Wed, 20 Jan 2021 16:41:48 -0800 Arjun Roy wrote:
> >> diff --git a/include/uapi/linux/tcp.h b/include/uapi/linux/tcp.h
> >> index 768e93bd5b51..b216270105af 100644
> >> --- a/include/uapi
There exists many build warnings when make M=samples/bpf on the Loongson
platform, this issue is MIPS related, x86 compiles just fine.
Here are some warnings:
CC samples/bpf/ibumad_user.o
samples/bpf/ibumad_user.c: In function ‘dump_counts’:
samples/bpf/ibumad_user.c:46:24: warning: format ‘%l
I was trying to see if there were some Intel 8051 instructions in the
jam tables with Linus Walleij, when I noticed some oddities.
This patch's aim is to make the code more consistent and more similar
to the vendor's original source.
Link to the Realtek code the actual patch is based on:
https://sv
In the rtl8366rb driver there are some jam tables which contain
undocumented values.
While trying to understand what these tables actually do,
I noticed a discrepancy in how one of those was treated.
Most of them were plain u16 arrays, while the ethernet one was
an u16 matrix.
By looking at the ven
Gentle Ping...
Best Regards,
Joakim Zhang
> -Original Message-
> From: Joakim Zhang
> Sent: 2021年1月12日 19:34
> To: peppe.cavall...@st.com; alexandre.tor...@st.com;
> joab...@synopsys.com; da...@davemloft.net; k...@kernel.org
> Cc: netdev@vger.kernel.org; dl-linux-imx ;
> and...@lunn.ch;
Add device tree binding to support MT7530 GPIO controller.
Signed-off-by: DENG Qingfang
---
Changes v1 -> v2:
No changes.
Documentation/devicetree/bindings/net/dsa/mt7530.txt | 6 ++
1 file changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/dsa/mt7530.txt
MT7530's LED controller can drive up to 15 LED/GPIOs.
Add support for GPIO control and allow users to use its GPIOs by
setting gpio-controller property in device tree.
Signed-off-by: DENG Qingfang
---
Changes v1 -> v2:
Set Output Enable after changing direction to output to avoid signal
glitch.
MT7530's LED controller can be used as GPIO controller. Add support for
it.
DENG Qingfang (2):
dt-bindings: net: dsa: add MT7530 GPIO controller binding
net: dsa: mt7530: MT7530 optional GPIO support
.../devicetree/bindings/net/dsa/mt7530.txt| 6 +
drivers/net/dsa/mt7530.c
On Sat, Jan 23, 2021 at 11:11 PM Jakub Kicinski wrote:
>
> On Thu, 21 Jan 2021 00:17:09 -0600 Lijun Pan wrote:
> > rmb() was introduced to load rx_scrq->msgs after calling
> > pending_scrq(). Now since pending_scrq() itself already
> > has dma_rmb() at the end of the function, rmb() is
> > duplica
On Sat, Jan 23, 2021 at 11:10 PM Jakub Kicinski wrote:
>
> On Thu, 21 Jan 2021 00:17:08 -0600 Lijun Pan wrote:
> > Move the dma_rmb() between pending_scrq() and ibmvnic_next_scrq()
> > into the end of pending_scrq(), and explain why.
> > Explain in detail why the dma_rmb() is placed at the end of
MT762x HW, except for MT7628, supports frame length up to 2048
(maximum length on GDM), so allow setting MTU up to 2030.
Also set the default frame length to the hardware default 1518.
Signed-off-by: DENG Qingfang
---
Changes v1 -> v2:
- Set netdev->max_mtu accordingly
- Mention default MAX_RX
On Fri, Jan 22, 2021 at 02:38:40PM +0100, Toke Høiland-Jørgensen wrote:
> >> out:
> >> + drops = cnt - sent;
> >>bq->count = 0;
> >>
> >>trace_xdp_devmap_xmit(bq->dev_rx, dev, sent, drops, err);
> >>bq->dev_rx = NULL;
> >> + bq->xdp_prog = NULL;
> >
> > One more question, do you re
On 2021/1/23 上午3:43, Eugenio Perez Martin wrote:
On Tue, Jan 12, 2021 at 4:12 AM Jason Wang wrote:
On 2021/1/11 下午8:26, Eli Cohen wrote:
On Wed, Dec 16, 2020 at 02:48:18PM +0800, Jason Wang wrote:
This patch introduces the control virtqueue support for vDPA
simulator. This is a requirement
On 2021/1/23 下午4:08, Dongli Zhang wrote:
The size of 'struct vhost_scsi' is order-10 (~2.3MB). It may take long time
delay by kzalloc() to compact memory pages by retrying multiple times when
there is a lack of high-order pages. As a result, there is latency to
create a VM (with vhost-scsi) or
coccicheck suggested using PTR_ERR_OR_ZERO() and looking at the code.
Fix the following coccicheck warnings:
./net/bridge/br_multicast.c:1295:7-13: WARNING: PTR_ERR_OR_ZERO can be
used.
Reported-by: Abaci
Signed-off-by: Jiapeng Zhong
---
net/bridge/br_multicast.c | 2 +-
1 file changed, 1 ins
On 2021/01/25 8:48, Alexey Kardashevskiy wrote:
>
>
> On 23/01/2021 22:17, Tetsuo Handa wrote:
>> On 2021/01/23 12:27, Cong Wang wrote:
>>> On Fri, Jan 22, 2021 at 4:42 PM Tetsuo Handa
>>> wrote:
Hello, BPF developers.
Alexey Kardashevskiy is reporting that system_wq gets stu
Hi all,
Today's linux-next merge of the bpf-next tree got a conflict in:
net/ipv4/tcp.c
between commit:
7eeba1706eba ("tcp: Add receive timestamp support for receive zerocopy.")
from the net-next tree and commit:
9cacf81f8161 ("bpf: Remove extra lock_sock for TCP_ZEROCOPY_RECEIVE")
fro
On Mon, Jan 25, 2021 at 12:19:55AM +0100, Linus Walleij wrote:
> This is due to the internal architecture of the switch, while it does
> have an internal tagging format, this is stripped off before letting
> it exit through the CPU port, and tagged on by the hardware
> whenever the CPU transmits so
On Thu, Jan 21, 2021 at 11:45 PM Vladimir Oltean wrote:
> On Wed, Jan 20, 2021 at 07:30:18AM +0100, Pawel Dembicki wrote:
> > This patch adds support for vlan filtering in vsc73xx driver.
> >
> > After vlan filtering enable, CPU_PORT is configured as trunk, without
> > non-tagged frames. This all
For very large ELF objects (with many sections), we could
get special value SHN_XINDEX (65535) for symbol's st_shndx.
This patch is adding code to detect the optional extended
section index table and use it to resolve symbol's section
index.
Adding elf_symtab__for_each_symbol_index macro that ret
In case the elf's header e_shstrndx contains SHN_XINDEX,
we need to call elf_getshdrstrndx to get the proper
string table index.
Acked-by: Andrii Nakryiko
Signed-off-by: Jiri Olsa
---
dutil.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/dutil.c b/dutil.c
index 7b66
hi,
kpatch guys hit an issue with pahole over their vmlinux, which
contains many (over 10) sections, pahole crashes.
With so many sections, ELF is using extended section index table,
which is used to hold values for some of the indexes and extra
code is needed to retrieve them.
This patchset
On Wed, Jan 20, 2021 at 09:21:22PM +0900, Yuusuke Ashizuka wrote:
> Fixes: 558f7cc33daf ("netlink: add master/slave configuration support")
> Signed-off-by: Yuusuke Ashizuka
Applied, thank you.
Michal
> ---
> ethtool.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/e
Hello,
syzbot found the following issue on:
HEAD commit:7d68e382 bpf: Permit size-0 datasec
git tree: bpf-next
console output: https://syzkaller.appspot.com/x/log.txt?x=132567e750
kernel config: https://syzkaller.appspot.com/x/.config?x=e0c7843b8af99dff
dashboard link: https://syzk
On Fri, Jan 22, 2021 at 11:37 AM Saeed Mahameed wrote:
> This series form Parav was the theme of this mlx5 release cycle,
> we've been waiting anxiously for the auxbus infrastructure to make it into
> the kernel, and now as the auxbus is in and all the stars are aligned, I
> can finally submit th
Add a description section with basic info about the rdma command for users
unfamiliar with it.
Signed-off-by: Alan Perry
Acked-by: Leon Romanovsky
---
man/man8/rdma.8 | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/man/man8/rdma.8 b/man/man8/rdma.8
index c9e5d50d..6
On Sun, Jan 24, 2021 at 02:43:30PM +, Stefan Chulski wrote:
> >
> > --
> > On Sun, Jan 24, 2021 at 01:43:57PM +0200, stef...@marvell.com wrote:
> > > +/* Set Flow Control timer x140 faster than pause quanta to ensure
> > > +th
From: Tom Rix
This change fixes the checkpatch warning described in this commit
commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of
unnecessary %h[xudi] and %hh[xudi]")
Standard integer promotion is already done and %hx and %hhx is useless
so do not encourage the use of %hh[xud
On Sun, Jan 24, 2021 at 01:55:42PM +, Stefan Chulski wrote:
> > > Signed-off-by: Stefan Chulski
> > > ---
> > > drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 24 --
> > --
> > > drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 17 +-
> > > 2 files changed, 25
On Sun, Jan 24, 2021 at 10:09:55AM -0800, Alan Perry wrote:
>
> Add a description section with basic info about the rdma command for users
> unfamiliar with it.
>
> Signed-off-by: Alan Perry
> ---
> man/man8/rdma.8 | 9 -
> 1 file changed, 8 insertion(+), 1 deletion(-)
> diff --git a/ma
On Sun, Jan 24, 2021 at 08:47:44AM -0800, Alexander Duyck wrote:
> On Sun, Jan 24, 2021 at 5:11 AM Leon Romanovsky wrote:
> >
> > From: Leon Romanovsky
> >
> > Extend PCI sysfs interface with a new callback that allows configure
> > the number of MSI-X vectors for specific SR-IO VF. This is neede
On 1/24/21 2:57 AM, Justin Iurman wrote:
>> De: "Jakub Kicinski"
>> À: "Justin Iurman"
>> Cc: netdev@vger.kernel.org, da...@davemloft.net, "alex aring"
>>
>> Envoyé: Dimanche 24 Janvier 2021 05:54:44
>> Objet: Re: [PATCH net 1/1] uapi: fix big endian definition of ipv6_rpl_sr_hdr
>
>> On Thu,
On Sun, Jan 24, 2021 at 12:44:43PM +, Russell King - ARM Linux admin wrote:
> On Sun, Jan 24, 2021 at 01:43:52PM +0200, stef...@marvell.com wrote:
> > + priv->sram_pool = of_gen_pool_get(dn, "cm3-mem", 0);
> > + if (!priv->sram_pool) {
> > + if (!defer_once
> diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> index a07cf60..c969a2d 100644
> --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> @@ -25,6 +25,7 @@
> #include
> #in
Add a description section with basic info about the rdma command for users
unfamiliar with it.
Signed-off-by: Alan Perry
---
man/man8/rdma.8 | 9 -
1 file changed, 8 insertion(+), 1 deletion(-)
diff --git a/man/man8/rdma.8 b/man/man8/rdma.8
index c9e5d50d..66ef9902 100644
--- a/man/
On Sat, Jan 23, 2021 at 12:06 PM Jonas Bonn wrote:
>
> This series begins by reverting the recently added patch adding support
> for GTP with lightweight tunnels. That patch was added without getting
> any ACK from the maintainers and has several issues, as discussed on the
> mailing list.
>
> In
On Sat, Jan 23, 2021 at 01:26:18PM +0800, samirweng1979 wrote:
> From: wengjianfeng
>
> change 'regster' to 'register'
>
> Signed-off-by: wengjianfeng
> ---
> drivers/nfc/trf7970a.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nfc/trf7970a.c b/drivers/nfc/t
On Sun, 24 Jan 2021 at 17:26, David Ahern wrote:
>
> On 1/24/21 8:53 AM, Luca Boccassi wrote:
> > Since NETLINK_GET_STRICT_CHK was enabled, the kernel rejects commands
> > that pass a prefix length, eg:
> >
> > ip route get `1.0.0.0/1
> > Error: ipv4: Invalid values in header for route get requ
Since NETLINK_GET_STRICT_CHK was enabled, the kernel rejects commands
that pass a prefix length, eg:
ip route get `1.0.0.0/1
Error: ipv4: Invalid values in header for route get request.
ip route get 0.0.0.0/0
Error: ipv4: rtm_src_len and rtm_dst_len must be 32 for IPv4
Since there's no poin
On Fri, Jan 22, 2021 at 09:59:47AM -0600, George McCollister wrote:
> diff --git a/net/dsa/slave.c b/net/dsa/slave.c
> index f2fb433f3828..fc7e3ff11c5c 100644
> --- a/net/dsa/slave.c
> +++ b/net/dsa/slave.c
> @@ -1924,6 +1924,19 @@ static int dsa_slave_changeupper(struct net_device
> *dev,
>
On 1/24/21 8:53 AM, Luca Boccassi wrote:
> Since NETLINK_GET_STRICT_CHK was enabled, the kernel rejects commands
> that pass a prefix length, eg:
>
> ip route get `1.0.0.0/1
> Error: ipv4: Invalid values in header for route get request.
> ip route get 0.0.0.0/0
> Error: ipv4: rtm_src_len and
> drivers/net/ethernet/freescale/fec_main.c: In function ‘fec_restart’:
> drivers/net/ethernet/freescale/fec_main.c:958:46: warning: suggest
> parentheses around ‘&&’ within ‘||’ [-Wparentheses]
> 958 | (fep->quirks & FEC_QUIRK_NO_HARD_RESET) && fep->link) {
> |
Hi Jakub,
> -Original Message-
> From: Jakub Kicinski
> Sent: Saturday, January 23, 2021 10:00 AM
> To: Hariprasad Kelam
> Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org;
> da...@davemloft.net; Sunil Kovvuri Goutham ;
> Linu Cherian ; Geethasowjanya Akula
> ; Jerin Jacob Kollan
On Sat, Jan 23, 2021 at 08:59:12PM +0100, Jonas Bonn wrote:
> Signed-off-by: Jonas Bonn
Acked-by: Harald Welte
--
- Harald Weltehttp://laforge.gnumonks.org/
"Privacy in residential applications is a desirab
On Sat, Jan 23, 2021 at 08:59:05PM +0100, Jonas Bonn wrote:
> Signed-off-by: Jonas Bonn
Acked-by: Harald Welte
--
- Harald Weltehttp://laforge.gnumonks.org/
"Privacy in residential applications is a desirab
On Sun, Jan 24, 2021 at 5:11 AM Leon Romanovsky wrote:
>
> From: Leon Romanovsky
>
> Extend PCI sysfs interface with a new callback that allows configure
> the number of MSI-X vectors for specific SR-IO VF. This is needed
> to optimize the performance of newly bound devices by allocating
> the nu
Dear Jonas,
thanks for your effort in breaking this down into more digestible chunks
for further review.
> Signed-off-by: Jonas Bonn
Acked-by: Harald Welte
--
- Harald Weltehttp://laforge.gnumonks.org/
"
On Sun, Jan 24, 2021 at 6:14 AM Lukas Wunner wrote:
>
> On Fri, Jan 22, 2021 at 11:13:19AM -0500, Willem de Bruijn wrote:
> > On Fri, Jan 22, 2021 at 4:44 AM Lukas Wunner wrote:
> > > Add egress hook for AF_PACKET sockets that have the PACKET_QDISC_BYPASS
> > > socket option set to on, which allo
Since NETLINK_GET_STRICT_CHK was enabled, the kernel rejects commands
that pass a prefix length, eg:
ip route get `1.0.0.0/1
Error: ipv4: Invalid values in header for route get request.
ip route get 0.0.0.0/0
Error: ipv4: rtm_src_len and rtm_dst_len must be 32 for IPv4
Since there's no poin
From: Tom Rix
This change fixes the checkpatch warning described in this commit
commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of
unnecessary %h[xudi] and %hh[xudi]")
Standard integer promotion is already done and %hx and %hhx is useless
so do not encourage the use of %hh[xud
Hi,
On 23/01/2021 20:59, Jonas Bonn wrote:
From: Pravin B Shelar
This patch adds support for flow based tunneling, allowing to send and
receive GTP tunneled packets via the (lightweight) tunnel metadata
mechanism. This would allow integration with OVS and eBPF using flow
based tunneling APIs.
>
> --
> On Sun, Jan 24, 2021 at 01:43:57PM +0200, stef...@marvell.com wrote:
> > +/* Set Flow Control timer x140 faster than pause quanta to ensure
> > +that link
> > + * partner won't send taffic if port in XOFF mode.
>
> Can y
Hi Pravin,
A couple more comments around the GTP_METADATA bits:
On 23/01/2021 20:59, Jonas Bonn wrote:
From: Pravin B Shelar
This patch adds support for flow based tunneling, allowing to send and
receive GTP tunneled packets via the (lightweight) tunnel metadata
mechanism. This would allow i
Hi Pravin,
So, this whole GTP metadata thing has me a bit confused.
You've defined a metadata structure like this:
struct gtpu_metadata {
__u8ver;
__u8flags;
__u8type;
};
Here ver is the version of the metadata structure itself, which is fine.
'flags' corres
On Fri, Jan 22, 2021 at 05:48:20PM -0600, Shiraz Saleem wrote:
> From: Mustafa Ismail
>
> Implement device supported verb APIs. The supported APIs
> vary based on the underlying transport the ibdev is
> registered as (i.e. iWARP or RoCEv2).
>
> Signed-off-by: Mustafa Ismail
> Signed-off-by: Shira
> > Signed-off-by: Stefan Chulski
> > ---
> > drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 24 --
> --
> > drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 17 +-
> > 2 files changed, 25 insertions(+), 16 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/mar
On Fri, Jan 22, 2021 at 05:48:12PM -0600, Shiraz Saleem wrote:
> From: Mustafa Ismail
>
> Register irdma as an auxiliary driver which can attach to auxiliary RDMA
> devices from Intel PCI netdev drivers i40e and ice. Implement the private
> channel ops, add basic devlink support in the driver and
> > --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> > +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> > @@ -1154,6 +1154,9 @@ static void mvpp2_interrupts_mask(void *arg)
> > mvpp2_thread_write(port->priv,
> >mvpp2_cpu_to_thread(port->priv,
> smp_processo
On Sun, Jan 24, 2021 at 01:43:53PM +0200, stef...@marvell.com wrote:
> From: Stefan Chulski
>
> This patch add PPv23 version definition.
> PPv23 is new packet processor in CP115.
> Everything that supported by PPv22, also supported by PPv23.
> No functional changes in this stage.
>
> Signed-off-
Hi Phil,
On 2021-01-22 8:59 a.m., Phil Sutter wrote:
Jamal,
On Fri, Jan 22, 2021 at 06:25:22AM -0500, Jamal Hadi Salim wrote:
[...]
My gut feel is user space is the right/easier spot to fix this
as long as it doesnt break the working setup of 8b.
One last attempt at clarifying the situation:
From: Leon Romanovsky
Implement ability to configure MSI-X for the SR-IOV VFs.
Signed-off-by: Leon Romanovsky
---
.../net/ethernet/mellanox/mlx5/core/main.c| 12 +
.../ethernet/mellanox/mlx5/core/mlx5_core.h | 1 +
.../net/ethernet/mellanox/mlx5/core/sriov.c | 46 +
From: Leon Romanovsky
The number of MSI-X vectors is PCI property visible through lspci, that
field is read-only and configured by the device. The static assignment
of an amount of MSI-X vectors doesn't allow utilize the newly created
VF because it is not known to the device the future load and c
From: Leon Romanovsky
These new fields declare the number of MSI-X vectors that is
possible to allocate on the VF through PF configuration.
Value must be in range defined by min_dynamic_vf_msix_table_size
and max_dynamic_vf_msix_table_size.
The driver should continue to query its MSI-X table th
From: Leon Romanovsky
Changelog
v4:
* Used sysfs_emit() instead of sprintf() in new sysfs entries.
* Changed EXPORT_SYMBOL to be EXPORT_SYMBOL_GPL for pci_iov_virtfn_devfn().
* Rewrote sysfs registration code to be driven by PF that wants to enable VF
overlay instead of creating to all SR-I
From: Leon Romanovsky
Extend PCI sysfs interface with a new callback that allows configure
the number of MSI-X vectors for specific SR-IO VF. This is needed
to optimize the performance of newly bound devices by allocating
the number of vectors based on the administrator knowledge of targeted VM.
Hi,
> Great, thank you for looking into this. Let me know if you have a patch which
> you want me to test on a RTL8723BS adapter.
>
> One thing which I forgot to mention earlier, it is not just lockdep
> complaining
> this appears to be a real deadlock, the wifi no longer functions, where as it
On Sun, Jan 24, 2021 at 01:43:58PM +0200, stef...@marvell.com wrote:
> diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> index 9d69752..0f5069f 100644
> --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> +++ b/drivers/net/ethern
Commit 9ebeddef58c4 ("rxrpc: rxrpc_peer needs to hold a ref on the rxrpc_local
record")
Then release ref in __rxrpc_put_peer and rxrpc_put_peer_locked.
struct rxrpc_peer *rxrpc_alloc_peer(struct rxrpc_local *local, gfp_t
gfp)
- peer->local = local;
+
On Sun, Jan 24, 2021 at 01:43:52PM +0200, stef...@marvell.com wrote:
> + priv->sram_pool = of_gen_pool_get(dn, "cm3-mem", 0);
> + if (!priv->sram_pool) {
> + if (!defer_once) {
> + defer_once = true;
> +
>
> --
> On Sun, Jan 24, 2021 at 01:44:02PM +0200, stef...@marvell.com wrote:
> > @@ -6407,6 +6490,29 @@ static void mvpp2_mac_link_up(struct
> phylink_config *config,
> > val);
> > }
> >
> > + if (t
On Sun, Jan 24, 2021 at 01:44:02PM +0200, stef...@marvell.com wrote:
> @@ -6407,6 +6490,29 @@ static void mvpp2_mac_link_up(struct phylink_config
> *config,
>val);
> }
>
> + if (tx_pause && port->priv->global_tx_fc) {
> + port->tx_fc = true;
> +
On Sun, Jan 24, 2021 at 01:43:52PM +0200, stef...@marvell.com wrote:
> +static int mvpp2_get_sram(struct platform_device *pdev,
> + struct mvpp2 *priv)
> +{
> + struct device_node *dn = pdev->dev.of_node;
> + static bool defer_once;
> + struct resource *res;
> +
>
Here is the v11 of the patch which reflect the latest comments I
received on the mailing list (thanks for that!). The biggest change is
the modification on the FIFO. Making the FIFO length a power of two
allow to remove the spinlocks and drastically reduce the complexity.
In parallel, I am working
On Sun, Jan 24, 2021 at 01:43:57PM +0200, stef...@marvell.com wrote:
> +/* Set Flow Control timer x140 faster than pause quanta to ensure that link
> + * partner won't send taffic if port in XOFF mode.
Can you explain more why 140 times faster is desirable here? Why 140
times and not, say, 10 time
From: Stefan Chulski
Armada hardware has a pause generation mechanism in GOP (MAC).
The GOP generate flow control frames based on an indication programmed in Ports
Control 0 Register. There is a bit per port.
However assertion of the PortX Pause bits in the ports control 0 register only
sends a
From: Stefan Chulski
This patch adds CM3 memory map and CM3 read/write callbacks.
No functionality changes.
Signed-off-by: Stefan Chulski
---
drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 7 ++
drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 74 +++-
2 files changed, 78
From: Stefan Chulski
Flow Control periodic timer would be used if port in
XOFF to transmit periodic XOFF frames.
Signed-off-by: Stefan Chulski
---
drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 13 +-
drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 45
2 files cha
From: Stefan Chulski
BM pool size increased to support Firmware Flow Control.
Minimum depletion thresholds to support FC is 1024 buffers.
BM pool size increased to 2048 to have some 1024 buffers
space between depletion thresholds and BM pool size.
Jumbo frames require a 9888B buffer, so memory r
From: Stefan Chulski
Currently we have PP2v1 and PP2v2 hw-versions, with some different
handlers depending upon condition hw_version = MVPP21/MVPP22.
In a future there will be also PP2v3. Let's use now the generic
"if equal/notEqual MVPP21" for all cases instead of "if MVPP22".
This patch does n
1 - 100 of 136 matches
Mail list logo
