On Sat, Jan 23, 2021 at 11:11 PM Jakub Kicinski <k...@kernel.org> wrote:
>
> On Thu, 21 Jan 2021 00:17:09 -0600 Lijun Pan wrote:
> > rmb() was introduced to load rx_scrq->msgs after calling
> > pending_scrq(). Now since pending_scrq() itself already
> > has dma_rmb() at the end of the function, rmb() is
> > duplicated and can be removed.
> >
> > Fixes: ec20f36bb41a ("ibmvnic: Correctly re-enable interrupts in NAPI
> > polling routine")
> > Signed-off-by: Lijun Pan <l...@linux.ibm.com>
>
> rmb() is a stronger barrier than dma_rmb()
Yes. I think the weaker dma_rmb() here is enough.
And I let it reuse the dma_rmb() in the pending_scrq().
>
> also again, I don't see how this fixes any bugs
I will send to net-next if you are ok with it.
