> > We cannot access PPv2 register space before enabling clocks(done in > mvpp2_probe) , PP21 and PP22/23 have different sets of clocks. > > > So diff between PP21 and PP22/23 should be stored in device tree(in > > of_device_id), with MVPP22 and MVPP21 stored as .data > > Hi Stefan > > As far as i can see, you are not adding a new compatible. So 'marvell,armada- > 7k-pp2' means PPv2.2 and PPv2.3? It would be good to update the comment > at the beginning of marvell-pp2.txt to indicate this. > > Andrew
Ok, I would add comment. Thanks, Stefan.