Re: [PATCH mlx5-next v2 0/5] Dynamically assign MSI-X vectors count

2021-01-16 Thread Leon Romanovsky
On Sun, Jan 17, 2021 at 07:44:09AM +0200, Leon Romanovsky wrote: > On Thu, Jan 14, 2021 at 09:51:28AM -0800, Jakub Kicinski wrote: > > On Thu, 14 Jan 2021 12:31:35 +0200 Leon Romanovsky wrote: > > > The number of MSI-X vectors is PCI property visible through lspci, that > > > field is read-only and

Re: [PATCH mlx5-next v2 1/5] PCI: Add sysfs callback to allow MSI-X table size change of SR-IOV VFs

2021-01-16 Thread Leon Romanovsky
On Sat, Jan 16, 2021 at 10:23:31AM +0200, Leon Romanovsky wrote: > On Thu, Jan 14, 2021 at 05:05:43PM -0700, Alex Williamson wrote: > > On Thu, 14 Jan 2021 12:31:36 +0200 > > Leon Romanovsky wrote: > > > > > From: Leon Romanovsky > > > > > > Extend PCI sysfs interface with a new callback that all

Re: [PATCH mlx5-next v2 0/5] Dynamically assign MSI-X vectors count

2021-01-16 Thread Leon Romanovsky
On Thu, Jan 14, 2021 at 09:51:28AM -0800, Jakub Kicinski wrote: > On Thu, 14 Jan 2021 12:31:35 +0200 Leon Romanovsky wrote: > > The number of MSI-X vectors is PCI property visible through lspci, that > > field is read-only and configured by the device. > > > > The static assignment of an amount of

[Patch bpf-next v4 2/3] selftests/bpf: add test cases for bpf timeout map

2021-01-16 Thread Cong Wang
From: Cong Wang Add some test cases in test_maps.c for timeout map, which focus on testing timeout. Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: Dongdong Wang Signed-off-by: Cong Wang --- tools/testing/selftests/bpf/test_maps.c | 47 + 1 file changed, 47 insertions

[Patch bpf-next v4 3/3] selftests/bpf: add timeout map check in map_ptr tests

2021-01-16 Thread Cong Wang
From: Cong Wang Similar to regular hashmap test. Acked-by: Andrey Ignatov Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: Dongdong Wang Signed-off-by: Cong Wang --- .../selftests/bpf/progs/map_ptr_kern.c| 20 +++ 1 file changed, 20 insertions(+) diff --git a/tools/t

[Patch bpf-next v4 1/3] bpf: introduce timeout hash map

2021-01-16 Thread Cong Wang
From: Cong Wang This borrows the idea from conntrack and will be used for conntrack in ebpf too. Each element in a timeout map has a user-specified timeout in msecs, after it expires it will be automatically removed from the map. Cilium already does the same thing, it uses a regular map or LRU ma

[Patch bpf-next v4 0/3] bpf: introduce timeout hash map

2021-01-16 Thread Cong Wang
From: Cong Wang This patchset introduces a new eBPF hash map whose elements have timeouts. Patch 1 is the implementation of timeout map, patch 2 adds some test cases for timeout map in test_maps, and patch 3 adds a test case in map ptr test. Please check each patch description for more details.

Re: [PATCHv3 net-next 1/2] net: move the hsize check to the else block in skb_segment

2021-01-16 Thread Jakub Kicinski
On Fri, 15 Jan 2021 17:39:02 -0800 Alexander Duyck wrote: > On Fri, Jan 15, 2021 at 1:36 AM Xin Long wrote: > > > > After commit 89319d3801d1 ("net: Add frag_list support to skb_segment"), > > it goes to process frag_list when !hsize in skb_segment(). However, when > > using skb frag_list, sg norm

Re: [PATCH net-next 7/7] net: ipa: allow arbitrary number of interconnects

2021-01-16 Thread Jakub Kicinski
On Fri, 15 Jan 2021 06:50:50 -0600 Alex Elder wrote: > Currently we assume that the IPA hardware has exactly three > interconnects. But that won't be guaranteed for all platforms, > so allow any number of interconnects to be specified in the > configuration data. > > For each platform, define an

Re: [PATCH] net: mscc: ocelot: Remove unneeded semicolon

2021-01-16 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 15 Jan 2021 09:55:44 + you wrote: > fix semicolon.cocci warnings: > drivers/net/ethernet/mscc/ocelot_net.c:460:2-3: Unneeded semicolon > > Signed-off-by: Xu Wang > --- > drivers/net/ethernet/mscc/ocelot_net.c

Re: [PATCH v2 net] skbuff: back tiny skbs with kmalloc() in __netdev_alloc_skb() too

2021-01-16 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Fri, 15 Jan 2021 15:04:40 + you wrote: > Commit 3226b158e67c ("net: avoid 32 x truesize under-estimation for > tiny skbs") ensured that skbs with data size lower than 1025 bytes > will be kmalloc'ed to avoid excessive pag

Re: [PATCH net-next] cxgb4: enable interrupt based Tx completions for T5

2021-01-16 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 15 Jan 2021 15:50:59 +0530 you wrote: > Enable interrupt based Tx completions to improve latency for T5. > The consumer index (CIDX) will now come via interrupts so that Tx > SKBs can be freed up sooner in Rx path.

Re: [PATCH v3 net-next] net: bridge: check vlan with eth_type_vlan() method

2021-01-16 Thread Jakub Kicinski
On Thu, 14 Jan 2021 20:41:31 -0800 menglong8.d...@gmail.com wrote: > - if (data[IFLA_BR_VLAN_PROTOCOL]) { > - switch (nla_get_be16(data[IFLA_BR_VLAN_PROTOCOL])) { > - case htons(ETH_P_8021Q): > - case htons(ETH_P_8021AD): > - break; > -

Re: [PATCH net-next V2 5/8] net/bonding: Implement TLS TX device offload

2021-01-16 Thread Jakub Kicinski
On Thu, 14 Jan 2021 20:01:32 +0200 Tariq Toukan wrote: > As the bond interface is being bypassed by the TLS module, interacting > directly against the slaves, there is no way for the bond interface to > disable its device offload capabilities, as long as the mode/policy > config allows it. > Hence,

Re: [PATCH net-next V2 1/8] net: netdevice: Add operation ndo_sk_get_slave

2021-01-16 Thread Jakub Kicinski
On Thu, 14 Jan 2021 20:01:28 +0200 Tariq Toukan wrote: > ndo_sk_get_slave returns the slave that corresponds to a given socket. > Additionally, we implement a helper netdev_sk_get_lowest_dev() to get > the lowest slave netdevice. Please don't add new uses of the word "slave" outside of the bond,

Re: [PATCH net-next 3/3] qede: set default per queue rx/tx usecs coalescing parameters

2021-01-16 Thread Jakub Kicinski
On Fri, 15 Jan 2021 01:06:10 -0800 Bhaskar Upadhaya wrote: > Here we do the initialization of coalescing values on load. > Although the default device values are the same - explicit > config is better visible. Can you also make the driver store the settings across ifdown / ifup and allow the setti

Re: [PATCH net 0/2] ipv6: fixes for the multicast routes

2021-01-16 Thread Matteo Croce
On Sat, Jan 16, 2021 at 5:41 AM David Ahern wrote: > > On 1/15/21 4:12 PM, Matteo Croce wrote: > > On Fri, Jan 15, 2021 at 11:50 PM Jakub Kicinski wrote: > >> > >> On Fri, 15 Jan 2021 19:42:07 +0100 Matteo Croce wrote: > >>> From: Matteo Croce > >>> > >>> Fix two wrong flags in the IPv6 multicas

Re: [PATCH net-next 1/3] qede: add netpoll support for qede driver

2021-01-16 Thread Jakub Kicinski
On Fri, 15 Jan 2021 01:06:08 -0800 Bhaskar Upadhaya wrote: > Add net poll controller support to transmit kernel printks > over UDP Why do you need this patch? Couple years back netpoll was taught how to pull NAPIs by itself, and all you do is schedule NAPIs. All the driver should do is to make s

Re: [PATCH net-next] net: hns3: debugfs add dump tm info of nodes, priority and qset

2021-01-16 Thread Jakub Kicinski
On Fri, 15 Jan 2021 15:09:29 +0800 Huazhong Tan wrote: > From: Guangbin Huang > > To increase methods to dump more tm info, adds three debugfs commands > to dump tm info of nodes, priority and qset. And a new tm file of debugfs > is created for only dumping tm info. > > Unlike previous debugfs c

Re: [RESEND v2 0/7] Rid W=1 warnings in Ethernet

2021-01-16 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Fri, 15 Jan 2021 20:08:58 + you wrote: > Resending the stragglers again. > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly lit

Re: [PATCH v2 bpf-next 2/2] selftests: bpf: Add a new test for bare tracepoints

2021-01-16 Thread Yonghong Song
On 1/16/21 10:21 AM, Qais Yousef wrote: Reuse module_attach infrastructure to add a new bare tracepoint to check we can attach to it as a raw tracepoint. Signed-off-by: Qais Yousef --- .../bpf/bpf_testmod/bpf_testmod-events.h | 6 + .../selftests/bpf/bpf_testmod/bpf_testmod.c

Re: [PATCH v2 bpf-next 1/2] trace: bpf: Allow bpf to attach to bare tracepoints

2021-01-16 Thread Yonghong Song
On 1/16/21 10:21 AM, Qais Yousef wrote: Some subsystems only have bare tracepoints (a tracepoint with no associated trace event) to avoid the problem of trace events being an ABI that can't be changed. From bpf presepective, bare tracepoints are what it calls RAW_TRACEPOINT(). Since bpf ass

Re: [PATCH v2 net-next 00/14] LAG offload for Ocelot DSA switches

2021-01-16 Thread Jakub Kicinski
On Sat, 16 Jan 2021 17:25:10 -0800 Jakub Kicinski wrote: > On Sat, 16 Jan 2021 17:51:03 +0200 Vladimir Oltean wrote: > > On Sat, Jan 16, 2021 at 02:59:29AM +0200, Vladimir Oltean wrote: > > > From: Vladimir Oltean > > > > > > This patch series reworks the ocelot switchdev driver such that it co

Re: [PATCH v2 net-next 01/14] net: mscc: ocelot: allow offloading of bridge on top of LAG

2021-01-16 Thread Jakub Kicinski
On Sat, 16 Jan 2021 02:59:30 +0200 Vladimir Oltean wrote: > From: Vladimir Oltean > > Commit 7afb3e575e5a ("net: mscc: ocelot: don't handle netdev events for > other netdevs") was too aggressive, and it made ocelot_netdevice_event > react only to network interface events emitted for the ocelot sw

Re: [PATCH v2 net-next 00/14] LAG offload for Ocelot DSA switches

2021-01-16 Thread Jakub Kicinski
On Sat, 16 Jan 2021 17:51:03 +0200 Vladimir Oltean wrote: > On Sat, Jan 16, 2021 at 02:59:29AM +0200, Vladimir Oltean wrote: > > From: Vladimir Oltean > > > > This patch series reworks the ocelot switchdev driver such that it could > > share the same implementation for LAG offload as the felix DS

Re: [PATCH iproute2] iplink: work around rtattr length limits for IFLA_VFINFO_LIST

2021-01-16 Thread Jakub Kicinski
On Sat, 16 Jan 2021 22:12:23 +0100 Michal Kubecek wrote: > On Fri, Jan 15, 2021 at 03:53:25PM -0800, Jakub Kicinski wrote: > > On Fri, 15 Jan 2021 14:59:50 -0800 Edwin Peer wrote: > > > The maximum possible length of an RTNL attribute is 64KB, but the > > > nested VFINFO list exceeds this for mor

Re: [PATCH net-next 1/1] stmmac: intel: change all EHL/TGL to auto detect phy addr

2021-01-16 Thread Jakub Kicinski
On Sat, 16 Jan 2021 10:12:21 +0100 Jan Kiszka wrote: > On 06.11.20 10:43, Wong Vee Khee wrote: > > From: Voon Weifeng > > > > Set all EHL/TGL phy_addr to -1 so that the driver will automatically > > detect it at run-time by probing all the possible 32 addresses. > > > > Signed-off-by: Voon Weife

[Patch net-next] net_sched: fix RTNL deadlock again caused by request_module()

2021-01-16 Thread Cong Wang
From: Cong Wang tcf_action_init_1() loads tc action modules automatically with request_module() after parsing the tc action names, and it drops RTNL lock and re-holds it before and after request_module(). This causes a lot of troubles, as discovered by syzbot, because we can be in the middle of b

Re: [PATCH net-next v5] GTP: add support for flow based tunneling API

2021-01-16 Thread Jakub Kicinski
On Sat, 9 Jan 2021 23:00:21 -0800 Pravin B Shelar wrote: > Following patch add support for flow based tunneling API > to send and recv GTP tunnel packet over tunnel metadata API. > This would allow this device integration with OVS or eBPF using > flow based tunneling APIs. > > Signed-off-by: Prav

Re: [PATCH net-next] net: mdio: access c22 registers via debugfs

2021-01-16 Thread kernel test robot
Hi "Pavel, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Pavel-imerda/net-mdio-access-c22-registers-via-debugfs/20210117-053409 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/ne

Re: [PATCH net-next] net: mdio: access c22 registers via debugfs

2021-01-16 Thread kernel test robot
Hi "Pavel, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Pavel-imerda/net-mdio-access-c22-registers-via-debugfs/20210117-053409 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/ne

[RFC PATCH] net: mdio: mdio_debug_fops can be static

2021-01-16 Thread kernel test robot
Reported-by: kernel test robot Signed-off-by: kernel test robot --- mdio-debugfs.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/phy/mdio-debugfs.c b/drivers/net/phy/mdio-debugfs.c index abed40052c20a1d..f1c9a3c604714c2 100644 --- a/drivers/net/phy/md

Re: [PATCH net-next] net: mdio: access c22 registers via debugfs

2021-01-16 Thread kernel test robot
Hi "Pavel, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Pavel-imerda/net-mdio-access-c22-registers-via-debugfs/20210117-053409 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/ne

[PATCH v3] netdevice.7: Update documentation for SIOCGIFADDR SIOCSIFADDR SIOCDIFADDR

2021-01-16 Thread Pali Rohár
Unlike SIOCGIFADDR and SIOCSIFADDR which are supported by many protocol families, SIOCDIFADDR is supported by AF_INET6 and AF_APPLETALK only. Unlike other protocols, AF_INET6 uses struct in6_ifreq. Signed-off-by: Pali Rohár --- man7/netdevice.7 | 64 +

Re: [PATCH v2] netdevice.7: Update documentation for SIOCGIFADDR SIOCSIFADDR SIOCDIFADDR

2021-01-16 Thread Pali Rohár
On Saturday 16 January 2021 01:41:24 Alejandro Colomar (man-pages) wrote: > On 1/12/21 8:26 PM, Pali Rohár wrote: > > On Sunday 10 January 2021 20:57:50 Alejandro Colomar (man-pages) wrote: > >> [ CC += netdev ] > >> > >> On 1/10/21 5:38 PM, Pali Rohár wrote: > >>> On Saturday 02 January 2021 19:39

Re: [PATCH net-next V2] net: ks8851: Fix mixed module/builtin build

2021-01-16 Thread Heiner Kallweit
On 16.01.2021 22:25, Marek Vasut wrote: > On 1/16/21 9:39 PM, Lukas Wunner wrote: >> On Sat, Jan 16, 2021 at 08:26:22PM +0100, Arnd Bergmann wrote: >>> On Sat, Jan 16, 2021 at 6:56 PM Marek Vasut wrote: On 1/16/21 6:04 PM, Arnd Bergmann wrote: > On Sat, Jan 16, 2021 at 5:48 PM Marek Vasut

[PATCH net-next] net: mdio: access c22 registers via debugfs

2021-01-16 Thread Pavel Šimerda
Provide a debugging interface to read and write MDIO registers directly without the need for a device driver. This is extremely useful when debugging switch hardware and phy hardware issues. The interface provides proper locking for communication that consists of a sequence of MDIO read/write comm

Re: [PATCH net-next V2] net: ks8851: Fix mixed module/builtin build

2021-01-16 Thread Marek Vasut
On 1/16/21 9:39 PM, Lukas Wunner wrote: On Sat, Jan 16, 2021 at 08:26:22PM +0100, Arnd Bergmann wrote: On Sat, Jan 16, 2021 at 6:56 PM Marek Vasut wrote: On 1/16/21 6:04 PM, Arnd Bergmann wrote: On Sat, Jan 16, 2021 at 5:48 PM Marek Vasut wrote: I don't really like this version, as it doe

Re: [PATCH iproute2] iplink: work around rtattr length limits for IFLA_VFINFO_LIST

2021-01-16 Thread Michal Kubecek
On Fri, Jan 15, 2021 at 03:53:25PM -0800, Jakub Kicinski wrote: > On Fri, 15 Jan 2021 14:59:50 -0800 Edwin Peer wrote: > > The maximum possible length of an RTNL attribute is 64KB, but the > > nested VFINFO list exceeds this for more than about 220 VFs (each VF > > consumes approximately 300 bytes,

Re: [PATCH net-next V2] net: ks8851: Fix mixed module/builtin build

2021-01-16 Thread Lukas Wunner
On Sat, Jan 16, 2021 at 08:26:22PM +0100, Arnd Bergmann wrote: > On Sat, Jan 16, 2021 at 6:56 PM Marek Vasut wrote: > > On 1/16/21 6:04 PM, Arnd Bergmann wrote: > > > On Sat, Jan 16, 2021 at 5:48 PM Marek Vasut wrote: > > > > > I don't really like this version, as it does not actually solve the

Re: [PATCH net-next V2] net: ks8851: Fix mixed module/builtin build

2021-01-16 Thread Arnd Bergmann
On Sat, Jan 16, 2021 at 6:56 PM Marek Vasut wrote: > On 1/16/21 6:04 PM, Arnd Bergmann wrote: > > On Sat, Jan 16, 2021 at 5:48 PM Marek Vasut wrote: > > > I don't really like this version, as it does not actually solve the problem > > of > > linking the same object file into both vmlinux and a l

[PATCH v2 bpf-next 0/2] Allow attaching to bare tracepoints

2021-01-16 Thread Qais Yousef
Changes in v2: * Fix compilation error. * Make the new test use write() instead of read() Add some missing glue logic to teach bpf about bare tracepoints - tracepoints without any trace event associated with them. Bare tracepoints are declare with DECLARE_TRACE(). Full tracepoints

[PATCH v2 bpf-next 1/2] trace: bpf: Allow bpf to attach to bare tracepoints

2021-01-16 Thread Qais Yousef
Some subsystems only have bare tracepoints (a tracepoint with no associated trace event) to avoid the problem of trace events being an ABI that can't be changed. >From bpf presepective, bare tracepoints are what it calls RAW_TRACEPOINT(). Since bpf assumed there's 1:1 mapping, it relied on hookin

[PATCH v2 bpf-next 2/2] selftests: bpf: Add a new test for bare tracepoints

2021-01-16 Thread Qais Yousef
Reuse module_attach infrastructure to add a new bare tracepoint to check we can attach to it as a raw tracepoint. Signed-off-by: Qais Yousef --- .../bpf/bpf_testmod/bpf_testmod-events.h | 6 + .../selftests/bpf/bpf_testmod/bpf_testmod.c | 21 ++- .../selftests/bpf/bpf_tes

Re: [PATCH net-next V2] net: ks8851: Fix mixed module/builtin build

2021-01-16 Thread Marek Vasut
On 1/16/21 6:04 PM, Arnd Bergmann wrote: On Sat, Jan 16, 2021 at 5:48 PM Marek Vasut wrote: When either the SPI or PAR variant is compiled as module AND the other variant is compiled as built-in, the following build error occurs: arm-linux-gnueabi-ld: drivers/net/ethernet/micrel/ks8851_common

Re: [PATCH net-next V2] net: ks8851: Fix mixed module/builtin build

2021-01-16 Thread Arnd Bergmann
On Sat, Jan 16, 2021 at 5:48 PM Marek Vasut wrote: > > When either the SPI or PAR variant is compiled as module AND the other > variant is compiled as built-in, the following build error occurs: > > arm-linux-gnueabi-ld: drivers/net/ethernet/micrel/ks8851_common.o: in > function `ks8851_probe_com

Re: [PATCH net-next] net: ks8851: Fix mixed module/builtin build

2021-01-16 Thread Marek Vasut
On 1/15/21 10:36 PM, Arnd Bergmann wrote: On Fri, Jan 15, 2021 at 6:24 PM Heiner Kallweit wrote: On 15.01.2021 16:59, Andrew Lunn wrote: On Fri, Jan 15, 2021 at 04:05:57PM +0100, Marek Vasut wrote: On 1/15/21 4:00 PM, Andrew Lunn wrote: On Fri, Jan 15, 2021 at 02:42:39PM +0100, Marek Vasut w

[PATCH net-next V2] net: ks8851: Fix mixed module/builtin build

2021-01-16 Thread Marek Vasut
When either the SPI or PAR variant is compiled as module AND the other variant is compiled as built-in, the following build error occurs: arm-linux-gnueabi-ld: drivers/net/ethernet/micrel/ks8851_common.o: in function `ks8851_probe_common': ks8851_common.c:(.text+0x1564): undefined reference to `_

Re: [PATCH v2 net-next 1/1] Allow user to set metric on default route learned via Router Advertisement.

2021-01-16 Thread David Ahern
On 1/15/21 1:02 AM, Praveen Chaudhary wrote: > For IPv4, default route is learned via DHCPv4 and user is allowed to change > metric using config etc/network/interfaces. But for IPv6, default route can > be learned via RA, for which, currently a fixed metric value 1024 is used. > > Ideally, user sh

Re: [PATCH v2 net-next 00/14] LAG offload for Ocelot DSA switches

2021-01-16 Thread Vladimir Oltean
On Sat, Jan 16, 2021 at 02:59:29AM +0200, Vladimir Oltean wrote: > From: Vladimir Oltean > > This patch series reworks the ocelot switchdev driver such that it could > share the same implementation for LAG offload as the felix DSA driver. Jakub, I sent these patches a few hours early because I d

[PATCH] rtnetlink.7: Remove IPv4 from description

2021-01-16 Thread Alejandro Colomar
From: Pali Rohár rtnetlink is not only used for IPv4 Signed-off-by: Pali Rohár Signed-off-by: Alejandro Colomar --- man7/rtnetlink.7 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man7/rtnetlink.7 b/man7/rtnetlink.7 index cd6809320..aec005ff9 100644 --- a/man7/rtnetlink.7

Re: [RFC PATCH v2] net: bridge: igmp: Extend IGMP query to be per vlan

2021-01-16 Thread Joachim Wiberg
On Wed, Jan 13, 2021 at 14:15, Nikolay Aleksandrov wrote: > On 12/01/2021 15:59, Horatiu Vultur wrote: >> Based on the comments of the previous version, we started to work on a >> new version, so it would be possible to enable/disable queries per vlan. >> [snip] >> We were wondering if this what y

[PATCH net-next] cxgb4: remove bogus CHELSIO_VPD_UNIQUE_ID constant

2021-01-16 Thread Heiner Kallweit
The comment is quite weird, there is no such thing as a vendor-specific VPD id. 0x82 is the value of PCI_VPD_LRDT_ID_STRING. So what we are doing here is simply checking whether the byte at VPD address VPD_BASE is a valid string LRDT, same as what is done a few lines later in the code. LRDT = Large

Re: [PATCH v2] hv_netvsc: Add (more) validation for untrusted Hyper-V values

2021-01-16 Thread Andrea Parri
On Fri, Jan 15, 2021 at 08:30:22PM -0800, Jakub Kicinski wrote: > On Thu, 14 Jan 2021 21:26:28 +0100 Andrea Parri (Microsoft) wrote: > > For additional robustness in the face of Hyper-V errors or malicious > > behavior, validate all values that originate from packets that Hyper-V > > has sent to th

[PATCH net-next] mdio, phy: fix -Wshadow warnings triggered by nested container_of()

2021-01-16 Thread Alexander Lobakin
container_of() macro hides a local variable '__mptr' inside. This becomes a problem when several container_of() are nested in each other within single line or plain macros. As C preprocessor doesn't support generating random variable names, the sole solution is to avoid defining macros that consist

[PATCH v2 net-next 1/1] net: dsa: hellcreek: Add TAPRIO offloading support

2021-01-16 Thread Kurt Kanzenbach
The switch has support for the 802.1Qbv Time Aware Shaper (TAS). Traffic schedules may be configured individually on each front port. Each port has eight egress queues. The traffic is mapped to a traffic class respectively via the PCP field of a VLAN tagged frame. The TAPRIO Qdisc already implemen

[PATCH v2 net-next 0/1] net: dsa: hellcreek: Add TAPRIO offloading

2021-01-16 Thread Kurt Kanzenbach
Hi, The switch has support for the 802.1Qbv Time Aware Shaper (TAS). Traffic schedules may be configured individually on each front port. Each port has eight egress queues. The traffic is mapped to a traffic class respectively via the PCP field of a VLAN tagged frame. Previous attempts: * https

Re: [PATCH net-next 2/2] net: dsa: mv88e6xxx: use mv88e6185_g1_vtu_getnext() for the 6250

2021-01-16 Thread Tobias Waldekranz
On Sat, Jan 16, 2021 at 03:39, Rasmus Villemoes wrote: > mv88e6250_g1_vtu_getnext is almost identical to > mv88e6185_g1_vtu_getnext, except for the 6250 only having 64 databases > instead of 256. We can reduce code duplication by simply masking off > the extra two garbage bits when assembling the

Re: [PATCH net 1/2] net: dsa: mv88e6xxx: also read STU state in mv88e6250_g1_vtu_getnext

2021-01-16 Thread Tobias Waldekranz
On Sat, Jan 16, 2021 at 03:39, Rasmus Villemoes wrote: > mv88e6xxx_port_vlan_join checks whether the VTU already contains an > entry for the given vid (via mv88e6xxx_vtu_getnext), and if so, merely > changes the relevant .member[] element and loads the updated entry > into the VTU. > > However, a

Re: [PATCH net 1/2] ipv6: create multicast route with RTPROT_KERNEL

2021-01-16 Thread Matteo Croce
On Sat, Jan 16, 2021 at 5:36 AM David Ahern wrote: > > On 1/15/21 11:42 AM, Matteo Croce wrote: > > From: Matteo Croce > > > > The ff00::/8 multicast route is created without specifying the fc_protocol > > field, so the default RTPROT_BOOT value is used: > > > > $ ip -6 -d route > > unicast :

[PATCH net 2/2] netfilter: rpfilter: mask ecn bits before fib lookup

2021-01-16 Thread Guillaume Nault
RT_TOS() only masks one of the two ECN bits. Therefore rpfilter_mt() treats Not-ECT or ECT(1) packets in a different way than those with ECT(0) or CE. Reproducer: Create two netns, connected with a veth: $ ip netns add ns0 $ ip netns add ns1 $ ip link add name veth01 netns ns0 type veth p

[PATCH net 0/2] ipv4: Ensure ECN bits don't influence source address validation

2021-01-16 Thread Guillaume Nault
Functions that end up calling fib_table_lookup() should clear the ECN bits from the TOS, otherwise ECT(0) and ECT(1) packets can be treated differently. Most functions already clear the ECN bits, but there are a few cases where this is not done. This series only fixes the ones related to source ad

[PATCH net 1/2] udp: mask TOS bits in udp_v4_early_demux()

2021-01-16 Thread Guillaume Nault
udp_v4_early_demux() is the only function that calls ip_mc_validate_source() with a TOS that hasn't been masked with IPTOS_RT_MASK. This results in different behaviours for incoming multicast UDPv4 packets, depending on if ip_mc_validate_source() is called from the early-demux path (udp_v4_early_d

Re: [PATCH V2 4/4] net: ethernet: ravb: Enable optional refclk

2021-01-16 Thread Sergei Shtylyov
Hello! On 15.01.2021 23:19, Adam Ford wrote: For devices that use a programmable clock for the avb reference clock, AVB. the driver may need to enable them. Add code to find the optional clock and enable it when available. Signed-off-by: Adam Ford [...] diff --git a/drivers/net/ethe

[PATCH RFC] tools: Factor Clang, LLC and LLVM utils definitions

2021-01-16 Thread Sedat Dilek
When dealing with BPF/BTF/pahole and DWARF v5 I wanted to build bpftool. While looking into the source code I found duplicate assignments in misc tools for the LLVM eco system, e.g. clang and llvm-objcopy. Move the Clang, LLC and/or LLVM utils definitions to tools/scripts/Makefile.include file an

Re: [PATCH net-next 1/1] stmmac: intel: change all EHL/TGL to auto detect phy addr

2021-01-16 Thread Jan Kiszka
On 06.11.20 10:43, Wong Vee Khee wrote: > From: Voon Weifeng > > Set all EHL/TGL phy_addr to -1 so that the driver will automatically > detect it at run-time by probing all the possible 32 addresses. > > Signed-off-by: Voon Weifeng > Signed-off-by: Wong Vee Khee > --- > drivers/net/ethernet/s

Re: [PATCH mlx5-next v2 2/5] PCI: Add SR-IOV sysfs entry to read total number of dynamic MSI-X vectors

2021-01-16 Thread Leon Romanovsky
On Thu, Jan 14, 2021 at 05:05:36PM -0700, Alex Williamson wrote: > On Thu, 14 Jan 2021 12:31:37 +0200 > Leon Romanovsky wrote: > > > From: Leon Romanovsky > > > > Some SR-IOV capable devices provide an ability to configure specific > > number of MSI-X vectors on their VF prior driver is probed on

Re: [PATCH mlx5-next v2 1/5] PCI: Add sysfs callback to allow MSI-X table size change of SR-IOV VFs

2021-01-16 Thread Leon Romanovsky
On Thu, Jan 14, 2021 at 05:05:43PM -0700, Alex Williamson wrote: > On Thu, 14 Jan 2021 12:31:36 +0200 > Leon Romanovsky wrote: > > > From: Leon Romanovsky > > > > Extend PCI sysfs interface with a new callback that allows configure > > the number of MSI-X vectors for specific SR-IO VF. This is ne

Re: [PATCH mlx5-next v1 2/5] PCI: Add SR-IOV sysfs entry to read number of MSI-X vectors

2021-01-16 Thread Leon Romanovsky
On Fri, Jan 15, 2021 at 05:48:59PM -0800, Alexander Duyck wrote: > On Fri, Jan 15, 2021 at 7:53 AM Leon Romanovsky wrote: > > > > On Fri, Jan 15, 2021 at 10:06:19AM -0400, Jason Gunthorpe wrote: > > > On Thu, Jan 14, 2021 at 05:56:20PM -0800, Alexander Duyck wrote: > > > > > > > That said, it only

Re: [PATCH bpf-next] xsk: build skb by page

2021-01-16 Thread kernel test robot
Hi Xuan, Thank you for the patch! Yet something to improve: [auto build test ERROR on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Xuan-Zhuo/xsk-build-skb-by-page/20210116-105116 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master config: sh