Hi "Pavel, Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Pavel-imerda/net-mdio-access-c22-registers-via-debugfs/20210117-053409 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 9ab7e76aefc97a9aa664accb59d6e8dc5e52514a config: i386-randconfig-s002-20210117 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.3-208-g46a52ca4-dirty # https://github.com/0day-ci/linux/commit/22d74f4896850840331d36d6867f7bc5ce728bbd git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Pavel-imerda/net-mdio-access-c22-registers-via-debugfs/20210117-053409 git checkout 22d74f4896850840331d36d6867f7bc5ce728bbd # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> "sparse warnings: (new ones prefixed by >>)" >> drivers/net/phy/mdio-debugfs.c:160:17: sparse: sparse: incorrect type in >> initializer (different base types) @@ expected restricted __poll_t ( >> *poll )( ... ) @@ got unsigned int ( * )( ... ) @@ drivers/net/phy/mdio-debugfs.c:160:17: sparse: expected restricted __poll_t ( *poll )( ... ) drivers/net/phy/mdio-debugfs.c:160:17: sparse: got unsigned int ( * )( ... ) >> drivers/net/phy/mdio-debugfs.c:154:24: sparse: sparse: symbol >> 'mdio_debug_fops' was not declared. Should it be static? >> drivers/net/phy/mdio-debugfs.c:184:12: sparse: sparse: symbol >> 'mdio_debugfs_init' was not declared. Should it be static? >> drivers/net/phy/mdio-debugfs.c:192:13: sparse: sparse: symbol >> 'mdio_debugfs_exit' was not declared. Should it be static? Please review and possibly fold the followup patch. vim +160 drivers/net/phy/mdio-debugfs.c 153 > 154 struct file_operations mdio_debug_fops = { 155 .owner = THIS_MODULE, 156 .open = mdio_debug_open, 157 .release = mdio_debug_release, 158 .write = mdio_debug_write, 159 .read = mdio_debug_read, > 160 .poll = mdio_debug_poll, 161 }; 162 163 /* 164 * TODO: This implementation doesn't support module load/unload and has no 165 * error checking. 166 */ 167 168 static struct dentry *mdio_debugfs_dentry; 169 170 void mdio_debugfs_add(struct mii_bus *bus) 171 { 172 bus->debugfs_dentry = debugfs_create_dir(dev_name(&bus->dev), mdio_debugfs_dentry); 173 debugfs_create_file("control", 0600, bus->debugfs_dentry, bus, &mdio_debug_fops); 174 } 175 EXPORT_SYMBOL_GPL(mdio_debugfs_add); 176 177 void mdio_debugfs_remove(struct mii_bus *bus) 178 { 179 debugfs_remove(bus->debugfs_dentry); 180 bus->debugfs_dentry = NULL; 181 } 182 EXPORT_SYMBOL_GPL(mdio_debugfs_remove); 183 > 184 int __init mdio_debugfs_init(void) 185 { 186 mdio_debugfs_dentry = debugfs_create_dir("mdio", NULL); 187 188 return PTR_ERR_OR_ZERO(mdio_debugfs_dentry); 189 } 190 module_init(mdio_debugfs_init); 191 > 192 void __exit mdio_debugfs_exit(void) --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
