On Thu, 14 Jan 2021 20:01:32 +0200 Tariq Toukan wrote: > As the bond interface is being bypassed by the TLS module, interacting > directly against the slaves, there is no way for the bond interface to > disable its device offload capabilities, as long as the mode/policy > config allows it. > Hence, the feature flag is not directly controllable, but just reflects > the current offload status based on the logic under bond_sk_check().
In that case why set it in ->hw_features ? IIRC features set only in ->features but not ->hw_features show up to userspace as "fixed" which I gather is what we want here, no? > +#if IS_ENABLED(CONFIG_TLS_DEVICE) > + bond_dev->hw_features |= BOND_TLS_FEATURES; > + if (bond_sk_check(bond)) > + bond_dev->features |= BOND_TLS_FEATURES; > +#endif
