> On Oct 29, 2020, at 7:33 PM, Andrii Nakryiko
> wrote:
>
> On Thu, Oct 29, 2020 at 5:33 PM Song Liu wrote:
>>
>>
>>
>>> On Oct 28, 2020, at 5:58 PM, Andrii Nakryiko wrote:
>>>
>>> This patch set adds support for generating and deduplicating split BTF. This
>>> is an enhancement to the
On Fri Oct 30 2020, Vladimir Oltean wrote:
> At the moment, taggers are left with the task of ensuring that the skb
> headers are writable (which they aren't, if the frames were cloned for
> TX timestamping, for flooding by the bridge, etc), and that there is
> enough space in the skb data area for
Mauro Carvalho Chehab writes:
> There are some ABI documents that, while they don't generate
> any warnings, they have issues when parsed by get_abi.pl script
> on its output result.
>
> Address them, in order to provide a clean output.
>
> Signed-off-by: Mauro Carvalho Chehab
> diff --git a/D
Realtek single-port 2.5Gbps Ethernet PHYs are list as below:
RTL8226-CG: the 1st generation 2.5Gbps single port PHY
RTL8226B-CG/RTL8221B-CG: the 2nd generation 2.5Gbps single port PHY
RTL8221B-VB-CG: the 3rd generation 2.5Gbps single port PHY
RTL8221B-VM-CG: the 2.5Gbps single port PHY with MACsec
On 10/29/20 7:45 PM, Hemant Kumar wrote:
> diff --git a/drivers/bus/mhi/Kconfig b/drivers/bus/mhi/Kconfig
> index e841c10..476cc55 100644
> --- a/drivers/bus/mhi/Kconfig
> +++ b/drivers/bus/mhi/Kconfig
> @@ -20,3 +20,16 @@ config MHI_BUS_DEBUG
> Enable debugfs support for use with the MHI t
Hi Lorenzo,
On Thu, Oct 29, 2020 at 08:28:44PM +0100, Lorenzo Bianconi wrote:
> XDP bulk APIs introduce a defer/flush mechanism to return
> pages belonging to the same xdp_mem_allocator object
> (identified via the mem.id field) in bulk to optimize
> I-cache and D-cache since xdp_return_frame is
On Wed, Oct 28, 2020 at 07:05:19PM +0100, Guillaume Nault wrote:
>Test different encapsulation modes of the bareudp module:
Comprehensive tests. Thanks a lot William.
On 2020-10-23 19:02, Sukadev Bhattiprolu wrote:
Lijun Pan [l...@linux.vnet.ibm.com] wrote:
On Oct 19, 2020, at 2:52 PM, Sukadev Bhattiprolu
<[1]suka...@linux.ibm.com> wrote:
From 67f8977f636e462a1cd1eadb28edd98ef4f2b756 Mon Sep 17 00:00:00
2001
From: Sukadev Bhattiprolu <[2]suka..
From: wenxu
The tunnel dvice such as vxlan, bareudp and geneve in the lwt mode set
the outer df only based TUNNEL_DONT_FRAGMENT.
And this is also the some behavior for gre device before switching to use
ip_md_tunnel_xmit as the following patch.
962924f ip_gre: Refactor collect metatdata mode
syzbot suspects this issue was fixed by commit:
commit 1d0e850a49a5b56f8f3cb51e74a11e2fedb96be6
Author: David Howells
Date: Fri Oct 16 12:21:14 2020 +
afs: Fix cell removal
bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=164fdca850
start commit: fb0155a0 Merge tag '
Support ECM mode based on cdc_ether with relative mii functions,
when CONFIG_USB_RTL8152 is not set, or the device is not supported
by r8152 driver.
Signed-off-by: Hayes Wang
---
v2:
Add include/linux/usb/r8152.h to avoid the warning about
no previous prototype for rtl8152_get_version.
drivers/
On Thu, Oct 29, 2020 at 05:28:11PM -0700, Nick Desaulniers wrote:
>
> We already know that -fno-asynchronous-unwind-tables get dropped,
> hence this patch.
On arm64 only. Not on x86
> And we know -fomit-frame-pointer or
> -fno-omit-frame-pointer I guess gets dropped, hence your ask.
yep. th
On Tue, 27 Oct 2020 10:02:41 + Henrik Bjoernlund wrote:
> Connectivity Fault Management (CFM) is defined in 802.1Q
> section 12.14.
>
> Connectivity Fault Management (CFM) comprises capabilities for
> detecting, verifying, and isolating connectivity failures in Virtual
> Bridged Networks. Thes
On Tue, 27 Oct 2020 12:43:17 +0100 Łukasz Stelmach wrote:
> Unify the set of information returned by mii_ethtool_get_link_ksettings(),
> mii_ethtool_gset() and phy_ethtool_ksettings_get(). Make the mii_*()
> functions report advertised settings when autonegotiation if disabled.
>
> Suggested-by: A
On Tue, 27 Oct 2020 21:51:59 +0800 Zhang Qilong wrote:
> The 'break' is unnecessary because of previous 'return',
> and we could discard it.
>
> Signed-off-by: Zhang Qilong
Applied.
On Fri, Oct 30, 2020 at 6:42 AM Jakub Kicinski wrote:
>
> On Thu, 29 Oct 2020 02:12:21 +0800 DENG Qingfang wrote:
> > MT7530/7531 has a global RX packet length register, which can be used
> > to set MTU.
> >
> > Signed-off-by: DENG Qingfang
>
> Please wrap your code at 80 chars.
>
> > diff --git
On 10/29/20 6:42 PM, Sharma, Puneet wrote:
> Because basic match is made of multiple keywords and parsed and handle
> differently
> example:
> $ tc filter add dev $eth_dev_name ingress priority 2 protocol ipv4
> basic match '(cmp(u8 at 9 layer network eq 6) or cmp(u8 at 9 layer network
Introduce mhi_get_free_desc_count() API to return number
of TREs available to queue buffer. MHI clients can use this
API to know before hand if ring is full without calling queue
API.
Signed-off-by: Hemant Kumar
Reviewed-by: Jeffrey Hugo
Reviewed-by: Manivannan Sadhasivam
---
drivers/bus/mhi/c
MHI userspace client driver is creating device file node
for user application to perform file operations. File
operations are handled by MHI core driver. Currently
Loopback MHI channel is supported by this driver.
Signed-off-by: Hemant Kumar
---
Documentation/mhi/index.rst | 1 +
Documentation/
On Thu, Oct 29, 2020 21:49, Heiner Hallweit wrote:
> On 29.10.2020 14:37, Andrew Lunn wrote:
> > On Thu, Oct 29, 2020 at 08:07:57PM +0800, Willy Liu wrote:
> >> Realtek single-port 2.5Gbps Ethernet PHY ids as below:
> >> RTL8226-CG: 0x001cc800(ES)/0x001cc838(MP)
> >> RTL8226B-CG/RTL8221B-CG: 0x001c
This patch series adds support for UCI driver. UCI driver enables userspace
clients to communicate to external MHI devices like modem and WLAN. UCI driver
probe creates standard character device file nodes for userspace clients to
perform open, read, write, poll and release file operations. These f
Currently this macro is defined in internal MHI header as
a TRE length mask. Moving it to external header allows MHI
client drivers to set this upper bound for the transmit
buffer size.
Signed-off-by: Hemant Kumar
Reviewed-by: Jeffrey Hugo
Reviewed-by: Manivannan Sadhasivam
---
drivers/bus/mhi
This MHI client driver allows userspace clients to transfer
raw data between MHI device and host using standard file operations.
Driver instantiates UCI device object which is associated to device
file node. UCI device object instantiates UCI channel object when device
file node is opened. UCI chan
On Thu, Oct 29, 2020 at 9:02 PM Andrew Lunn wrote:
>
> On Thu, Oct 29, 2020 at 02:39:15PM +0800, DENG Qingfang wrote:
> > MT762x HW supports frame length up to 2048 (maximum length on GDM),
> > so allow setting MTU up to 2030.
> >
> > Signed-off-by: DENG Qingfang
> > ---
> >
> > I only tested thi
On Thu, Oct 29, 2020 at 5:33 PM Song Liu wrote:
>
>
>
> > On Oct 28, 2020, at 5:58 PM, Andrii Nakryiko wrote:
> >
> > This patch set adds support for generating and deduplicating split BTF. This
> > is an enhancement to the BTF, which allows to designate one BTF as the "base
> > BTF" (e.g., vmlin
The main purpose of this series is the last patch. The previous 4 patches
are just code clean-ups so that the last patch will not make the code too
messy. The patches must be applied in sequence.
The receiving code of this driver doesn't support arbitrary Ethertype
values. It only recognizes a few
When an skb is received on a normal (non-Ethernet-emulating) PVC device,
call skb_reset_mac_header before we pass it to upper layers.
This is because normal PVC devices don't have header_ops, so any header we
have would not be visible to upper layer code when sending, so the header
shouldn't be vi
1.
Change the skb->len check from "<= 4" to "< 4".
At first we only need to ensure a 4-byte header is present. We indeed
normally need the 5th byte, too, but it'd be more logical and cleaner
to check its existence when we actually need it.
2.
Add an fh->ea2 check to the initial checks in fr_rx. fh
Change the fr_rx function to make this driver support any Ethertype
when receiving skbs on normal (non-Ethernet-emulating) PVC devices.
(This driver is already able to handle any Ethertype when sending.)
Originally in the fr_rx function, the code that parses the long (10-byte)
header only recogniz
On Thu, Oct 29, 2020 at 5:42 PM Alexander Duyck
wrote:
>
> On Thu, Oct 29, 2020 at 4:20 PM Andrii Nakryiko
> wrote:
> >
> > On Thu, Oct 29, 2020 at 12:57 AM Alexander Duyck
> > wrote:
> > >
> > > From: Alexander Duyck
> > >
> > > Update tcpbpf_user.c to make use of the BPF skeleton. Doing this
1.
When the fr_rx function drops a received frame (because the protocol type
is not supported, or because the PVC virtual device that corresponds to
the DLCI number and the protocol type doesn't exist), the function frees
the skb and returns.
The code for freeing the skb and returning is repeated
The eth_type_trans function is called when we receive frames carrying
Ethernet frames. This function expects a non-NULL pointer as an argument,
and assigns it directly to skb->dev.
However, the code handling other types of frames first assigns the pointer
to "dev", and then at the end checks wheth
32-bit to 64-bit messages translator zerofies needed paddings in the
translation, the rest is the actual payload.
Don't allocate zero pages as they are not needed.
Signed-off-by: Dmitry Safonov
---
net/xfrm/xfrm_compat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/xfr
32-bit messages translated by xfrm_compat can have attributes attached.
For all, but XFRMA_SA, XFRMA_POLICY the size of payload is the same
in 32-bit UABI and 64-bit UABI. For XFRMA_SA (struct xfrm_usersa_info)
and XFRMA_POLICY (struct xfrm_userpolicy_info) it's only tail-padding
that is present in
WARN_ON() for XFRMA_UNSPEC translation which likely no-one except
syzkaller uses; properly zerofy tail-padding for 64-bit attribute;
don't use __GFP_ZERO as the memory is initialized during translation.
Cc: Steffen Klassert
Cc: "David S. Miller"
Cc: Jakub Kicinski
Cc: Herbert Xu
Cc: Hillf Dant
xfrm_xlate32() translates 64-bit message provided by kernel to be sent
for 32-bit listener (acknowledge or monitor). Translator code doesn't
expect XFRMA_UNSPEC attribute as it doesn't know its payload.
Kernel never attaches such attribute, but a user can.
I've searched if any opensource does it a
Hi Randy,
On 10/29/20 2:51 PM, Randy Dunlap wrote:
Hi,
On 10/29/20 2:40 PM, Hemant Kumar wrote:
MHI userspace client driver is creating device file node
for user application to perform file operations. File
operations are handled by MHI core driver. Currently
Loopback MHI channel is supported
Now that we have a central TX reallocation procedure that accounts for
the tagger's needed headroom in a generic way, we can remove the
skb_cow_head call.
Similar to the EtherType DSA tagger, the old Marvell tagger can
transform an 802.1Q header if present into a DSA tag, so there is no
headroom r
Now that we have a central TX reallocation procedure that accounts for
the tagger's needed headroom in a generic way, we can remove the
skb_cow_head call.
Cc: John Crispin
Cc: Alexander Lobakin
Signed-off-by: Vladimir Oltean
---
Changes in v2:
None.
net/dsa/tag_qca.c | 3 ---
1 file changed,
Now that we have a central TX reallocation procedure that accounts for
the tagger's needed headroom in a generic way, we can remove the
skb_cow_head call.
Cc: Per Forlin
Cc: Oleksij Rempel
Signed-off-by: Vladimir Oltean
---
Changes in v2:
None.
net/dsa/tag_ar9331.c | 3 ---
1 file changed, 3
Now that we have a central TX reallocation procedure that accounts for
the tagger's needed headroom in a generic way, we can remove the
skb_cow_head call.
Cc: Florian Fainelli
Signed-off-by: Vladimir Oltean
---
Changes in v2:
None.
net/dsa/tag_brcm.c | 3 ---
1 file changed, 3 deletions(-)
di
Now that we have a central TX reallocation procedure that accounts for
the tagger's needed headroom in a generic way, we can remove the
skb_cow_head call.
Cc: DENG Qingfang
Cc: Sean Wang
Cc: John Crispin
Signed-off-by: Vladimir Oltean
---
Changes in v2:
None.
net/dsa/tag_mtk.c | 3 ---
1 fil
Now that we have a central TX reallocation procedure that accounts for
the tagger's needed headroom in a generic way, we can remove the
skb_cow_head call.
Signed-off-by: Vladimir Oltean
---
Changes in v2:
None.
net/dsa/tag_lan9303.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/ne
Now that we have a central TX reallocation procedure that accounts for
the tagger's needed headroom in a generic way, we can remove the
skb_cow_head call.
Signed-off-by: Vladimir Oltean
---
Changes in v2:
None.
net/dsa/tag_ocelot.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/net/d
Now that we have a central TX reallocation procedure that accounts for
the tagger's needed headroom in a generic way, we can remove the
skb_cow_head call.
This one is interesting, the DSA tag is 8 bytes on RX and 4 bytes on TX.
Because DSA is unaware of asymmetrical tag lengths, the overhead/neede
Now that we have a central TX reallocation procedure that accounts for
the tagger's needed headroom in a generic way, we can remove the
skb_cow_head call.
Note that the VLAN code path needs a smaller extra headroom than the
regular EtherType DSA path. That isn't a problem, because this tagger
decl
From: Christian Eggers
The caller (dsa_slave_xmit) guarantees that the frame length is at least
ETH_ZLEN and that enough memory for tail tagging is available.
Signed-off-by: Christian Eggers
Signed-off-by: Vladimir Oltean
---
Changes in v2:
None.
net/dsa/tag_trailer.c | 31 ++
Christian has reported buggy usage of skb_put() in tag_ksz.c, which is
only triggerable in real life using his not-yet-published patches for
IEEE 1588 timestamping on Micrel KSZ switches.
The concrete problem there is that the driver can end up calling
skb_put() and exceed the end of the skb data
At the moment, taggers are left with the task of ensuring that the skb
headers are writable (which they aren't, if the frames were cloned for
TX timestamping, for flooding by the bridge, etc), and that there is
enough space in the skb data area for the DSA tag to be pushed.
Moreover, the life of t
From: Christian Eggers
The caller (dsa_slave_xmit) guarantees that the frame length is at least
ETH_ZLEN and that enough memory for tail tagging is available.
Signed-off-by: Christian Eggers
Signed-off-by: Vladimir Oltean
---
Changes in v2:
None.
net/dsa/tag_ksz.c | 73 ++
On 2020/10/29 23:18, David Ahern wrote:
> On 10/29/20 8:10 AM, Joakim Tjernlund wrote:
>> OK, bisecting (was a bit of a bother since we merge upstream releases into
>> our tree, is there a way to just bisect that?)
>>
>> Result was commit "net: sch_generic: aviod concurrent reset and enqueue op
>
From: Jon Maloy
TIPC reserves 64 service types for current and future internal use.
Therefore, the bind() function is meant to block regular user sockets
from being bound to these values, while it should let through such
bindings from internal users.
However, since we at the design moment saw no
On Thu, 29 Oct 2020 10:30:50 +0800 wenxu wrote:
> On 10/27/2020 11:55 PM, Jakub Kicinski wrote:
> > On Tue, 27 Oct 2020 08:51:07 -0600 David Ahern wrote:
> >>> Is this another incarnation of 4cb47a8644cc ("tunnels: PMTU discovery
> >>> support for directly bridged IP packets")? Sounds like non-UD
On Thu, Oct 29, 2020 at 8:49 PM Xie He wrote:
>
> On Thu, Oct 29, 2020 at 4:53 PM Xie He wrote:
> >
> > > Does it make sense to define a struct snap_hdr instead of manually
> > > casting all these bytes?
> >
> > > And macros or constant integers to self document these kinds of fields.
> >
> > Yes
On Thu, Oct 29, 2020 at 7:53 PM Xie He wrote:
>
> On Thu, Oct 29, 2020 at 10:24 AM Willem de Bruijn
> wrote:
> >
> > > Also add skb_reset_mac_header before we pass an skb (received on normal
> > > PVC devices) to upper layers. Because we don't use header_ops for normal
> > > PVC devices, we shoul
On Thu, Oct 29, 2020 at 4:53 PM Xie He wrote:
>
> > Does it make sense to define a struct snap_hdr instead of manually
> > casting all these bytes?
>
> > And macros or constant integers to self document these kinds of fields.
>
> Yes, we can define a struct snap_hdr, like this:
>
> struct snap_hdr
Because basic match is made of multiple keywords and parsed and handle
differently
example:
$ tc filter add dev $eth_dev_name ingress priority 2 protocol ipv4
basic match '(cmp(u8 at 9 layer network eq 6) or cmp(u8 at 9 layer network eq
17)) and ipset(sg-test-ipv4 src)' action pass
On Thu, Oct 29, 2020 at 4:20 PM Andrii Nakryiko
wrote:
>
> On Thu, Oct 29, 2020 at 12:57 AM Alexander Duyck
> wrote:
> >
> > From: Alexander Duyck
> >
> > Update tcpbpf_user.c to make use of the BPF skeleton. Doing this we can
> > simplify test_tcpbpf_user and reduce the overhead involved in set
On Tue, 27 Oct 2020 09:09:40 + Colin King wrote:
> From: Colin Ian King
>
> Two minor changes to the ioctl error handling.
Applied, thanks!
On Thu, Oct 29, 2020 at 4:27 PM Andrii Nakryiko
wrote:
>
> On Wed, Oct 28, 2020 at 4:50 PM Alexander Duyck
> wrote:
> >
> > From: Alexander Duyck
> >
> > Recently a bug was missed due to the fact that test_tcpbpf_user is not a
> > part of test_progs. In order to prevent similar issues in the fut
> On Oct 28, 2020, at 5:58 PM, Andrii Nakryiko wrote:
>
> Factor out commiting of appended type data. Also extract fetching the very
> last type in the BTF (to append members to). These two operations are common
> across many APIs and will be easier to refactor with split BTF, if they are
> ex
> On Oct 28, 2020, at 5:58 PM, Andrii Nakryiko wrote:
>
> This patch set adds support for generating and deduplicating split BTF. This
> is an enhancement to the BTF, which allows to designate one BTF as the "base
> BTF" (e.g., vmlinux BTF), and one or more other BTFs as "split BTF" (e.g.,
> k
Hi Daniel,
On Thu, Oct 29, 2020 at 3:25 PM Daniel Winkler wrote:
>
> Hi Luiz,
>
> Thank you for the feedback regarding mgmt-tester. I intended to use
> the tool, but found that it had a very high rate of test failure even
> before I started adding new tests. If you have a strong preference for
>
On Wed, Oct 28, 2020 at 03:22:32PM +1000, Greg Ungerer wrote:
> Some (apparently older) versions of the FEC hardware block do not like
> the MMFR register being cleared to avoid generation of MII events at
> initialization time. The action of clearing this register results in no
> future MII events
On Thu, Oct 29, 2020 at 10:24 AM Willem de Bruijn
wrote:
>
> > Also add skb_reset_mac_header before we pass an skb (received on normal
> > PVC devices) to upper layers. Because we don't use header_ops for normal
> > PVC devices, we should hide the header from upper layer code in this case.
>
> Thi
syzbot suspects this issue was fixed by commit:
commit 1d0e850a49a5b56f8f3cb51e74a11e2fedb96be6
Author: David Howells
Date: Fri Oct 16 12:21:14 2020 +
afs: Fix cell removal
bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=14bc220a50
start commit: fb0155a0 Merge tag '
On Thu, Oct 29, 2020 at 3:37 PM Andrii Nakryiko
wrote:
>
> On Thu, Oct 29, 2020 at 11:36 AM Song Liu wrote:
> >
> > On Thu, Oct 29, 2020 at 4:19 AM David Verbeiren
> > wrote:
> > >
> > > Tests that when per-cpu hash map or LRU hash map elements are
> > > re-used as a result of a bpf program inse
On Wed, Oct 28, 2020 at 4:50 PM Alexander Duyck
wrote:
>
> From: Alexander Duyck
>
> Recently a bug was missed due to the fact that test_tcpbpf_user is not a
> part of test_progs. In order to prevent similar issues in the future move
> the test functionality into test_progs. By doing this we can
On 10/29/2020 2:53 PM, Michael S. Tsirkin wrote:
On Thu, Oct 15, 2020 at 01:17:14PM -0700, si-wei liu wrote:
On 10/15/2020 6:11 AM, Michael S. Tsirkin wrote:
On Thu, Oct 15, 2020 at 02:15:32PM +0800, Jason Wang wrote:
On 2020/10/14 上午7:42, si-wei liu wrote:
So what I suggest is to fix the p
On Thu, Oct 29, 2020 at 12:57 AM Alexander Duyck
wrote:
>
> From: Alexander Duyck
>
> Update tcpbpf_user.c to make use of the BPF skeleton. Doing this we can
> simplify test_tcpbpf_user and reduce the overhead involved in setting up
> the test.
>
> Signed-off-by: Alexander Duyck
> ---
Few sugge
On Thu, 29 Oct 2020 21:20:55 +
"Sharma, Puneet" wrote:
> I did provide an example to better explain what patch is doing.
>
> Sorry for long paste.
>
> So, with current implementation output of command:
> $ tc -s -d -j filter show dev ingress
>
> would contain:
> [{
> "protocol": "
On Thu, Oct 29, 2020 at 9:58 AM Willem de Bruijn
wrote:
>
> No need for dev at all then?
Right, there's no need for "dev" at all actually. I kept "dev" just to
keep the code for updating "dev->stats" simpler, because otherwise we
need to write "skb->dev->stats" instead, and there are 3 lines wher
On Thu, Oct 29, 2020 at 10:00 AM Willem de Bruijn
wrote:
>
> This does change rx_dropped count on errors. Not sure how important
> that is. But perhaps good to call out in the commit explicitly if it's
> intentional.
Yes, this is intentional, because I think we need to count it as a
"drop" whenev
On Thu, 29 Oct 2020 13:34:45 +0100 Andrew Lunn wrote:
> On Thu, Oct 29, 2020 at 10:33:52AM +0800, Zou Wei wrote:
> > Fix the following coccinelle report:
> >
> > ./drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c:233:6-8:
> > WARNING: possible condition with no effect (if == else)
> >
> > Bo
It was <2020-10-29 czw 18:27>, when Marc Kleine-Budde wrote:
> On 10/28/20 10:40 PM, Łukasz Stelmach wrote:
>> ASIX AX88796[1] is a versatile ethernet adapter chip, that can be
>> connected to a CPU with a 8/16-bit bus or with an SPI. This driver
>> supports SPI connection.
>>
>> The driver has be
Cc'ing Cong, Paul, Oz and Davide.
On Thu, Oct 29, 2020 at 10:22:04AM +0800, wenxu wrote:
> Only do gso for the reassembly big packet is also can't fix all the
> case such for icmp packet.
Good point. And as we can't know that a fragment was for an icmp
packet before defraging it, this is quite im
> On Oct 29, 2020, at 3:38 PM, Andrii Nakryiko
> wrote:
>
> On Thu, Oct 29, 2020 at 3:38 PM Ian Rogers wrote:
>>
>> If bits is 0, the case when the map is empty, then the >> is the size of
>> the register which is undefined behavior - on x86 it is the same as a
>> shift by 0. Fix by handlin
On Thu, 29 Oct 2020 15:53:48 -0700
Jakub Kicinski wrote:
> +1
>
> Maybe we should patch checkpatch to still enforce 80 for networking.
If you do, do that for leds as well, Pavel will be glad.
On Thu, 29 Oct 2020 13:41:07 + Russell King - ARM Linux admin wrote:
> On Thu, Oct 29, 2020 at 01:54:39PM +0100, Andrew Lunn wrote:
> > > It would be good to pass this through checkpatch - I notice some lines
> > > seem to be over the 80 character limit now.
> >
> > Hi Russell
> >
> > The l
On Thu, Oct 29, 2020 at 2:31 AM Jiri Olsa wrote:
>
> On Wed, Oct 28, 2020 at 02:15:02PM -0700, Alexei Starovoitov wrote:
> > On Wed, Oct 28, 2020 at 07:25:34PM +0100, Jiri Olsa wrote:
> > > On Thu, Oct 22, 2020 at 10:21:29AM +0200, Jiri Olsa wrote:
> > > > The kallsyms_expand_symbol function showe
On Thu, 29 Oct 2020 02:12:21 +0800 DENG Qingfang wrote:
> MT7530/7531 has a global RX packet length register, which can be used
> to set MTU.
>
> Signed-off-by: DENG Qingfang
Please wrap your code at 80 chars.
> diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c
> index de7692b763
On Thu, Oct 29, 2020 at 7:44 AM David Verbeiren
wrote:
>
> On Tue, Oct 27, 2020 at 11:55 PM Andrii Nakryiko
> wrote:
> > Looks good, but would be good to have a unit test (see below). Maybe
> > in a follow up.
>
> Here is the associated new selftest, implementing the sequence you
> proposed (than
On Thu, Oct 29, 2020 at 3:38 PM Ian Rogers wrote:
>
> If bits is 0, the case when the map is empty, then the >> is the size of
> the register which is undefined behavior - on x86 it is the same as a
> shift by 0. Fix by handling the 0 case explicitly and guarding calls to
> hash_bits for empty map
On Thu, Oct 29, 2020 at 11:36 AM Song Liu wrote:
>
> On Thu, Oct 29, 2020 at 4:19 AM David Verbeiren
> wrote:
> >
> > Tests that when per-cpu hash map or LRU hash map elements are
> > re-used as a result of a bpf program inserting elements, the
> > element values for the other CPUs than the one e
From: Vladimir Oltean
Extend the 'bridge mdb' command for the following syntax:
bridge mdb add dev br0 port swp0 grp 01:02:03:04:05:06 permanent
Signed-off-by: Vladimir Oltean
---
Changes in v2:
- Removed the const void casts.
- Removed MDB_FLAGS_L2 from the UAPI to be in sync with the latest
Instead of configuring the I2C mdiobus when SFP driver is probed,
create/destroy the mdiobus before the PHY is probed for/after it is
released.
This way we can tell the mdio-i2c code which protocol to use for each
SFP transceiver.
Signed-off-by: Marek Behún
Cc: Andrew Lunn
Cc: Russell King
---
Some SFPs may contain an internal PHY which may in some cases want to
connect with the host interface in 1000base-x/2500base-x mode.
Do not fail if such PHY is being attached in one of these PHY interface
modes.
Signed-off-by: Marek Behún
Cc: Andrew Lunn
Cc: Russell King
---
drivers/net/phy/ph
This adds support for multigig copper SFP modules from RollBall/Hilink.
These modules have a specific way to access clause 45 registers of the
internal PHY.
We also need to wait at least 25 seconds after deasserting TX disable
before accessing the PHY. The code waits for 30 seconds just to be sure
Hello,
this is v2 of series adding support for RollBall/Hilink SFP modules.
Checked with:
checkpatch.pl --max-line-length=80
Changes from v1:
- wrapped to 80 columns as per Russell's request
- initialization of RollBall MDIO I2C protocol moved from sfp.c to
mdio-i2c.c as per Russell's reques
On Thu, Oct 29, 2020 at 3:10 PM Ian Rogers wrote:
>
> If bits is 0, the case when the map is empty, then the >> is the size of
> the register which is undefined behavior - on x86 it is the same as a
> shift by 0.
> Avoid calling hash_bits with bits == 0 by adding additional empty
> hashmap tests.
RollBall SFPs contain a Marvell 88X3310 PHY, but by default the MACTYPE
is set to 10GBASE-R with Rate Matching.
Some devices (for example those based on Armada 38x) only support up to
2500base-x SerDes modes.
Change the PHY's MACTYPE to 4 (which means changing between 10gbase-r,
5gbase-r, 2500bas
Some multigig SFPs from RollBall and Hilink do not expose functional
MDIO access to the internal PHY of the SFP via I2C address 0x56
(although there seems to be read-only clause 22 access on this address).
Instead these SFPs PHY can be accessed via I2C via the SFP Enhanced
Digital Diagnostic Inter
From: Colin Ian King
The for-loop iterates with a u8 loop counter and compares this
with the loop upper limit of request->n_ssids which is an int type.
There is a potential infinite loop if n_ssids is larger than the
u8 loop counter, so fix this by making the loop counter an int.
Addresses-Cover
On Wed, 28 Oct 2020 09:19:12 -0400 jma...@redhat.com wrote:
> From: Jon Maloy
>
> TIPC reserves 64 service types for current and future internal use.
> Therefore, the bind() function is meant to block regular user sockets
> from being bound to these values, while it should let through such
> bind
On Wed, 28 Oct 2020 14:17:36 + Mark Deneen wrote:
> In my test setup, I had a SAMA5D27 device configured with ip forwarding, and
> second device with usb ethernet (r8152) sending ICMP packets. If the packet
> was larger than about 220 bytes, the SAMA5 device would "oops" with the
> following t
On Thu, 29 Oct 2020 at 21:35, Segher Boessenkool
wrote:
>
> On Wed, Oct 28, 2020 at 10:57:45PM -0400, Arvind Sankar wrote:
> > On Wed, Oct 28, 2020 at 04:20:01PM -0700, Alexei Starovoitov wrote:
> > > All compilers have bugs. Kernel has bugs. What can go wrong?
>
> Heh.
>
> > +linux-toolchains. GC
On Thu, Oct 29, 2020 at 03:04:54PM +0800, Xin Long wrote:
...
> Patches:
>
>This patchset is using the udp4/6 tunnel APIs to implement the UDP
>Encapsulation of SCTP with not much change in SCTP protocol stack
>and with all current SCTP features keeped in Linux Kernel.
Acked-by: Marce
On Thu, Oct 15, 2020 at 01:17:14PM -0700, si-wei liu wrote:
>
> On 10/15/2020 6:11 AM, Michael S. Tsirkin wrote:
> > On Thu, Oct 15, 2020 at 02:15:32PM +0800, Jason Wang wrote:
> > > On 2020/10/14 上午7:42, si-wei liu wrote:
> > > > >
> > > > > So what I suggest is to fix the pinning leakage first
Hi,
On 10/29/20 2:40 PM, Hemant Kumar wrote:
> MHI userspace client driver is creating device file node
> for user application to perform file operations. File
> operations are handled by MHI core driver. Currently
> Loopback MHI channel is supported by this driver.
>
> Signed-off-by: Hemant Kuma
On Wed, 28 Oct 2020 01:22:33 +0100 Andrew Lunn wrote:
> Both the Marvell mvneta and rose driver accidentally make use of a
> trigraph. When compiling with W=1 an warning is issues because we have
> trigraphs disabled. So for mvneta, which is only a diagnostic print,
> remove the trigraph. For rose,
1 - 100 of 364 matches
Mail list logo
