> On Oct 29, 2020, at 3:38 PM, Andrii Nakryiko <andrii.nakry...@gmail.com>
> wrote:
>
> On Thu, Oct 29, 2020 at 3:38 PM Ian Rogers <irog...@google.com> wrote:
>>
>> If bits is 0, the case when the map is empty, then the >> is the size of
>> the register which is undefined behavior - on x86 it is the same as a
>> shift by 0. Fix by handling the 0 case explicitly and guarding calls to
>> hash_bits for empty maps in hashmap__for_each_key_entry and
>> hashmap__for_each_entry_safe.
>>
>> Suggested-by: Andrii Nakryiko <andr...@fb.com>,
>> Signed-off-by: Ian Rogers <irog...@google.com>
>> ---
>
> Looks good. Thanks and sorry for unnecessary iterations.
>
> Acked-by: Andrii Nakryiko <and...@kernel.org>
Acked-by: Song Liu <songliubrav...@fb.com>
