Re: [Intel-wired-lan] [PATCH v4] e1000e: Increase polling timeout on MDIC ready bit

2020-10-04 Thread Kai-Heng Feng
Hi Vitaly, > On Sep 30, 2020, at 14:54, Vitaly Lifshits wrote: > > On 9/29/2020 18:08, Kai-Heng Feng wrote: > > Hello Kai-Heng, >>> On Sep 29, 2020, at 21:46, Neftin, Sasha wrote: >>> >>> Hello Kai-Heng, >>> On 9/29/2020 16:31, Kai-Heng Feng wrote: Hi Sasha, > On Sep 29, 2020, at 21:

Re: [PATCH net-next v6 1/7] net: dsa: Add tag handling for Hirschmann Hellcreek switches

2020-10-04 Thread Kurt Kanzenbach
On Sun Oct 04 2020, Vladimir Oltean wrote: > On Sun, Oct 04, 2020 at 01:29:05PM +0200, Kurt Kanzenbach wrote: >> +static const struct dsa_device_ops hellcreek_netdev_ops = { >> +.name = "hellcreek", >> +.proto= DSA_TAG_PROTO_HELLCREEK, >> +.xmit = hellcreek_xmit, >> +.rc

[GIT] Networking

2020-10-04 Thread David Miller
1) Make sure SKB control block is in the proper state during IPSEC ESP-in-TCP encapsulation. From Sabrina Dubroca. 2) Various kinds of attributes were not being cloned properly when we build new xfrm_state objects from existing ones. Fix from Antony Antony. 3) Make sure to keep BTF s

Re: [PATCH net-next v2 0/2] net: Constify struct genl_small_ops

2020-10-04 Thread David Miller
From: Rikard Falkeborn Date: Mon, 5 Oct 2020 01:44:15 +0200 > Make a couple of static struct genl_small_ops const to allow the compiler > to put them in read-only memory. Patches are independent. > > v2: Rebase on net-next, genl_ops -> genl_small_ops Applied, thank you.

Re: [PATCH net-next] net: dsa: propagate switchdev vlan_filtering prepare phase to drivers

2020-10-04 Thread Florian Fainelli
On 10/2/2020 15:06, Vladimir Oltean wrote: A driver may refuse to enable VLAN filtering for any reason beyond what the DSA framework cares about, such as: - having tc-flower rules that rely on the switch being VLAN-aware - the particular switch does not support VLAN, even if the driver does

Re: [RFC 1/3] Initialize devlink health dump framework for the dlge driver

2020-10-04 Thread Coiby Xu
On Fri, Aug 21, 2020 at 11:08:22AM +0800, Coiby Xu wrote: On Sun, Aug 16, 2020 at 11:56:40AM +0900, Benjamin Poirier wrote: On 2020-08-15 00:05 +0800, Coiby Xu wrote: Initialize devlink health dump framework for the dlge driver so the coredump could be done via devlink. Signed-off-by: Coiby Xu

RE: [PATCH 0/6] Ancillary bus implementation and SOF multi-client support

2020-10-04 Thread Ertman, David M
> -Original Message- > From: Greg KH > Sent: Saturday, October 3, 2020 2:11 AM > To: Leon Romanovsky > Cc: Ertman, David M ; linux- > r...@vger.kernel.org; linux-netdev ; alsa- > de...@alsa-project.org > Subject: Re: [PATCH 0/6] Ancillary bus implementation and SOF multi-client > support

Re: [PATCH net-next] net: dsa: propagate switchdev vlan_filtering prepare phase to drivers

2020-10-04 Thread Florian Fainelli
On 10/4/2020 1:59 PM, Vladimir Oltean wrote: On Sat, Oct 03, 2020 at 01:06:46AM +0300, Vladimir Oltean wrote: [...] --- The API for this one was chosen to be different than the one for .port_vlan_add and .port_vlan_prepare because (a) the list of dsa_switch_ops is growing bigger but in this c

Re: [PATCH v4] staging: qlge: fix build breakage with dumping enabled

2020-10-04 Thread Benjamin Poirier
On 2020-10-04 23:22 +0800, Coiby Xu wrote: > On Sat, Oct 03, 2020 at 02:53:48PM +0900, Benjamin Poirier wrote: > > On 2020-10-03 07:59 +0800, Coiby Xu wrote: > > > This fixes commit 0107635e15ac > > > ("staging: qlge: replace pr_err with netdev_err") which introduced an > > > build breakage of miss

[PATCH net-next v2 2/2] net: openvswitch: Constify static struct genl_small_ops

2020-10-04 Thread Rikard Falkeborn
The only usage of these is to assign their address to the small_ops field in the genl_family struct, which is a const pointer, and applying ARRAY_SIZE() on them. Make them const to allow the compiler to put them in read-only memory. Signed-off-by: Rikard Falkeborn --- net/openvswitch/conntrack.c

[PATCH net-next v2 0/2] net: Constify struct genl_small_ops

2020-10-04 Thread Rikard Falkeborn
Make a couple of static struct genl_small_ops const to allow the compiler to put them in read-only memory. Patches are independent. v2: Rebase on net-next, genl_ops -> genl_small_ops Rikard Falkeborn (2): mptcp: Constify mptcp_pm_ops net: openvswitch: Constify static struct genl_small_ops n

[PATCH net-next v2 1/2] mptcp: Constify mptcp_pm_ops

2020-10-04 Thread Rikard Falkeborn
The only usages of mptcp_pm_ops is to assign its address to the small_ops field of the genl_family struct, which is a const pointer, and applying ARRAY_SIZE() on it. Make it const to allow the compiler to put it in read-only memory. Signed-off-by: Rikard Falkeborn --- net/mptcp/pm_netlink.c | 2

Re: [EXT] Re: [PATCH v4 03/13] task_isolation: userspace hard isolation from kernel

2020-10-04 Thread Frederic Weisbecker
On Sun, Oct 04, 2020 at 02:44:39PM +, Alex Belits wrote: > On Thu, 2020-10-01 at 15:56 +0200, Frederic Weisbecker wrote: > > External Email > > > > --- > > --- > > On Wed, Jul 22, 2020 at 02:49:49PM +, Alex Belits wrote: > > >

Re: [PATCH net] drivers/net/wan: lapb: Replace the skb->len checks with pskb_may_pull

2020-10-04 Thread David Miller
From: Xie He Date: Sat, 3 Oct 2020 17:46:19 -0700 > The purpose of these skb->len checks in these drivers is to ensure that > there is a header in the skb available to be read and pulled. > > However, we already have the pskb_may_pull function for this purpose. > > The pskb_may_pull function a

Re: [PATCH net-next] drivers/net/wan/hdlc_fr: Improvements to the code of pvc_xmit

2020-10-04 Thread David Miller
From: Xie He Date: Sat, 3 Oct 2020 15:41:05 -0700 > 1. Keep the code for the normal (non-error) flow at the lowest > indentation level. And use "goto drop" for all error handling. > > 2. Replace code that pads short Ethernet frames with a "__skb_pad" call. > > 3. Change "dev_kfree_skb" to "kfr

Re: [PATCH net] net/core: check length before updating Ethertype in skb_mpls_{push,pop}

2020-10-04 Thread David Miller
From: Guillaume Nault Date: Fri, 2 Oct 2020 21:53:08 +0200 > Openvswitch allows to drop a packet's Ethernet header, therefore > skb_mpls_push() and skb_mpls_pop() might be called with ethernet=true > and mac_len=0. In that case the pointer passed to skb_mod_eth_type() > doesn't point to an Ethern

Re: [PATCH] net: mvneta: fix double free of txq->buf

2020-10-04 Thread David Miller
From: t...@redhat.com Date: Sat, 3 Oct 2020 11:51:21 -0700 > From: Tom Rix > > clang static analysis reports this problem: > > drivers/net/ethernet/marvell/mvneta.c:3465:2: warning: > Attempt to free released memory > kfree(txq->buf); > ^~~ > > When mvneta_txq_sw

Re: [PATCH net-next 0/2] net: Constify struct genl_ops

2020-10-04 Thread David Miller
From: Rikard Falkeborn Date: Sun, 4 Oct 2020 23:58:08 +0200 > Make a couple of static struct genl_ops const to allow the compiler to put > them in read-only memory. Patches are independent. These do not apply cleanly to net-next, please respin.

[PATCH net-next 2/2] net: openvswitch: Constify static struct genl_ops

2020-10-04 Thread Rikard Falkeborn
The only usage of these is to assign their address to the ops field in the genl_family struct, which is a const pointer, and applying ARRAY_SIZE() on them. Make them const to allow the compiler to put them in read-only memory. Signed-off-by: Rikard Falkeborn --- net/openvswitch/conntrack.c | 2 +

[PATCH net-next 1/2] mptcp: Constify mptcp_pm_ops

2020-10-04 Thread Rikard Falkeborn
The only usages of mptcp_pm_ops is to assign its address to the ops field of the genl_family struct, which is a const pointer, and applying ARRAY_SIZE() on it. Make it const to allow the compiler to put it in read-only memory. Signed-off-by: Rikard Falkeborn --- net/mptcp/pm_netlink.c | 2 +- 1

[PATCH net-next 0/2] net: Constify struct genl_ops

2020-10-04 Thread Rikard Falkeborn
Make a couple of static struct genl_ops const to allow the compiler to put them in read-only memory. Patches are independent. Rikard Falkeborn (2): mptcp: Constify mptcp_pm_ops net: openvswitch: Constify static struct genl_ops net/mptcp/pm_netlink.c | 2 +- net/openvswitch/conntrack.c |

Re: [Patch net] net_sched: check error pointer in tcf_dump_walker()

2020-10-04 Thread David Miller
From: Cong Wang Date: Fri, 2 Oct 2020 12:13:34 -0700 > Although we take RTNL on dump path, it is possible to > skip RTNL on insertion path. So the following race condition > is possible: > > rtnl_lock() // no rtnl lock > mutex_lock(&idrinfo->lock); >

Re: [PATCH] net: team: fix memory leak in __team_options_register

2020-10-04 Thread David Miller
From: Anant Thazhemadam Date: Mon, 5 Oct 2020 02:25:36 +0530 > The variable "i" isn't initialized back correctly after the first loop > under the label inst_rollback gets executed. > > The value of "i" is assigned to be option_count - 1, and the ensuing > loop (under alloc_rollback) begins by

Re: [PATCH net-next 00/11] bnxt_en: net-next updates.

2020-10-04 Thread David Miller
From: Michael Chan Date: Sun, 4 Oct 2020 15:22:50 -0400 > This series starts off with the usual update of the firmware interface > spec. A new firmware status bit in the interface will be used in patch > #4 to perform recovery on some SoC platforms. Patches #2 and #3 first > add the infrastruc

Re: [PATCH net-next v3 0/7] mv88e6xxx: Add per port devlink regions

2020-10-04 Thread David Miller
From: Andrew Lunn Date: Sun, 4 Oct 2020 18:12:50 +0200 > This patchset extends devlink regions to support per port regions, and > them makes use of them to support the ports of the mv88e6xxx switches. ... Series applied, thanks!

Re: [PATCH 00/11] Netfilter updates for net-next

2020-10-04 Thread David Miller
From: Pablo Neira Ayuso Date: Sun, 4 Oct 2020 21:49:29 +0200 > git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git Pulled, thank you.

Re: [PATCH net] net/core: check length before updating Ethertype in skb_mpls_{push,pop}

2020-10-04 Thread David Miller
From: "Varghese, Martin (Nokia - IN/Bangalore)" Date: Sun, 4 Oct 2020 14:50:58 + > Is this check redundant. I believe Openvswitch already takes care of it ? Openvswitch isn't the only user of these skb_mpls_*() helpers.

ravb ethernet failures in 4.19.148 and -cip kernels

2020-10-04 Thread Pavel Machek
Hi! It seems commit fb3a780e7a76cf8efb055f8322ec039923cee41f Author: Yuusuke Ashizuka Date: Thu Aug 20 18:43:07 2020 +0900 ravb: Fixed to be able to unload modules causes problems in at least -cip-rt kernels. (I'd have to verify it is present in -cip and plain -stable). Symptoms are like

Re: [PATCH net-next v3 7/7] net: dsa: mv88e6xxx: Add per port devlink regions

2020-10-04 Thread Vladimir Oltean
On Sun, Oct 04, 2020 at 06:12:57PM +0200, Andrew Lunn wrote: > Add a devlink region to return the per port registers. > > Signed-off-by: Andrew Lunn > --- Sorry for the wrong "while (port-- >= 0)" advice given in v2. "while (port-- > 0)" is definitely the correct idiom, which is what you are usi

Re: [PATCH net-next v3 6/7] net: dsa: Add helper for converting devlink port to ds and port

2020-10-04 Thread Vladimir Oltean
On Sun, Oct 04, 2020 at 06:12:56PM +0200, Andrew Lunn wrote: > Hide away from DSA drivers how devlink works. > > Signed-off-by: Andrew Lunn > --- Reviewed-by: Vladimir Oltean

Re: [PATCH net-next] net: dsa: propagate switchdev vlan_filtering prepare phase to drivers

2020-10-04 Thread Vladimir Oltean
On Sat, Oct 03, 2020 at 01:06:46AM +0300, Vladimir Oltean wrote: [...] > --- > The API for this one was chosen to be different than the one for > .port_vlan_add and .port_vlan_prepare because > (a) the list of dsa_switch_ops is growing bigger but in this case there > is no justification for it.

Re: [PATCH net-next v3 3/7] net: dsa: Register devlink ports before calling DSA driver setup()

2020-10-04 Thread Vladimir Oltean
On Sun, Oct 04, 2020 at 06:12:53PM +0200, Andrew Lunn wrote: > DSA drivers want to create regions on devlink ports as well as the > devlink device instance, in order to export registers and other tables > per port. To keep all this code together in the drivers, have the > devlink ports registered e

[PATCH] net: team: fix memory leak in __team_options_register

2020-10-04 Thread Anant Thazhemadam
The variable "i" isn't initialized back correctly after the first loop under the label inst_rollback gets executed. The value of "i" is assigned to be option_count - 1, and the ensuing loop (under alloc_rollback) begins by initializing i--. Thus, the value of i when the loop begins execution wil

[PATCH 03/11] ipvs: Remove unused macros

2020-10-04 Thread Pablo Neira Ayuso
From: YueHaibing They are not used since commit e4ff67513096 ("ipvs: add sync_maxlen parameter for the sync daemon") Signed-off-by: YueHaibing Acked-by: Simon Horman Signed-off-by: Pablo Neira Ayuso --- net/netfilter/ipvs/ip_vs_sync.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/net

[PATCH 02/11] netfilter: nf_tables: Remove ununsed function nft_data_debug

2020-10-04 Thread Pablo Neira Ayuso
From: YueHaibing It is never used, so can be removed. Signed-off-by: YueHaibing Signed-off-by: Pablo Neira Ayuso --- include/net/netfilter/nf_tables.h | 7 --- 1 file changed, 7 deletions(-) diff --git a/include/net/netfilter/nf_tables.h b/include/net/netfilter/nf_tables.h index 8ceca0e

[PATCH 01/11] netfilter: conntrack: proc: rename stat column

2020-10-04 Thread Pablo Neira Ayuso
From: Florian Westphal Rename 'searched' column to 'clashres' (same len). conntrack(8) using the old /proc interface (ctnetlink not available) shows: cpu=0 entries=4784 clashres=2292 [..] Another alternative is to add another column, but this increases the number of always-0 columns. Fixes:

[PATCH 04/11] netfilter: nf_tables: fix userdata memleak

2020-10-04 Thread Pablo Neira Ayuso
From: "Jose M. Guisado Gomez" When userdata was introduced for tables and objects its allocation was only freed inside the error path of the new{table, object} functions. Free user data inside corresponding destroy functions for tables and objects. Fixes: b131c96496b3 ("netfilter: nf_tables: ad

[PATCH 05/11] netfilter: nf_tables: use nla_memdup to copy udata

2020-10-04 Thread Pablo Neira Ayuso
From: "Jose M. Guisado Gomez" When userdata support was added to tables and objects, user data coming from user space was allocated and copied using kzalloc + nla_memcpy. Use nla_memdup to copy userdata of tables and objects. Signed-off-by: Jose M. Guisado Gomez Signed-off-by: Pablo Neira Ayus

[PATCH 06/11] netfilter: nf_tables: add userdata attributes to nft_chain

2020-10-04 Thread Pablo Neira Ayuso
From: "Jose M. Guisado Gomez" Enables storing userdata for nft_chain. Field udata points to user data and udlen stores its length. Adds new attribute flag NFTA_CHAIN_USERDATA. Signed-off-by: Jose M. Guisado Gomez Signed-off-by: Pablo Neira Ayuso --- include/net/netfilter/nf_tables.h|

[PATCH 08/11] netfilter: ipset: enable memory accounting for ipset allocations

2020-10-04 Thread Pablo Neira Ayuso
From: Vasily Averin Currently netadmin inside non-trusted container can quickly allocate whole node's memory via request of huge ipset hashtable. Other ipset-related memory allocations should be restricted too. v2: fixed typo ALLOC -> ACCOUNT Signed-off-by: Vasily Averin Signed-off-by: Pablo N

[PATCH 09/11] netfilter: nfnetlink: place subsys mutexes in distinct lockdep classes

2020-10-04 Thread Pablo Neira Ayuso
From: Florian Westphal >From time to time there are lockdep reports similar to this one: WARNING: possible circular locking dependency detected -- 4f61aa56 (&table[i].mutex){+.+.}, at: nfnl_lock [nfnetlink] but task is already holdi

[PATCH 10/11] netfilter: nf_tables: Enable fast nft_cmp for inverted matches

2020-10-04 Thread Pablo Neira Ayuso
From: Phil Sutter Add a boolean indicating NFT_CMP_NEQ. To include it into the match decision, it is sufficient to XOR it with the data comparison's result. While being at it, store the mask that is calculated during expression init and free the eval routine from having to recalculate it each ti

[PATCH 07/11] netfilter: nf_tables_offload: Remove unused macro FLOW_SETUP_BLOCK

2020-10-04 Thread Pablo Neira Ayuso
From: YueHaibing commit 9a32669fecfb ("netfilter: nf_tables_offload: support indr block call") left behind this. Signed-off-by: YueHaibing Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nf_tables_offload.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/netfilter/nf_tables_offloa

[PATCH 11/11] netfilter: nf_tables: Implement fast bitwise expression

2020-10-04 Thread Pablo Neira Ayuso
From: Phil Sutter A typical use of bitwise expression is to mask out parts of an IP address when matching on the network part only. Optimize for this common use with a fast variant for NFT_BITWISE_BOOL-type expressions operating on 32bit-sized values. Signed-off-by: Phil Sutter Signed-off-by: P

[PATCH 00/11] Netfilter updates for net-next

2020-10-04 Thread Pablo Neira Ayuso
Hi, The following patchset contains Netfilter updates for net-next: 1) Rename 'searched' column to 'clashres' in conntrack /proc/ stats to amend a recent patch, from Florian Westphal. 2) Remove unused nft_data_debug(), from YueHaibing. 3) Remove unused definitions in IPVS, also from YueHaibi

[PATCH net-next 00/11] bnxt_en: net-next updates.

2020-10-04 Thread Michael Chan
This series starts off with the usual update of the firmware interface spec. A new firmware status bit in the interface will be used in patch #4 to perform recovery on some SoC platforms. Patches #2 and #3 first add the infrastructure to read the firmware status very early during driver probe and

[PATCH net-next 01/11] bnxt_en: Update firmware interface spec to 1.10.1.68.

2020-10-04 Thread Michael Chan
From: Vasundhara Volam Main changes is to extend hwrm_nvm_get_dev_info_output() for stored firmware versions and a new flag is added to fw_status_reg. Reviewed-by: Edwin Peer Signed-off-by: Vasundhara Volam Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt_hsi.h | 24 ++

[PATCH net-next 11/11] bnxt_en: Eliminate unnecessary RX resets.

2020-10-04 Thread Michael Chan
Currently, the driver will schedule RX ring reset when we get a buffer error in the RX completion record. These RX buffer errors can be due to normal out-of-buffer conditions or a permanent error in the RX ring. Because the driver cannot distinguish between these 2 conditions, we assume all these

[PATCH net-next 03/11] bnxt_en: log firmware status on firmware init failure

2020-10-04 Thread Michael Chan
From: Edwin Peer Firmware now supports device independent discovery of the status register location. This status register can provide more detailed information about firmware errors, especially if problems occur before the HWRM interface is functioning. Attempt to map this register if it is prese

[PATCH net-next 05/11] bnxt_en: Log FW health status info, if reset is aborted.

2020-10-04 Thread Michael Chan
If firmware does not come out of reset, log FW health status info to provide more information on firmware status. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bn

[PATCH net-next 10/11] bnxt_en: Reduce unnecessary message log during RX errors.

2020-10-04 Thread Michael Chan
There is logic in the RX path to detect unexpected handles in the RX completion. We'll print a warning and schedule a reset. The next expected handle is then set to 0x which is guaranteed to not match any valid handle. This will force all remaining packets in the ring to be discarded before

[PATCH net-next 09/11] bnxt_en: Add a software counter for RX ring reset.

2020-10-04 Thread Michael Chan
Add a per ring rx_resets counter to count these RX resets. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 14 ++ drivers/net/ethernet/broadcom/bnxt/bnxt.h | 1 + drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 1 + 3 files changed, 1

[PATCH net-next 02/11] bnxt_en: refactor bnxt_alloc_fw_health()

2020-10-04 Thread Michael Chan
From: Edwin Peer The allocator for the firmware health structure conflates allocation and capability checks, limiting the reusability of the code. This patch separates out the capability check and disablement and improves the warning message to better describe the consequences of an allocation fa

[PATCH net-next 06/11] bnxt_en: Refactor bnxt_free_rx_skbs().

2020-10-04 Thread Michael Chan
bnxt_free_rx_skbs() frees all the allocated buffers and SKBs for every RX ring. Refactor this function by calling a new function bnxt_free_one_rx_ring_skbs() to free these buffers on one specified RX ring at a time. This is preparation work for resetting one RX ring during run-time. Reviewed-by:

[PATCH net-next 04/11] bnxt_en: perform no master recovery during startup

2020-10-04 Thread Michael Chan
From: Edwin Peer The NS3 SoC platforms require assistance from the OP-TEE to recover firmware if a crash occurs while no driver is bound. The CRASHED_NO_MASTER condition is recorded in the firmware status register during the crash to indicate when driver intervension is needed to coordinate a fir

[PATCH net-next 07/11] bnxt_en: Refactor bnxt_init_one_rx_ring().

2020-10-04 Thread Michael Chan
bnxt_init_one_rx_ring() includes logic to initialize the BDs for one RX ring and to allocate the buffers. Separate the allocation logic into a new bnxt_alloc_one_rx_ring() function. The allocation function will be used later to allocate new buffers for one specified RX ring when we reset that RX

[PATCH net-next 08/11] bnxt_en: Implement RX ring reset in response to buffer errors.

2020-10-04 Thread Michael Chan
On some older chips, it is necessary to do a reset when we get buffer errors associated with an RX ring. These buffer errors may become frequent if the RX ring underruns under heavy traffic. The current code does a global reset of all reasources when this happens. This works but creates a big di

Re: [PATCH net-next] netfilter: nf_tables_offload: Remove unused macro FLOW_SETUP_BLOCK

2020-10-04 Thread Pablo Neira Ayuso
On Fri, Sep 18, 2020 at 09:17:29PM +0800, YueHaibing wrote: > commit 9a32669fecfb ("netfilter: nf_tables_offload: support indr block call") > left behind this. Applied.

Re: [PATCH 1/2] usb: serial: qmi_wwan: add Cellient MPL200 card

2020-10-04 Thread Wilken Gottwalt
On Sun, 04 Oct 2020 17:29:38 +0200 Bjørn Mork wrote: > Wilken Gottwalt writes: > > > Add usb ids of the Cellient MPL200 card. > > > > Signed-off-by: Wilken Gottwalt > > --- > > drivers/net/usb/qmi_wwan.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/net/usb/qmi_wwan.c

Re: [EXT] Re: [PATCH v4 11/13] task_isolation: net: don't flush backlog on CPUs running isolated tasks

2020-10-04 Thread Alex Belits
On Thu, 2020-10-01 at 16:47 +0200, Frederic Weisbecker wrote: > External Email > > --- > --- > On Wed, Jul 22, 2020 at 02:58:24PM +, Alex Belits wrote: > > From: Yuri Norov > > > > If CPU runs isolated task, there's no any back

Re: [PATCH] Revert "Bluetooth: Update resolving list when updating whitelist"

2020-10-04 Thread Marcel Holtmann
Hi Greg, > This reverts commit 0eee35bdfa3b472cc986ecc6ad76293fdcda59e2 as it > breaks all bluetooth connections on my machine. > > Cc: Marcel Holtmann > Cc: Sathish Narsimman > Fixes: 0eee35bdfa3b ("Bluetooth: Update resolving list when updating > whitelist") >

Re: [PATCH net-next v3 7/7] net: dsa: mv88e6xxx: Add per port devlink regions

2020-10-04 Thread Florian Fainelli
On 10/4/2020 9:12 AM, Andrew Lunn wrote: Add a devlink region to return the per port registers. Signed-off-by: Andrew Lunn Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net-next v3 6/7] net: dsa: Add helper for converting devlink port to ds and port

2020-10-04 Thread Florian Fainelli
On 10/4/2020 9:12 AM, Andrew Lunn wrote: Hide away from DSA drivers how devlink works. Signed-off-by: Andrew Lunn Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net-next v3 5/7] net: dsa: Add devlink port regions support to DSA

2020-10-04 Thread Florian Fainelli
On 10/4/2020 9:12 AM, Andrew Lunn wrote: Allow DSA drivers to make use of devlink port regions, via simple wrappers. Reviewed-by: Vladimir Oltean Tested-by: Vladimir Oltean Signed-off-by: Andrew Lunn Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net-next v3 3/7] net: dsa: Register devlink ports before calling DSA driver setup()

2020-10-04 Thread Florian Fainelli
On 10/4/2020 9:12 AM, Andrew Lunn wrote: DSA drivers want to create regions on devlink ports as well as the devlink device instance, in order to export registers and other tables per port. To keep all this code together in the drivers, have the devlink ports registered early, so the setup() me

Re: [PATCH net-next v3 2/7] net: dsa: Make use of devlink port flavour unused

2020-10-04 Thread Florian Fainelli
On 10/4/2020 9:12 AM, Andrew Lunn wrote: If a port is unused, still create a devlink port for it, but set the flavour to unused. This allows us to attach devlink regions to the port, etc. Reviewed-by: Vladimir Oltean Tested-by: Vladimir Oltean Signed-off-by: Andrew Lunn Reviewed-by: Flor

Re: [PATCH net-next v3 1/7] net: devlink: Add unused port flavour

2020-10-04 Thread Florian Fainelli
On 10/4/2020 9:12 AM, Andrew Lunn wrote: Not all ports of a switch need to be used, particularly in embedded systems. Add a port flavour for ports which physically exist in the switch, but are not connected to the front panel etc, and so are unused. By having unused ports present in devlink, i

Re: [PATCH] dt-bindings: Another round of adding missing 'additionalProperties'

2020-10-04 Thread Vinod Koul
On 02-10-20, 18:41, Rob Herring wrote: > .../phy/amlogic,meson-g12a-usb2-phy.yaml | 2 ++ > .../bindings/phy/qcom,ipq806x-usb-phy-hs.yaml | 2 ++ > .../bindings/phy/qcom,ipq806x-usb-phy-ss.yaml | 2 ++ > .../bindings/phy/qcom,qusb2-phy.yaml | 1 + > .../bindings/phy/qcom-usb-ipq

[PATCH net-next v3 0/7] mv88e6xxx: Add per port devlink regions

2020-10-04 Thread Andrew Lunn
This patchset extends devlink regions to support per port regions, and them makes use of them to support the ports of the mv88e6xxx switches. root@rap:~# devlink region show mdio_bus/gpio-0:00/global1: size 64 snapshot [] mdio_bus/gpio-0:00/global2: size 64 snapshot [] mdio_bus/gpio-0:00/atu: size

[PATCH net-next v3 2/7] net: dsa: Make use of devlink port flavour unused

2020-10-04 Thread Andrew Lunn
If a port is unused, still create a devlink port for it, but set the flavour to unused. This allows us to attach devlink regions to the port, etc. Reviewed-by: Vladimir Oltean Tested-by: Vladimir Oltean Signed-off-by: Andrew Lunn --- net/dsa/dsa2.c | 10 ++ 1 file changed, 10 insertion

[PATCH net-next v3 3/7] net: dsa: Register devlink ports before calling DSA driver setup()

2020-10-04 Thread Andrew Lunn
DSA drivers want to create regions on devlink ports as well as the devlink device instance, in order to export registers and other tables per port. To keep all this code together in the drivers, have the devlink ports registered early, so the setup() method can setup both device and port devlink re

[PATCH net-next v3 7/7] net: dsa: mv88e6xxx: Add per port devlink regions

2020-10-04 Thread Andrew Lunn
Add a devlink region to return the per port registers. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/devlink.c | 109 +++- 1 file changed, 105 insertions(+), 4 deletions(-) diff --git a/drivers/net/dsa/mv88e6xxx/devlink.c b/drivers/net/dsa/mv88e6xxx/devlink.c

[PATCH net-next v3 6/7] net: dsa: Add helper for converting devlink port to ds and port

2020-10-04 Thread Andrew Lunn
Hide away from DSA drivers how devlink works. Signed-off-by: Andrew Lunn --- include/net/dsa.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/include/net/dsa.h b/include/net/dsa.h index ca426cf9927b..c0185660881c 100644 --- a/include/net/dsa.h +++ b/include/net/dsa.h @@ -701

[PATCH net-next v3 5/7] net: dsa: Add devlink port regions support to DSA

2020-10-04 Thread Andrew Lunn
Allow DSA drivers to make use of devlink port regions, via simple wrappers. Reviewed-by: Vladimir Oltean Tested-by: Vladimir Oltean Signed-off-by: Andrew Lunn --- include/net/dsa.h | 5 + net/dsa/dsa.c | 14 ++ 2 files changed, 19 insertions(+) diff --git a/include/net/ds

[PATCH net-next v3 1/7] net: devlink: Add unused port flavour

2020-10-04 Thread Andrew Lunn
Not all ports of a switch need to be used, particularly in embedded systems. Add a port flavour for ports which physically exist in the switch, but are not connected to the front panel etc, and so are unused. By having unused ports present in devlink, it gives a more accurate representation of the

[PATCH net-next v3 4/7] net: devlink: Add support for port regions

2020-10-04 Thread Andrew Lunn
Allow regions to be registered to a devlink port. The same netlink API is used, but the port index is provided to indicate when a region is a port region as opposed to a device region. Reviewed-by: Vladimir Oltean Tested-by: Vladimir Oltean Signed-off-by: Andrew Lunn --- include/net/devlink.h

Re: [PATCH] man: fix typos

2020-10-04 Thread Andrew Lunn
On Sun, Oct 04, 2020 at 11:42:59AM +, Samanta Navarro wrote: > --- > man/man8/ip-link.8.in | 14 +++--- > man/man8/ip-neighbour.8 | 6 +++--- > man/man8/tc-actions.8 | 2 +- > man/man8/tc-pie.8 | 4 ++-- > 4 files changed, 13 insertions(+), 13 deletions(-) > > diff --git

Re: [PATCH 1/2] usb: serial: qmi_wwan: add Cellient MPL200 card

2020-10-04 Thread Bjørn Mork
Wilken Gottwalt writes: > Add usb ids of the Cellient MPL200 card. > > Signed-off-by: Wilken Gottwalt > --- > drivers/net/usb/qmi_wwan.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c > index 07c42c0719f5..0bf2b19d5d54 100644 > -

Re: [EXT] Re: [PATCH v4 10/13] task_isolation: don't interrupt CPUs with tick_nohz_full_kick_cpu()

2020-10-04 Thread Alex Belits
On Thu, 2020-10-01 at 16:44 +0200, Frederic Weisbecker wrote: > External Email > > --- > --- > On Wed, Jul 22, 2020 at 02:57:33PM +, Alex Belits wrote: > > From: Yuri Norov > > > > For nohz_full CPUs the desirable behavior is t

Re: [PATCH v4] staging: qlge: fix build breakage with dumping enabled

2020-10-04 Thread Coiby Xu
On Sat, Oct 03, 2020 at 02:53:48PM +0900, Benjamin Poirier wrote: On 2020-10-03 07:59 +0800, Coiby Xu wrote: This fixes commit 0107635e15ac ("staging: qlge: replace pr_err with netdev_err") which introduced an build breakage of missing `struct ql_adapter *qdev` for some functions and a warning o

Re: [EXT] Re: [PATCH v4 03/13] task_isolation: userspace hard isolation from kernel

2020-10-04 Thread Alex Belits
On Thu, 2020-10-01 at 16:40 +0200, Frederic Weisbecker wrote: > External Email > > --- > --- > On Wed, Jul 22, 2020 at 02:49:49PM +, Alex Belits wrote: > > +/** > > + * task_isolation_kernel_enter() - clear low-level task isolati

RE: [PATCH net] net/core: check length before updating Ethertype in skb_mpls_{push,pop}

2020-10-04 Thread Varghese, Martin (Nokia - IN/Bangalore)
On Fri, 2020-10-02 at 21:53 +0200, Guillaume Nault wrote: > Openvswitch allows to drop a packet's Ethernet header, therefore >skb_mpls_push() and skb_mpls_pop() might be called with ethernet=true and >mac_len=0. In that case the pointer passed to skb_mod_eth_type() >doesn't >point to an Ether

Re: [EXT] Re: [PATCH v4 03/13] task_isolation: userspace hard isolation from kernel

2020-10-04 Thread Alex Belits
On Thu, 2020-10-01 at 15:56 +0200, Frederic Weisbecker wrote: > External Email > > --- > --- > On Wed, Jul 22, 2020 at 02:49:49PM +, Alex Belits wrote: > > +/* > > + * Description of the last two tasks that ran isolated on a given

Re: [PATCH net-next v6 4/7] net: dsa: hellcreek: Add support for hardware timestamping

2020-10-04 Thread Vladimir Oltean
On Sun, Oct 04, 2020 at 01:29:08PM +0200, Kurt Kanzenbach wrote: > From: Kamil Alkhouri > > The switch has the ability to take hardware generated time stamps per port for > PTPv2 event messages in Rx and Tx direction. That is useful for achieving > needed > time synchronization precision for TSN

Re: [PATCH net] net/core: check length before updating Ethertype in skb_mpls_{push,pop}

2020-10-04 Thread Davide Caratti
On Fri, 2020-10-02 at 21:53 +0200, Guillaume Nault wrote: > Openvswitch allows to drop a packet's Ethernet header, therefore > skb_mpls_push() and skb_mpls_pop() might be called with ethernet=true > and mac_len=0. In that case the pointer passed to skb_mod_eth_type() > doesn't point to an Ethernet

Re: [RFC PATCH net-next v2] ethtool: Improve compatibility between netlink and ioctl interfaces

2020-10-04 Thread Ido Schimmel
On Sun, Oct 04, 2020 at 12:46:31PM +, David Laight wrote: > From: Ido Schimmel > > Sent: 04 October 2020 11:17 > > > > With the ioctl interface, when autoneg is enabled, but without > > specifying speed, duplex or link modes, the advertised link modes are > > set to the supported link modes by

Re: [PATCH] Revert "Bluetooth: Update resolving list when updating whitelist"

2020-10-04 Thread Bastien Nocera
On Sun, 2020-10-04 at 15:18 +0200, Greg Kroah-Hartman wrote: > On Sun, Oct 04, 2020 at 02:17:06PM +0200, Bastien Nocera wrote: > > On Sun, 2020-10-04 at 12:51 +0200, Greg Kroah-Hartman wrote: > > > On Sat, Oct 03, 2020 at 08:33:18PM +0200, Marcel Holtmann wrote: > > > > Hi Greg, > > > > > > > > >

[PATCH] wireless: mwifiex: fix double free

2020-10-04 Thread trix
From: Tom Rix clang static analysis reports this problem: sdio.c:2403:3: warning: Attempt to free released memory kfree(card->mpa_rx.buf); ^~~ When mwifiex_init_sdio() fails in its first call to mwifiex_alloc_sdio_mpa_buffer, it falls back to calling it again

Re: [PATCH] Revert "Bluetooth: Update resolving list when updating whitelist"

2020-10-04 Thread Greg Kroah-Hartman
On Sun, Oct 04, 2020 at 02:17:06PM +0200, Bastien Nocera wrote: > On Sun, 2020-10-04 at 12:51 +0200, Greg Kroah-Hartman wrote: > > On Sat, Oct 03, 2020 at 08:33:18PM +0200, Marcel Holtmann wrote: > > > Hi Greg, > > > > > > > > > This reverts commit 0eee35bdfa3b472cc986ecc6ad76293fdcda59e2 > > > >

Re: [PATCH net-next 1/2] net/smc: send ISM devices with unique chid in CLC proposal

2020-10-04 Thread Karsten Graul
On Sat, 03 Oct 2020 17:05:38 -0700 (PDT) David Miller wrote: > Series applied, but could you send a proper patch series in the future > with a "[PATCH 0/N] ..." header posting? It must explain what the > patch series does at a high level, how it is doing it, and why it is > doing it that way. >

Re: [PATCH net-next v6 2/7] net: dsa: Add DSA driver for Hirschmann Hellcreek switches

2020-10-04 Thread Vladimir Oltean
On Sun, Oct 04, 2020 at 01:29:06PM +0200, Kurt Kanzenbach wrote: > Add a basic DSA driver for Hirschmann Hellcreek switches. Those switches are > implementing features needed for Time Sensitive Networking (TSN) such as > support > for the Time Precision Protocol and various shapers like the Time A

RE: [RFC PATCH net-next v2] ethtool: Improve compatibility between netlink and ioctl interfaces

2020-10-04 Thread David Laight
From: Ido Schimmel > Sent: 04 October 2020 11:17 > > With the ioctl interface, when autoneg is enabled, but without > specifying speed, duplex or link modes, the advertised link modes are > set to the supported link modes by the ethtool user space utility. ... > Fix this incompatibility problem by

Re: [PATCH AUTOSEL 5.8 08/29] net: dsa: microchip: look for phy-mode in port nodes

2020-10-04 Thread Sasha Levin
On Tue, Sep 29, 2020 at 07:56:30AM +0200, Helmut Grohne wrote: Hi Sascha, On Tue, Sep 29, 2020 at 03:30:05AM +0200, Sasha Levin wrote: From: Helmut Grohne [ Upstream commit edecfa98f602a597666e3c5cab2677ada38d93c5 ] Documentation/devicetree/bindings/net/dsa/dsa.txt says that the phy-mode pro

Re: [PATCH] Revert "Bluetooth: Update resolving list when updating whitelist"

2020-10-04 Thread Bastien Nocera
On Sun, 2020-10-04 at 12:51 +0200, Greg Kroah-Hartman wrote: > On Sat, Oct 03, 2020 at 08:33:18PM +0200, Marcel Holtmann wrote: > > Hi Greg, > > > > > > > This reverts commit 0eee35bdfa3b472cc986ecc6ad76293fdcda59e2 > > > > > as it > > > > > breaks all bluetooth connections on my machine. > > > >

Re: [PATCH v3 6/7] can: usb: etas_es58X: add support for ETAS ES58X CAN USB interfaces

2020-10-04 Thread Marc Kleine-Budde
On 10/2/20 5:41 PM, Vincent Mailhol wrote: > This driver supports the ES581.4, ES582.1 and ES584.1 interfaces from > ETAS GmbH (https://www.etas.com/en/products/es58x.php). > > Co-developed-by: Arunachalam Santhanam > Signed-off-by: Arunachalam Santhanam > Signed-off-by: Vincent Mailhol > --- >

Re: [PATCH net-next v6 1/7] net: dsa: Add tag handling for Hirschmann Hellcreek switches

2020-10-04 Thread Vladimir Oltean
On Sun, Oct 04, 2020 at 01:29:05PM +0200, Kurt Kanzenbach wrote: > The Hirschmann Hellcreek TSN switches have a special tagging protocol for > frames > exchanged between the CPU port and the master interface. The format is a one > byte trailer indicating the destination or origin port. > > It's q

[PATCH] man: fix typos

2020-10-04 Thread Samanta Navarro
--- man/man8/ip-link.8.in | 14 +++--- man/man8/ip-neighbour.8 | 6 +++--- man/man8/tc-actions.8 | 2 +- man/man8/tc-pie.8 | 4 ++-- 4 files changed, 13 insertions(+), 13 deletions(-) diff --git a/man/man8/ip-link.8.in b/man/man8/ip-link.8.in index f451ecf..fbc45df 100644 ---

[PATCH net-next v6 7/7] dt-bindings: net: dsa: Add documentation for Hellcreek switches

2020-10-04 Thread Kurt Kanzenbach
Add basic documentation and example. Signed-off-by: Kurt Kanzenbach Reviewed-by: Rob Herring Reviewed-by: Florian Fainelli --- .../bindings/net/dsa/hellcreek.yaml | 127 ++ 1 file changed, 127 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/dsa

[PATCH net-next v6 6/7] dt-bindings: Add vendor prefix for Hirschmann

2020-10-04 Thread Kurt Kanzenbach
Hirschmann is building devices for automation and networking. Add them to the vendor prefixes. Signed-off-by: Kurt Kanzenbach Reviewed-by: Florian Fainelli Acked-by: Rob Herring --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Doc

[PATCH net-next v6 5/7] net: dsa: hellcreek: Add PTP status LEDs

2020-10-04 Thread Kurt Kanzenbach
The switch has two controllable I/Os which are usually connected to LEDs. This is useful to immediately visually see the PTP status. These provide two signals: * is_gm This LED can be activated if the current device is the grand master in that PTP domain. * sync_good This LED can be

  1   2   >