On 10/4/2020 1:59 PM, Vladimir Oltean wrote:
On Sat, Oct 03, 2020 at 01:06:46AM +0300, Vladimir Oltean wrote: [...]--- The API for this one was chosen to be different than the one for .port_vlan_add and .port_vlan_prepare because (a) the list of dsa_switch_ops is growing bigger but in this case there is no justification for it. For example there are some drivers that don't do anything in .port_vlan_prepare, and likewise, they may not need to do anything in .port_vlan_filtering_prepare either (b) the DSA API should be as close as possible to the switchdev API except when there's a strong reason for that not to be the case. In this situation, I don't see why it would be different.I understand that this new function prototype is not to everyone's taste?
Just need more time to review, have not looked at it yet. -- Florian
