From: Xie He <xie.he.0...@gmail.com> Date: Sat, 3 Oct 2020 15:41:05 -0700
> 1. Keep the code for the normal (non-error) flow at the lowest > indentation level. And use "goto drop" for all error handling. > > 2. Replace code that pads short Ethernet frames with a "__skb_pad" call. > > 3. Change "dev_kfree_skb" to "kfree_skb" in error handling code. > "kfree_skb" is the correct function to call when dropping an skb due to > an error. "dev_kfree_skb", which is an alias of "consume_skb", is for > dropping skbs normally (not due to an error). > > Cc: Krzysztof Halasa <k...@pm.waw.pl> > Cc: Stephen Hemminger <step...@networkplumber.org> > Signed-off-by: Xie He <xie.he.0...@gmail.com> Applied, thank you.
