[PATCH] rtlwifi: Use ffs in _phy_calculate_bit_shift

2020-09-18 Thread Joe Perches
Remove the loop and use the generic ffs instead. Signed-off-by: Joe Perches --- Just saw one by happenstance, might as well fix them all. drivers/net/wireless/realtek/rtlwifi/rtl8188ee/phy.c | 18 ++ .../net/wireless/realtek/rtlwifi/rtl8192c/phy_common.c | 8 ++-- drivers

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-18 Thread Greg Kroah-Hartman
On Fri, Sep 18, 2020 at 03:19:05PM +0300, Leon Romanovsky wrote: > > So we do have an open-source library called hl-thunk, which uses our > > driver and indeed that was part of the requirement. > > It is similar to libdrm. > > Here is the link: > > https://github.com/HabanaAI/hl-thunk > > Are you

Re: [PATCH 2/2] dev_ioctl: split out SIOC?IFMAP ioctls

2020-09-18 Thread Christoph Hellwig
> diff --git a/include/uapi/linux/if.h b/include/uapi/linux/if.h > index 797ba2c1562a..a332d6ae4dc6 100644 > --- a/include/uapi/linux/if.h > +++ b/include/uapi/linux/if.h > @@ -247,7 +247,13 @@ struct ifreq { > short ifru_flags; > int ifru_ivalue; > i

RE: [PATCH net-next v1 7/7] ice: convert to new udp_tunnel infrastructure

2020-09-18 Thread Brown, Aaron F
> From: netdev-ow...@vger.kernel.org On > Behalf Of Jakub Kicinski > Sent: Tuesday, July 21, 2020 6:27 PM > To: da...@davemloft.net > Cc: netdev@vger.kernel.org; Nguyen, Anthony L > ; Kirsher, Jeffrey T > ; > intel-wired-...@lists.osuosl.org; Jakub Kicinski > Subject: [PATCH net-next v1 7/7] ice

Re: [PATCH 1/2] ethtool: improve compat ioctl handling

2020-09-18 Thread Christoph Hellwig
> + if (ethtool_translate_compat()) { > + struct compat_ethtool_rxnfc crxnfc = {}; > + > + if (copy_from_user(&crxnfc, useraddr, > +min(size, sizeof(crxnfc > + return -EFAULT; > + > + *rxnfc = (struct et

RE: [PATCH net-next v1 6/7] ice: remove unused args from ice_get_open_tunnel_port()

2020-09-18 Thread Brown, Aaron F
> From: netdev-ow...@vger.kernel.org On > Behalf Of Jakub Kicinski > Sent: Tuesday, July 21, 2020 6:27 PM > To: da...@davemloft.net > Cc: netdev@vger.kernel.org; Nguyen, Anthony L > ; Kirsher, Jeffrey T > ; > intel-wired-...@lists.osuosl.org; Jakub Kicinski > Subject: [PATCH net-next v1 6/7] ice

RE: [PATCH net-next v2 3/8] devlink: Prepare code to fill multiple port function attributes

2020-09-18 Thread Parav Pandit
> From: Jacob Keller > Sent: Saturday, September 19, 2020 4:24 AM > > > On 9/17/2020 8:35 PM, Parav Pandit wrote: > > Hi Jacob, > > > >> From: Jacob Keller > >> Sent: Friday, September 18, 2020 12:29 AM > >> > >> > >> We lost this comment in the move it looks like. I think it's still > >> use

RE: [PATCH net-next v2 2/8] devlink: Support add and delete devlink port

2020-09-18 Thread Parav Pandit
> From: Jacob Keller > Sent: Saturday, September 19, 2020 4:37 AM > > > On 9/17/2020 9:25 PM, Parav Pandit wrote: > >> From: Jacob Keller > >> Sent: Friday, September 18, 2020 12:13 AM > >> > >> > >> On 9/17/2020 10:20 AM, Parav Pandit wrote: > >>> Extended devlink interface for the user to a

RE: [PATCH net-next v2 1/8] devlink: Introduce PCI SF port flavour and port attribute

2020-09-18 Thread Parav Pandit
> From: David Ahern > Sent: Saturday, September 19, 2020 10:19 AM > > On 9/18/20 10:13 AM, Parav Pandit wrote: > >> You keep adding patches that extend the template based names. Those > >> are going to cause odd EINVAL failures (the absolute worst kind of > >> configuration > >> failure) with n

Re: [External] Re: [RFC PATCH] bpf: Fix potential call bpf_link_free() in atomic context

2020-09-18 Thread Muchun Song
On Fri, Sep 18, 2020 at 6:37 AM Song Liu wrote: > > On Thu, Sep 17, 2020 at 12:46 AM Muchun Song wrote: > > > > The in_atomic macro cannot always detect atomic context. In particular, > > it cannot know about held spinlocks in non-preemptible kernels. Although, > > there is no user call bpf_link_

Re: [PATCH iproute2-next] ip: promote missed packets to the -s row

2020-09-18 Thread David Ahern
On 9/18/20 9:48 AM, Jakub Kicinski wrote: > On Fri, 18 Sep 2020 09:44:35 -0600 David Ahern wrote: >> On 9/16/20 1:42 PM, Jakub Kicinski wrote: >>> 2: eth0: mtu 1500 qdisc mq state UP mode >>> DEFAULT group default qlen 1000 >>> link/ether 00:0a:f7:c1:4d:38 brd ff:ff:ff:ff:ff:ff >>> RX: by

Re: [PATCH net-next v2 1/8] devlink: Introduce PCI SF port flavour and port attribute

2020-09-18 Thread David Ahern
On 9/18/20 10:13 AM, Parav Pandit wrote: >> You keep adding patches that extend the template based names. Those are >> going to cause odd EINVAL failures (the absolute worst kind of configuration >> failure) with no way for a user to understand why the command is failing, and >> you need to handle

答复: [PATCH net-next] net: microchip: Remove set but not used variable

2020-09-18 Thread zhengyongjun
This is the bad patch, my fault, I forget to check patch title, please ignore it, thank you very much. -邮件原件- 发件人: zhengyongjun 发送时间: 2020年9月19日 10:39 收件人: bryan.whiteh...@microchip.com; unglinuxdri...@microchip.com; da...@davemloft.net; k...@kernel.org; netdev@vger.kernel.org; linux-k

答复: [PATCH net-next] net: microchip: Remove set but not used variable

2020-09-18 Thread zhengyongjun
This is the bad patch, please ignore it, thank you very much. -邮件原件- 发件人: zhengyongjun 发送时间: 2020年9月19日 10:38 收件人: bryan.whiteh...@microchip.com; unglinuxdri...@microchip.com; da...@davemloft.net; k...@kernel.org; netdev@vger.kernel.org; linux-ker...@vger.kernel.org 抄送: zhengyongjun 主题

[PATCH -next v2] mt7601u: Convert to DEFINE_SHOW_ATTRIBUTE

2020-09-18 Thread Qinglang Miao
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Qinglang Miao --- .../net/wireless/mediatek/mt7601u/debugfs.c | 34 --- 1 file changed, 6 insertions(+), 28 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt7601u/debugfs.c b/drivers/net/wireless/me

[PATCH net-next] net: natsemi: Remove set but not used variable

2020-09-18 Thread Zheng Yongjun
Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/ethernet/natsemi/ns83820.c: In function ns83820_get_link_ksettings: drivers/net/ethernet/natsemi/ns83820.c:1210:11: warning: variable ‘tanar’ set but not used [-Wunused-but-set-variable] `tanar` is never used, so remove it. Signed-off-b

[PATCH net-next] net: microchip: Remove set but not used variable

2020-09-18 Thread Zheng Yongjun
Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/ethernet/microchip/lan743x_main.c: In function lan743x_pm_suspend: drivers/net/ethernet/microchip/lan743x_main.c:3041:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] `ret` is set but not used, so check it's value.

[PATCH net-next] net: microchip: Remove set but not used variable

2020-09-18 Thread Zheng Yongjun
Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/ethernet/microchip/lan743x_main.c: In function lan743x_pm_suspend: drivers/net/ethernet/microchip/lan743x_main.c:3041:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] `ret` is never used, so remove it. Signed-off-

[PATCH net-next] net: micrel: Remove set but not used variable

2020-09-18 Thread Zheng Yongjun
Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/ethernet/micrel/ksz884x.c: In function rx_proc: drivers/net/ethernet/micrel/ksz884x.c:4981:6: warning: variable ‘rx_status’ set but not used [-Wunused-but-set-variable] drivers/net/ethernet/micrel/ksz884x.c: In function netdev_get_ethtoo

[PATCH net-next] net: mventa: remove unused variable 'dummy' in mvneta_mib_counters_clear()

2020-09-18 Thread Zhang Changzhong
Fixes the following W=1 kernel build warning(s): drivers/net/ethernet/marvell/mvneta.c:754:6: warning: variable 'dummy' set but not used [-Wunused-but-set-variable] 754 | u32 dummy; | ^ This variable is not used in function mvneta_mib_counters_clear(), so remove it to avoid bui

[PATCH net-next] net: remove unnecessary NULL checking in napi_consume_skb()

2020-09-18 Thread Yunsheng Lin
When budget is non-zero, skb_unref() has already handled the NULL checking. When budget is zero, the dev_consume_skb_any() has handled NULL checking in __dev_kfree_skb_irq(), or dev_kfree_skb() which also ultimately call skb_unref(). So remove the unnecessary checking in napi_consume_skb(). Sign

Re: [PATCH net-next] net: hns3: remove unnecessary NULL checking in napi_consume_skb()

2020-09-18 Thread Yunsheng Lin
Please ignore this patch, the title is not right, sorry for the noise. On 2020/9/19 10:16, Yunsheng Lin wrote: > When budget is non-zero, skb_unref() has already handled the > NULL checking. > > When budget is zero, the dev_consume_skb_any() has handled NULL > checking in __dev_kfree_skb_irq(), o

[PATCH net-next] net: hns3: remove unnecessary NULL checking in napi_consume_skb()

2020-09-18 Thread Yunsheng Lin
When budget is non-zero, skb_unref() has already handled the NULL checking. When budget is zero, the dev_consume_skb_any() has handled NULL checking in __dev_kfree_skb_irq(), or dev_kfree_skb() which also ultimately call skb_unref(). So remove the unnecessary checking in napi_consume_skb(). Sign

[PATCH -next v2] mt76: Convert to DEFINE_SHOW_ATTRIBUTE

2020-09-18 Thread Qinglang Miao
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Qinglang Miao --- .../wireless/mediatek/mt76/mt7603/debugfs.c | 18 +++--- .../wireless/mediatek/mt76/mt7615/debugfs.c | 17 ++ .../wireless/mediatek/mt76/mt76x02_debugfs.c | 34 --- 3 files cha

[PATCH v2] brcmfmac: check return value of driver_for_each_device()

2020-09-18 Thread Zhang Changzhong
Fixes the following W=1 kernel build warning(s): drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c:1576:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable] 1576 | int ret; | ^~~ driver_for_each_device() has been declared with __must_check, so the return va

[PATCH net-next] net: marvell: Remove set but not used variable

2020-09-18 Thread Zheng Yongjun
Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/ethernet/marvell/pxa168_eth.c: In function pxa168_eth_change_mtu: drivers/net/ethernet/marvell/pxa168_eth.c:1190:6: warning: variable ‘retval’ set but not used [-Wunused-but-set-variable] `retval` is never used, so remove it. Signed-off

Re: [PATCH v2] net: sctp: Fix IPv6 ancestor_size calc in sctp_copy_descendant

2020-09-18 Thread Marcelo Ricardo Leitner
On Sat, Sep 19, 2020 at 12:12:11AM +, Henry Ptasinski wrote: > When calculating ancestor_size with IPv6 enabled, simply using > sizeof(struct ipv6_pinfo) doesn't account for extra bytes needed for > alignment in the struct sctp6_sock. On x86, there aren't any extra > bytes, but on ARM the ipv6_

[PATCH net-next] net: e1000: Remove set but not used variable

2020-09-18 Thread Zheng Yongjun
Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/ethernet/intel/e1000/e1000_hw.c: In function e1000_phy_init_script: drivers/net/ethernet/intel/e1000/e1000_hw.c:132:6: warning: variable ‘ret_val’ set but not used [-Wunused-but-set-variable] `ret_val` is never used, so remove it. Signe

答复: [PATCH net-next] net: ethernet: Remove set but not used variable

2020-09-18 Thread zhengyongjun
I have fix it and send back the patch to you. Thank you very much. -邮件原件- 发件人: David Miller [mailto:da...@davemloft.net] 发送时间: 2020年9月19日 5:30 收件人: zhengyongjun 抄送: fmanlu...@marvell.com; sbu...@marvell.com; dchick...@marvell.com; k...@kernel.org; netdev@vger.kernel.org; linux-ker...@vg

[PATCH net-next] net: liquidio: Remove set but not used variable

2020-09-18 Thread Zheng Yongjun
Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/ethernet/cavium/liquidio/octeon_device.c: In function lio_pci_readq: drivers/net/ethernet/cavium/liquidio/octeon_device.c:1327:6: warning: variable ‘val32’ set but not used [-Wunused-but-set-variable] drivers/net/ethernet/cavium/liquidio

Re: [PATCH] MAINTAINERS: Update ibmveth maintainer

2020-09-18 Thread David Miller
From: Cristobal Forno Date: Fri, 18 Sep 2020 13:47:43 -0500 > Removed Thomas Falcon. Added myself (Cristobal Forno) as the maintainer of > ibmveth. > > Signed-off-by: Cristobal Forno Applied.

Re: [PATCH net-next v4 0/9] mv88e6xxx: Add devlink regions support

2020-09-18 Thread David Miller
From: Andrew Lunn Date: Fri, 18 Sep 2020 21:11:00 +0200 > Make use of devlink regions to allow read access to some of the > internal of the switches. Currently access to global1, global2 and the > ATU is provided. > > The switch itself will never trigger a region snapshot, it is assumed > it is

Re: [PATCH] net/sched: cbs: fix calculation error of idleslope credits

2020-09-18 Thread David Miller
From: Xiaoyong Yan Date: Fri, 18 Sep 2020 01:42:52 -0700 > + delay = delay_from_credits(q->credits, q->idleslope); > + cbs_timer_schedule(q, now+ delay); > + q->last = now; This indentation cannot be correct. Please fix this.

Re: [v2, 0/2] ptp_qoriq: support FIPER3

2020-09-18 Thread David Miller
From: Yangbo Lu Date: Fri, 18 Sep 2020 17:47:59 +0800 > The FIPER3 (fixed interval period pulse generator) is supported on > DPAA2 and ENETC network controller hardware. This patch-set is to > support it in ptp_qoriq driver and dt-binding. > > Changes for v2: > - Some improvement in code. > - Ad

Re: [PATCH net-next v3 0/7] net: ipa: wake up system on RX available

2020-09-18 Thread David Miller
From: Alex Elder Date: Thu, 17 Sep 2020 12:39:19 -0500 > This series arranges for the IPA driver to wake up a suspended > system if the IPA hardware has a packet to deliver to the AP. > > Version 2 replaced the first patch from version 1 with three > patches, in response to David Miller's feedba

Re: [PATCH] net: ipv6: fix kconfig dependency warning for IPV6_SEG6_HMAC

2020-09-18 Thread David Miller
From: Necip Fazil Yildiran Date: Thu, 17 Sep 2020 19:46:43 +0300 > When IPV6_SEG6_HMAC is enabled and CRYPTO is disabled, it results in the > following Kbuild warning: > > WARNING: unmet direct dependencies detected for CRYPTO_HMAC > Depends on [n]: CRYPTO [=n] > Selected by [y]: > - IPV6_

Re: [PATCH v6 0/3] Add 802.1AD protocol support for dsa switch and ocelot driver

2020-09-18 Thread Florian Fainelli
On 9/18/2020 5:20 PM, David Miller wrote: From: hongbo.w...@nxp.com Date: Wed, 16 Sep 2020 17:48:42 +0800 1. Overview a) 0001* is for support to set dsa slave into 802.1AD(QinQ) mode. b) 0002* is for vlan_proto support for br_switchdev_port_vlan_add and br_switchdev_port_vlan_del. c) 0003*

Re: [PATCH net-next v2] net: phy: bcm7xxx: request and manage GPHY clock

2020-09-18 Thread David Miller
From: Florian Fainelli Date: Wed, 16 Sep 2020 19:04:13 -0700 > The internal Gigabit PHY on Broadcom STB chips has a digital clock which > drives its MDIO interface among other things, the driver now requests > and manage that clock during .probe() and .remove() accordingly. > > Because the PHY d

Re: [PATCH v6 0/3] Add 802.1AD protocol support for dsa switch and ocelot driver

2020-09-18 Thread David Miller
From: hongbo.w...@nxp.com Date: Wed, 16 Sep 2020 17:48:42 +0800 > 1. Overview > a) 0001* is for support to set dsa slave into 802.1AD(QinQ) mode. > b) 0002* is for vlan_proto support for br_switchdev_port_vlan_add and > br_switchdev_port_vlan_del. > c) 0003* is for setting QinQ related registers

Re: [net-next v7 0/5] devlink flash update overwrite mask

2020-09-18 Thread Shannon Nelson
On 9/18/20 4:42 PM, Jacob Keller wrote: This series introduces support for a new attribute to the flash update command: DEVLINK_ATTR_FLASH_UPDATE_OVERWRITE_MASK. This attribute is a bitfield which allows userspace to specify what set of subfields to overwrite when performing a flash update for a

[PATCH net-next] net: mvneta: avoid copying shared_info frags in mvneta_swbm_build_skb

2020-09-18 Thread Lorenzo Bianconi
Avoid copying skb_shared_info frags array in mvneta_swbm_build_skb() since __build_skb_around() does not overwrite it Signed-off-by: Lorenzo Bianconi --- drivers/net/ethernet/marvell/mvneta.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/mar

[net-next v7 2/5] devlink: convert flash_update to use params structure

2020-09-18 Thread Jacob Keller
The devlink core recently gained support for checking whether the driver supports a flash_update parameter, via `supported_flash_update_params`. However, parameters are specified as function arguments. Adding a new parameter still requires modifying the signature of the .flash_update callback in al

[net-next v7 4/5] netdevsim: add support for flash_update overwrite mask

2020-09-18 Thread Jacob Keller
The devlink interface recently gained support for a new "overwrite mask" parameter that allows specifying how various sub-sections of a flash component are modified when updating. Add support for this to netdevsim, to enable easily testing the interface. Make the allowed overwrite mask values cont

[net-next v7 1/5] devlink: check flash_update parameter support in net core

2020-09-18 Thread Jacob Keller
When implementing .flash_update, drivers which do not support per-component update are manually checking the component parameter to verify that it is NULL. Without this check, the driver might accept an update request with a component specified even though it will not honor such a request. Instead

[net-next v7 0/5] devlink flash update overwrite mask

2020-09-18 Thread Jacob Keller
This series introduces support for a new attribute to the flash update command: DEVLINK_ATTR_FLASH_UPDATE_OVERWRITE_MASK. This attribute is a bitfield which allows userspace to specify what set of subfields to overwrite when performing a flash update for a device. The intention is to support the

[net-next v7 3/5] devlink: introduce flash update overwrite mask

2020-09-18 Thread Jacob Keller
Sections of device flash may contain settings or device identifying information. When performing a flash update, it is generally expected that these settings and identifiers are not overwritten. However, it may sometimes be useful to allow overwriting these fields when performing a flash update. S

Re: Exposing device ACL setting through devlink

2020-09-18 Thread Thomas Falcon
On 9/18/20 2:20 AM, Jiri Pirko wrote: Thu, Sep 17, 2020 at 10:31:10PM CEST, tlfal...@linux.ibm.com wrote: On 9/10/20 2:00 AM, Jiri Pirko wrote: Tue, Sep 08, 2020 at 08:27:13PM CEST, tlfal...@linux.ibm.com wrote: On 9/4/20 5:37 PM, Jakub Kicinski wrote: On Fri, 4 Sep 2020 10:31:41 +0200 Jiri

Re: [PATCH bpf-next] bpf: Use hlist_add_head_rcu when linking to local_storage

2020-09-18 Thread Daniel Borkmann
On 9/16/20 10:44 PM, Martin KaFai Lau wrote: The local_storage->list will be traversed by rcu reader in parallel. Thus, hlist_add_head_rcu() is needed in bpf_selem_link_storage_nolock(). This patch fixes it. This part of the code has recently been refactored in bpf-next and this patch makes chan

Re: [PATCH bpf v1] tools/bpftool: support passing BPFTOOL_VERSION to make

2020-09-18 Thread Daniel Borkmann
On 9/17/20 1:58 PM, Tony Ambardar wrote: This change facilitates out-of-tree builds, packaging, and versioning for test and debug purposes. Defining BPFTOOL_VERSION allows self-contained builds within the tools tree, since it avoids use of the 'kernelversion' target in the top-level makefile, whi

Re: [net-next v6 0/5] devlink flash update overwrite mask

2020-09-18 Thread Jacob Keller
On 9/18/2020 2:04 PM, David Miller wrote: > From: Jacob Keller > Date: Thu, 17 Sep 2020 17:45:24 -0700 > >> This series introduces support for a new attribute to the flash update >> command: DEVLINK_ATTR_FLASH_UPDATE_OVERWRITE_MASK. >> >> This attribute is a bitfield which allows userspace to

Re: [PATCH net-next v2 2/8] devlink: Support add and delete devlink port

2020-09-18 Thread Jacob Keller
On 9/17/2020 9:25 PM, Parav Pandit wrote: >> From: Jacob Keller >> Sent: Friday, September 18, 2020 12:13 AM >> >> >> On 9/17/2020 10:20 AM, Parav Pandit wrote: >>> Extended devlink interface for the user to add and delete port. >>> Extend devlink to connect user requests to driver to add/delet

Re: [PATCH net-next v2 1/8] devlink: Introduce PCI SF port flavour and port attribute

2020-09-18 Thread Jacob Keller
On 9/17/2020 8:54 PM, Parav Pandit wrote: > > >> From: Jacob Keller >> Sent: Friday, September 18, 2020 12:00 AM >> >> >> On 9/17/2020 10:20 AM, Parav Pandit wrote: >>> A PCI sub-function (SF) represents a portion of the device similar to >>> PCI VF. >>> >>> In an eswitch, PCI SF may have por

Re: [PATCH net-next v2 3/8] devlink: Prepare code to fill multiple port function attributes

2020-09-18 Thread Jacob Keller
On 9/17/2020 8:35 PM, Parav Pandit wrote: > Hi Jacob, > >> From: Jacob Keller >> Sent: Friday, September 18, 2020 12:29 AM >> >> >> We lost this comment in the move it looks like. I think it's still useful to >> keep for >> clarity of why we're converting -EOPNOTSUPP in the return. > You are

[net-next PATCH] net: dsa: rtl8366: Skip PVID setting if not requested

2020-09-18 Thread Linus Walleij
We go to lengths to determine whether the PVID should be set for this port or not, and then fail to take it into account. Fix this oversight. Fixes: d8652956cf37 ("net: dsa: realtek-smi: Add Realtek SMI driver") Signed-off-by: Linus Walleij --- drivers/net/dsa/rtl8366.c | 3 +++ 1 file changed,

Re: [PATCH bpf-next v3 1/5] bpf: expose is_mptcp flag to bpf_tcp_sock

2020-09-18 Thread Song Liu
On Fri, Sep 18, 2020 at 5:13 AM Nicolas Rybowski wrote: > > is_mptcp is a field from struct tcp_sock used to indicate that the > current tcp_sock is part of the MPTCP protocol. > > In this protocol, a first socket (mptcp_sock) is created with > sk_protocol set to IPPROTO_MPTCP (=262) for control p

Re: [net 0/4][pull request] Intel Wired LAN Driver Updates 2020-09-18

2020-09-18 Thread David Miller
Tony, there seems to be repeated problems with the patch serieses you post. Several of the patches in the series don't make it to the mailing list and looking at the vger.kernel.org logs I see: RVeMDj9w553 5.4.3 Hello [192.55.52.118], for MAIL FROM address the policy analysis reports

Re: [PATCH] Revert "net: linkwatch: add check for netdevice being present to linkwatch_do_dev"

2020-09-18 Thread David Miller
From: Saeed Mahameed Date: Fri, 18 Sep 2020 10:58:49 -0700 > On Tue, 2020-09-01 at 17:02 +0200, Geert Uytterhoeven wrote: >> @@ -158,7 +158,7 @@ static void linkwatch_do_dev(struct net_device >> *dev) >> clear_bit(__LINK_STATE_LINKWATCH_PENDING, &dev->state); >> >> rfc2863_policy(dev)

Re: [PATCH 0/6] pull request for net: batman-adv 2020-09-18

2020-09-18 Thread David Miller
From: Simon Wunderlich Date: Fri, 18 Sep 2020 15:19:50 +0200 > here are some late bugfixes which we would like to have integrated into net. > > Please pull or let me know of any problem! Pulled, thanks Simon.

Re: [PATCH net-next] net: tipc: Supply missing udp_media.h include file

2020-09-18 Thread David Miller
From: Wang Hai Date: Fri, 18 Sep 2020 21:18:19 +0800 > If the header file containing a function's prototype isn't included by > the sourcefile containing the associated function, the build system > complains of missing prototypes. > > Fixes the following W=1 kernel build warning(s): > > net/tip

Re: [PATCH net-next] tipc: Remove unused macro CF_SERVER

2020-09-18 Thread David Miller
From: YueHaibing Date: Fri, 18 Sep 2020 21:16:15 +0800 > It is no used any more, so can remove it. > > Signed-off-by: YueHaibing Applied.

Re: [PATCH net-next] net: hns3: Supply missing hclge_dcb.h include file

2020-09-18 Thread David Miller
From: Wang Hai Date: Fri, 18 Sep 2020 21:06:53 +0800 > If the header file containing a function's prototype isn't included by > the sourcefile containing the associated function, the build system > complains of missing prototypes. > > Fixes the following W=1 kernel build warning(s): > > drivers

Re: [PATCH net-next] liquidio: Fix -Wmissing-prototypes warnings for liquidio

2020-09-18 Thread David Miller
From: Wang Hai Date: Fri, 18 Sep 2020 21:02:10 +0800 > If the header file containing a function's prototype isn't included by > the sourcefile containing the associated function, the build system > complains of missing prototypes. > > Fixes the following W=1 kernel build warning(s): > > drivers

Re: [PATCH net-next] net/appletalk: Supply missing net/Space.h include file

2020-09-18 Thread David Miller
From: Wang Hai Date: Fri, 18 Sep 2020 20:55:51 +0800 > If the header file containing a function's prototype isn't included by > the sourcefile containing the associated function, the build system > complains of missing prototypes. > > Fixes the following W=1 kernel build warning(s): > > drivers

[PATCH] rhashtable: fix indentation of a continue statement

2020-09-18 Thread Colin King
From: Colin Ian King A continue statement is indented incorrectly, add in the missing tab. Signed-off-by: Colin Ian King --- lib/test_rhashtable.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/test_rhashtable.c b/lib/test_rhashtable.c index c5a6fef7b45d..76c607ee6db5

Re: [PATCH] Revert "net: linkwatch: add check for netdevice being present to linkwatch_do_dev"

2020-09-18 Thread David Miller
From: Nikolay Aleksandrov Date: Fri, 18 Sep 2020 12:35:02 + > Thanks for the analysis, I don't see any issues with checking if the device > isn't present. It will have to go through some testing, but no obvious > objections/issues. Have you tried if it fixes your case? > I have briefly gone o

Re: [PATCH net-next 1/1] l2tp: fix up inconsistent rx/tx statistics

2020-09-18 Thread David Miller
From: Tom Parkin Date: Fri, 18 Sep 2020 11:23:21 +0100 > Historically L2TP core statistics count the L2TP header in the > per-session and per-tunnel byte counts tracked for transmission and > receipt. > > Now that l2tp_xmit_skb updates tx stats, it is necessary for > l2tp_xmit_core to pass out t

Re: [v2] dpaa2-eth: fix a build warning in dpmac.c

2020-09-18 Thread David Miller
From: Yangbo Lu Date: Fri, 18 Sep 2020 17:22:25 +0800 > Fix below sparse warning in dpmac.c. > warning: cast to restricted __le64 > > Signed-off-by: Yangbo Lu Applied.

[net 2/4] ice: Fix call trace on suspend

2020-09-18 Thread Tony Nguyen
From: Anirudh Venkataramanan It appears that the ice_suspend flow is missing a call to pci_save_state and this is triggering the message "State of device not saved by ice_suspend" and a call trace. Fix it. Fixes: 769c500dcc1e ("ice: Add advanced power mgmt for WoL") Signed-off-by: Anirudh Venkat

Re: [PATCH net-next] hinic: modify irq name

2020-09-18 Thread David Miller
From: Luo bin Date: Fri, 18 Sep 2020 17:23:22 +0800 > Make a distinction between different irqs by netdev name or pci name. > > Signed-off-by: Luo bin Applied.

Re: [PATCH net-next] net: cortina: Remove set but not used variable

2020-09-18 Thread David Miller
From: Zheng Yongjun Date: Fri, 18 Sep 2020 16:49:51 +0800 > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/ethernet/cortina/gemini.c: In function gmac_get_ringparam: > drivers/net/ethernet/cortina/gemini.c:2125:21: warning: variable ‘config0’ > set but not used [-Wunused-but-set

[net 0/4][pull request] Intel Wired LAN Driver Updates 2020-09-18

2020-09-18 Thread Tony Nguyen
This series contains updates to the iavf and ice driver. Sylwester fixes a crash with iavf resume due to getting the wrong pointers. Ani fixes a call trace in ice resume by calling pci_save_state(). Jakes fixes memory leaks in case of register_netdev() failure or ice_cfg_vsi_lan() failure for th

[net 4/4] ice: fix memory leak in ice_vsi_setup

2020-09-18 Thread Tony Nguyen
From: Jacob Keller During ice_vsi_setup, if ice_cfg_vsi_lan fails, it does not properly release memory associated with the VSI rings. If we had used devres allocations for the rings, this would be ok. However, we use kzalloc and kfree_rcu for these ring structures. Using the correct label to cle

Re: [v4, 0/5] dpaa2_eth: support 1588 one-step timestamping

2020-09-18 Thread David Miller
From: Yangbo Lu Date: Fri, 18 Sep 2020 17:07:57 +0800 > This patch-set is to add MC APIs of 1588 one-step timestamping, and > support one-step timestamping for PTP Sync packet on DPAA2. > > Before egress, one-step timestamping enablement needs, > > - Enabling timestamp and FAS (Frame Annotation

Re: [PATCH net-next] net: ethernet: Remove set but not used variable

2020-09-18 Thread David Miller
From: Zheng Yongjun Date: Fri, 18 Sep 2020 16:39:38 +0800 > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/ethernet/cavium/liquidio/octeon_device.c: In function > lio_pci_readq: > drivers/net/ethernet/cavium/liquidio/octeon_device.c:1327:6: warning: > variable ‘val32’ set but n

[PATCH net] net: mvneta: recycle the page in case of out-of-order

2020-09-18 Thread Lorenzo Bianconi
Recycle the received page into the page_pool cache if the dma descriptors arrived in a wrong order Fixes: ca0e014609f05 ("net: mvneta: move skb build after descriptors processing") Signed-off-by: Lorenzo Bianconi --- drivers/net/ethernet/marvell/mvneta.c | 6 +- 1 file changed, 5 insertions

Re: [PATCH] net: openswitch: reuse the helper variable to improve the code readablity

2020-09-18 Thread David Miller
From: Zeng Tao Date: Fri, 18 Sep 2020 15:14:30 +0800 > In the function ovs_ct_limit_exit, there is already a helper vaibale > which could be reused to improve the readability, so i fix it in this > patch. > > Signed-off-by: Zeng Tao Applied, thanks.

Re: [PATCH] net: hns: kerneldoc fixes

2020-09-18 Thread David Miller
From: Lu Wei Date: Fri, 18 Sep 2020 14:36:46 +0800 > Fix some parameter description mistakes. > > Signed-off-by: Lu Wei Applied, thanks.

Re: [PATCH v2] ptp: mark symbols static where possible

2020-09-18 Thread David Miller
From: Herrington Date: Fri, 18 Sep 2020 14:10:13 +0800 > +void pch_ch_control_write(struct pci_dev *pdev, u32 val); > void pch_ch_control_write(struct pci_dev *pdev, u32 val) Prototypes belong in a header file not in the C file where they are defined. If these functions are accessed in other f

Re: [PATCH next] net: fix build without CONFIG_SYSCTL definition

2020-09-18 Thread David Miller
From: Mahesh Bandewar Date: Thu, 17 Sep 2020 22:08:32 -0700 > Earlier commit 316cdaa1158a ("net: add option to not create fall-back > tunnels in root-ns as well") removed the CONFIG_SYSCTL to enable the > kernel-commandline to work. However, this variable gets defined only > when CONFIG_SYSCTL op

Re: [PATCH 0/7 net-next] net: various: delete duplicated words

2020-09-18 Thread David Miller
From: Randy Dunlap Date: Thu, 17 Sep 2020 21:35:14 -0700 > [PATCH 1/7 net-next] net: core: delete duplicated words > [PATCH 2/7 net-next] net: rds: delete duplicated words > [PATCH 3/7 net-next] net: ipv6: delete duplicated words > [PATCH 4/7 net-next] net: bluetooth: delete duplicated words > [P

Re: [PATCH net] hinic: fix sending pkts from core while self testing

2020-09-18 Thread David Miller
From: Luo bin Date: Fri, 18 Sep 2020 12:09:38 +0800 > Call netif_tx_disable firstly before starting doing self-test to > avoid sending packet from networking core and self-test packet > simultaneously which may cause self-test failure or hw abnormal. > > Fixes: 4aa218a4fe77 ("hinic: add self tes

Re: [PATCH net-next] Revert "ibmvnic: remove never executed if statement"

2020-09-18 Thread David Miller
From: Lijun Pan Date: Thu, 17 Sep 2020 21:12:46 -0500 > This reverts commit 550f4d46aff6fe57c9b1c6719c3c9de2237d7ac2. > > adapter->from_passive_init may be changed in ibmvnic_handle_crq > while ibmvnic_reset_init is waiting for the completion of > adapter->init_done. > > Signed-off-by: Lijun Pa

Re: [net-next v6 0/5] devlink flash update overwrite mask

2020-09-18 Thread David Miller
From: Jacob Keller Date: Thu, 17 Sep 2020 17:45:24 -0700 > This series introduces support for a new attribute to the flash update > command: DEVLINK_ATTR_FLASH_UPDATE_OVERWRITE_MASK. > > This attribute is a bitfield which allows userspace to specify what set of > subfields to overwrite when perf

Re: [net-next v3 0/4] tipc: add more features to TIPC encryption

2020-09-18 Thread David Miller
From: Tuong Lien Date: Fri, 18 Sep 2020 08:17:25 +0700 > This series adds some new features to TIPC encryption: > > - Patch 1 ("tipc: optimize key switching time and logic") optimizes the > code and logic in preparation for the following commits. > > - Patch 2 ("tipc: introduce encryption maste

[PATCH v3 1/2] net: mdio-ipq4019: change defines to upper case

2020-09-18 Thread Robert Marko
In the commit adding the IPQ4019 MDIO driver, defines for timeout and sleep partially used lower case. Lets change it to upper case in line with the rest of driver defines. Signed-off-by: Robert Marko Cc: Luka Perkov Reviewed-by: Andrew Lunn Reviewed-by: Florian Fainelli --- drivers/net/phy/

[PATCH v3 2/2] net: mdio-ipq4019: add Clause 45 support

2020-09-18 Thread Robert Marko
While up-streaming the IPQ4019 driver it was thought that the controller had no Clause 45 support, but it actually does and its activated by writing a bit to the mode register. So lets add it as newer SoC-s use the same controller and Clause 45 compliant PHY-s. Signed-off-by: Robert Marko Cc:

[PATCH v3 0/2] net: mdio-ipq4019: add Clause 45 support

2020-09-18 Thread Robert Marko
This patch series adds support for Clause 45 to the driver. While at it also change some defines to upper case to match rest of the driver. Changes since v1: * Drop clock patches, these need further investigation and no user for non default configuration has been found Robert Marko (2): net: m

Re: [PATCH v5 net-next 0/5] ionic: add devlink dev flash support

2020-09-18 Thread David Miller
From: Shannon Nelson Date: Thu, 17 Sep 2020 18:13:22 -0700 > Add support for using devlink's dev flash facility to update the > firmware on an ionic device, and add a new timeout parameter to the > devlink flash netlink message. > > For long-running flash commands, we add a timeout element to th

Re: [PATCH v2 net 0/8] Bugfixes in Microsemi Ocelot switch driver

2020-09-18 Thread David Miller
From: Vladimir Oltean Date: Fri, 18 Sep 2020 04:07:22 +0300 > From: Vladimir Oltean > > This is a series of 8 assorted patches for "net", on the drivers for the > VSC7514 MIPS switch (Ocelot-1), the VSC9953 PowerPC (Seville), and a few > more that are common to all supported devices since they

[PATCH v2 2/2] net: mdio-ipq4019: add Clause 45 support

2020-09-18 Thread Robert Marko
While up-streaming the IPQ4019 driver it was thought that the controller had no Clause 45 support, but it actually does and its activated by writing a bit to the mode register. So lets add it as newer SoC-s use the same controller and Clause 45 compliant PHY-s. Signed-off-by: Robert Marko Cc:

[PATCH v2 0/2] net: mdio-ipq4019: add Clause 45 support

2020-09-18 Thread Robert Marko
This patch series adds support for Clause 45 to the driver. While at it also change some defines to upper case to match rest of the driver. Changes since v1: * Drop clock patches, these need further investigation and no user for non default configuration has been found Robert Marko (2): net: m

[PATCH v2 1/2] net: mdio-ipq4019: change defines to upper case

2020-09-18 Thread Robert Marko
In the commit adding the IPQ4019 MDIO driver, defines for timeout and sleep partially used lower case. Lets change it to upper case in line with the rest of driver defines. Signed-off-by: Robert Marko Cc: Luka Perkov Reviewed-by: Andrew Lunn Reviewed-by: Florian Fainelli --- drivers/net/phy/

Re: [PATCH -next 7/9] rtlwifi: rtl8192ce: fix comparison to bool warning in hw.c

2020-09-18 Thread Larry Finger
On 9/18/20 5:25 AM, Zheng Bin wrote: Fixes coccicheck warning: drivers/net/wireless/realtek/rtlwifi/rtl8192ce/hw.c:616:14-20: WARNING: Comparison to bool drivers/net/wireless/realtek/rtlwifi/rtl8192ce/hw.c:621:13-19: WARNING: Comparison to bool drivers/net/wireless/realtek/rtlwifi/rtl8192ce/hw

Re: [PATCH -next 8/9] rtlwifi: rtl8192de: fix comparison to bool warning in hw.c

2020-09-18 Thread Larry Finger
On 9/18/20 5:25 AM, Zheng Bin wrote: Fixes coccicheck warning: drivers/net/wireless/realtek/rtlwifi/rtl8192de/hw.c:566:14-20: WARNING: Comparison to bool drivers/net/wireless/realtek/rtlwifi/rtl8192de/hw.c:572:13-19: WARNING: Comparison to bool drivers/net/wireless/realtek/rtlwifi/rtl8192de/hw

Re: [PATCH -next 9/9] rtlwifi: rtl8723be: fix comparison to bool warning in hw.c

2020-09-18 Thread Larry Finger
On 9/18/20 5:25 AM, Zheng Bin wrote: Fixes coccicheck warning: drivers/net/wireless/realtek/rtlwifi/rtl8723be/hw.c:861:6-35: WARNING: Comparison to bool Signed-off-by: Zheng Bin --- drivers/net/wireless/realtek/rtlwifi/rtl8723be/hw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH -next 4/9] rtlwifi: rtl8821ae: fix comparison to bool warning in hw.c

2020-09-18 Thread Larry Finger
On 9/18/20 5:25 AM, Zheng Bin wrote: Fixes coccicheck warning: drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c:1897:5-13: WARNING: Comparison to bool Signed-off-by: Zheng Bin --- drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH -next 6/9] rtlwifi: rtl8192cu: fix comparison to bool warning in hw.c

2020-09-18 Thread Larry Finger
On 9/18/20 5:25 AM, Zheng Bin wrote: Fixes coccicheck warning: drivers/net/wireless/realtek/rtlwifi/rtl8192cu/hw.c:831:14-49: WARNING: Comparison to bool Signed-off-by: Zheng Bin --- drivers/net/wireless/realtek/rtlwifi/rtl8192cu/hw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH v4] net: use exponential backoff in netdev_wait_allrefs

2020-09-18 Thread David Miller
From: frugg...@arista.com (Francesco Ruggeri) Date: Fri, 18 Sep 2020 13:19:01 -0700 > The combination of aca_free_rcu, introduced in commit 2384d02520ff > ("net/ipv6: Add anycast addresses to a global hashtable"), and > fib6_info_destroy_rcu, introduced in commit 9b0a8da8c4c6 ("net/ipv6: > respect

Re: [PATCH -next 5/9] rtlwifi: rtl8821ae: fix comparison to bool warning in phy.c

2020-09-18 Thread Larry Finger
On 9/18/20 5:25 AM, Zheng Bin wrote: Fixes coccicheck warning: drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c:1816:5-13: WARNING: Comparison to bool drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c:1825:5-13: WARNING: Comparison to bool drivers/net/wireless/realtek/rtlwifi/rtl8821ae/

Re: [PATCH -next 3/9] rtlwifi: rtl8192cu: fix comparison to bool warning in mac.c

2020-09-18 Thread Larry Finger
On 9/18/20 5:24 AM, Zheng Bin wrote: Fixes coccicheck warning: drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c:161:14-17: WARNING: Comparison to bool drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c:168:13-16: WARNING: Comparison to bool drivers/net/wireless/realtek/rtlwifi/rtl8192cu/

  1   2   3   4   >