On 9/17/2020 8:35 PM, Parav Pandit wrote: > Hi Jacob, > >> From: Jacob Keller <jacob.e.kel...@intel.com> >> Sent: Friday, September 18, 2020 12:29 AM >> >> >> We lost this comment in the move it looks like. I think it's still useful to >> keep for >> clarity of why we're converting -EOPNOTSUPP in the return. > You are right. It is a useful comment. > However, it is already covered in include/net/devlink.h in the standard > comment of the callback function. > For new driver implementation, looking there will be more useful. > So I guess its ok to drop from here. > Yea if it's still in the header I don't think it's too important to keep here. Thanks! -Jake
- Re: [PATCH net-next v2 8/8] netde... David Ahern
- RE: [PATCH net-next v2 8/8] netde... Parav Pandit
- [PATCH net-next v2 5/8] netdevsim: Add support for... Parav Pandit
- [PATCH net-next v2 6/8] netdevsim: Simulate get/se... Parav Pandit
- [PATCH net-next v2 4/8] devlink: Support get and s... Parav Pandit
- Re: [PATCH net-next v2 4/8] devlink: Support g... David Ahern
- RE: [PATCH net-next v2 4/8] devlink: Suppo... Parav Pandit
- [PATCH net-next v2 7/8] netdevsim: Simulate port f... Parav Pandit
- [PATCH net-next v2 3/8] devlink: Prepare code to f... Parav Pandit
- RE: [PATCH net-next v2 3/8] devlink: Prepare c... Parav Pandit
- Re: [PATCH net-next v2 3/8] devlink: Prepa... Jacob Keller
- RE: [PATCH net-next v2 3/8] devlink: ... Parav Pandit
- Re: [PATCH net-next v2 0/8] devlink: Add SF add/de... Jakub Kicinski
- RE: [PATCH net-next v2 0/8] devlink: Add SF ad... Parav Pandit
- Re: [PATCH net-next v2 0/8] devlink: Add S... Jakub Kicinski
- RE: [PATCH net-next v2 0/8] devlink: ... Parav Pandit
- Re: [PATCH net-next v2 0/8] devli... Jakub Kicinski
- RE: [PATCH net-next v2 0/8] devli... Parav Pandit
- Re: [PATCH net-next v2 0/8] devli... Jakub Kicinski
- RE: [PATCH net-next v2 0/8] devli... Parav Pandit
- [PATCH net-next 1/8] devlink: Introduce PCI SF port flavour... Parav Pandit