RE: [PATCH net-next v2 3/8] devlink: Prepare code to fill multiple port function attributes

[Parav Pandit]

> From: Jacob Keller <jacob.e.kel...@intel.com>
> Sent: Saturday, September 19, 2020 4:24 AM
> 
> 
> On 9/17/2020 8:35 PM, Parav Pandit wrote:
> > Hi Jacob,
> >
> >> From: Jacob Keller <jacob.e.kel...@intel.com>
> >> Sent: Friday, September 18, 2020 12:29 AM
> >>
> >>
> >> We lost this comment in the move it looks like. I think it's still
> >> useful to keep for clarity of why we're converting -EOPNOTSUPP in the
> return.
> > You are right. It is a useful comment.
> > However, it is already covered in include/net/devlink.h in the standard
> comment of the callback function.
> > For new driver implementation, looking there will be more useful.
> > So I guess its ok to drop from here.
> >
> 
> Yea if it's still in the header I don't think it's too important to keep here.
>
Alright. Will keep in the header.
Thanks.
 
> Thanks!
> -Jake