On Fri, Sep 18, 2020 at 6:37 AM Song Liu <s...@kernel.org> wrote: > > On Thu, Sep 17, 2020 at 12:46 AM Muchun Song <songmuc...@bytedance.com> wrote: > > > > The in_atomic macro cannot always detect atomic context. In particular, > > it cannot know about held spinlocks in non-preemptible kernels. Although, > > there is no user call bpf_link_put() with holding spinlock now. Be the > > safe side, we can avoid this in the feature. > > > > Signed-off-by: Muchun Song <songmuc...@bytedance.com> > > Acked-by: Song Liu <songliubrav...@fb.com> > > This is a little weird, but I guess that is OK, as bpf_link_put() is > not in the critical
Yeah, bpf_link_put() is OK now because there is no user call it with a holding spinlock. > path. Is the plan to eliminate in_atomic() (as much as possible)? Most other users of in_atomic() just for WARN_ON. It seems there is no problem :). -- Yours, Muchun
