Re: [PATCH net-next 0/2] PCI: let pci_disable_link_state propagate errors

2019-06-21 Thread David Miller
From: Heiner Kallweit Date: Tue, 18 Jun 2019 23:12:56 +0200 > Drivers like r8169 rely on pci_disable_link_state() having disabled > certain ASPM link states. If OS can't control ASPM then > pci_disable_link_state() turns into a no-op w/o informing the caller. > The driver therefore may falsely as

Re: [PATCH net] tcp: refine memory limit test in tcp_fragment()

2019-06-21 Thread David Miller
From: Eric Dumazet Date: Fri, 21 Jun 2019 06:09:55 -0700 > tcp_fragment() might be called for skbs in the write queue. > > Memory limits might have been exceeded because tcp_sendmsg() only > checks limits at full skb (64KB) boundaries. > > Therefore, we need to make sure tcp_fragment() wont pun

[PATCH next 2/3] blackhole_netdev: use blackhole_netdev to invalidate dst entries

2019-06-21 Thread Mahesh Bandewar
Use blackhole_netdev instead of 'lo' device with lower MTU when marking dst "dead". Signed-off-by: Mahesh Bandewar --- net/core/dst.c | 2 +- net/ipv4/route.c | 3 +-- net/ipv6/route.c | 2 +- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/net/core/dst.c b/net/core/dst.c index

[PATCH next 3/3] blackhole_dev: add a selftest

2019-06-21 Thread Mahesh Bandewar
Since this is not really a device with all capabilities, this test ensures that it has *enough* to make it through the data path without causing unwanted side-effects (read crash!). Signed-off-by: Mahesh Bandewar --- lib/Kconfig.debug | 9 ++ lib/Makefile

[PATCH next 1/3] loopback: create blackhole net device similar to loopack.

2019-06-21 Thread Mahesh Bandewar
Create a blackhole net device that can be used for "dead" dst entries instead of loopback device. This blackhole device differs from loopback in few aspects: (a) It's not per-ns. (b) MTU on this device is ETH_MIN_MTU (c) The xmit function is essentially kfree_skb(). and (d) since it's not register

[PATCH next 0/3] blackhole device to invalidate dst

2019-06-21 Thread Mahesh Bandewar
When we invalidate dst or mark it "dead", we assign 'lo' to dst->dev. First of all this assignment is racy and more over, it has MTU implications. The standard dev MTU is 1500 while the Loopback MTU is 64k. TCP code when dereferencing the dst don't check if the dst is valid or not. TCP when derefe

Re: Removing skb_orphan() from ip_rcv_core()

2019-06-21 Thread Eric Dumazet
On 6/21/19 10:58 AM, Joe Stringer wrote: > Hi folks, picking this up again.. > > As discussed during LSFMM, I've been looking at adding something like > an `skb_sk_assign()` helper to BPF so that logic similar to TPROXY can > be implemented with integration into other BPF logic, however > curre

[PATCH net-next] rtnetlink: skip metrics loop for dst_default_metrics

2019-06-21 Thread David Ahern
From: David Ahern dst_default_metrics has all of the metrics initialized to 0, so nothing will be added to the skb in rtnetlink_put_metrics. Avoid the loop if metrics is from dst_default_metrics. Signed-off-by: David Ahern --- net/core/rtnetlink.c | 4 1 file changed, 4 insertions(+) dif

Re: [PATCH iproute2-next v2 1/2] ipaddress: correctly print a VF hw address in the IPoIB case

2019-06-21 Thread David Ahern
On 6/20/19 3:02 AM, Denis Kirjanov wrote: > @@ -349,9 +350,10 @@ static void print_af_spec(FILE *fp, struct rtattr > *af_spec_attr) > > static void print_vf_stats64(FILE *fp, struct rtattr *vfstats); > > -static void print_vfinfo(FILE *fp, struct rtattr *vfinfo) > +static void print_vfinfo(st

Re: [PATCH iproute2-next] tc: q_netem: JSON-ify the output

2019-06-21 Thread David Ahern
On 6/14/19 11:28 AM, Jakub Kicinski wrote: > Add JSON output support to q_netem. > > The normal output is untouched. > > In JSON output always use seconds as the base of time units, > and non-percentage numbers (0.01 instead of 1%). Try to always > report the fields, even if they are zero. > All

Re: [iproute2-next v5] tipc: support interface name when activating UDP bearer

2019-06-21 Thread David Ahern
On 6/13/19 2:07 AM, Hoang Le wrote: > @@ -119,6 +121,74 @@ static int generate_multicast(short af, char *buf, int > bufsize) > return 0; > } > > +static struct ifreq ifr = {}; you don't need to initialize globals, but you could pass a a struct as the arg to the filter here which is both

[PATCH bpf-next] bpftool: Add BPF_F_QUERY_EFFECTIVE support in bpftool cgroup [show|tree]

2019-06-21 Thread Takshak Chahande
With different bpf attach_flags available to attach bpf programs specially with BPF_F_ALLOW_OVERRIDE and BPF_F_ALLOW_MULTI, the list of effective bpf-programs available to any sub-cgroups really needs to be available for easy debugging. Using BPF_F_QUERY_EFFECTIVE flag, one can get the list of not

Re: [PATCH net-next 13/18] ionic: Add initial ethtool support

2019-06-21 Thread Shannon Nelson
On 6/20/19 7:32 PM, Michal Kubecek wrote: On Thu, Jun 20, 2019 at 01:24:19PM -0700, Shannon Nelson wrote: Add in the basic ethtool callbacks for device information and control. Signed-off-by: Shannon Nelson --- ... +static int ionic_get_link_ksettings(struct net_device *netdev, +

Re: [PATCH net-next v7 08/11] ipv6: Dump route exceptions if requested

2019-06-21 Thread David Ahern
On 6/21/19 9:45 AM, Stefano Brivio wrote: > Since commit 2b760fcf5cfb ("ipv6: hook up exception table to store dst > cache"), route exceptions reside in a separate hash table, and won't be > found by walking the FIB, so they won't be dumped to userspace on a > RTM_GETROUTE message. > > This causes

Re: [PATCH net-next 02/18] ionic: Add hardware init and device commands

2019-06-21 Thread Shannon Nelson
On 6/20/19 2:54 PM, Andrew Lunn wrote: On Thu, Jun 20, 2019 at 01:24:08PM -0700, Shannon Nelson wrote: + err = ionic_debugfs_add_dev(ionic); + if (err) { + dev_err(dev, "Cannot add device debugfs: %d , aborting\n", err); + goto err_out_clear_drvdata; +

Re: [PATCH net-next v7 04/11] ipv4: Dump route exceptions if requested

2019-06-21 Thread David Ahern
On 6/21/19 9:45 AM, Stefano Brivio wrote: > Since commit 4895c771c7f0 ("ipv4: Add FIB nexthop exceptions."), cached > exception routes are stored as a separate entity, so they are not dumped > on a FIB dump, even if the RTM_F_CLONED flag is passed. > > This implies that the command 'ip route list

Re: [PATCH net-next 01/18] ionic: Add basic framework for IONIC Network device driver

2019-06-21 Thread Shannon Nelson
On 6/20/19 2:24 PM, Andrew Lunn wrote: Hi Andrew, thanks for your time and comments.  Responses below... +++ b/drivers/net/ethernet/pensando/ionic/ionic.h @@ -0,0 +1,27 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* Copyright(c) 2017 - 2019 Pensando Systems, Inc */ + +#ifndef _IONIC_H_ +#define

Re: [RFC net-next] net: dsa: add support for MC_DISABLED attribute

2019-06-21 Thread Russell King - ARM Linux admin
On Fri, Jun 21, 2019 at 05:29:52PM -0400, Vivien Didelot wrote: > Russell, Ido, Florian, so far I understand that a multicast-unaware > bridge must flood unknown traffic everywhere (CPU included); ^ multicast > and a multicast-aware bridge must on

Re: [RFC net-next] net: dsa: add support for MC_DISABLED attribute

2019-06-21 Thread Vivien Didelot
On Thu, 20 Jun 2019 19:24:47 -0700, Florian Fainelli wrote: > > This patch adds support for enabling or disabling the flooding of > > unknown multicast traffic on the CPU ports, depending on the value > > of the switchdev SWITCHDEV_ATTR_ID_BRIDGE_MC_DISABLED attribute. > > > > This allows the us

[PATCH] bnx2x: Prevent ptp_task to be rescheduled indefinitely

2019-06-21 Thread Guilherme G. Piccoli
Currently bnx2x ptp worker tries to read a register with timestamp information in case of TX packet timestamping and in case it fails, the routine reschedules itself indefinitely. This was reported as a kworker always at 100% of CPU usage, which was narrowed down to be bnx2x ptp_task. By following

Re: [PATCH v2 bpf-next 0/7] libbpf: add tracing attach APIs

2019-06-21 Thread Stanislav Fomichev
On 06/20, Andrii Nakryiko wrote: > This patchset adds the following APIs to allow attaching BPF programs to > tracing entities: > - bpf_program__attach_perf_event for attaching to any opened perf event FD, > allowing users full control; > - bpf_program__attach_kprobe for attaching to kernel probe

Re: [PATCH net-next] ipv6: Convert gateway validation to use fib6_info

2019-06-21 Thread David Ahern
On 6/20/19 5:43 PM, Wei Wang wrote: > I am not very convinced that fib6_lookup() could be equivalent to > rt6_lookup(). Specifically, rt6_lookup() calls rt6_device_match() > while fib6_lookup() calls rt6_select() to match the oif. From a brief > glance, it does seem to be similar, especially consid

Re: Removing skb_orphan() from ip_rcv_core()

2019-06-21 Thread Florian Westphal
Joe Stringer wrote: > As discussed during LSFMM, I've been looking at adding something like > an `skb_sk_assign()` helper to BPF so that logic similar to TPROXY can > be implemented with integration into other BPF logic, however > currently any attempts to do so are blocked by the skb_orphan() cal

[PATCH] xsk: sample kernel code is now in libbpf

2019-06-21 Thread Eric Leblond
Fix documentation that mention xdpsock_kern.c which has been replaced by code embedded in libbpf. Signed-off-by: Eric Leblond --- Documentation/networking/af_xdp.rst | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/Documentation/networking/af_xdp.rst b/Docume

Re: [PATCH net] af_packet: Block execution of tasks waiting for transmit to complete in AF_PACKET

2019-06-21 Thread Willem de Bruijn
On Fri, Jun 21, 2019 at 3:18 PM Neil Horman wrote: > > On Fri, Jun 21, 2019 at 02:31:17PM -0400, Willem de Bruijn wrote: > > On Fri, Jun 21, 2019 at 12:42 PM Neil Horman wrote: > > > > > > On Thu, Jun 20, 2019 at 11:16:13AM -0400, Willem de Bruijn wrote: > > > > On Thu, Jun 20, 2019 at 10:24 AM N

Re: [PATCH v2 net-next 5/5] ipv6: convert major tx path to use RT6_LOOKUP_F_DST_NOREF

2019-06-21 Thread kbuild test robot
Hi Wei, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Wei-Wang/ipv6-avoid-taking-refcnt-on-dst-during-route-lookup/20190621-195237 config: x86_64-randconfig-u0-06220153 (attached as .config

Re: [PATCH v3 rdma-next 0/3] RDMA/qedr: Use the doorbell overflow recovery mechanism for RDMA

2019-06-21 Thread Jason Gunthorpe
On Fri, Jun 21, 2019 at 07:49:39PM +, Michal Kalderon wrote: > > From: linux-rdma-ow...@vger.kernel.org > ow...@vger.kernel.org> On Behalf Of Doug Ledford > > > > On Thu, 2019-06-13 at 11:38 +0300, Michal Kalderon wrote: > > > This patch series used the doorbell overflow recovery mechanism >

Re: [PATCH bpf-next v5 00/16] AF_XDP infrastructure improvements and mlx5e support

2019-06-21 Thread Saeed Mahameed
On Thu, Jun 20, 2019 at 2:13 AM Björn Töpel wrote: > > On Tue, 18 Jun 2019 at 14:00, Maxim Mikityanskiy wrote: > > > > This series contains improvements to the AF_XDP kernel infrastructure > > and AF_XDP support in mlx5e. The infrastructure improvements are > > required for mlx5e, but also some o

RE: [PATCH v3 rdma-next 0/3] RDMA/qedr: Use the doorbell overflow recovery mechanism for RDMA

2019-06-21 Thread Michal Kalderon
> From: linux-rdma-ow...@vger.kernel.org ow...@vger.kernel.org> On Behalf Of Doug Ledford > > On Thu, 2019-06-13 at 11:38 +0300, Michal Kalderon wrote: > > This patch series used the doorbell overflow recovery mechanism > > introduced in commit 36907cd5cd72 ("qed: Add doorbell overflow > > recove

Re: [PATCH net] af_packet: Block execution of tasks waiting for transmit to complete in AF_PACKET

2019-06-21 Thread Neil Horman
On Fri, Jun 21, 2019 at 02:31:17PM -0400, Willem de Bruijn wrote: > On Fri, Jun 21, 2019 at 12:42 PM Neil Horman wrote: > > > > On Thu, Jun 20, 2019 at 11:16:13AM -0400, Willem de Bruijn wrote: > > > On Thu, Jun 20, 2019 at 10:24 AM Neil Horman > > > wrote: > > > > > > > > On Thu, Jun 20, 2019 a

Re: [PATCH bpf-next] libbpf: add xsk_ring_prod__free() function

2019-06-21 Thread Andrii Nakryiko
On Fri, Jun 21, 2019 at 8:26 AM Eelco Chaudron wrote: > > When an AF_XDP application received X packets, it does not mean X > frames can be stuffed into the producer ring. To make it easier for > AF_XDP applications this API allows them to check how many frames can > be added into the ring. > > Si

Re: [PATCH net] ipv6: fix neighbour resolution with raw socket

2019-06-21 Thread kbuild test robot
Hi Nicolas, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net/master] url: https://github.com/0day-ci/linux/commits/Nicolas-Dichtel/ipv6-fix-neighbour-resolution-with-raw-socket/20190621-115455 reproduce: # apt-get install sparse # sparse

Re: [PATCH net] af_packet: Block execution of tasks waiting for transmit to complete in AF_PACKET

2019-06-21 Thread Willem de Bruijn
On Fri, Jun 21, 2019 at 12:42 PM Neil Horman wrote: > > On Thu, Jun 20, 2019 at 11:16:13AM -0400, Willem de Bruijn wrote: > > On Thu, Jun 20, 2019 at 10:24 AM Neil Horman wrote: > > > > > > On Thu, Jun 20, 2019 at 09:41:30AM -0400, Willem de Bruijn wrote: > > > > On Wed, Jun 19, 2019 at 4:26 PM N

Re: [PATCH v2 net-next 5/5] ipv6: convert major tx path to use RT6_LOOKUP_F_DST_NOREF

2019-06-21 Thread kbuild test robot
Hi Wei, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Wei-Wang/ipv6-avoid-taking-refcnt-on-dst-during-route-lookup/20190621-195237 config: x86_64-kexec (attached as .config) compiler: gcc-7 (Debian

[RFC PATCH v4 net-next 04/11] net: ethernet: ti: cpsw: move set of common functions in cpsw_priv

2019-06-21 Thread Grygorii Strashko
As a preparatory patch to add support for a switchdev based cpsw driver, move common functions to cpsw-priv.c so that they can be used across both drivers. Signed-off-by: Ilias Apalodimas Signed-off-by: Murali Karicheri Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/cpsw.c |

[RFC PATCH v4 net-next 09/11] Documentation: networking: add cpsw switchdev based driver documentation

2019-06-21 Thread Grygorii Strashko
From: Ilias Apalodimas A new cpsw dirver based on switchdev was added. Add documentation about basic configuration and future features Signed-off-by: Ilias Apalodimas Signed-off-by: Grygorii Strashko --- .../device_drivers/ti/cpsw_switchdev.txt | 207 ++ 1 file changed, 2

Removing skb_orphan() from ip_rcv_core()

2019-06-21 Thread Joe Stringer
Hi folks, picking this up again.. As discussed during LSFMM, I've been looking at adding something like an `skb_sk_assign()` helper to BPF so that logic similar to TPROXY can be implemented with integration into other BPF logic, however currently any attempts to do so are blocked by the skb_orphan

Re: [PATCH v2 bpf-next 00/11] BTF-defined BPF map definitions

2019-06-21 Thread Andrii Nakryiko
On Fri, Jun 21, 2019 at 3:29 AM Lorenz Bauer wrote: > > On Fri, 21 Jun 2019 at 05:20, Andrii Nakryiko > wrote: > > > > On Thu, Jun 20, 2019 at 7:49 AM Lorenz Bauer wrote: > > > > > > On Tue, 18 Jun 2019 at 22:37, Andrii Nakryiko > > > wrote: > > > > > > > > I would just drop the object-scope

[PATCH net-next v5 4/7] taprio: Remove inline directive

2019-06-21 Thread Vedang Patel
Remove inline directive from length_to_duration(). We will let the compiler make the decisions. Signed-off-by: Vedang Patel --- net/sched/sch_taprio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sched/sch_taprio.c b/net/sched/sch_taprio.c index a41d7d4434ee..6ef0cc03f

[PATCH net-next v5 5/7] taprio: Add support for txtime-assist mode

2019-06-21 Thread Vedang Patel
Currently, we are seeing non-critical packets being transmitted outside of their timeslice. We can confirm that the packets are being dequeued at the right time. So, the delay is induced in the hardware side. The most likely reason is the hardware queues are starving the lower priority queues. In

[PATCH net-next v5 6/7] taprio: make clock reference conversions easier

2019-06-21 Thread Vedang Patel
Later in this series we will need to transform from CLOCK_MONOTONIC (used in TCP) to the clock reference used in TAPRIO. Signed-off-by: Vinicius Costa Gomes Signed-off-by: Vedang Patel --- net/sched/sch_taprio.c | 30 ++ 1 file changed, 22 insertions(+), 8 deletions(

[PATCH net-next v5 7/7] taprio: Adjust timestamps for TCP packets

2019-06-21 Thread Vedang Patel
When the taprio qdisc is running in "txtime offload" mode, it will set the launchtime value (in skb->tstamp) for all the packets which do not have the SO_TXTIME socket option. But, the TCP packets already have this value set and it indicates the earliest departure time represented in CLOCK_MONOTONI

[PATCH net-next v5 3/7] taprio: calculate cycle_time when schedule is installed

2019-06-21 Thread Vedang Patel
cycle time for a particular schedule is calculated only when it is first installed. So, it makes sense to just calculate it once right after the 'cycle_time' parameter has been parsed and store it in cycle_time. Signed-off-by: Vedang Patel --- net/sched/sch_taprio.c | 29 +++-

[PATCH net-next v5 0/7] net/sched: Add txtime-assist support for taprio.

2019-06-21 Thread Vedang Patel
Changes in v5: - Commit message improved for the igb patch (patch #1). - Fixed typo in commit message for etf patch (patch #2). Changes in v4: - Remove inline directive from functions in foo.c. - Fix spacing in pkt_sched.h (for etf patch). Changes in v3: - Simplify implementation for taprio flags

[PATCH net-next v5 2/7] etf: Add skip_sock_check

2019-06-21 Thread Vedang Patel
Currently, etf expects a socket with SO_TXTIME option set for each packet it encounters. So, it will drop all other packets. But, in the future commits we are planning to add functionality where tstamp value will be set by another qdisc. Also, some packets which are generated from within the kernel

[PATCH net-next v5 1/7] igb: clear out skb->tstamp after reading the txtime

2019-06-21 Thread Vedang Patel
If a packet which is utilizing the launchtime feature (via SO_TXTIME socket option) also requests the hardware transmit timestamp, the hardware timestamp is not delivered to the userspace. This is because the value in skb->tstamp is mistaken as the software timestamp. Applications, like ptp4l, req

Re: [PATCH net-next 04/12] net: sched: add tcf_block_setup()

2019-06-21 Thread Jiri Pirko
Thu, Jun 20, 2019 at 09:49:09PM CEST, pa...@netfilter.org wrote: [...] > >+static LIST_HEAD(tcf_block_cb_list); I still don't like the global list. Have to go throught the code more carefully, but why you can't pass the priv/ctx from tc/netfilter. From tc it would be tcf_block as it is now, fro

Re: [PATCH bpf-next v7 1/9] bpf: implement getsockopt and setsockopt hooks

2019-06-21 Thread kbuild test robot
Hi Stanislav, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Stanislav-Fomichev/bpf-implement-getsockopt-and-setsockopt-hooks/20190621-064924 base: https://git.kernel.org/pub/scm/linux

Re: [PATCH net] tcp: refine memory limit test in tcp_fragment()

2019-06-21 Thread Christoph Paasch
> On Jun 21, 2019, at 6:11 AM, Eric Dumazet wrote: > > tcp_fragment() might be called for skbs in the write queue. > > Memory limits might have been exceeded because tcp_sendmsg() only > checks limits at full skb (64KB) boundaries. > > Therefore, we need to make sure tcp_fragment() wont pun

Re: [RFC bpf-next 0/7] Programming socket lookup with BPF

2019-06-21 Thread Paolo Abeni
Hi, On Fri, 2019-06-21 at 18:41 +0200, Florian Westphal wrote: > Eric Dumazet wrote: > > > AFAICS so far this would be enough: > > > > > > 1. remove the BUG_ON() in skb_orphan, letting it clear skb->sk instead > > > 2. in nf_queue_entry_get_refs(), if skb->sk and no destructor: > > >call nf_

Re: [RFC bpf-next 0/7] Programming socket lookup with BPF

2019-06-21 Thread Joe Stringer
On Fri, Jun 21, 2019 at 1:44 AM Jakub Sitnicki wrote: > > On Fri, Jun 21, 2019, 00:20 Joe Stringer wrote: >> >> On Wed, Jun 19, 2019 at 2:14 AM Jakub Sitnicki wrote: >> > >> > Hey Florian, >> > >> > Thanks for taking a look at it. >> > >> > On Tue, Jun 18, 2019 at 03:52 PM CEST, Florian Westphal

Re: [PATCH net] af_packet: Block execution of tasks waiting for transmit to complete in AF_PACKET

2019-06-21 Thread Neil Horman
On Thu, Jun 20, 2019 at 11:16:13AM -0400, Willem de Bruijn wrote: > On Thu, Jun 20, 2019 at 10:24 AM Neil Horman wrote: > > > > On Thu, Jun 20, 2019 at 09:41:30AM -0400, Willem de Bruijn wrote: > > > On Wed, Jun 19, 2019 at 4:26 PM Neil Horman wrote: > > > > > > > > When an application is run tha

Re: [RFC bpf-next 0/7] Programming socket lookup with BPF

2019-06-21 Thread Florian Westphal
Eric Dumazet wrote: > > AFAICS so far this would be enough: > > > > 1. remove the BUG_ON() in skb_orphan, letting it clear skb->sk instead > > 2. in nf_queue_entry_get_refs(), if skb->sk and no destructor: > >call nf_tproxy_assign_sock() so a reference gets taken. > > 3. change skb_steal_sock

Re: [PATCH net-next 08/12] net: cls_api: do not expose tcf_block to drivers

2019-06-21 Thread Jiri Pirko
Thu, Jun 20, 2019 at 09:49:13PM CEST, pa...@netfilter.org wrote: >Expose the block index which is sufficient to look up for the >tcf_block_cb object. This patch is not exposing block index. I guess this is a leftover.

Re: 6c409a3aee: kernel_selftests.bpf.test_verifier.fail

2019-06-21 Thread Alexei Starovoitov
On Fri, Jun 21, 2019 at 1:36 AM kernel test robot wrote: > # #340/p direct packet access: test22 (x += pkt_ptr, 3) OK > # #341/p direct packet access: test23 (x += pkt_ptr, 4) FAIL > # Unexpected success to load! > # verification time 17 usec > # stack depth 8 > # processed 18 insns (limit 100

Re: [PATCH v3 rdma-next 0/3] RDMA/qedr: Use the doorbell overflow recovery mechanism for RDMA

2019-06-21 Thread Doug Ledford
On Thu, 2019-06-13 at 11:38 +0300, Michal Kalderon wrote: > This patch series used the doorbell overflow recovery mechanism > introduced in > commit 36907cd5cd72 ("qed: Add doorbell overflow recovery mechanism") > for rdma ( RoCE and iWARP ) > > rdma-core pull request #493 > > Changes from V2: >

[PATCH net-next v7 11/11] selftests: pmtu: Make list_flush_ipv6_exception test more demanding

2019-06-21 Thread Stefano Brivio
Instead of just listing and flushing two cached exceptions, create a relatively big number of them, and count how many are listed. Single netlink dump messages contain approximately 25 entries each, and this way we can make sure the partial dump tracking mechanism is working properly. While at it,

[PATCH net-next v7 05/11] Revert "net/ipv6: Bail early if user only wants cloned entries"

2019-06-21 Thread Stefano Brivio
This reverts commit 08e814c9e8eb5a982cbd1e8f6bd255d97c51026f: as we are preparing to fix listing and dumping of IPv6 cached routes, we need to allow RTM_F_CLONED as a flag to match routes against while dumping them. Signed-off-by: Stefano Brivio Reviewed-by: David Ahern --- v7: No changes v6: N

[PATCH net-next v7 06/11] ipv6/route: Don't match on fc_nh_id if not set in ip6_route_del()

2019-06-21 Thread Stefano Brivio
If fc_nh_id isn't set, we shouldn't try to match against it. This actually matters just for the RTF_CACHE below (where this case is already handled): if iproute2 gets a route exception and tries to delete it, it won't reference it by fc_nh_id, even if a nexthop object might be associated to the ori

[PATCH net-next v7 08/11] ipv6: Dump route exceptions if requested

2019-06-21 Thread Stefano Brivio
Since commit 2b760fcf5cfb ("ipv6: hook up exception table to store dst cache"), route exceptions reside in a separate hash table, and won't be found by walking the FIB, so they won't be dumped to userspace on a RTM_GETROUTE message. This causes 'ip -6 route list cache' and 'ip -6 route flush cache

[PATCH net-next v7 02/11] ipv4/fib_frontend: Allow RTM_F_CLONED flag to be used for filtering

2019-06-21 Thread Stefano Brivio
This functionally reverts the check introduced by commit e8ba330ac0c5 ("rtnetlink: Update fib dumps for strict data checking") as modified by commit e4e92fb160d7 ("net/ipv4: Bail early if user only wants prefix entries"). As we are preparing to fix listing of IPv4 cached routes, we need to give us

[PATCH net-next v7 10/11] selftests: pmtu: Introduce list_flush_ipv4_exception test case

2019-06-21 Thread Stefano Brivio
This test checks that route exceptions can be successfully listed and flushed using ip -6 route {list,flush} cache. v7: No changes v6: - Merge this patch into series including fix, as it's also targeted for net-next - Drop left-over print of 'ip route list cache | wc -l' Signed-off-by: S

[PATCH net-next v7 09/11] ip6_fib: Don't discard nodes with valid routing information in fib6_locate_1()

2019-06-21 Thread Stefano Brivio
When we perform an inexact match on FIB nodes via fib6_locate_1(), longer prefixes will be preferred to shorter ones. However, it might happen that a node, with higher fn_bit value than some other, has no valid routing information. In this case, we'll pick that node, but it will be discarded by th

[PATCH net-next v7 07/11] ipv6/route: Change return code of rt6_dump_route() for partial node dumps

2019-06-21 Thread Stefano Brivio
In the next patch, we are going to add optional dump of exceptions to rt6_dump_route(). Change the return code of rt6_dump_route() to accomodate partial node dumps: we might dump multiple routes per node, and might be able to dump only a given number of them, so fib6_dump_node() will need to know

[PATCH net-next v7 04/11] ipv4: Dump route exceptions if requested

2019-06-21 Thread Stefano Brivio
Since commit 4895c771c7f0 ("ipv4: Add FIB nexthop exceptions."), cached exception routes are stored as a separate entity, so they are not dumped on a FIB dump, even if the RTM_F_CLONED flag is passed. This implies that the command 'ip route list cache' doesn't return any result anymore. If the RT

[PATCH net-next v7 03/11] ipv4/route: Allow NULL flowinfo in rt_fill_info()

2019-06-21 Thread Stefano Brivio
In the next patch, we're going to use rt_fill_info() to dump exception routes upon RTM_GETROUTE with NLM_F_ROOT, meaning userspace is requesting a dump and not a specific route selection, which in turn implies the input interface is not relevant. Update rt_fill_info() to handle a NULL flowinfo. v7

[PATCH net-next v7 00/11] Fix listing (IPv4, IPv6) and flushing (IPv6) of cached route exceptions

2019-06-21 Thread Stefano Brivio
For IPv6 cached routes, the commands 'ip -6 route list cache' and 'ip -6 route flush cache' don't work at all after route exceptions have been moved to a separate hash table in commit 2b760fcf5cfb ("ipv6: hook up exception table to store dst cache"). For IPv4 cached routes, the command 'ip route l

[PATCH net-next v7 01/11] fib_frontend, ip6_fib: Select routes or exceptions dump from RTM_F_CLONED

2019-06-21 Thread Stefano Brivio
The following patches add back the ability to dump IPv4 and IPv6 exception routes, and we need to allow selection of regular routes or exceptions. Use RTM_F_CLONED as filter to decide whether to dump routes or exceptions: iproute2 passes it in dump requests (except for IPv6 cache flush requests, t

Re: [PATCH] ionic: fix semicolon.cocci warnings

2019-06-21 Thread Shannon Nelson
e nod support") CC: Shannon Nelson Signed-off-by: kbuild test robot --- Thanks, I'll roll this into the next version of the patchset. sln url: https://github.com/0day-ci/linux/commits/Shannon-Nelson/ionic-Add-basic-framework-for-IONIC-Network-device-driver/20190621-110046 ion

Re: [PATCH] ionic: fix simple_open.cocci warnings

2019-06-21 Thread Shannon Nelson
sln --- url: https://github.com/0day-ci/linux/commits/Shannon-Nelson/ionic-Add-basic-framework-for-IONIC-Network-device-driver/20190621-110046 ionic_debugfs.c |8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) --- a/drivers/net/ethernet/pensando/ionic/ionic_debugfs.c ++

Re: [PATCH nf-next v5] netfilter: add support for matching IPv4 options

2019-06-21 Thread Pablo Neira Ayuso
On Thu, Jun 20, 2019 at 12:19:59PM -0400, Stephen Suryaputra wrote: > This is the kernel change for the overall changes with this description: > Add capability to have rules matching IPv4 options. This is developed > mainly to support dropping of IP packets with loose and/or strict source > route r

[PATCH bpf-next] libbpf: add xsk_ring_prod__free() function

2019-06-21 Thread Eelco Chaudron
When an AF_XDP application received X packets, it does not mean X frames can be stuffed into the producer ring. To make it easier for AF_XDP applications this API allows them to check how many frames can be added into the ring. Signed-off-by: Eelco Chaudron --- tools/lib/bpf/xsk.h | 6 ++ 1

Re: [PATCH net-next 10/12] net: flow_offload: add flow_block_cb API

2019-06-21 Thread Jiri Pirko
Thu, Jun 20, 2019 at 09:49:15PM CEST, pa...@netfilter.org wrote: [...] >diff --git a/include/net/flow_offload.h b/include/net/flow_offload.h >index 36127c1858a4..728ded7e4361 100644 >--- a/include/net/flow_offload.h >+++ b/include/net/flow_offload.h >@@ -232,4 +232,56 @@ static inline void flow_s

Re: [PATCH v4 0/3] net: fddi: skfp: Use PCI generic definitions instead of private duplicates

2019-06-21 Thread Puranjay Mohan
On Fri, Jun 21, 2019 at 08:44:12PM +0530, Puranjay Mohan wrote: > This patch series removes the private duplicates of PCI definitions in > favour of generic definitions defined in pci_regs.h. > > This driver only uses some of the generic PCI definitons, > which are included from pci_regs.h and thi

Re: [PATCH net-next] netfilter: ipv6: Fix build error without CONFIG_IPV6

2019-06-21 Thread Pablo Neira Ayuso
On Wed, Jun 12, 2019 at 04:47:15PM +0800, YueHaibing wrote: > If CONFIG_IPV6 is not set, building fails: > > net/bridge/netfilter/nf_conntrack_bridge.o: In function `nf_ct_bridge_pre': > nf_conntrack_bridge.c:(.text+0x41c): undefined symbol `nf_ct_frag6_gather' > net/bridge/netfilter/nf_conntrack_

Re: [PATCH net-next 00/12] netfilter: add hardware offload infrastructure

2019-06-21 Thread Jiri Pirko
Thu, Jun 20, 2019 at 09:49:05PM CEST, pa...@netfilter.org wrote: >Hi, > >This patchset adds support for Netfilter hardware offloads. > >This patchset reuses the existing block infrastructure, the >netdev_ops->ndo_setup_tc() interface, TC_SETUP_CLSFLOWER classifier and >the flow rule API. > >Patch #

Re: [PATCH nf-next] netfilter: bridge: Fix non-untagged fragment packet

2019-06-21 Thread Pablo Neira Ayuso
On Wed, Jun 19, 2019 at 10:35:07PM +0800, we...@ucloud.cn wrote: > From: wenxu > > ip netns exec ns1 ip a a dev eth0 10.0.0.7/24 > ip netns exec ns2 ip link a link eth0 name vlan type vlan id 200 > ip netns exec ns2 ip a a dev vlan 10.0.0.8/24 > > ip l add dev br0 type bridge vlan_filtering 1 >

[PATCH net-next 2/4] cxgb4: Add MPS TCAM refcounting for raw mac filters

2019-06-21 Thread Raju Rangoju
This patch adds TCAM reference counting support for raw mac filters. Signed-off-by: Raju Rangoju --- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 16 + drivers/net/ethernet/chelsio/cxgb4/cxgb4_mps.c | 46 ++ 2 files changed, 62 insertions(+) diff --git a/driv

[PATCH net-next 1/4] cxgb4: Re-work the logic for mps refcounting

2019-06-21 Thread Raju Rangoju
Remove existing mps refcounting code which was added only for encap filters and add necessary data structures/functions to support mps reference counting for all the mac filters. Also add wrapper functions for allocating and freeing encap mac filters. Signed-off-by: Raju Rangoju --- drivers/net/

[PATCH net-next 3/4] cxgb4: Add MPS TCAM refcounting for cxgb4 change mac

2019-06-21 Thread Raju Rangoju
This patch adds TCAM reference counting support for cxgb4 change mac path Signed-off-by: Raju Rangoju --- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 7 +++ drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 14 +++--- drivers/net/ethernet/chelsio/cxgb4/cxgb4_mps.c | 15 ++

[PATCH net-next 4/4] cxgb4: Add MPS refcounting for alloc/free mac filters

2019-06-21 Thread Raju Rangoju
This patch adds reference counting support for alloc/free mac filters Signed-off-by: Raju Rangoju --- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 6 +++ drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 12 +++-- drivers/net/ethernet/chelsio/cxgb4/cxgb4_mps.c | 72 +++

[PATCH net-next 0/4] cxgb4: Reference count MPS TCAM entries within a PF

2019-06-21 Thread Raju Rangoju
Firmware reference counts the MPS TCAM entries by PF and VF, but it does not do it for usage within a PF or VF. This patch adds the support to track MPS TCAM entries within a PF. Raju Rangoju (4): cxgb4: Re-work the logic for mps refcounting cxgb4: Add MPS TCAM refcounting for raw mac filters

Re: [RFC bpf-next 0/7] Programming socket lookup with BPF

2019-06-21 Thread Eric Dumazet
On 6/21/19 5:51 AM, Florian Westphal wrote: > Jakub Sitnicki wrote: >>> So, at least for this part I don't see a technical reason why this >>> has to grab a reference for listener socket. >> >> That's helpful, thanks! We rely on TPROXY, so I would like to help with >> that. Let me see if I can

Re: Stats for XDP actions

2019-06-21 Thread Toke Høiland-Jørgensen
David Ahern writes: > On 6/20/19 2:42 PM, Toke Høiland-Jørgensen wrote: I don't recall seeing any follow-up on this. Did you have a chance to formulate your ideas? :) >>> >>> Not yet. Almost done with the nexthop changes. Once that is out of the >>> way I can come back to this. >>

[PATCH net] tcp: refine memory limit test in tcp_fragment()

2019-06-21 Thread Eric Dumazet
tcp_fragment() might be called for skbs in the write queue. Memory limits might have been exceeded because tcp_sendmsg() only checks limits at full skb (64KB) boundaries. Therefore, we need to make sure tcp_fragment() wont punish applications that might have setup very low SO_SNDBUF values. Fixe

Re: [PATCH net-next 02/18] ionic: Add hardware init and device commands

2019-06-21 Thread kbuild test robot
Hi Shannon, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Shannon-Nelson/ionic-Add-basic-framework-for-IONIC-Network-device-driver/20190621-110046 config: arm-allyesconfig (attached as .config) compiler

Re: [RFC bpf-next 0/7] Programming socket lookup with BPF

2019-06-21 Thread Florian Westphal
Jakub Sitnicki wrote: > > So, at least for this part I don't see a technical reason why this > > has to grab a reference for listener socket. > > That's helpful, thanks! We rely on TPROXY, so I would like to help with > that. Let me see if I can get time to work on it. AFAICS so far this would b

Re: [PATCH v3 net-next 0/5] ipv6: avoid taking refcnt on dst during route lookup

2019-06-21 Thread Eric Dumazet
On Thu, Jun 20, 2019 at 8:50 PM David Ahern wrote: > > On 6/20/19 6:36 PM, Wei Wang wrote: > > From: Wei Wang > > > > Ipv6 route lookup code always grabs refcnt on the dst for the caller. > > But for certain cases, grabbing refcnt is not always necessary if the > > call path is rcu protected and

Re: bonded active-backup ethernet-wifi drops packets

2019-06-21 Thread Brian J. Murrell
On Tue, 2019-06-18 at 14:57 -0400, Brian J. Murrell wrote: > Hi. An update... I have another machine with the same ethernet-wifi bonded connection and it behaves perfectly but only when disconnected from the wired- ethernet and therefore on the bonded-wifi. The ping -f occasionally bursts out a

Re: [PATCH net-next 11/18] ionic: Add Rx filter and rx_mode nod support

2019-06-21 Thread kbuild test robot
Hi Shannon, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Shannon-Nelson/ionic-Add-basic-framework-for-IONIC-Network-device-driver/20190621-110046 If you fix the issue, kindly add following tag

[PATCH] ionic: fix semicolon.cocci warnings

2019-06-21 Thread kbuild test robot
by: kbuild test robot --- url: https://github.com/0day-ci/linux/commits/Shannon-Nelson/ionic-Add-basic-framework-for-IONIC-Network-device-driver/20190621-110046 ionic_lif.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/ethernet/pensando/ionic/ionic_lif.c +++ b/d

Re: [PATCH iproute2-next v2 1/2] ipaddress: correctly print a VF hw address in the IPoIB case

2019-06-21 Thread Denis Kirjanov
On 6/20/19, Denis Kirjanov wrote: > Current code assumes that we print Etheret mac and > that doesn't work in IPoIB case with SRIOV-enabled hardware > > Before: > 11: ib1: mtu 2044 qdisc pfifo_fast > state UP mode DEFAULT group default qlen 256 > link/infiniband > 80:00:00:66:fe:80:00:00:

Re: [PATCH v2 bpf-next 00/11] BTF-defined BPF map definitions

2019-06-21 Thread Lorenz Bauer
On Fri, 21 Jun 2019 at 05:20, Andrii Nakryiko wrote: > > On Thu, Jun 20, 2019 at 7:49 AM Lorenz Bauer wrote: > > > > On Tue, 18 Jun 2019 at 22:37, Andrii Nakryiko > > wrote: > > > > > > I would just drop the object-scope pinning. We avoided using it and I'm > > > > not > > > > aware if anyone

Re: [PATCH net-next 02/18] ionic: Add hardware init and device commands

2019-06-21 Thread kbuild test robot
Hi Shannon, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Shannon-Nelson/ionic-Add-basic-framework-for-IONIC-Network-device-driver/20190621-110046 config: i386-allmodconfig (attached as .config) compiler

[PATCH] ionic: fix simple_open.cocci warnings

2019-06-21 Thread kbuild test robot
ice-driver/20190621-110046 ionic_debugfs.c |8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) --- a/drivers/net/ethernet/pensando/ionic/ionic_debugfs.c +++ b/drivers/net/ethernet/pensando/ionic/ionic_debugfs.c @@ -9,12 +9,6 @@ #ifdef CONFIG_DEBUG_FS -static int blob_open(struct in

[PATCH iproute2] ip monitor: display interfaces from all groups

2019-06-21 Thread Nicolas Dichtel
Only interface from group 0 were displayed. ip monitor calls ipaddr_reset_filter() and there is no reason to not reset the filter group in this function. Fixes: c4fdf75d3def ("ip link: fix display of interface groups") Signed-off-by: Nicolas Dichtel --- ip/ipaddress.c | 2 +- 1 file changed, 1

Re: Poor Loopback Interface Performance

2019-06-21 Thread Li Feng
Correct CC netdev@vger.kernel.org. Thanks, Feng Li Li Feng 于2019年6月21日周五 下午4:07写道: > > Hi, SPDK & Netdev, > > When running fio with SPDK iscsi target, > we find the localhost interface has a bad performance, > contrast to access from the remote node. > After upgrade the kernel to 5.1, this issu

Re: [PATCH net] ipv6: fix neighbour resolution with raw socket

2019-06-21 Thread Nicolas Dichtel
Le 20/06/2019 à 18:36, David Ahern a écrit : [snip] > You don't have a fixes tag, but this should go to stable releases. Yeah, I was not able to point a specific commit. The bug is reproducible with a 4.4 from ubuntu-16.04, with a 3.10 from redhat-7 but not with a vanilla 3.10.20.

Re: [RFC PATCH net-next 1/1] tc-testing: Restore original behaviour for namespaces in tdc

2019-06-21 Thread Nicolas Dichtel
Le 21/06/2019 à 02:45, Lucas Bates a écrit : [snip] > Very true. I think I just put that one in quickly and meant to come > back to it later, but either way it's a bit too vague. I understand. As a developer, we tend to focus on the technical part, but we need to remember to look at the big picture