Hi Shannon, I love your patch! Yet something to improve:
[auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Shannon-Nelson/ionic-Add-basic-framework-for-IONIC-Network-device-driver/20190621-110046 config: i386-allmodconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 If you fix the issue, kindly add following tag Reported-by: kbuild test robot <l...@intel.com> All errors (new ones prefixed by >>): In file included from drivers/net/ethernet/pensando/ionic/ionic_dev.h:11:0, from drivers/net/ethernet/pensando/ionic/ionic.h:8, from drivers/net/ethernet/pensando/ionic/ionic_main.c:9: drivers/net/ethernet/pensando/ionic/ionic_regs.h: In function 'ionic_dbell_ring': >> drivers/net/ethernet/pensando/ionic/ionic_regs.h:130:2: error: implicit >> declaration of function 'writeq'; did you mean 'writel'? >> [-Werror=implicit-function-declaration] writeq(val, &db_page[qtype]); ^~~~~~ writel cc1: some warnings being treated as errors coccinelle warnings: (new ones prefixed by >>) >> drivers/net/ethernet/pensando/ionic/ionic_debugfs.c:12:11-20: WARNING >> opportunity for simple_open, see also structure on line 56 Please review and possibly fold the followup patch. vim +130 drivers/net/ethernet/pensando/ionic/ionic_regs.h 127 128 static inline void ionic_dbell_ring(u64 __iomem *db_page, int qtype, u64 val) 129 { > 130 writeq(val, &db_page[qtype]); 131 } 132 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
