Re: [PATCH net-next 00/24] sctp: support SCTP_FUTURE/CURRENT/ALL_ASSOC

2019-01-29 Thread Neil Horman
On Mon, Jan 28, 2019 at 03:08:22PM +0800, Xin Long wrote: > This patchset adds the support for 3 assoc_id constants: SCTP_FUTURE_ASSOC > SCTP_CURRENT_ASSOC, SCTP_ALL_ASSOC, described in rfc6458#section-7.2: > >All socket options set on a one-to-one style listening socket also >apply to all

Re: [PATCH net] net: b44: replace dev_kfree_skb_xxx by dev_consume_skb_xxx for drop profiles

2019-01-29 Thread Sergei Shtylyov
Hello! On 29.01.2019 18:04, Yang Wei wrote: From: Yang Wei The skb should be freed by dev_consume_skb_any() in b44_start_xmit() when bounce_skb is used. The skb is be replaced by bounce_skb, so the s/be/being/? original skb should be consumed(not drop). dev_consume_skb_irq() should be

Re: [PATCH net-next v2 00/12] net: dsa: management mode for bcm_sf2

2019-01-29 Thread Ido Schimmel
On Tue, Jan 29, 2019 at 04:55:36PM -0800, Florian Fainelli wrote: > Hi all, > > This patch series does a number of things in order to enable management > mode for bcm_sf2 (which could be easily extended to b53 with proper > testing later on). In order to get there, there were several use cases > t

Re: [PATCH net-next 02/24] sctp: use SCTP_FUTURE_ASSOC for SCTP_PEER_ADDR_PARAMS sockopt

2019-01-29 Thread Neil Horman
On Wed, Jan 30, 2019 at 03:03:01PM +0800, Xin Long wrote: > On Wed, Jan 30, 2019 at 5:25 AM Neil Horman wrote: > > > > On Mon, Jan 28, 2019 at 03:08:24PM +0800, Xin Long wrote: > > > Check with SCTP_FUTURE_ASSOC instead in > > > sctp_/setgetsockopt_peer_addr_params, it's compatible with 0. > > > >

Re: [PATCH net-next v2 01/12] net: bridge: multicast: Propagate br_mc_disabled_update() return

2019-01-29 Thread Ido Schimmel
On Tue, Jan 29, 2019 at 04:55:37PM -0800, Florian Fainelli wrote: > Some Ethernet switches might not be able to support disabling multicast > flooding globally when e.g: several bridges span the same physical > device, propagate the return value of br_mc_disabled_update() such that > this propagate

[PATCH net-next] strparser: Return if socket does not have required number of bytes

2019-01-29 Thread Vakul Garg
Function strp_data_ready() should peek the associated socket to check whether it has the required number of bytes available before queueing work or initiating socket read via strp_read_sock(). This saves cpu cycles because strp_read_sock() is called only when required amount of data is available.

Re: [PATCH] ipmr: ip6mr: Create new sockopt to clear mfc cache only

2019-01-29 Thread kbuild test robot
Hi Callum, Thank you for the patch! Yet something to improve: [auto build test ERROR on net/master] [also build test ERROR on v5.0-rc4 next-20190129] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

Re: [PATCH net v3] net: l2tp: fix reading optional fields of L2TPv3

2019-01-29 Thread Jacob Wen
Thanks for the detailed review. On 1/30/19 6:37 AM, Guillaume Nault wrote: On Tue, Jan 29, 2019 at 02:18:13PM +0800, Jacob Wen wrote: Use pskb_may_pull() to make sure the optional fields are in skb linear parts, so we can safely read them in l2tp_recv_common. Looks fine to me. Just a few nitp

Re: [PATCH net-next 02/24] sctp: use SCTP_FUTURE_ASSOC for SCTP_PEER_ADDR_PARAMS sockopt

2019-01-29 Thread Xin Long
On Wed, Jan 30, 2019 at 5:25 AM Neil Horman wrote: > > On Mon, Jan 28, 2019 at 03:08:24PM +0800, Xin Long wrote: > > Check with SCTP_FUTURE_ASSOC instead in > > sctp_/setgetsockopt_peer_addr_params, it's compatible with 0. > > > > Signed-off-by: Xin Long > > --- > > net/sctp/socket.c | 18 ++

[PATCH iproute2-next v2] ss: add AF_XDP support

2019-01-29 Thread bjorn . topel
From: Björn Töpel AF_XDP is an address family that is optimized for high performance packet processing. This patch adds AF_XDP support to ss(8) so that sockets can be queried and monitored. Example: $ sudo ss --xdp -e -p -m Recv-Q Send-Q Local Address:Port Peer Addres

[PATCH net v4] l2tp: fix reading optional fields of L2TPv3

2019-01-29 Thread Jacob Wen
Use pskb_may_pull() to make sure the optional fields are in skb linear parts, so we can safely read them later. It's easy to reproduce the issue with a net driver that supports paged skb data. Just create a L2TPv3 over IP tunnel and then generates some network traffic. Once reproduced, rx err in /

[Patch net] xfrm: destroy xfrm_state synchronously on net exit path

2019-01-29 Thread Cong Wang
xfrm_state_put() moves struct xfrm_state to the GC list and schedules the GC work to clean it up. On net exit call path, xfrm_state_flush() is called to clean up and xfrm_flush_gc() is called to wait for the GC work to complete before exit. However, this doesn't work because one of the ->destructo

Re: [PATCH net 0/4] various compat ioctl fixes

2019-01-29 Thread David Miller
From: Johannes Berg Date: Mon, 28 Jan 2019 22:32:30 +0100 > Al, care to speak up about this here? I'll give Al one day to respond. I'll apply this series if he agrees or fails to give feedback.

Re: [PATCH net] net: tls: Save iv in tls_rec for async crypto requests

2019-01-29 Thread David Miller
From: Dave Watson Date: Tue, 29 Jan 2019 17:21:41 + > Can we get a net->net-next merge when convenient? This has now been done.

Re: [PATCH net-next v8 0/8] devlink: Add configuration parameters support for devlink_port

2019-01-29 Thread David Miller
From: Vasundhara Volam Date: Mon, 28 Jan 2019 18:00:19 +0530 > This patchset adds support for configuration parameters setting through > devlink_port. Each device registers supported configuration parameters > table. > > The user can retrieve data on these parameters by > "devlink port param sh

Re: [PATCH iproute2-next 2/2] ss: add AF_XDP support

2019-01-29 Thread Björn Töpel
Den ons 30 jan. 2019 kl 03:39 skrev David Ahern : > [...] > > AF_XDP is not currently defined for a number of distributions. Add a > definition to include/utils.h similar to what is done for MPLS. > > Also, please add example output to the commit log. Ok, I'll address AF_XDP/AF_MAX and fix the com

Re: [PATCH] ipmr: ip6mr: Create new sockopt to clear mfc cache only

2019-01-29 Thread kbuild test robot
Hi Callum, Thank you for the patch! Yet something to improve: [auto build test ERROR on net/master] [also build test ERROR on v5.0-rc4 next-20190129] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

Re: [PATCH iproute2-next] Introduce ip-brctl shell script

2019-01-29 Thread David Ahern
On 1/18/19 10:00 AM, Stefano Brivio wrote: > This script wraps 'ip' and 'bridge' tools to provide a drop-in replacement > of the standalone 'brctl' utility. > > It's bug-to-bug compatible with brctl as of bridge-utils version 1.6, > has no dependencies other than a POSIX shell, and it's less than

Re: [RFC 03/14] net: hstats: add basic/core functionality

2019-01-29 Thread David Ahern
On 1/28/19 4:44 PM, Jakub Kicinski wrote: > @@ -4946,6 +4964,9 @@ static size_t if_nlmsg_stats_size(const struct > net_device *dev, > rcu_read_unlock(); > } > > + if (stats_attr_valid(filter_mask, IFLA_STATS_LINK_HSTATS, 0)) filter_mask is populated by RTEXT_FILTER_ from

Re: [PATCH bpf-next 0/4] bpf: fixes for lockdep and deadlock

2019-01-29 Thread Alexei Starovoitov
On Tue, Jan 29, 2019 at 8:06 PM Alexei Starovoitov wrote: > > In addition to preempt_disable patch for socket filters > https://patchwork.ozlabs.org/patch/1032437/ > the first three patches fix various lockdep false positives. > Last patch fixes potential deadlock in stackmap access from > tracing

[PATCH bpf-next 3/4] bpf: fix lockdep false positive in bpf_prog_register

2019-01-29 Thread Alexei Starovoitov
Lockdep warns about false positive: [ 13.007000] WARNING: possible circular locking dependency detected [ 13.007587] 5.0.0-rc3-00018-g2fa53f892422-dirty #477 Not tainted [ 13.008124] -- [ 13.008624] test_progs/246 is trying to acquire lock

[PATCH bpf-next 0/4] bpf: fixes for lockdep and deadlock

2019-01-29 Thread Alexei Starovoitov
In addition to preempt_disable patch for socket filters https://patchwork.ozlabs.org/patch/1032437/ the first three patches fix various lockdep false positives. Last patch fixes potential deadlock in stackmap access from tracing bpf prog and from syscall. Alexei Starovoitov (3): bpf: fix lockdep

[PATCH bpf-next 4/4] bpf: Fix syscall's stackmap lookup potential deadlock

2019-01-29 Thread Alexei Starovoitov
From: Martin KaFai Lau The map_lookup_elem used to not acquiring spinlock in order to optimize the reader. It was true until commit 557c0c6e7df8 ("bpf: convert stackmap to pre-allocation") The syscall's map_lookup_elem(stackmap) calls bpf_stackmap_copy(). bpf_stackmap_copy() may find the elem n

[PATCH bpf-next 2/4] bpf: fix lockdep false positive in stackmap

2019-01-29 Thread Alexei Starovoitov
Lockdep warns about false positive: [ 11.211460] [ cut here ] [ 11.211936] DEBUG_LOCKS_WARN_ON(depth <= 0) [ 11.211985] WARNING: CPU: 0 PID: 141 at ../kernel/locking/lockdep.c:3592 lock_release+0x1ad/0x280 [ 11.213134] Modules linked in: [ 11.213413] CPU: 0 PID: 1

[PATCH bpf-next 1/4] bpf: fix lockdep false positive in percpu_freelist

2019-01-29 Thread Alexei Starovoitov
Lockdep warns about false positive: [ 12.492084] e6b28347 (&head->lock){+...}, at: pcpu_freelist_push+0x2a/0x40 [ 12.492696] but this lock was taken by another, HARDIRQ-safe lock in the past: [ 12.493275] (&rq->lock){-.-.} [ 12.493276] [ 12.493276] [ 12.493276] and interrupts

Re: [PATCH net-next] cxgb4: cxgb4_tc_u32: use struct_size() in kvzalloc()

2019-01-29 Thread Gustavo A. R. Silva
On 1/29/19 12:57 PM, David Miller wrote: >> >> Signed-off-by: Gustavo A. R. Silva > > Applied, thanks. > Thanks, Dave. -- Gustavo

Re: [PATCHv4 2/3] net: dsa: mt7530: support the 7530 switch on the Mediatek MT7621 SoC

2019-01-29 Thread Sean Wang
On Tue, Jan 29, 2019 at 7:39 PM Florian Fainelli wrote: > > > > On 1/29/19 5:24 PM, g...@kernel.org wrote: > > From: Greg Ungerer > > > > The MediaTek MT7621 SoC device contains a 7530 switch, and the existing > > linux kernel 7530 DSA switch driver can be used with it. > > > > The bulk of the ch

Re: [PATCHv4 3/3] dt-bindings: net: dsa: add new MT7530 binding to support MT7621

2019-01-29 Thread Sean Wang
On Tue, Jan 29, 2019 at 7:40 PM Florian Fainelli wrote: > > > > On 1/29/19 5:24 PM, g...@kernel.org wrote: > > From: Greg Ungerer > > > > Add devicetree binding to support the compatible mt7530 switch as used > > in the MediaTek MT7621 SoC. > > > > Signed-off-by: Greg Ungerer > > Reviewed-by: An

Re: [PATCHv4 1/3] net: ethernet: mediatek: support MT7621 SoC ethernet hardware

2019-01-29 Thread Sean Wang
On Tue, Jan 29, 2019 at 7:40 PM Florian Fainelli wrote: > > > > On 1/29/19 5:24 PM, g...@kernel.org wrote: > > From: Bjørn Mork > > > > The Mediatek MT7621 SoC contains the same ethernet hardware module as > > used on a number of other MediaTek SoC parts. There are some minor > > differences to d

[PATCH] tun: move the call to tun_set_real_num_queues

2019-01-29 Thread George Amanakis
Call tun_set_real_num_queues() after the increment of tun->numqueues since the former depends on it. Otherwise, the number of queues is not correctly accounted for, which results to warnings similar to: "vnet0 selects TX queue 11, but real number of TX queues is 11". Fixes: 0b7959b62573 ("tun: pub

[PATCH] tun: move the call to tun_set_real_num_queues

2019-01-29 Thread George Amanakis
Call tun_set_real_num_queues() after the increment of tun->numqueues since the former depends on it. Otherwise, the number of queues is not correctly accounted for, which results to warnings similar to: "vnet0 selects TX queue 11, but real number of TX queues is 11". Fixes: 0b7959b62573 ("tun: pub

Re: [PATCHv4 3/3] dt-bindings: net: dsa: add new MT7530 binding to support MT7621

2019-01-29 Thread Florian Fainelli
On 1/29/19 5:24 PM, g...@kernel.org wrote: > From: Greg Ungerer > > Add devicetree binding to support the compatible mt7530 switch as used > in the MediaTek MT7621 SoC. > > Signed-off-by: Greg Ungerer > Reviewed-by: Andrew Lunn Reviewed-by: Florian Fainelli -- Florian

Re: [PATCHv4 1/3] net: ethernet: mediatek: support MT7621 SoC ethernet hardware

2019-01-29 Thread Florian Fainelli
On 1/29/19 5:24 PM, g...@kernel.org wrote: > From: Bjørn Mork > > The Mediatek MT7621 SoC contains the same ethernet hardware module as > used on a number of other MediaTek SoC parts. There are some minor > differences to deal with but we can use the same driver to support > them all. > > Thi

Re: [PATCHv4 2/3] net: dsa: mt7530: support the 7530 switch on the Mediatek MT7621 SoC

2019-01-29 Thread Florian Fainelli
On 1/29/19 5:24 PM, g...@kernel.org wrote: > From: Greg Ungerer > > The MediaTek MT7621 SoC device contains a 7530 switch, and the existing > linux kernel 7530 DSA switch driver can be used with it. > > The bulk of the changes required stem from the 7621 having different > regulator and pad s

Re: [PATCH bpf-next v3 1/4] bpf: add plumbing for BPF_LWT_ENCAP_IP in bpf_lwt_push_encap

2019-01-29 Thread David Ahern
On 1/28/19 6:12 PM, Peter Oskolkov wrote > @@ -2583,7 +2594,15 @@ enum bpf_ret_code { > BPF_DROP = 2, > /* 3-6 reserved */ > BPF_REDIRECT = 7, > - /* >127 are reserved for prog type specific return codes */ > + /* >127 are reserved for prog type specific return codes. > +

Re: [PATCH bpf 0/2] bpf: btf: allow typedef func_proto

2019-01-29 Thread Alexei Starovoitov
On Tue, Jan 29, 2019 at 04:38:16PM -0800, Yonghong Song wrote: > The current btf implementation disallows the typedef of > a func_proto type. This actually is allowed per C standard. > This patch fixed btf verification to permit such types. > Patch #1 fixed the kernel side and Patch #2 fixed > the

[PATCH][RESEND] rtlwifi: remove set but not used variable 'cmd_seq'

2019-01-29 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/wireless/realtek/rtlwifi/base.c: In function 'rtl_c2h_content_parsing': drivers/net/wireless/realtek/rtlwifi/base.c:2313:13: warning: variable 'cmd_seq' set but not used [-Wunused-but-set-variable] Signed-off-by: YueHaibing Acked-by: P

[PATCH][RESEND] ath10k: snoc: remove set but not used variable 'ar_snoc'

2019-01-29 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/wireless/ath/ath10k/snoc.c: In function 'ath10k_snoc_tx_pipe_cleanup': drivers/net/wireless/ath/ath10k/snoc.c:681:22: warning: variable 'ar_snoc' set but not used [-Wunused-but-set-variable] Signed-off-by: YueHaibing Reviewed-by: Brian

Re: BUG: vnet0 selects TX queue 11, but real number of TX queues is 11

2019-01-29 Thread Stanislav Fomichev
On Tue, Jan 29, 2019 at 6:16 PM George Amanakis wrote: > > Since 4.20.4 when running a KVM with vhost_net I am seeing in dmesg: > vnet0 selects TX queue 11, but real number of TX queues is 11 > > The corresponding part in the xml definition of the virtual machine is: > ---8<--- > > >

[PATCH] Revert "ethtool: change to new sane powerpc64 kernel headers"

2019-01-29 Thread Maciej Żenczykowski
From: Maciej Żenczykowski This reverts commit 4df55c81996dfb1dbe98c93ee62d8067ed5073a9. It turns out this is not needed due to: commit c0a2c04b3cbf6d399a2551654401957ddb529a50 internal.h: change to new sane kernel headers on 64-bit archs which I apparently entirely forgot about while try

Re: ethtool - manual changes in ethtool-copy.h

2019-01-29 Thread Maciej Żenczykowski
Eh, I think this patch can simply be reverted. This is a dupe. ethtool-copy.h is only included from internal.h which already includes: ... #ifndef ETHTOOL_INTERNAL_H__ #define ETHTOOL_INTERNAL_H__ /* Some platforms (eg. ppc64) need __SANE_USERSPACE_TYPES__ before * to select 'int-ll64.h' and a

Re: [PATCH iproute2-next 2/2] ss: add AF_XDP support

2019-01-29 Thread David Ahern
On 1/25/19 12:18 AM, bjorn.to...@gmail.com wrote: > From: Björn Töpel > > AF_XDP is an address family that is optimized for high performance > packet processing. > > This patch adds AF_XDP support to ss(8) so that sockets can be queried > and monitored. > > Signed-off-by: Björn Töpel > --- >

Re: [PATCH iproute2-next v2] netns: add subcommand to attach an existing network namespace

2019-01-29 Thread David Ahern
On 1/29/19 8:01 AM, Matteo Croce wrote: > ip tracks namespaces with dummy files in /var/run/netns/, but can't see > namespaces created with other tools. > Creating the dummy file and bind mounting the correct procfs entry will > make ip aware of that namespace. > Add an ip netns subcommand to autom

Re: bpf memory model. Was: [PATCH v4 bpf-next 1/9] bpf: introduce bpf_spin_lock

2019-01-29 Thread Alexei Starovoitov
On Tue, Jan 29, 2019 at 10:16:54AM +0100, Peter Zijlstra wrote: > On Mon, Jan 28, 2019 at 01:56:24PM -0800, Alexei Starovoitov wrote: > > On Mon, Jan 28, 2019 at 10:24:08AM +0100, Peter Zijlstra wrote: > > > > Ah, but the loop won't be in the BPF program itself. The BPF program > > > would only ha

[PATCH] ipmr: ip6mr: Create new sockopt to clear mfc cache only

2019-01-29 Thread Callum Sinclair
Currently the only way to clear the mfc cache was to delete the entries one by one using the MRT_DEL_MFC socket option or to destroy and recreate the socket. Create a new socket option which will clear the multicast forwarding cache on the socket without destroying the socket. Signed-off-by: Call

[PATCH] ipmr: ip6mr: Create new sockopt to clear mfc cache only

2019-01-29 Thread Callum Sinclair
Created a way to clear the multicast forwarding cache on a socket without having to either remove the entries manually using the delete entry socket option or destroy and recreate the multicast socket. Callum Sinclair (1): ipmr: ip6mr: Create new sockopt to clear mfc cache only include/uapi/li

Re: [PATCH v4 bpf-next 1/9] bpf: introduce bpf_spin_lock

2019-01-29 Thread Alexei Starovoitov
On Tue, Jan 29, 2019 at 09:59:03AM +0100, Peter Zijlstra wrote: > On Mon, Jan 28, 2019 at 01:37:12PM -0800, Alexei Starovoitov wrote: > > On Mon, Jan 28, 2019 at 09:43:10AM +0100, Peter Zijlstra wrote: > > > > Isn't that still broken? AFAIU networking progs can happen in task > > > context (TX) an

Re: [RFC PATCH 0/3] RV64G eBPF JIT

2019-01-29 Thread Palmer Dabbelt
On Tue, 15 Jan 2019 00:35:15 PST (-0800), bjorn.to...@gmail.com wrote: Hi! I've been hacking on a RV64G eBPF JIT compiler, and would like some feedback. Codewise, it needs some refactoring. Currently there's a bit too much copy-and-paste going on, and I know some places where I could optimize t

Re: ethtool - manual changes in ethtool-copy.h

2019-01-29 Thread Maciej Żenczykowski
On Tue, Jan 29, 2019 at 1:00 PM John W. Linville wrote: > > On Tue, Jan 29, 2019 at 09:28:42PM +0100, Michal Kubecek wrote: > > Hello, > > > > I'm sorry I didn't notice earlier but ethtool commit 4df55c81996d > > ("ethtool: change to new sane powerpc64 kernel headers") adds changes to > > ethtool-

Re: [RFC net-next 1/4] net: Reserve protocol identifiers for EnOcean

2019-01-29 Thread Andreas Färber
Hi Alex, Am 29.01.19 um 13:57 schrieb Alexander Aring: > On Tue, Jan 29, 2019 at 06:01:27AM +0100, Andreas Färber wrote: >> EnOcean wireless technology is based on ASK (ERP1) and FSK (ERP2) modulations >> for sub-GHz and on IEEE 802.15.4 for 2.4 GHz. >> > > I am not sure what you try to do here.

Re: [PATCH net] vhost: fix OOB in get_rx_bufs()

2019-01-29 Thread Michael S. Tsirkin
On Tue, Jan 29, 2019 at 03:38:10PM -0800, David Miller wrote: > From: David Miller > Date: Tue, 29 Jan 2019 15:10:26 -0800 (PST) > > > Yeah the CVE pushed my hand a little bit, and I knew I was going to > > send Linus a pull request today because David Watson needs some TLS > > changes in net-nex

Re: [PATCH] rtlwifi: remove set but not used variable 'cmd_seq'

2019-01-29 Thread Pkshih
On Tue, 2019-01-29 at 14:03 +0800, YueHaibing wrote: > +cc netdev@vger.kernel.org > > On 2019/1/29 13:57, YueHaibing wrote: > > ping... > >  > > On 2018/9/11 20:12, YueHaibing wrote: > >> Fixes gcc '-Wunused-but-set-variable' warning: > >> > >> drivers/net/wireless/realtek/rtlwifi/base.c: In funct

Re: [PATCH] ath10k: snoc: remove set but not used variable 'ar_snoc'

2019-01-29 Thread YueHaibing
On 2019/1/30 2:12, Brian Norris wrote: > On Mon, Jan 28, 2019 at 9:53 PM YueHaibing wrote: >> >> ping... > > For some reason, your patch shows up as Deferred in patchwork: > > https://patchwork.kernel.org/patch/10589789/ > > So the maintainers have accidentally (?) ignored it. I'm not what th

[PATCHv4 1/3] net: ethernet: mediatek: support MT7621 SoC ethernet hardware

2019-01-29 Thread gerg
From: Bjørn Mork The Mediatek MT7621 SoC contains the same ethernet hardware module as used on a number of other MediaTek SoC parts. There are some minor differences to deal with but we can use the same driver to support them all. This patch is based on work by Bjørn Mork , and his original patc

[PATCHv4 2/3] net: dsa: mt7530: support the 7530 switch on the Mediatek MT7621 SoC

2019-01-29 Thread gerg
From: Greg Ungerer The MediaTek MT7621 SoC device contains a 7530 switch, and the existing linux kernel 7530 DSA switch driver can be used with it. The bulk of the changes required stem from the 7621 having different regulator and pad setup. The existing setup of these in the 7530 driver appears

[PATCHv4 3/3] dt-bindings: net: dsa: add new MT7530 binding to support MT7621

2019-01-29 Thread gerg
From: Greg Ungerer Add devicetree binding to support the compatible mt7530 switch as used in the MediaTek MT7621 SoC. Signed-off-by: Greg Ungerer Reviewed-by: Andrew Lunn --- Documentation/devicetree/bindings/net/dsa/mt7530.txt | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) v1: i

Re: [GIT] Networking

2019-01-29 Thread pr-tracker-bot
The pull request you sent on Tue, 29 Jan 2019 12:55:00 -0800 (PST): > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net master has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/62967898789dc1f09a06e59fa85ae2c5ca4dc2da Thank you! -- Deet-doot-dot, I am a bot. http

[PATCHv4 0/3]: net: dsa: mt7530: support MT7530 in the MT7621 SoC

2019-01-29 Thread gerg
This is the fourth version of a patch series supporting the MT7530 switch as used in the MediaTek MT7621 SoC. Unlike the MediaTek MT7623 the MT7621 is built around a dual core MIPS CPU architecture. But inside it uses basically the same 7530 switch. This series resolves all issues I had with pre

[PATCH net-next v2 11/12] net: dsa: b53: Add support for toggling IGMP snooping

2019-01-29 Thread Florian Fainelli
Add the required configuration knobs to honor the turning off of IGMP snooping (typically through the bridge interface) which means that when IGMP snooping is off, we must be flooding mutlicast since we do not get any notifications about IGMP join/leave through the network stack running on the brid

[PATCH net-next v2 10/12] net: dsa: Wire up multicast IGMP snooping attribute notification

2019-01-29 Thread Florian Fainelli
The bridge can at runtime be configured with or without IGMP snooping enabled but we were not processing the switchdev attribute that notifies about that toggle, do this now. Signed-off-by: Florian Fainelli --- include/net/dsa.h | 2 ++ net/dsa/dsa_priv.h | 11 +++ net/dsa/port.c |

[PATCH net-next v2 12/12] net: dsa: bcm_sf2: Enable management mode

2019-01-29 Thread Florian Fainelli
Now that we have all the necessary plumbing in place to get notified when a multicast MAC address must be programmed, configure the switch to oeprate in managed mode and let the network stack learn about management traffic. Signed-off-by: Florian Fainelli --- drivers/net/dsa/b53/b53_common.c | 3

[PATCH net-next v2 09/12] net: dsa: Make VLAN filtering use DSA notifiers

2019-01-29 Thread Florian Fainelli
In preparation for allowing for global checks that would apply to the entire switch and not just on a per-port basis, make the VLAN filtering attribute follow other switchdev attributes/objects and make it use the DSA notifier infrastructure. Signed-off-by: Florian Fainelli --- net/dsa/dsa_priv.

[PATCH net-next v2 06/12] net: dsa: b53: Add support for MDB

2019-01-29 Thread Florian Fainelli
In preparation for supporting IGMP snooping with or without the use of a bridge, add support within b53_common.c to program the ARL entries for multicast operations. The key difference is that a multicast ARL entry is comprised of a bitmask of enabled ports, instead of a port number. Signed-off-by

[PATCH net-next v2 04/12] net: systemport: Fix reception of BPDUs

2019-01-29 Thread Florian Fainelli
SYSTEMPORT has its RXCHK parser block that attempts to validate the packet structures, unfortunately setting the L2 header check bit will cause Bridge PDUs (BPDUs) to be incorrectly rejected because they look like LLC/SNAP packets with a non-IPv4 or non-IPv6 Ethernet Type. Fixes: 4e8aedfe78c7 ("ne

[PATCH net-next v2 03/12] net: dsa: b53: Properly account for VLAN filtering

2019-01-29 Thread Florian Fainelli
VLAN filtering can be built into the kernel, and also dynamically turned on/off through the bridge master device. Allow re-configuring the switch appropriately to account for that by deciding whether VLAN table (v_table) misses should lead to a drop or forward. Fixes: a2482d2ce349 ("net: dsa: b53:

[PATCH net-next v2 07/12] net: dsa: Add ability to program multicast filter for CPU port

2019-01-29 Thread Florian Fainelli
When the switch ports operate as individual network devices, the switch driver might have configured the switch to flood multicast all the way to the CPU port. This is really undesireable as it can lead to receiving a lot of unwanted traffic that the network stack needs to filter in software. For

[PATCH net-next v2 05/12] net: dsa: b53: Define registers for IGMP snooping

2019-01-29 Thread Florian Fainelli
Define all necessary registers in order to implement IGMP snooping later on, which are mostly comprised of the high-level protocol register control definitions. Signed-off-by: Florian Fainelli --- drivers/net/dsa/b53/b53_regs.h | 22 ++ 1 file changed, 22 insertions(+) diff

[PATCH net-next v2 08/12] net: dsa: Add ndo_vlan_rx_{add,kill}_vid implementation

2019-01-29 Thread Florian Fainelli
In order to properly support VLAN filtering being enabled/disabled on a bridge, while having other ports being non bridge port members, we need to support the ndo_vlan_rx_{add,kill}_vid callbacks in order to make sure the non-bridge ports can continue receiving VLAN tags, even when the switch is gl

[PATCH net-next v2 00/12] net: dsa: management mode for bcm_sf2

2019-01-29 Thread Florian Fainelli
Hi all, This patch series does a number of things in order to enable management mode for bcm_sf2 (which could be easily extended to b53 with proper testing later on). In order to get there, there were several use cases that did not work correctly and that needed to be fixed: - VLAN devices on top

[PATCH net-next v2 02/12] net: dsa: b53: Fix default VLAN ID

2019-01-29 Thread Florian Fainelli
We were not consistent in how the default VID of a given port was defined, b53_br_leave() would make sure the VLAN ID would be either 0/1 depending on the switch generation, but b53_configure_vlan(), which is the default configuration would unconditionally set it to 1. The correct value is 1 for 53

[PATCH net-next v2 01/12] net: bridge: multicast: Propagate br_mc_disabled_update() return

2019-01-29 Thread Florian Fainelli
Some Ethernet switches might not be able to support disabling multicast flooding globally when e.g: several bridges span the same physical device, propagate the return value of br_mc_disabled_update() such that this propagates correctly to user-space. Signed-off-by: Florian Fainelli --- net/brid

[PATCH RFC RFT net-next 08/10] net: dsa: Remove legacy probing support

2019-01-29 Thread Andrew Lunn
Now that all drivers can be probed using more traditional methods, remove the legacy probe code. Signed-off-by: Andrew Lunn --- include/net/dsa.h | 23 -- net/dsa/Kconfig| 9 - net/dsa/Makefile | 1 - net/dsa/dsa.c | 5 - net/dsa/dsa_priv.h | 12 - net/dsa/legacy.c | 745 --

[PATCH RFC RFT net-next 07/10] net: dsa: mv88e6060: Add SPDX header

2019-01-29 Thread Andrew Lunn
Add an SPDX header, and remove the license text. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6060.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/net/dsa/mv88e6060.c b/drivers/net/dsa/mv88e6060.c index 792091a7153b..df5940259604 100644 --- a/drivers/net

[PATCH RFC RFT net-next 05/10] net: dsa: mv88e6060: Support probing as an mdio device

2019-01-29 Thread Andrew Lunn
Probing DSA devices as platform devices has been superseded by using normal bus drivers. Add support for probing the mv88e6060 device as an mdio device. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6060.c | 61 - 1 file changed, 60 insertions(+), 1 dele

[PATCH RFC RFT net-next 03/10] net: dsa: mv88e6060: Replace REG_WRITE macro

2019-01-29 Thread Andrew Lunn
The REG_WRITE macro contains a return statement, making it not very safe. Remove it by inlining the code. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6060.c | 73 + 1 file changed, 41 insertions(+), 32 deletions(-) diff --git a/drivers/net/dsa/mv88e60

[PATCH RFC RFT net-next 04/10] net: dsa: mv88e6060: Replace REG_READ macro

2019-01-29 Thread Andrew Lunn
The REG_READ macro contains a return statement, making it not very safe. Remove it by inlining the code. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6060.c | 20 +++- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/drivers/net/dsa/mv88e6060.c b/drivers/net/

[PATCH RFC RFT net-next 06/10] net: dsa: mv88e6060: Remove support for legacy probing

2019-01-29 Thread Andrew Lunn
Now that the driver can be probed as an mdio device, remove the legacy DSA platform device probing. Signed-off-by: Andrew Lunn --- drivers/net/dsa/Kconfig | 2 +- drivers/net/dsa/mv88e6060.c | 42 + 2 files changed, 2 insertions(+), 42 deletions(-) diff

[PATCH RFC RFT net-next 02/10] net: dsa: mv88e6060: Replace ds with priv

2019-01-29 Thread Andrew Lunn
Pass around priv, not ds. This will help with changing to an mdio driver, and makes this driver more like mv88e6xxx. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6060.c | 43 +++-- drivers/net/dsa/mv88e6060.h | 1 + 2 files changed, 23 insertions(+), 21 de

[PATCH RFC RFT net-next 10/10] bt-bindings: net: DSA: Remove legacy binding

2019-01-29 Thread Andrew Lunn
Now that the code to support the legacy binding has been removed, remove the documentation for it. Signed-off-by: Andrew Lunn --- .../devicetree/bindings/net/dsa/dsa.txt | 155 -- 1 file changed, 155 deletions(-) diff --git a/Documentation/devicetree/bindings/net/dsa/dsa.t

[PATCH RFC RFT net-next 01/10] net: dsa: mv88e6xxx: Remove legacy probe support

2019-01-29 Thread Andrew Lunn
Remove the legacy method of probing the mv88e6xxx driver, now that all the mainline boards have been converted to use mdio based probing for a number of cycles. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/chip.c | 71 +--- 1 file changed, 1 insertion(+),

[PATCH RFC RFT net-next 09/10] arch: arm: dts: Remove disabled marvell,dsa properties

2019-01-29 Thread Andrew Lunn
These have been disable since the change to probe Marvell Ethernet switches as MDIO devices. Remove the properties now that the code to suppport them has also been removed. Signed-off-by: Andrew Lunn --- arch/arm/boot/dts/armada-370-rd.dts | 42 -- arch/arm/boot/dts/armada-

[PATCH bpf 2/2] tools/bpf: fix test_btf for typedef func_proto case

2019-01-29 Thread Yonghong Song
Fixed one test_btf raw test such that typedef func_proto is permitted now. Fixes: 78a2540e8945 ("tools/bpf: Add tests for BTF_KIND_FUNC_PROTO and BTF_KIND_FUNC") Acked-by: Martin KaFai Lau Signed-off-by: Yonghong Song --- tools/testing/selftests/bpf/test_btf.c | 9 +++-- 1 file changed, 3

[PATCH bpf 1/2] bpf: btf: allow typedef func_proto

2019-01-29 Thread Yonghong Song
Current implementation does not allow typedef func_proto. But it is actually allowed. -bash-4.4$ cat t.c typedef int (f) (int); f *g; -bash-4.4$ clang -O2 -g -c -target bpf t.c -Xclang -target-feature -Xclang +dwarfris -bash-4.4$ pahole -JV t.o File t.o: [1] PTR (anon) type_id=2 [2

[PATCH RFC RFT net-next 00/10] Modernize mv88e6060 and remove legacy probe

2019-01-29 Thread Andrew Lunn
The mv88e6060 is the last device using the legacy method of probing an DSA Ethernet switch. This patchset applies some cleanups to the driver, and then adds support for probing the device as an MDIO bus device. The legacy probe is then removed from the driver, and then from DSA as a whole. This is

[PATCH bpf 0/2] bpf: btf: allow typedef func_proto

2019-01-29 Thread Yonghong Song
The current btf implementation disallows the typedef of a func_proto type. This actually is allowed per C standard. This patch fixed btf verification to permit such types. Patch #1 fixed the kernel side and Patch #2 fixed the tools test_btf test. Yonghong Song (2): bpf: btf: allow typedef func_p

(Basic Greenhorn Q) add ethernet access point 130 feet away

2019-01-29 Thread Harry Putnam
Sorry about the greenhorn question. When I got to thinking about doing this, I realized that I really wasn't sure I knew how. My googling has failed to turn up a definitive answer... never clear if what is talked about is the same as what I want to do. Probably due to my inexperience with the li

Re: [PATCH net] vhost: fix OOB in get_rx_bufs()

2019-01-29 Thread David Miller
From: David Miller Date: Tue, 29 Jan 2019 15:10:26 -0800 (PST) > Yeah the CVE pushed my hand a little bit, and I knew I was going to > send Linus a pull request today because David Watson needs some TLS > changes in net-next. I also want to make a general comment for the record. If I let pa

Re: [PATCH] ucc_geth: Reset BQL queue when stopping device

2019-01-29 Thread David Miller
From: Mathias Thore Date: Tue, 29 Jan 2019 08:07:54 + > Is there a scenario where we are clearing the TX ring but don't want to reset > the BQL TX queue? > > I think it makes sense to keep it in ucc_geth_free_tx since the > reason it is needed isn't the timeout per se, but rather the > clea

Re: mv88e6xxx -- DSA support for Marvell 88e6065 switch (and maybe 88e6060?)

2019-01-29 Thread Vivien Didelot
Hi Pavel, On Tue, 29 Jan 2019 23:57:32 +0100, Pavel Machek wrote: > Ok, so I took a long look at mv88e6xxx... and got it to work. > > Good news is that modifications needed are not too heavy. Most are > inlined below. (tag_daddr is still needed. I can send that too). > > Bad news is that onl

Re: mv88e6xxx -- DSA support for Marvell 88e6065 switch (and maybe 88e6060?)

2019-01-29 Thread Andrew Lunn
> Is someone is interested in getting 6060 to work with mv88e6xxx? Vivien is. I also have a set of patches which modernize the driver. That might be a step towards merging it in. > @@ -2126,6 +2146,7 @@ static int mv88e6xxx_setup_egress_floods(struct > mv88e6xxx_chip *chip, int port) > >

Re: [PATCH net] vhost: fix OOB in get_rx_bufs()

2019-01-29 Thread David Miller
From: "Michael S. Tsirkin" Date: Tue, 29 Jan 2019 17:54:44 -0500 > On Mon, Jan 28, 2019 at 10:54:44PM -0800, David Miller wrote: >> From: Jason Wang >> Date: Mon, 28 Jan 2019 15:05:05 +0800 >> >> > After batched used ring updating was introduced in commit e2b3b35eb989 >> > ("vhost_net: batch us

mv88e6xxx -- DSA support for Marvell 88e6065 switch (and maybe 88e6060?)

2019-01-29 Thread Pavel Machek
Hi! > > > > I'm trying to create support for Marvell 88e6065 switch... and it > > > > seems like drivers/net/dsa supports everything, but this model. > > > > > > > > Did someone work with this hardware before? Any idea if it would be > > > > more suitable to support by existing 88e6060 code, or i

Re: [PATCH net] vhost: fix OOB in get_rx_bufs()

2019-01-29 Thread Michael S. Tsirkin
On Mon, Jan 28, 2019 at 10:54:44PM -0800, David Miller wrote: > From: Jason Wang > Date: Mon, 28 Jan 2019 15:05:05 +0800 > > > After batched used ring updating was introduced in commit e2b3b35eb989 > > ("vhost_net: batch used ring update in rx"). We tend to batch heads in > > vq->heads for more t

Re: [PATCH v2 net 7/7] virtio_net: Differentiate sk_buff and xdp_frame on freeing

2019-01-29 Thread Michael S. Tsirkin
On Tue, Jan 29, 2019 at 09:45:59AM +0900, Toshiaki Makita wrote: > We do not reset or free up unused buffers when enabling/disabling XDP, > so it can happen that xdp_frames are freed after disabling XDP or > sk_buffs are freed after enabling XDP on xdp tx queues. > Thus we need to handle both forms

Re: [PATCH v2 net 5/7] virtio_net: Don't process redirected XDP frames when XDP is disabled

2019-01-29 Thread Michael S. Tsirkin
On Tue, Jan 29, 2019 at 09:45:57AM +0900, Toshiaki Makita wrote: > Commit 8dcc5b0ab0ec ("virtio_net: fix ndo_xdp_xmit crash towards dev not > ready for XDP") tried to avoid access to unexpected sq while XDP is > disabled, but was not complete. > > There was a small window which causes out of bound

Re: [PATCH iproute2-next v2] netns: add subcommand to attach an existing network namespace

2019-01-29 Thread Andrea Claudi
On Tue, Jan 29, 2019 at 4:01 PM Matteo Croce wrote: > > ip tracks namespaces with dummy files in /var/run/netns/, but can't see > namespaces created with other tools. > Creating the dummy file and bind mounting the correct procfs entry will > make ip aware of that namespace. > Add an ip netns subc

Re: Kernel memory corruption in CIPSO labeled TCP packets processing.

2019-01-29 Thread Paul Moore
On Tue, Jan 29, 2019 at 2:23 AM Nazarov Sergey wrote: > 29.01.2019, 01:18, "Paul Moore" : > > If we don't pass a skb into ip_options_compile(), meaning both "skb" > > and "rt" will be NULL, then I don't believe the option data will > > change. Am I missing something? > > I mean, in cipso_v4_error

Re: [PATCH net v3] net: l2tp: fix reading optional fields of L2TPv3

2019-01-29 Thread Guillaume Nault
On Tue, Jan 29, 2019 at 02:18:13PM +0800, Jacob Wen wrote: > Use pskb_may_pull() to make sure the optional fields are in skb linear > parts, so we can safely read them in l2tp_recv_common. > Looks fine to me. Just a few nitpicks. Not sure if they're worth a repost. But if you send a v4, you can:

Re: [PATCH net v5 2/2] net/mlx5e: Don't overwrite pedit action when multiple pedit used

2019-01-29 Thread Saeed Mahameed
On Mon, 2019-01-28 at 15:28 -0800, xiangxia.m@gmail.com wrote: > From: Tonghao Zhang > > In some case, we may use multiple pedit actions to modify packets. > The command shown as below: the last pedit action is effective. > > $ tc filter add dev netdev_rep parent : protocol ip prio 1

Re: [PATCH net v5 1/2] net/mlx5e: Update hw flows when encap source mac changed

2019-01-29 Thread Saeed Mahameed
On Mon, 2019-01-28 at 15:28 -0800, xiangxia.m@gmail.com wrote: > From: Tonghao Zhang > > When we offload tc filters to hardware, hardware flows can > be updated when mac of encap destination ip is changed. > But we ignore one case, that the mac of local encap ip can > be changed too, so we sh

  1   2   3   >