Re: [PATCH RFC lora-next 1/4] net: lora: sx125x sx1301: correct style warnings

2019-01-04 Thread Ben Whitten
Hi Andreas, On 29/12/2018 09:05, Andreas Färber wrote: Hi Ben, Am 19.12.18 um 16:56 schrieb Ben Whitten: Checkpatch highlights some style issues which need to be addressed. Signed-off-by: Ben Whitten --- drivers/net/lora/sx125x.c | 20 +-- drivers/net/lora/sx1301.c | 52 ++

Re: Problem with queuing vlan tagged packets after migration from 3.16.0 to 4.9.0

2019-01-04 Thread Cong Wang
(Cc'ing Jamal) On Fri, Jan 4, 2019 at 10:11 AM Bartek Kois wrote: > > Basically my current scenario looks like this: > - router with eth0 as WAN and eth1 as LAN with 10-20 vlans, > - around 1000-2000 ip addresses in differnets subnets behind router (on > the LAN side), > - QoS made with tc + ifb

Re: [PATCH ipsec 7/7] xfrm: policy: fix infinite loop when merging src-nodes

2019-01-04 Thread Cong Wang
On Fri, Jan 4, 2019 at 5:19 AM Florian Westphal wrote: > > With very small change to test script we can trigger softlockup due to > bogus assignment of 'p' (policy to be examined) on restart. > > Previously the two to-be-merged nodes had same address/prefixlength pair, > so no erase/reinsert was n

Re: [PATCH ipsec 5/7] xfrm: policy: fix reinsertion on node merge

2019-01-04 Thread Cong Wang
On Fri, Jan 4, 2019 at 5:19 AM Florian Westphal wrote: > > "newpos" has wrong scope. It must be NULL on each iteration of the loop. > Otherwise, when policy is to be inserted at the start, we would instead > insert at point found by the previous loop-iteration instead. > > Also, we need to unlink

Re: [PATCH ipsec 4/7] xfrm: policy: delete inexact policies from inexact list on hash rebuild

2019-01-04 Thread Cong Wang
On Fri, Jan 4, 2019 at 5:19 AM Florian Westphal wrote: > > An xfrm hash rebuild has to reset the inexact policy list before the > policies get re-inserted: A change of hash thresholds will result in > policies to get moved from inexact tree to the policy hash table. > > If the thresholds are incre

Re: [PATCH bpf] selftests/bpf: fix incorrect users of create_and_get_cgroup

2019-01-04 Thread Alexei Starovoitov
On Thu, Jan 03, 2019 at 10:57:17AM -0800, Stanislav Fomichev wrote: > create_and_get_cgroup returns 0 on error, fix the users that assume > negative value in case of an error. > > Signed-off-by: Stanislav Fomichev > --- > tools/testing/selftests/bpf/get_cgroup_id_user.c | 2 +- > tools/testing/s

Re: [Patch net] xfrm: fix reinsert in xfrm_hash_rebuild()

2019-01-04 Thread Cong Wang
On Thu, Jan 3, 2019 at 10:58 PM Florian Westphal wrote: > > Cong Wang wrote: > > xfrm_hash_rebuild() re-inserts existing policies into the hashtables, > > so it should not insert a same policy in the same place twice. This > > means we have to pass excl==1 to xfrm_policy_inexact_insert() and igno

Re: [PATCH bpf v2 0/2] bpf: Fix [::] -> [::1] rewrite in sys_sendmsg

2019-01-04 Thread Alexei Starovoitov
On Fri, Jan 04, 2019 at 01:07:06AM -0800, Andrey Ignatov wrote: > The patch set fixes BSD'ism in sys_sendmsg to rewrite unspecified > destination IPv6 for unconnected UDP sockets in sys_sendmsg with [::1] in > case when either CONFIG_CGROUP_BPF is enabled or when sys_sendmsg BPF hook > sets destina

Re: Question: pause mode disabled for marvell 88e151x phy

2019-01-04 Thread Yunsheng Lin
On 2018/12/17 22:36, Russell King - ARM Linux wrote: > I'll try to do further diagnosis over Christmas in case I've missed > something, but I suspect it may be one of those "weird behaviour" issues > where the safest action is to disable pause mode as per my commit - > which is far saner than havin

RE: [PATCH 1/2] e1000e: Exclude device from suspend direct complete optimization

2019-01-04 Thread Brown, Aaron F
> From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of Kai-Heng Feng > Sent: Tuesday, December 11, 2018 12:00 AM > To: Kirsher, Jeffrey T > Cc: da...@davemloft.net; intel-wired-...@lists.osuosl.org; > netdev@vger.kernel.org; linux-ker...@vger.kernel.org; Kai-Hen

Re: [PATCH net 0/4] net: bpfilter: fix two bugs in bpfilter

2019-01-04 Thread Taehee Yoo
On Sat, 5 Jan 2019 at 05:54, David Miller wrote: > > From: Taehee Yoo > Date: Mon, 31 Dec 2018 01:30:45 +0900 > > > This patches fix two bugs in the bpfilter_umh which are related in > > iptables command. > ... > > I am still thinking about these patches, sorry for taking so long to > give a res

Re: [PATCH 1/4] rtlwifi: rtl8723ae: Take the FW LPS mode handling out

2019-01-04 Thread Larry Finger
On 1/4/19 6:48 AM, Bernd Edlinger wrote: This appears to trigger a firmware bug and causes severe problems with rtl8723ae PCI devices. When the power save mode is activated for longer periods of time the firmware stops to receive any packets. This problem was exposed by commit 873ffe154ae0 ("rt

Re: [PATCH lora-next 3/5] net: lora: sx130x: Add PicoCell serdev driver

2019-01-04 Thread Andreas Färber
Am 04.01.19 um 12:21 schrieb Andreas Färber: > Currently there's still some bugs to be investigated, with communication > stalling on one device and another reading the radio versions wrong > (07 / 1f instead of 21, also observed on spi once). Reproducable 100% on SPI by setting REGCACHE_RBTREE in

Re: [PATCH lora-next 3/5] net: lora: sx130x: Add PicoCell serdev driver

2019-01-04 Thread Andreas Färber
Am 04.01.19 um 12:21 schrieb Andreas Färber: > diff --git a/drivers/net/lora/sx130x_picogw.c > b/drivers/net/lora/sx130x_picogw.c > new file mode 100644 > index ..577f9fb71d46 > --- /dev/null > +++ b/drivers/net/lora/sx130x_picogw.c [...] > + serdev_device_set_baudrate(sdev, 115200

Re: [PATCH net] ipv6: Consider sk_bound_dev_if when binding a socket to a v4 mapped address

2019-01-04 Thread David Miller
From: David Ahern Date: Fri, 4 Jan 2019 16:58:15 -0800 > From: David Ahern > > Similar to c5ee066333eb ("ipv6: Consider sk_bound_dev_if when binding a > socket to an address"), binding a socket to v4 mapped addresses needs to > consider if the socket is bound to a device. > > This problem als

[PATCH net] ipv6: Consider sk_bound_dev_if when binding a socket to a v4 mapped address

2019-01-04 Thread David Ahern
From: David Ahern Similar to c5ee066333eb ("ipv6: Consider sk_bound_dev_if when binding a socket to an address"), binding a socket to v4 mapped addresses needs to consider if the socket is bound to a device. This problem also exists from the beginning of git history. Signed-off-by: David Ahern

Re: [RFC PATCH V3 1/5] vhost: generalize adding used elem

2019-01-04 Thread Sean Christopherson
On Fri, Jan 04, 2019 at 04:29:34PM -0500, Michael S. Tsirkin wrote: > On Sat, Dec 29, 2018 at 08:46:52PM +0800, Jason Wang wrote: > > Use one generic vhost_copy_to_user() instead of two dedicated > > accessor. This will simplify the conversion to fine grain > > accessors. About 2% improvement of PP

[RFC ipsec 1/1] xfrm: Make set-mark default behavior backward compatible

2019-01-04 Thread Benedict Wong
Fixes 9b42c1f179a6, which changed the default route lookup behavior for tunnel mode SAs in the outbound direction to use the skb mark, whereas previously mark=0 was used if the output mark was unspecified. In mark-based routing schemes such as Android’s, this change in default behavior causes routi

[RFC ipsec 0/1] xfrm: set-mark default behavior changes

2019-01-04 Thread Benedict Wong
A behavior change introduced in 9b42c1f179a6 (“xfrm: Extend the output_mark to support input direction and masking”) results in a change in: 1. Default outbound behavior with regards to route lookup marks, and 2. Inbound behavior for SAs used to decapsulate packets when the output mark (as sp

Re: [RFC iproute2] xfrm: add option to hide keys in state output

2019-01-04 Thread Stephen Hemminger
On Fri, 4 Jan 2019 15:19:10 -0800 Benedict Wong wrote: > ip xfrm state show currently dumps keys unconditionally. This limits its > use in logging, as security information can be leaked. > > This patch adds a nokeys option to ip xfrm ( state show | monitor ), which > prevents the printing of ke

Re: [RFC lora-next 5/5] HACK: net: lora: sx130x: Add PicoCell gateway shim for cdc-acm

2019-01-04 Thread Andreas Färber
Hi Rob, Am 04.01.19 um 18:07 schrieb Rob Herring: > On Fri, Jan 4, 2019 at 5:21 AM Andreas Färber wrote: >> >> Ignore our device in cdc-acm probing and add a new driver for it, >> dispatching to cdc-acm for the actual implementation. >> >> WARNING: It is likely that this VID/PID is in use for unr

[RFC iproute2] xfrm: add option to hide keys in state output

2019-01-04 Thread Benedict Wong
ip xfrm state show currently dumps keys unconditionally. This limits its use in logging, as security information can be leaked. This patch adds a nokeys option to ip xfrm ( state show | monitor ), which prevents the printing of keys. This allows ip xfrm state show to be used in logging without exp

Re: "bpf: Improve the info.func_info and info.func_info_rec_size behavior" breaks strace self tests

2019-01-04 Thread Dmitry V. Levin
On Fri, Jan 04, 2019 at 10:25:24AM +0100, Heiko Carstens wrote: > On Thu, Jan 03, 2019 at 11:52:51PM +, Martin Lau wrote: > > On Thu, Jan 03, 2019 at 11:41:18PM +0100, Heiko Carstens wrote: > > > On Thu, Jan 03, 2019 at 07:12:05PM +, Martin Lau wrote: > > > > On Thu, Jan 03, 2019 at 12:46:1

Re: WARNING in mem_cgroup_update_lru_size

2019-01-04 Thread syzbot
syzbot has found a reproducer for the following crash on: HEAD commit:96d4f267e40f Remove 'type' argument from access_ok() funct.. git tree: net console output: https://syzkaller.appspot.com/x/log.txt?x=160c9a80c0 kernel config: https://syzkaller.appspot.com/x/.config?x=7308e682739

Re: [PATCH] octeontx2-af: Fix a resource leak in an error handling path in 'cgx_probe()'

2019-01-04 Thread Christophe JAILLET
Le 04/01/2019 à 21:46, David Miller a écrit : From: Christophe JAILLET Date: Sat, 29 Dec 2018 17:42:22 +0100 If an error occurs after the call to 'pci_alloc_irq_vectors()', we must call 'pci_free_irq_vectors()' in order to avoid a resource leak. The same sequence is already in place in

Re: [PATCH ghak90 (was ghak32) V4 01/10] audit: collect audit task parameters

2019-01-04 Thread Guenter Roeck
On Fri, Jan 04, 2019 at 09:57:35AM -0500, Richard Guy Briggs wrote: > On 2019-01-03 18:50, Guenter Roeck wrote: > > Hi Richard, > > > > On Tue, Jul 31, 2018 at 04:07:36PM -0400, Richard Guy Briggs wrote: > > > The audit-related parameters in struct task_struct should ideally be > > > collected tog

Re: [net v3] ixgbe: fix Kconfig when driver is not a module

2019-01-04 Thread David Miller
From: Jeff Kirsher Date: Fri, 04 Jan 2019 13:47:09 -0800 > On Fri, 2019-01-04 at 13:39 -0800, David Miller wrote: >> From: Jeff Kirsher >> Date: Fri, 4 Jan 2019 10:48:02 -0800 >> >> > The new ability added to the driver to use mii_bus to handle MII >> > related >> > ioctls is causing compile i

Re: [net v3] ixgbe: fix Kconfig when driver is not a module

2019-01-04 Thread Jeff Kirsher
On Fri, 2019-01-04 at 13:39 -0800, David Miller wrote: > From: Jeff Kirsher > Date: Fri, 4 Jan 2019 10:48:02 -0800 > > > The new ability added to the driver to use mii_bus to handle MII > > related > > ioctls is causing compile issues when the driver is compiled into > > the > > kernel (i.e. not

Re: [PATCH v4 1/2] net/mlx4: Get rid of page operation after dma_alloc_coherent

2019-01-04 Thread David Miller
Mellanox folks, these two patches could use some review. Thank you.

Re: [RFC PATCH V3 0/5] Hi:

2019-01-04 Thread Michael S. Tsirkin
On Sat, Dec 29, 2018 at 08:46:51PM +0800, Jason Wang wrote: > This series tries to access virtqueue metadata through kernel virtual > address instead of copy_user() friends since they had too much > overheads like checks, spec barriers or even hardware feature > toggling. I think it's a reasonabl

Re: [PATCH v3] can: gw: ensure DLC boundaries after CAN frame modification

2019-01-04 Thread David Miller
From: Marc Kleine-Budde Date: Fri, 4 Jan 2019 15:55:26 +0100 > From: Oliver Hartkopp > > Muyu Yu provided a POC where user root with CAP_NET_ADMIN can create a CAN > frame modification rule that makes the data length code a higher value than > the available CAN frame data size. In combination

Re: [PATCH net] ipv6: make icmp6_send() robust against null skb->dev

2019-01-04 Thread David Miller
From: Eric Dumazet Date: Fri, 4 Jan 2019 11:00:00 -0800 > syzbot was able to crash one host with the following stack trace : ... > This is because a RX packet found socket owned by user and > was stored into socket backlog. Before leaving RCU protected section, > skb->dev was cleared in __sk_re

Re: [net v3] ixgbe: fix Kconfig when driver is not a module

2019-01-04 Thread David Miller
From: Jeff Kirsher Date: Fri, 4 Jan 2019 10:48:02 -0800 > The new ability added to the driver to use mii_bus to handle MII related > ioctls is causing compile issues when the driver is compiled into the > kernel (i.e. not a module). > > The problem was in selecting MDIO_DEVICE instead of the pr

Re: [PATCH net] selftests: net: fix/improve ip_defrag selftest

2019-01-04 Thread David Miller
From: Peter Oskolkov Date: Fri, 4 Jan 2019 09:43:08 -0800 > Commit ade446403bfb ("net: ipv4: do not handle duplicate fragments as > overlapping") changed IPv4 defragmentation so that duplicate fragments, > as well as _some_ fragments completely covered by previously delivered > fragments, do not

Re: [PATCH 1/1] qmi_wwan: add MTU default to qmap network interface

2019-01-04 Thread David Miller
From: Daniele Palmas Date: Fri, 4 Jan 2019 13:26:10 +0100 > This patch adds MTU default value to qmap network interface in > order to avoid "RTNETLINK answers: No buffer space available" > error when setting an ipv6 address. > > Signed-off-by: Daniele Palmas Applied.

Re: [RFC PATCH V3 5/5] vhost: access vq metadata through kernel virtual address

2019-01-04 Thread Michael S. Tsirkin
On Sat, Dec 29, 2018 at 08:46:56PM +0800, Jason Wang wrote: > It was noticed that the copy_user() friends that was used to access > virtqueue metdata tends to be very expensive for dataplane > implementation like vhost since it involves lots of software checks, > speculation barrier, hardware featu

Re: [PATCH net 0/2] net: hns: Bugfixes for HNS driver

2019-01-04 Thread David Miller
From: Huazhong Tan Date: Fri, 4 Jan 2019 20:18:09 +0800 > This patchset includes bugfixes for the HNS ethernet controller driver. > > Every patch is independent. Series applied, thanks.

Re: [RFC PATCH V3 1/5] vhost: generalize adding used elem

2019-01-04 Thread Michael S. Tsirkin
On Sat, Dec 29, 2018 at 08:46:52PM +0800, Jason Wang wrote: > Use one generic vhost_copy_to_user() instead of two dedicated > accessor. This will simplify the conversion to fine grain > accessors. About 2% improvement of PPS were seen during vitio-user > txonly test. > > Signed-off-by: Jason Wang

Re: thoughts stac/clac and get user for vhost

2019-01-04 Thread Michael S. Tsirkin
On Wed, Jan 02, 2019 at 11:25:14AM +0800, Jason Wang wrote: > > On 2018/12/31 上午2:40, Michael S. Tsirkin wrote: > > On Thu, Dec 27, 2018 at 05:55:52PM +0800, Jason Wang wrote: > > > On 2018/12/26 下午11:06, Michael S. Tsirkin wrote: > > > > On Wed, Dec 26, 2018 at 12:03:50PM +0800, Jason Wang wrote:

Re: [PATCH 1/1] net-next/hinic: replace disable_irq_nosync/enable_irq

2019-01-04 Thread David Miller
From: Xue Chaojing Date: Thu, 3 Jan 2019 23:04:00 + > In order to avoid frequent system interrupts when sending and > receiving packets. we replace disable_irq_nosync/enable_irq > with hinic_set_msix_state(), hinic_set_msix_state is used to > access memory mapped hinic devices. > > Signed-of

Re: [PATCH] net: dsa: mt7530: Drop unused GPIO include

2019-01-04 Thread David Miller
From: Linus Walleij Date: Thu, 3 Jan 2019 22:31:32 +0100 > This driver uses GPIO descriptors only, > is not used so drop the include. > > Signed-off-by: Linus Walleij Applied.

Re: [PATCH net 0/2] Fix two further potential unbounded recursions in GUE error handlers

2019-01-04 Thread David Miller
From: Stefano Brivio Date: Thu, 3 Jan 2019 21:43:33 +0100 > Patch 1/2 takes care of preventing the issue fixed by commit 11789039da53 > ("fou: Prevent unbounded recursion in GUE error handler") also with > UDP-Lite payloads -- I just realised this might happen from a syzbot > report. > > Patch

Re: [PATCH] net: macb: remove unnecessary code

2019-01-04 Thread David Miller
From: Date: Thu, 3 Jan 2019 14:59:35 + > From: Claudiu Beznea > > Commit 653e92a9175e ("net: macb: add support for padding and fcs > computation") introduced a bug fixed by commit 899ecaedd155 ("net: > ethernet: cadence: fix socket buffer corruption problem"). Code removed > in this patch i

Re: [PATCH net] openvswitch: Fix IPv6 later frags parsing

2019-01-04 Thread David Miller
From: Yi-Hung Wei Date: Thu, 3 Jan 2019 09:51:57 -0800 > The previous commit fa642f08839b > ("openvswitch: Derive IP protocol number for IPv6 later frags") > introduces IP protocol number parsing for IPv6 later frags that can mess > up the network header length calculation logic, i.e. nh_len < 0

Re: [PATCH] net: dsa: microchip: Drop unused GPIO includes

2019-01-04 Thread David Miller
From: Linus Walleij Date: Thu, 3 Jan 2019 13:36:43 +0100 > This driver does not use the old GPIO includes so drop > them. > > Signed-off-by: Linus Walleij Applied.

Re: [PATCH net 0/2] qed: Misc fixes in qed

2019-01-04 Thread David Miller
From: Denis Bolotin Date: Thu, 3 Jan 2019 12:02:38 +0200 > This patch series fixes 2 potential bugs in qed. > Please consider applying to net. Series applied.

Re: [PATCH] rds: use DIV_ROUND_UP instead of ceil

2019-01-04 Thread David Miller
From: Jacob Wen Date: Thu, 3 Jan 2019 16:46:08 +0800 > Yes indeed, DIV_ROUND_UP is in kernel.h. > > Signed-off-by: Jacob Wen This does not apply to my tree.

Re: [PATCH net 0/4] net: bpfilter: fix two bugs in bpfilter

2019-01-04 Thread David Miller
From: Taehee Yoo Date: Mon, 31 Dec 2018 01:30:45 +0900 > This patches fix two bugs in the bpfilter_umh which are related in > iptables command. ... I am still thinking about these patches, sorry for taking so long to give a response. Thank you.

Re: [PATCH net-next] Optimize sk_msg_clone() by data merge to end dst sg entry

2019-01-04 Thread David Miller
From: Vakul Garg Date: Wed, 2 Jan 2019 09:36:59 + > Function sk_msg_clone has been modified to merge the data from source sg > entry to destination sg entry if the cloned data resides in same page > and is contiguous to the end entry of destination sk_msg. This improves > kernel tls throughpu

Re: [patch] net, skbuff: do not prefer skb allocation fails early

2019-01-04 Thread David Miller
From: David Rientjes Date: Wed, 2 Jan 2019 13:01:43 -0800 (PST) > Commit dcda9b04713c ("mm, tree wide: replace __GFP_REPEAT by > __GFP_RETRY_MAYFAIL with more useful semantic") replaced __GFP_REPEAT in > alloc_skb_with_frags() with __GFP_RETRY_MAYFAIL when the allocation may > directly reclaim.

Re: [RESEND PATCH v5] soc/fsl/qe: fix err handling of ucc_of_parse_tdm

2019-01-04 Thread David Miller
From: Peng Hao Date: Thu, 3 Jan 2019 01:09:53 +0800 > From: Wen Yang > > Currently there are some issues with the ucc_of_parse_tdm function: > 1, a possible null pointer dereference in ucc_of_parse_tdm, > detected by the semantic patch deref_null.cocci, > with the following warning: > drivers/s

Re: [PATCH] r8169: Add support for new Realtek Ethernet

2019-01-04 Thread David Miller
From: Kai-Heng Feng Date: Wed, 2 Jan 2019 14:45:07 +0800 > There are two new Realtek Ethernet devices which are re-branded r8168h. > Add the IDs to to support them. > > Signed-off-by: Kai-Heng Feng Applied.

Re: [PATCH v2] netlink: fixup regression in RTM_GETADDR

2019-01-04 Thread David Miller
From: ba...@gandi.net Date: Mon, 31 Dec 2018 02:10:58 + > From: Arthur Gautier > > This commit fixes a regression in AF_INET/RTM_GETADDR and > AF_INET6/RTM_GETADDR. > > Before this commit, the kernel would stop dumping addresses once the first > skb was full and end the stream with NLMSG_DO

Re: [PATCH] octeontx2-af: Fix a resource leak in an error handling path in 'cgx_probe()'

2019-01-04 Thread David Miller
From: Christophe JAILLET Date: Sat, 29 Dec 2018 17:42:22 +0100 > If an error occurs after the call to 'pci_alloc_irq_vectors()', we must > call 'pci_free_irq_vectors()' in order to avoid a resource leak. > > The same sequence is already in place in the corresponding 'cgx_remove()' > function

Re: [net v3] ixgbe: fix Kconfig when driver is not a module

2019-01-04 Thread Florian Fainelli
On 1/4/19 10:48 AM, Jeff Kirsher wrote: > The new ability added to the driver to use mii_bus to handle MII related > ioctls is causing compile issues when the driver is compiled into the > kernel (i.e. not a module). > > The problem was in selecting MDIO_DEVICE instead of the preferred PHYLIB > Kc

Re: [net v3] ixgbe: fix Kconfig when driver is not a module

2019-01-04 Thread Stephen Douthit
On 1/4/19 1:48 PM, Jeff Kirsher wrote: > The new ability added to the driver to use mii_bus to handle MII related > ioctls is causing compile issues when the driver is compiled into the > kernel (i.e. not a module). > > The problem was in selecting MDIO_DEVICE instead of the preferred PHYLIB > Kco

Re: [PATCH net] ipv6: make icmp6_send() robust against null skb->dev

2019-01-04 Thread Casey Schaufler
On 1/4/2019 11:38 AM, Eric Dumazet wrote: > On Fri, Jan 4, 2019 at 11:36 AM Casey Schaufler > wrote: >> On 1/4/2019 11:00 AM, Eric Dumazet wrote: >>> syzbot was able to crash one host with the following stack trace : >>> >>> kasan: GPF could be caused by NULL-ptr deref or user memory access >>> g

Re: [PATCH net] ipv6: make icmp6_send() robust against null skb->dev

2019-01-04 Thread Eric Dumazet
On Fri, Jan 4, 2019 at 11:36 AM Casey Schaufler wrote: > > On 1/4/2019 11:00 AM, Eric Dumazet wrote: > > syzbot was able to crash one host with the following stack trace : > > > > kasan: GPF could be caused by NULL-ptr deref or user memory access > > general protection fault: [#1] PREEMPT SMP

Re: [PATCH net] ipv6: make icmp6_send() robust against null skb->dev

2019-01-04 Thread Casey Schaufler
On 1/4/2019 11:00 AM, Eric Dumazet wrote: > syzbot was able to crash one host with the following stack trace : > > kasan: GPF could be caused by NULL-ptr deref or user memory access > general protection fault: [#1] PREEMPT SMP KASAN > CPU: 0 PID: 8625 Comm: syz-executor4 Not tainted 4.20.0+ #8

Re: [PATCH V4] net: phy: tja11xx: Add TJA11xx PHY driver

2019-01-04 Thread Marek Vasut
On 1/4/19 5:24 PM, Florian Fainelli wrote: > > > On January 3, 2019 6:15:47 PM PST, Marek Vasut wrote: >> Add driver for the NXP TJA1100 and TJA1101 PHYs. These PHYs are special >> BroadRReach 100BaseT1 PHYs used in automotive. >> >> Signed-off-by: Marek Vasut >> Cc: Andrew Lunn >> Cc: Florian

Re: selftests/bpf doesn't compile

2019-01-04 Thread shuah
Hi Geert, On 1/4/19 10:16 AM, Geert Uytterhoeven wrote: Hi Shuah, CC kbuild, gpio On Thu, Sep 14, 2017 at 5:34 PM Shuah Khan wrote: bpf test depends on clang and fails to compile when -- make -C tools/testing/selftests/bpf run_tests make

[PATCH net] ipv6: make icmp6_send() robust against null skb->dev

2019-01-04 Thread Eric Dumazet
syzbot was able to crash one host with the following stack trace : kasan: GPF could be caused by NULL-ptr deref or user memory access general protection fault: [#1] PREEMPT SMP KASAN CPU: 0 PID: 8625 Comm: syz-executor4 Not tainted 4.20.0+ #8 RIP: 0010:dev_net include/linux/netdevice.h:2169 [

[net v3] ixgbe: fix Kconfig when driver is not a module

2019-01-04 Thread Jeff Kirsher
The new ability added to the driver to use mii_bus to handle MII related ioctls is causing compile issues when the driver is compiled into the kernel (i.e. not a module). The problem was in selecting MDIO_DEVICE instead of the preferred PHYLIB Kconfig option. The reason being that MDIO_DEVICE had

Requesting stable backport of "SUNRPC: Ensure we always close the socket after a connection shuts down"

2019-01-04 Thread Ian Campbell
Hi Dave, Trond et al, I'd been seeing occasional false positives from rkhunter's hidden tcp port check every couple of days while running 4.9.130 (via the Debian kernel packages), see https://bugs.debian.org/917533 for more background. I found the solution was 9b30889c548a ("SUNRPC: Ensure we al

Re: Problem with queuing vlan tagged packets after migration from 3.16.0 to 4.9.0

2019-01-04 Thread Bartek Kois
Hi W dniu 03.01.2019 o 21:44, Cong Wang pisze: On Thu, Jan 3, 2019 at 7:25 AM Bartek Kois wrote: Hi 1. What exactly caused this change in the kernel? I don't follow VLAN changes, I guess it must be some change which inserts the VLAN tag before this ->ndo_start_xmit(). 2. I don`t understan

Re: [PATCH] ixgbe: fix Kconfig when driver is not a module

2019-01-04 Thread Jeff Kirsher
On Fri, 2019-01-04 at 15:09 +, Steve Douthit wrote: > On 1/3/19 7:55 PM, Jeff Kirsher wrote: > > I initially tried that, but we get a recursive Kconfig dependency > > error > > when IPSec is enabled as well, which I noted in the commit message. > I'm not running into the dependency issue you me

Re: kernel panic: stack is corrupted in udp4_lib_lookup2

2019-01-04 Thread Stefano Brivio
On Fri, 4 Jan 2019 18:26:16 +0100 Dmitry Vyukov wrote: > On Fri, Jan 4, 2019 at 6:14 PM Stefano Brivio wrote: > > > > On Fri, 4 Jan 2019 12:05:04 +0100 > > Dmitry Vyukov wrote: > > > > > I've added these as tests: > > > > > > https://github.com/google/syzkaller/blob/master/pkg/report/testdata/l

Re: [PATCH 10/19] usbnet: smsc95xx: Replace smsc95xx_mdio_read() with phy_read()

2019-01-04 Thread Heiner Kallweit
On 04.01.2019 16:57, Andrew Lunn wrote: >> I wonder, if I use the phylib functions instead of the ad-hoc ones in >> the MAC driver, is there still a problem with synchronization ? > > You would need to look deep into phylib. When does it reset the PHY? > Configure auto-neg, setup interrupts, etc?

Re: kernel panic: stack is corrupted in udp4_lib_lookup2

2019-01-04 Thread Stefano Brivio
On Fri, 4 Jan 2019 12:24:18 -0500 Willem de Bruijn wrote: > On Fri, Jan 4, 2019 at 12:14 PM Stefano Brivio wrote: > > > > On Fri, 4 Jan 2019 12:05:04 +0100 > > Dmitry Vyukov wrote: > > > > > On Fri, Jan 4, 2019 at 11:54 AM Stefano Brivio > > > wrote: > > > > > > > > On Fri, 4 Jan 2019 11:

Re: selftests/net/ip_defrag.sh fails on mainline since v4.20-rc7-202-g1d51b4b1d3f2

2019-01-04 Thread Peter Oskolkov
On Fri, Jan 4, 2019 at 9:46 AM David Miller wrote: > > From: Peter Oskolkov > Date: Fri, 4 Jan 2019 09:27:29 -0800 > > > This is caused by commit ade446403bfb ("net: ipv4: do not handle > > duplicate fragments as overlapping"). I have a patch that fixes the > > test - waiting for net-next to reop

Re: selftests/net/ip_defrag.sh fails on mainline since v4.20-rc7-202-g1d51b4b1d3f2

2019-01-04 Thread David Miller
From: Peter Oskolkov Date: Fri, 4 Jan 2019 09:27:29 -0800 > This is caused by commit ade446403bfb ("net: ipv4: do not handle > duplicate fragments as overlapping"). I have a patch that fixes the > test - waiting for net-next to reopen. Or maybe I should send it to > net? It should be sent now si

[PATCH net] selftests: net: fix/improve ip_defrag selftest

2019-01-04 Thread Peter Oskolkov
Commit ade446403bfb ("net: ipv4: do not handle duplicate fragments as overlapping") changed IPv4 defragmentation so that duplicate fragments, as well as _some_ fragments completely covered by previously delivered fragments, do not lead to the whole frag queue being discarded. This makes the existin

Re: [RFC bpf-next v3 3/9] tools: bpftool: add probes for kernel configuration options

2019-01-04 Thread Y Song
On Fri, Jan 4, 2019 at 6:27 AM Quentin Monnet wrote: > > 2019-01-03 22:35 UTC-0800 ~ Y Song > > On Thu, Jan 3, 2019 at 9:27 AM Quentin Monnet > > wrote: > >> > >> Add probes to dump a number of options set (or not set) for compiling > >> the kernel image. These parameters provide information abo

Re: selftests/net/ip_defrag.sh fails on mainline since v4.20-rc7-202-g1d51b4b1d3f2

2019-01-04 Thread Peter Oskolkov
This is caused by commit ade446403bfb ("net: ipv4: do not handle duplicate fragments as overlapping"). I have a patch that fixes the test - waiting for net-next to reopen. Or maybe I should send it to net? On Fri, Jan 4, 2019 at 9:10 AM Dan Rue wrote: > > Hi! We've noticed selftests/net/ip_defrag

Re: kernel panic: stack is corrupted in udp4_lib_lookup2

2019-01-04 Thread Dmitry Vyukov
On Fri, Jan 4, 2019 at 6:14 PM Stefano Brivio wrote: > > On Fri, 4 Jan 2019 12:05:04 +0100 > Dmitry Vyukov wrote: > > > On Fri, Jan 4, 2019 at 11:54 AM Stefano Brivio wrote: > > > > > > On Fri, 4 Jan 2019 11:32:12 +0100 > > > Dmitry Vyukov wrote: > > > > > > > On Thu, Jan 3, 2019 at 10:54 PM St

Re: kernel panic: stack is corrupted in udp4_lib_lookup2

2019-01-04 Thread Willem de Bruijn
On Fri, Jan 4, 2019 at 12:14 PM Stefano Brivio wrote: > > On Fri, 4 Jan 2019 12:05:04 +0100 > Dmitry Vyukov wrote: > > > On Fri, Jan 4, 2019 at 11:54 AM Stefano Brivio wrote: > > > > > > On Fri, 4 Jan 2019 11:32:12 +0100 > > > Dmitry Vyukov wrote: > > > > > > > On Thu, Jan 3, 2019 at 10:54 PM S

Re: selftests/bpf doesn't compile

2019-01-04 Thread Geert Uytterhoeven
Hi Shuah, CC kbuild, gpio On Thu, Sep 14, 2017 at 5:34 PM Shuah Khan wrote: > bpf test depends on clang and fails to compile when > > -- > make -C tools/testing/selftests/bpf run_tests > > > make: clang: Command not found > Makefile:39: recipe

Re: kernel panic: stack is corrupted in udp4_lib_lookup2

2019-01-04 Thread Stefano Brivio
On Fri, 4 Jan 2019 12:05:04 +0100 Dmitry Vyukov wrote: > On Fri, Jan 4, 2019 at 11:54 AM Stefano Brivio wrote: > > > > On Fri, 4 Jan 2019 11:32:12 +0100 > > Dmitry Vyukov wrote: > > > > > On Thu, Jan 3, 2019 at 10:54 PM Stefano Brivio > > > wrote: > > > > > > > > On Thu, 3 Jan 2019 15:15:

Re: [RFC lora-next 5/5] HACK: net: lora: sx130x: Add PicoCell gateway shim for cdc-acm

2019-01-04 Thread Rob Herring
On Fri, Jan 4, 2019 at 5:21 AM Andreas Färber wrote: > > Ignore our device in cdc-acm probing and add a new driver for it, > dispatching to cdc-acm for the actual implementation. > > WARNING: It is likely that this VID/PID is in use for unrelated devices. > Only the Product string hints what this

selftests/net/ip_defrag.sh fails on mainline since v4.20-rc7-202-g1d51b4b1d3f2

2019-01-04 Thread Dan Rue
Hi! We've noticed selftests/net/ip_defrag.sh started failing on mainline between v4.20-rc7-23-gab63e725b49c (good) and v4.20-rc7-202-g1d51b4b1d3f2 (bad). Output looks like: selftests: net: ip_defrag.sh ipv4 defrag PASS seed = 1545325420 ipv4 defrag with overlaps seed = 1545

WARNING in xfrm_policy_insert_list

2019-01-04 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:c5ee066333eb ipv6: Consider sk_bound_dev_if when binding a.. git tree: net console output: https://syzkaller.appspot.com/x/log.txt?x=11e796d740 kernel config: https://syzkaller.appspot.com/x/.config?x=b03c5892bb940c76 dashboa

Re: [PATCH V4] net: phy: tja11xx: Add TJA11xx PHY driver

2019-01-04 Thread Florian Fainelli
On January 3, 2019 6:15:47 PM PST, Marek Vasut wrote: >Add driver for the NXP TJA1100 and TJA1101 PHYs. These PHYs are special >BroadRReach 100BaseT1 PHYs used in automotive. > >Signed-off-by: Marek Vasut >Cc: Andrew Lunn >Cc: Florian Fainelli >Cc: Guenter Roeck >Cc: Heiner Kallweit >Cc: J

Re: [PATCH 1/1] qmi_wwan: add MTU default to qmap network interface

2019-01-04 Thread Daniele Palmas
Hi Bjørn, Il giorno ven 4 gen 2019 alle ore 14:24 Bjørn Mork ha scritto: > > Daniele Palmas writes: > > > This patch adds MTU default value to qmap network interface in > > order to avoid "RTNETLINK answers: No buffer space available" > > error when setting an ipv6 address. > > > > Signed-off-by

[PATCH] octeontx2-af: Fix a resource leak in an error handling path in 'cgx_probe()'

2019-01-04 Thread Christophe JAILLET
If an error occurs after the call to 'pci_alloc_irq_vectors()', we must call 'pci_free_irq_vectors()' in order to avoid a resource leak. The same sequence is already in place in the corresponding 'cgx_remove()' function. Fixes: 1463f382f58d ("octeontx2-af: Add support for CGX link managemen

Re: [PATCH 10/19] usbnet: smsc95xx: Replace smsc95xx_mdio_read() with phy_read()

2019-01-04 Thread Andrew Lunn
> I wonder, if I use the phylib functions instead of the ad-hoc ones in > the MAC driver, is there still a problem with synchronization ? You would need to look deep into phylib. When does it reset the PHY? Configure auto-neg, setup interrupts, etc? It looks like both are going to do this, so i ex

WARNING in bpf_prog_kallsyms_add

2019-01-04 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:645ff1e8e704 Merge branch 'for-linus' of git://git.kernel... git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=14a5c64b40 kernel config: https://syzkaller.appspot.com/x/.config?x=20271e14bc1c87f0 da

Re: [PATCH] Revert "can: dev: __can_get_echo_skb(): print error message, if trying to echo non existing skb"

2019-01-04 Thread Marc Kleine-Budde
On 12/19/18 7:39 PM, Manfred Schlaegl wrote: > This reverts commit 7da11ba5c5066dadc2e96835a6233d56d7b7764a. > > After introduction of this change we encountered following new error > message on various i.MX plattforms (flexcan) > flexcan 53fc8000.can can0: __can_get_echo_skb: BUG! Trying to echo

Re: [PATCH net-next] can: flexcan: fix 'passing zero to ERR_PTR()' warning

2019-01-04 Thread Marc Kleine-Budde
On 12/12/18 10:24 AM, YueHaibing wrote: > Fix a static code checker warning: > drivers/net/can/flexcan.c:1435 flexcan_setup_stop_mode() warn: passing zero > to 'PTR_ERR' > > Fixes: de3578c198c6 ("can: flexcan: add self wakeup support") > Signed-off-by: YueHaibing Applied to linux-can. tnx, Mar

Re: [PATCH] ixgbe: fix Kconfig when driver is not a module

2019-01-04 Thread Steve Douthit
On 1/3/19 7:55 PM, Jeff Kirsher wrote: > I initially tried that, but we get a recursive Kconfig dependency error > when IPSec is enabled as well, which I noted in the commit message. I'm not running into the dependency issue you mention in my own testing of the 'select PHYLIB' patch. All of the fo

Re: [PATCH 10/19] usbnet: smsc95xx: Replace smsc95xx_mdio_read() with phy_read()

2019-01-04 Thread Marek Vasut
On 1/4/19 2:24 PM, Andrew Lunn wrote: >>> All this crossover code should be moved into the PHY driver. >> >> Fine, this can be done in a subsequent patch though, right ? I'd like to >> keep the changes small, so if something breaks, it could be bisected easily. > > Hi Marek Hi, > The problem is,

Re: [PATCH ghak90 (was ghak32) V4 01/10] audit: collect audit task parameters

2019-01-04 Thread Richard Guy Briggs
On 2019-01-03 18:50, Guenter Roeck wrote: > Hi Richard, > > On Tue, Jul 31, 2018 at 04:07:36PM -0400, Richard Guy Briggs wrote: > > The audit-related parameters in struct task_struct should ideally be > > collected together and accessed through a standard audit API. > > > > Collect the existing l

[PATCH v3] can: gw: ensure DLC boundaries after CAN frame modification

2019-01-04 Thread Marc Kleine-Budde
From: Oliver Hartkopp Muyu Yu provided a POC where user root with CAP_NET_ADMIN can create a CAN frame modification rule that makes the data length code a higher value than the available CAN frame data size. In combination with a configured checksum calculation where the result is stored relative

[PATCH RFC v2 1/2] vsock/virtio: fix kernel panic after device hot-unplug

2019-01-04 Thread Stefano Garzarella
virtio_vsock_remove() invokes the vsock_core_exit() also if there are opened sockets for the AF_VSOCK protocol family. In this way the vsock "transport" pointer is set to NULL, triggering the kernel panic at the first socket activity. This patch move the vsock_core_init()/vsock_core_exit() in the

[PATCH RFC v2 0/2] vsock/virtio: fix issues on device hot-unplug

2019-01-04 Thread Stefano Garzarella
These patches try to handle the hot-unplug of vsock virtio transport device in a proper way. Maybe move the vsock_core_init()/vsock_core_exit() functions in the module_init and module_exit of vsock_virtio_transport module can't be the best way, but the architecture of vsock_core forces us to this

[PATCH RFC v2 2/2] vsock/virtio: reset connected sockets on device removal

2019-01-04 Thread Stefano Garzarella
When the virtio transport device disappear, we should reset all connected sockets in order to inform the users. Signed-off-by: Stefano Garzarella Reviewed-by: Stefan Hajnoczi --- net/vmw_vsock/virtio_transport.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/vmw_vsock/virtio_transpo

Re: [RFC bpf-next v3 3/9] tools: bpftool: add probes for kernel configuration options

2019-01-04 Thread Quentin Monnet
2019-01-03 22:35 UTC-0800 ~ Y Song > On Thu, Jan 3, 2019 at 9:27 AM Quentin Monnet > wrote: >> >> Add probes to dump a number of options set (or not set) for compiling >> the kernel image. These parameters provide information about what BPF >> components should be available on the system. A numbe

Re: [PATCH RFC 0/2] vsock/virtio: fix issues on device hot-unplug

2019-01-04 Thread Stefano Garzarella
On Fri, Jan 4, 2019 at 12:44 PM Stefan Hajnoczi wrote: > > On Thu, Dec 20, 2018 at 01:15:33PM +0100, Stefano Garzarella wrote: > > These patches try to handle the hot-unplug of vsock virtio transport device > > in > > a proper way. > > > > Maybe move the vsock_core_init()/vsock_core_exit() functi

Re: [RFC bpf-next v3 2/9] tools: bpftool: add probes for /proc/ eBPF parameters

2019-01-04 Thread Quentin Monnet
2019-01-03 22:32 UTC-0800 ~ Y Song > On Thu, Jan 3, 2019 at 9:26 AM Quentin Monnet > wrote: >> >> Add a set of probes to dump the eBPF-related parameters available from >> /proc/: availability of bpf() syscall for unprivileged users, >> JIT compiler status and hardening status, kallsyms exports s

Re: [PATCH] can: gw: ensure DLC boundaries after CAN frame modification

2019-01-04 Thread Marc Kleine-Budde
On 1/4/19 10:13 AM, Oliver Hartkopp wrote: > Muyu Yu provided a POC where user root with CAP_NET_ADMIN can create a CAN > frame modification rule that makes the data length code a higher value than > the available CAN frame data size. In combination with a configured checksum > calculation where th

Re: [PATCH net-next v2] Documentation: networking: Clarify switchdev devices behavior

2019-01-04 Thread Ido Schimmel
On Thu, Jan 03, 2019 at 02:47:02PM -0800, Florian Fainelli wrote: > +A switchdev driver can also refuse to support dynamic toggling of the VLAN > +filtering knob at runtime and require a destruction of the bridge device(s) > and > +a creation of new bridge device(s) with a different VLAN filtering

  1   2   >