On Thu, Jan 03, 2019 at 10:57:17AM -0800, Stanislav Fomichev wrote: > create_and_get_cgroup returns 0 on error, fix the users that assume > negative value in case of an error. > > Signed-off-by: Stanislav Fomichev <s...@google.com> > --- > tools/testing/selftests/bpf/get_cgroup_id_user.c | 2 +- > tools/testing/selftests/bpf/test_sockmap.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/bpf/get_cgroup_id_user.c > b/tools/testing/selftests/bpf/get_cgroup_id_user.c > index e8da7b39158d..dfaa9b353ac3 100644 > --- a/tools/testing/selftests/bpf/get_cgroup_id_user.c > +++ b/tools/testing/selftests/bpf/get_cgroup_id_user.c > @@ -64,7 +64,7 @@ int main(int argc, char **argv) > return 1; > > cgroup_fd = create_and_get_cgroup(TEST_CGROUP); > - if (CHECK(cgroup_fd < 0, "create_and_get_cgroup", "err %d errno %d\n", > + if (CHECK(!cgroup_fd, "create_and_get_cgroup", "err %d errno %d\n",
fd can be zero. Hence I prefer to fix it the other way to avoid this corner case. Pls fix create_and_get_cgroup() to return -1 in case of error. The diff will be much bigger, but overall it's imo cleaner. Also pls add Fixes tag. Thanks
