From: Jeff Kirsher <jeffrey.t.kirs...@intel.com> Date: Fri, 04 Jan 2019 13:47:09 -0800
> On Fri, 2019-01-04 at 13:39 -0800, David Miller wrote: >> From: Jeff Kirsher <jeffrey.t.kirs...@intel.com> >> Date: Fri, 4 Jan 2019 10:48:02 -0800 >> >> > The new ability added to the driver to use mii_bus to handle MII >> > related >> > ioctls is causing compile issues when the driver is compiled into >> > the >> > kernel (i.e. not a module). >> > >> > The problem was in selecting MDIO_DEVICE instead of the preferred >> > PHYLIB >> > Kconfig option. The reason being that MDIO_DEVICE had a dependency >> > on >> > PHYLIB and would be compiled as a module when PHYLIB was a module, >> > no >> > matter whether ixgbe was compiled into the kernel. >> > >> > CC: Dave Jones <da...@codemonkey.org.uk> >> > CC: Steve Douthit <steph...@silicom-usa.com> >> > CC: Florian Fainelli <f.faine...@gmail.com> >> > Signed-off-by: Jeff Kirsher <jeffrey.t.kirs...@intel.com> >> > --- >> > v2: fixed up the Kconfig help section to include the clause 22/45 >> > address information and also changed the IXGBE_MDIO config option >> > to be >> > dependent upon PHYLIB versus MDIO_BUS since that appears to be >> > the >> > common usage >> > >> > v3: Steve Douthit found a much simpler solution of changing the >> > dependency from MDIO_DEVICE to PHYLIB, which is consistent with >> > other >> > Ethernet drivers >> >> Jeff, would you like me to apply this directly? >> >> Thanks. > > Yes, please. It is the only fix I have for your net tree. Awesome, done.
