[PATCH net-next] bpf: libbpf: fix memleak by freeing line_info

2018-12-16 Thread Prashant Bhole
This patch fixes a memory leak in libbpf by freeing up line_info member of struct bpf_program while unloading a program. Fixes: 3d65014146c6 ("bpf: libbpf: Add btf_line_info support to libbpf") Signed-off-by: Prashant Bhole --- tools/lib/bpf/libbpf.c | 1 + 1 file changed, 1 insertion(+) diff -

Re: [PATCH v2 1/2] net: dsa: ksz9477: add I2C managed mode support

2018-12-16 Thread Andrew Lunn
On Sun, Dec 16, 2018 at 10:49:52AM +0100, Sergio Paracuellos wrote: > In this mode the switch device and the internal phys will be managed via > I2C interface. > > Signed-off-by: Sergio Paracuellos > --- > Changes v2: > - Use dev->txbuf as transmition buffer which is allocated using > k

Re: [PATCH 1/3] 9p/net: implement asynchronous rpc

2018-12-16 Thread Tomas Bortoli
Hey Dominique, sorry for the delay, I've been quite busy these days. The patches looks good to me and should indeed speed up the code a bit. I quickly tested them against Syzkaller tuned for the 9p subsystem and everything seems fine. And by the way, which refcount races? Cheers, Tomas On 12/1

Re: [PATCH 1/3] 9p/net: implement asynchronous rpc

2018-12-16 Thread Tomas Bortoli
Hey Dominique, sorry for the delay, I've been quite busy these days. The patches looks good to me and should indeed speed up the code a bit. I quickly tested them against Syzkaller tuned for the 9p subsystem and everything seems fine. And by the way, which refcount races? Cheers, Tomas On 12/1

Re: [PATCH net] net: mvneta: fix operation for 64K PAGE_SIZE

2018-12-16 Thread Thomas Petazzoni
Hello Marcin, On Mon, 17 Dec 2018 00:25:58 +0100, Marcin Wojtas wrote: > Thanks. Indeed, the patch is valid as a fix for current version of SW > BM. However, because this concept is broken, I will rework it and > submit patch/patches some time early 2019. I know some people are working on XDP su

Re: [PATCH net 1/2] net: bpfilter: restart bpfilter_umh when error occurred

2018-12-16 Thread Taehee Yoo
On Mon, 17 Dec 2018 at 07:20, David Miller wrote: > > From: Taehee Yoo > Date: Sat, 15 Dec 2018 13:22:39 +0900 > > > If bpfilter_umh process is killed, shutdown_umh() is executed via > > __stop_umh(). > > because, __kernel_write() or kernel_read() will be failed in > > __bpfilter_process_sockopt

[Patch net] tipc: check group dests after tipc_wait_for_cond()

2018-12-16 Thread Cong Wang
Similar to commit 143ece654f9f ("tipc: check tsk->group in tipc_wait_for_cond()") we have to reload grp->dests too after we re-take the sock lock. This means we need to move the dsts check after tipc_wait_for_cond() too. Fixes: 75da2163dbb6 ("tipc: introduce communication groups") Reported-and-te

Re: [PATCH net-next v2] net: dccp: initialize (addr,port) listening hashtable

2018-12-16 Thread Eric Dumazet
On 12/16/2018 10:49 PM, Peter Oskolkov wrote: > Actually, no: the earlier patch has this condition: > > + if (ilb->count <= 10 || !hashinfo->lhash2) > + goto port_lookup; > > that checks if lhash2 is initialized. So the bug is in my patch. Great, thanks for double checki

Re: KMSAN: uninit-value in __inet6_bind

2018-12-16 Thread syzbot
syzbot has found a reproducer for the following crash on: HEAD commit:0a602458c72c kmsan: random: another take at unpoisoning CR.. git tree: https://github.com/google/kmsan.git/master console output: https://syzkaller.appspot.com/x/log.txt?x=129e103540 kernel config: https://syzkal

Re: [PATCH 0/3]: net: dsa: mt7530: support MT7530 in the MT7621 SoC

2018-12-16 Thread NeilBrown
On Sun, Dec 16 2018, Florian Fainelli wrote: > On December 16, 2018 3:19:22 PM PST, NeilBrown wrote: >>On Sun, Dec 16 2018, David Miller wrote: >> >>> From: NeilBrown >>> Date: Mon, 17 Dec 2018 09:08:54 +1100 >>> In my 4.4 kernel, the build_skb() call in (the equivalent of) mtk_poll_rx

[PATCH net] qed: Fix an error code qed_ll2_start_xmit()

2018-12-16 Thread Dan Carpenter
We accidentally deleted the code to set "rc = -ENOMEM;" and this patch adds it back. Fixes: d2201a21598a ("qed: No need for LL2 frags indication") Signed-off-by: Dan Carpenter --- I'm not totally sure about this patch. Please review it carefully. There are four callers of this function: qedi_d

Re: [PATCH 1/2] net: dsa: ksz9477: add I2C managed mode support

2018-12-16 Thread Dan Carpenter
On Sun, Dec 16, 2018 at 08:57:40AM +0100, Sergio Paracuellos wrote: > +static int ksz_i2c_write(struct ksz_device *dev, u32 reg, u8 *val, > + unsigned int len) > +{ > + struct i2c_client *client = dev->priv; > + unsigned int cnt = len; > + int i = 0; > + u8 txb[

Re: [PATCH net-next v2] net: dccp: initialize (addr,port) listening hashtable

2018-12-16 Thread Peter Oskolkov
On Sun, Dec 16, 2018 at 10:46 PM Peter Oskolkov wrote: > > On Sun, Dec 16, 2018 at 10:41 PM Eric Dumazet wrote: > > > > On Sun, Dec 16, 2018 at 10:35 PM Peter Oskolkov > > wrote: > > > > > > I guess DCCP is not used to the extent that 10 listeners per bucket > > > happen in real life scenarios,

Re: [PATCH net-next v2] net: dccp: initialize (addr,port) listening hashtable

2018-12-16 Thread Peter Oskolkov
On Sun, Dec 16, 2018 at 10:41 PM Eric Dumazet wrote: > > On Sun, Dec 16, 2018 at 10:35 PM Peter Oskolkov wrote: > > > > I guess DCCP is not used to the extent that 10 listeners per bucket > > happen in real life scenarios, so the issue is purely theoretical; as > > my patch would cause a sefgault

Re: [PATCH net-next 2/2] net: fec: remove workaround to restart state machine on MDIO error

2018-12-16 Thread Heiner Kallweit
On 17.12.2018 03:05, Andy Duan wrote: > From: Heiner Kallweit Sent: 2018年12月16日 0:20 >> Now that the PHY isn't stopped any longer by phylib in case of a MDIO error, >> we can remove this workaround. >> >> Signed-off-by: Heiner Kallweit > > The old workaround can be removed NOW, thanks. > This

Re: [RFC PATCH net v3] net: phy: Fix the issue that netif always links up after resuming

2018-12-16 Thread Kunihiko Hayashi
Hi, Gentle ping... Are there any comments about changes since v2? v2: https://www.spinics.net/lists/netdev/msg536926.html Thank you, On Mon, 3 Dec 2018 17:22:29 +0900 wrote: > Even though the link is down before entering hibernation, > there is an issue that the network interface always links

Re: [PATCH net-next v2] net: dccp: initialize (addr,port) listening hashtable

2018-12-16 Thread Eric Dumazet
On Sun, Dec 16, 2018 at 10:35 PM Peter Oskolkov wrote: > > I guess DCCP is not used to the extent that 10 listeners per bucket > happen in real life scenarios, so the issue is purely theoretical; as > my patch would cause a sefgault for even a single listening dccp > socket, I felt it was my patch

Re: [PATCH net-next v2] net: dccp: initialize (addr,port) listening hashtable

2018-12-16 Thread Peter Oskolkov
I guess DCCP is not used to the extent that 10 listeners per bucket happen in real life scenarios, so the issue is purely theoretical; as my patch would cause a sefgault for even a single listening dccp socket, I felt it was my patch that the "Fixes" tag should refer to. On Sun, Dec 16, 2018 at 9:

Re: [PATCH net-next 5/5] tcp: TFO - cleanup code duplication

2018-12-16 Thread Eric Dumazet
On 12/14/2018 02:40 PM, Christoph Paasch wrote: > We can actually easily reuse __tcp_fastopen_cookie_gen_with_ctx to > generate the cookie based on a give TFO-context. > s/give/given/

Re: [PATCH net-next 3/5] tcp: Print list of TFO-keys from proc

2018-12-16 Thread Eric Dumazet
On 12/14/2018 02:40 PM, Christoph Paasch wrote: > Print the list of the TFO-keys with a comma separated. For setting the > keys, we still only allow a single one to be set. > I wonder if some applications expecting current format could break after a formatting change.

Re: [PATCH net-next 1/5] tcp: Create list of TFO-contexts

2018-12-16 Thread Eric Dumazet
On 12/14/2018 02:40 PM, Christoph Paasch wrote: > Instead of having a single TFO-context, we now have a list of > tcp_fastopen_context, bounded by TCP_FASTOPEN_CTXT_LEN (set to 2). > > This enables us to do a rolling TFO-key update that allows the server to > accept old cookies and at the same

Re: [PATCH net-next 2/5] tcp: TFO: search for correct cookie and accept data

2018-12-16 Thread Eric Dumazet
On 12/14/2018 02:40 PM, Christoph Paasch wrote: > This change allows to search for the right cookie and accepts old ones > (announcing a new one if it has changed). > > __tcp_fastopen_cookie_gen_with_ctx() allows to generate a cookie based > on a given TFO-context. A later patch will cleanup th

[PATCH 1/1] net-next/hinic:optmize rx refill buffer mechanism

2018-12-16 Thread Xue Chaojing
In rx_alloc_pkts(), there is no need to schedule a different tasklet for refill and it will cause some extra overhead. this patch remove it. Suggested-by: Neil Horman Signed-off-by: Xue Chaojing --- drivers/net/ethernet/huawei/hinic/hinic_rx.c | 23 +--- drivers/net/ethernet/hua

KASAN: use-after-free Read in tipc_mcast_xmit

2018-12-16 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:8203e2d844d3 net: clear skb->tstamp in forwarding paths git tree: net console output: https://syzkaller.appspot.com/x/log.txt?x=17d37c1b40 kernel config: https://syzkaller.appspot.com/x/.config?x=c8970c89a0efbb23 dashboard li

Re: [PATCH net-next 0/5] tcp: Introduce a TFO key-pool for clean cookie-rotation

2018-12-16 Thread Eric Dumazet
On 12/16/2018 12:19 PM, David Miller wrote: > From: Christoph Paasch > Date: Fri, 14 Dec 2018 14:40:02 -0800 > >> Currently, TFO only allows a single TFO-secret. This means that whenever >> the secret gets changed for key-rotation purposes, all the previously >> issued TFO-cookies become inval

Re: [PATCH net-next v2] net: dccp: initialize (addr,port) listening hashtable

2018-12-16 Thread Eric Dumazet
On 12/16/2018 03:42 PM, Peter Oskolkov wrote: > Commit d9fbc7f6431f "net: tcp: prefer listeners bound to an address" > removes port-only listener lookups. This caused segfaults in DCCP > lookups because DCCP did not initialize the (addr,port) hashtable. > > This patch adds said initialization.

[PATCH v2] net/smc: fix TCP fallback socket release

2018-12-16 Thread Myungho Jung
clcsock can be released while kernel_accept() references it in TCP listen worker. Also, clcsock needs to wake up before released if TCP fallback is used and the clcsock is blocked by accept. Add a lock to safely release clcsock and call kernel_sock_shutdown() to wake up clcsock from accept in smc_r

Re: [PATCH] net/smc: fix TCP fallback socket release

2018-12-16 Thread kbuild test robot
Hi Myungho, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] [also build test WARNING on v4.20-rc7 next-20181214] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0da

Re: [PATCH v9 RESEND 0/4] KASLR feature to randomize each loadable module

2018-12-16 Thread Jessica Yu
+++ Edgecombe, Rick P [12/12/18 23:05 +]: On Wed, 2018-11-28 at 01:40 +, Edgecombe, Rick P wrote: On Tue, 2018-11-27 at 11:21 +0100, Daniel Borkmann wrote: > On 11/27/2018 01:19 AM, Edgecombe, Rick P wrote: > > On Mon, 2018-11-26 at 16:36 +0100, Jessica Yu wrote: > > > +++ Rick Edgecombe

Re: [PATCH net-next] Documentation: networking: Clarify switchdev devices behavior

2018-12-16 Thread Florian Fainelli
On December 16, 2018 12:25:19 AM PST, Ido Schimmel wrote: >On Wed, Dec 12, 2018 at 03:09:43PM -0800, Florian Fainelli wrote: > >mlxsw doesn't support it. These bridges are mainly used with VLAN >devices where the packets ingress the bridge untagged. When configured >over physical ports, we onl

RE: [PATCH net-next 1/2] net: phy: don't stop state machine in case of MDIO error

2018-12-16 Thread Andy Duan
From: Heiner Kallweit Sent: 2018年12月16日 0:19 > If we detect a MDIO error, it seems to be a little bit too aggressive to stop > the > state machine and bring down the PHY completely. > E.g. when polling and we miss one update, then this has no relevant impact. > And in phy_stop_interrupts() actual

RE: [PATCH net-next 2/2] net: fec: remove workaround to restart state machine on MDIO error

2018-12-16 Thread Andy Duan
From: Heiner Kallweit Sent: 2018年12月16日 0:20 > Now that the PHY isn't stopped any longer by phylib in case of a MDIO error, > we can remove this workaround. > > Signed-off-by: Heiner Kallweit The old workaround can be removed NOW, thanks. Acked-by: Fugang Duan > --- > drivers/net/ethernet/f

Re: [PATCH] net: wireless: FTM: fix kernel-doc "cannot understand" warnings

2018-12-16 Thread Randy Dunlap
ping? On 12/6/18 12:58 PM, Randy Dunlap wrote: > From: Randy Dunlap > > Fix kernel-doc warnings in FTM due to missing "struct" keyword. > > Fixes 109 warnings from : > ../include/net/cfg80211.h:2838: warning: cannot understand function > prototype: 'struct cfg80211_ftm_responder_stats ' > > a

linux-next: build failure after merge of the net-next tree

2018-12-16 Thread Stephen Rothwell
Hi all, After merging the net-next tree, today's linux-next build (arm multi_v7_defconfig) failed like this: In file included from net/core/dev.c:148: net/core/dev.c: In function 'napi_gro_complete': net/core/dev.c:5364:26: error: 'inet_gro_complete' undeclared (first use in this function); did

[PATCH] man: ss: fix typos about wscale

2018-12-16 Thread Masatake YAMATO
Signed-off-by: Masatake YAMATO --- man/man8/ss.8 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/man8/ss.8 b/man/man8/ss.8 index 699a1271..f138c91a 100644 --- a/man/man8/ss.8 +++ b/man/man8/ss.8 @@ -163,7 +163,7 @@ the congestion algorithm name, the default congestion alg

linux-next: manual merge of the net-next tree with the net tree

2018-12-16 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: net/ipv6/ip6_output.c between commit: 8203e2d844d3 ("net: clear skb->tstamp in forwarding paths") from the net tree and commit: f839a6c92504 ("net: Do not route unicast IP packets twice") from the net-next tree.

linux-next: manual merge of the net-next tree with the net tree

2018-12-16 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/ethernet/mellanox/mlx5/core/en_tc.c between commit: 154e62abe9cd ("net/mlx5e: Properly initialize flow attributes for slow path eswitch rule deletion") from the net tree and commit: e88afe759a49 ("net/

linux-next: manual merge of the net-next tree with the net tree

2018-12-16 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/crypto/chelsio/chtls/chtls_cm.c between commit: 0c3a16be700e ("crypto/chelsio/chtls: send/recv window update") from the net tree and commit: 02d805dc5fe3 ("cxgb4: use new fw interface to get the VIN and smt

wohltätige Spende von 2.000.000 euro

2018-12-16 Thread Tayeb Souami
-- Lieber Freund, Ich bin Herr Tayeb Souami, New Jersey, Vereinigte Staaten von Amerika, der Mega-Gewinner von $ 315million In Mega Millions Jackpot, spende ich an 5 zufällige Personen, wenn Sie diese E-Mail erhalten, dann wurde Ihre E-Mail nach einem Spinball ausgewählt.Ich habe den größte

linux-next: manual merge of the rdma tree with the net tree

2018-12-16 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the rdma tree got a conflict in: include/linux/mlx5/mlx5_ifc.h between commit: 663f146f2ecf ("net/mlx5: E-Switch, Fix fdb cap bits swap") from the net tree and commit: c74d90c11c05 ("net/mlx5: Fix offsets of ifc reserved fields") from the rdma tree.

Re: [PATCH 0/3]: net: dsa: mt7530: support MT7530 in the MT7621 SoC

2018-12-16 Thread Florian Fainelli
On December 16, 2018 3:19:22 PM PST, NeilBrown wrote: >On Sun, Dec 16 2018, David Miller wrote: > >> From: NeilBrown >> Date: Mon, 17 Dec 2018 09:08:54 +1100 >> >>> In my 4.4 kernel, the build_skb() call in (the equivalent of) >>> mtk_poll_rx() takes about 1.2usec and the call to napi_gro_rece

[PATCH net-next 13/13] bnxt_en: query force speeds before disabling autoneg mode.

2018-12-16 Thread Michael Chan
From: Vasundhara Volam With autoneg enabled, PHY loopback test fails. To disable autoneg, driver needs to send a valid forced speed to FW. FW is not sending async event for invalid speeds. To fix this, query forced speeds and send the correct speed when disabling autoneg mode. Signed-off-by: Vas

[PATCH bpf-next 3/3] bpf: sk_msg, add tests for size field

2018-12-16 Thread John Fastabend
This adds tests to read the size field to test_verifier. Signed-off-by: John Fastabend --- tools/testing/selftests/bpf/test_verifier.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/tools/testing/selftests/bpf/test_verifier.c b/tools/testing/selftests/bpf/

[PATCH bpf-next 0/3] add size field to sk_msg_md

2018-12-16 Thread John Fastabend
This adds a size field to the sk_msg_md data structure used by SK_MSG programs. Without this in the zerocopy case and in the copy case where multiple iovs are in use its difficult to know how much data can be pulled in. The normal method of reading data and data_end only give the current contiguous

[PATCH bpf-next 1/3] bpf: sockmap, metadata support for reporting size of msg

2018-12-16 Thread John Fastabend
This adds metadata to sk_msg_md for BPF programs to read the sk_msg size. When the SK_MSG program is running under an application that is using sendfile the data is not copied into sk_msg buffers by default. Rather the BPF program uses sk_msg_pull_data to read the bytes in. This avoids doing the c

[PATCH net-next 04/13] bnxt_en: Do not modify max_stat_ctxs after RDMA driver requests/frees stat_ctxs

2018-12-16 Thread Michael Chan
From: Vasundhara Volam Calling bnxt_set_max_func_stat_ctxs() to modify max stat_ctxs requested or freed by the RDMA driver is wrong. After introducing reservation of resources recently, the driver has to keep track of all stat_ctxs including the ones used by the RDMA driver. This will provide a

[PATCH bpf-next 2/3] bpf: add tools lib/include support sk_msg_md size field

2018-12-16 Thread John Fastabend
Add the size field to sk_msg_md for tools. Signed-off-by: John Fastabend --- tools/include/uapi/linux/bpf.h | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.h index 597afdb..498badc 100644 --- a/tools/include/uapi/linux/bpf.h +++ b

[PATCH net-next 03/13] bnxt_en: get rid of num_stat_ctxs variable

2018-12-16 Thread Michael Chan
From: Vasundhara Volam For bnxt_en driver, stat_ctxs created will always be same as cp_nr_rings. Remove extra variable that duplicates the value. Also introduce bnxt_get_avail_stat_ctxs_for_en() helper to get available stat_ctxs and bnxt_get_ulp_stat_ctxs() helper to return number of stat_ctxs us

[PATCH net-next 12/13] bnxt_en: Do not free port statistics buffer when device is down.

2018-12-16 Thread Michael Chan
Port statistics which include RDMA counters are useful even when the netdevice is down. Do not free the port statistics DMA buffers when the netdevice is down. This is keep the snapshot of the port statistics and counters will just continue counting when the netdevice goes back up. Split the bnx

[PATCH net-next 05/13] bnxt_en: Reserve 1 stat_ctx for RDMA driver.

2018-12-16 Thread Michael Chan
From: Vasundhara Volam bnxt_en requires same number of stat_ctxs as CP rings but RDMA requires only 1 stat_ctx. Also add a new parameter resv_stat_ctxs to better keep track of stat_ctxs reserved including resources used by RDMA. Add a stat_ctxs parameter to all the relevant resource reservation

[PATCH net-next 10/13] bnxt_en: Return linux standard errors in bnxt_ethtool.c

2018-12-16 Thread Michael Chan
From: Vasundhara Volam Currently firmware specific errors are returned directly in flash_device and reset ethtool hooks. Modify it to return linux standard errors to userspace when flashing operations fail. Signed-off-by: Vasundhara Volam Signed-off-by: Michael Chan --- drivers/net/ethernet/b

[PATCH net-next 09/13] bnxt_en: Don't set ETS on unused TCs.

2018-12-16 Thread Michael Chan
Currently, the code allows ETS bandwidth weight 0 to be set on unused TCs. We should not set any DCB parameters on unused TCs at all. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/

[PATCH net-next 00/13] bnxt_en: Updates for net-next.

2018-12-16 Thread Michael Chan
Two main changes in this seris plus some miscellaneous changes. 1. Improvements and fixes for resource accounting which are required for enabling SR-IOV and RDMA on the new 57500 chips. Only SR-IOV for 57500 chips is enabled in this series. 2. New statistics counters and improvements to keep the

[PATCH net-next 01/13] bnxt_en: Store the maximum NQs available on the PF.

2018-12-16 Thread Michael Chan
The PF has a pool of NQs and MSIX vectors assigned to it based on NVRAM configurations. The number of usable MSIX vectors on the PF is the minimum of the NQs and MSIX vectors. Any excess NQs without associated MSIX may be used for the VFs, so we need to store this max_nqs value. max_nqs minus th

[PATCH net-next 06/13] bnxt_en: Disable MSIX before re-reserving NQs/CMPL rings.

2018-12-16 Thread Michael Chan
When bringing up a device, the code checks to see if the number of MSIX has changed. pci_disable_msix() should be called first before changing the number of reserved NQs/CMPL rings. This ensures that the MSIX vectors associated with the NQs/CMPL rings are still properly mapped when pci_disable_ms

[PATCH net-next 11/13] bnxt_en: Save ring statistics before reset.

2018-12-16 Thread Michael Chan
With the current driver, the statistics reported by .ndo_get_stats64() are reset when the device goes down. Store a snapshot of the rtnl_link_stats64 before shutdown. This snapshot is added to the current counters in .ndo_get_stats64() so that the counters will not get reset when the device is do

[PATCH net-next 02/13] bnxt_en: Add bnxt_get_avail_cp_rings_for_en() helper function.

2018-12-16 Thread Michael Chan
The available CP rings are calculated differently on the new 57500 chips, so add this helper to do this calculation correctly. The VFs will be assigned these available CP rings. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 13 - drivers/net/ether

[PATCH net-next 08/13] bnxt_en: Add ethtool -S priority counters.

2018-12-16 Thread Michael Chan
Display the CoS counters as additional priority counters by looking up the priority to CoS queue mapping. If the TX extended port statistics block size returned by firmware is big enough to cover the CoS counters, then we will display the new priority counters. We call firmware to get the up-to-d

[PATCH net-next 07/13] bnxt_en: Add SR-IOV support for 57500 chips.

2018-12-16 Thread Michael Chan
There are some minor differences when assigning VF resources on the new chips. The MSIX (NQ) resource has to be assigned and ring group is not needed on the new chips. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 7 +-- drivers/net/ethernet/broadcom/bnx

[PATCH net-next v2] net: dccp: initialize (addr,port) listening hashtable

2018-12-16 Thread Peter Oskolkov
Commit d9fbc7f6431f "net: tcp: prefer listeners bound to an address" removes port-only listener lookups. This caused segfaults in DCCP lookups because DCCP did not initialize the (addr,port) hashtable. This patch adds said initialization. The only non-trivial issue here is the size of the new has

Re: [PATCH net] net: mvneta: fix operation for 64K PAGE_SIZE

2018-12-16 Thread Marcin Wojtas
Hi David, niedz., 16 gru 2018 o 21:41 David Miller napisał(a): > > From: Marcin Wojtas > Date: Tue, 11 Dec 2018 13:56:49 +0100 > > > Recent changes in the mvneta driver reworked allocation > > and handling of the ingress buffers to use entire pages. > > Apart from that in SW BM scenario the HW m

Re: [PATCH net-next 00/12] mlxsw: spectrum_acl: Add Bloom filter support

2018-12-16 Thread David Miller
From: Ido Schimmel Date: Sun, 16 Dec 2018 08:49:23 + > Nir says: > > Spectrum-2 uses Bloom filter to reduce the number of lookups in the > algorithmic TCAM (A-TCAM). HW performs multiple exact match lookups in a > given region using a key composed of { packet & mask, mask ID, region ID }. >

Re: [PATCH 0/3]: net: dsa: mt7530: support MT7530 in the MT7621 SoC

2018-12-16 Thread NeilBrown
On Sun, Dec 16 2018, David Miller wrote: > From: NeilBrown > Date: Mon, 17 Dec 2018 09:08:54 +1100 > >> In my 4.4 kernel, the build_skb() call in (the equivalent of) >> mtk_poll_rx() takes about 1.2usec and the call to napi_gro_receive() >> takes about 3usec. >> >> In my 4.20 kernel, these calls

[PATCH] net/smc: fix TCP fallback socket release

2018-12-16 Thread Myungho Jung
clcsock can be released while kernel_accept() references it in TCP listen worker. Also, clcsock needs to wake up before released if TCP fallback is used and the clcsock is blocked by accept. Add a lock to safely release clcsock and call kernel_sock_shutdown() to wake up clcsock from accept in smc_r

Re: [PATCH net-next v3 0/4] rtnl fdb get

2018-12-16 Thread David Miller
From: Roopa Prabhu Date: Sat, 15 Dec 2018 22:35:07 -0800 > From: Roopa Prabhu > > This series adds support for rtnl fdb get similar to > route get. > > v2: add nda_policy, fixes to exact msgs, strict nlmsg parsing > > v3: remove unnecessary attribute length checks + simplify code > as pointed

Re: [PATCH V3 0/3] net: dsa: ksz: Clean up the tag code in prep for more switches

2018-12-16 Thread David Miller
From: Marek Vasut Date: Sat, 15 Dec 2018 01:58:03 +0100 > Clean up the KSZ DSA tag code in preparation for adding more switches. Series applied, thank you.

Re: [PATCH net 1/2] net: bpfilter: restart bpfilter_umh when error occurred

2018-12-16 Thread David Miller
From: Taehee Yoo Date: Sat, 15 Dec 2018 13:22:39 +0900 > If bpfilter_umh process is killed, shutdown_umh() is executed via > __stop_umh(). > because, __kernel_write() or kernel_read() will be failed in > __bpfilter_process_sockopt() if bpfilter_umh process had killed > or crashed. then, __bpfilt

Re: [PATCH 0/3]: net: dsa: mt7530: support MT7530 in the MT7621 SoC

2018-12-16 Thread David Miller
From: NeilBrown Date: Mon, 17 Dec 2018 09:08:54 +1100 > In my 4.4 kernel, the build_skb() call in (the equivalent of) > mtk_poll_rx() takes about 1.2usec and the call to napi_gro_receive() > takes about 3usec. > > In my 4.20 kernel, these calls take about 30 and 24 usec respectively. > This easi

Re: [PATCH 0/3]: net: dsa: mt7530: support MT7530 in the MT7621 SoC

2018-12-16 Thread NeilBrown
On Tue, Dec 11 2018, NeilBrown wrote: > > I got your patch working on 4.20-rc5 and did a performance comparison. > With the staging driver (using iperf3) I get > 220 MBit/sec in > 680 MBit/sec out > > with the patched mainline driver I get > 190 MBit/sec in >93 MBit/sec out > > (numbers

Re: [PATCH net-next v3 1/4] net: rtnetlink: support for fdb get

2018-12-16 Thread David Ahern
On 12/15/18 11:35 PM, Roopa Prabhu wrote: > From: Roopa Prabhu > > This patch adds support for fdb get similar to > route get. arguments can be any of the following (similar to fdb > add/del/dump): > [bridge, mac, vlan] or > [bridge_port, mac, vlan, flags=[NTF_MASTER]] or > [dev, mac, [vni|vlan]

Re: [PATCH iproute2 v3 4/4] testsuite: remove gre kmods if the test loads them

2018-12-16 Thread Petr Vorel
Hi Luca, > Signed-off-by: Luca Boccassi > Reviewed-by: Petr Vorel Tested-by: Petr Vorel > --- > v2: applied suggestions from Petr to simplify the modules parsing/unloading > v3: ditto, added reviewed-by tag Kind regards, Petr

Re: [PATCH/RFT net] ravb: expand rx descriptor data to accommodate hw checksum

2018-12-16 Thread Simon Horman
On Mon, Dec 10, 2018 at 07:56:14PM +0300, Sergei Shtylyov wrote: > Hello! > > On 12/10/2018 11:59 AM, Simon Horman wrote: > > > From: Simon Horman > > > > EtherAVB may provide a checksum of packet data appended to packet data. In > > order to allow this checksum to be received by the host descr

Re: [PATCH iproute2 v2 4/4] testsuite: remove gre kmods if the test loads them

2018-12-16 Thread Luca Boccassi
On Sun, 2018-12-16 at 21:21 +0100, Petr Vorel wrote: > Hi Luca, > > Reviewed-by: Petr Vorel > LGTM, but I'd suggest 2 small changes (see bellow). > > > +++ b/testsuite/tests/ip/tunnel/add_tunnel.t > >  TUNNEL_NAME="tunnel_test_ip" > > I'd put KMODS here: > KMODS="ip6_gre ip6_tunnel ip_gre ip_tu

[PATCH iproute2 v3 4/4] testsuite: remove gre kmods if the test loads them

2018-12-16 Thread Luca Boccassi
The tunnel test leaves behind link devices created by the GRE kernel modules: $ ip -br link ... gre0@NONEDOWN 0.0.0.0 gretap0@NONE DOWN 00:00:00:00:00:00 erspan0@NONE DOWN 00:00:00:00:00:00 ip6tnl0@NONE DOWN :: ip6gre0@NONE DOWN 00:00:00:00: $ lsmod | grep gre ip6_gre 40960 0 ip6_tu

[PATCH iproute2 v3 2/4] testsuite: declare dependency between $(TESTS) and generate_nlmsg

2018-12-16 Thread Luca Boccassi
Parallel make from the top level directory fails since tests are at the same time as generate_nlmsg: $ make check -j4 ... cd testsuite && make && make alltests echo "Entering iproute2" && cd iproute2 && make configure && cd ..; Entering iproute2 make -C tools Removing results dir ... make[1]: ./

[PATCH iproute2 v3 3/4] testsuite: delete dummy interface after default route test

2018-12-16 Thread Luca Boccassi
Signed-off-by: Luca Boccassi Reviewed-by: Petr Vorel --- v2: fixed copypasta in log message v3: added reviewed-by tag testsuite/tests/ip/route/add_default_route.t | 2 ++ 1 file changed, 2 insertions(+) diff --git a/testsuite/tests/ip/route/add_default_route.t b/testsuite/tests/ip/route/add_d

[PATCH iproute2 v3 1/4] Makefile: have check target depend on all

2018-12-16 Thread Luca Boccassi
Otherwise it will simply fail immediately from a just-cleaned workspace: $ make check -j1 cd testsuite && make && make alltests echo "Entering iproute2" && cd iproute2 && make configure && cd ..; Entering iproute2 make -C tools Makefile:3: ../../config.mk: No such file or directory make[2]: *** No

Re: [PATCH net-next] nfp: abm: allow to opt-out of RED offload

2018-12-16 Thread David Miller
From: Jakub Kicinski Date: Fri, 14 Dec 2018 15:01:54 -0800 > FW team asks to be able to not support RED even if NIC is capable > of buffering for testing and experimentation. Add an opt-out flag. > > Signed-off-by: Jakub Kicinski > Reviewed-by: Dirk van der Merwe Applied, thanks Jakub.

Re: [PATCH net] net: mvneta: fix operation for 64K PAGE_SIZE

2018-12-16 Thread David Miller
From: Marcin Wojtas Date: Tue, 11 Dec 2018 13:56:49 +0100 > Recent changes in the mvneta driver reworked allocation > and handling of the ingress buffers to use entire pages. > Apart from that in SW BM scenario the HW must be informed > via PRXDQS about the biggest possible incoming buffer > that

Re: [PATCH net-next 1/2] net: dccp: initialize (addr,port) listening hashtable

2018-12-16 Thread David Miller
From: David Miller Date: Sun, 16 Dec 2018 12:14:50 -0800 (PST) > From: Peter Oskolkov > Date: Sat, 15 Dec 2018 14:27:23 -0800 > >> Commit d9fbc7f6431f "net: tcp: prefer listeners bound to an address" >> removes port-only listener lookups. This caused segfaults in DCCP >> lookups because DCCP di

Re: [PATCH iproute2 v2 4/4] testsuite: remove gre kmods if the test loads them

2018-12-16 Thread Petr Vorel
Hi Luca, Reviewed-by: Petr Vorel LGTM, but I'd suggest 2 small changes (see bellow). > +++ b/testsuite/tests/ip/tunnel/add_tunnel.t > TUNNEL_NAME="tunnel_test_ip" I'd put KMODS here: KMODS="ip6_gre ip6_tunnel ip_gre ip_tunnel gre" The reason is maintenance of this script - maybe one day there

Re: [PATCH net-next 0/5] tcp: Introduce a TFO key-pool for clean cookie-rotation

2018-12-16 Thread David Miller
From: Christoph Paasch Date: Fri, 14 Dec 2018 14:40:02 -0800 > Currently, TFO only allows a single TFO-secret. This means that whenever > the secret gets changed for key-rotation purposes, all the previously > issued TFO-cookies become invalid. This means that clients will fallback > to "regular"

Re: [PATCH net-next] neighbor: Add protocol attribute

2018-12-16 Thread David Miller
From: David Ahern Date: Sat, 15 Dec 2018 14:09:06 -0800 > From: David Ahern > > Similar to routes and rules, add protocol attribute to neighbor entries > for easier tracking of how each was created. > > Signed-off-by: David Ahern Applied, thanks David.

Re: [PATCH net-next 2/2] selftests: net: reuseport_addr_any: add DCCP

2018-12-16 Thread David Miller
From: Peter Oskolkov Date: Sat, 15 Dec 2018 14:27:24 -0800 > This patch adds coverage of DCCP to reuseport_addr_any selftest. > > Signed-off-by: Peter Oskolkov Applied.

Re: [PATCH net-next 1/2] net: dccp: initialize (addr,port) listening hashtable

2018-12-16 Thread David Miller
From: Peter Oskolkov Date: Sat, 15 Dec 2018 14:27:23 -0800 > Commit d9fbc7f6431f "net: tcp: prefer listeners bound to an address" > removes port-only listener lookups. This caused segfaults in DCCP > lookups because DCCP did not initialize the (addr,port) hashtable. > > This patch adds said init

Re: [PATCH iproute2 v2 3/4] testsuite: delete dummy interface after default route test

2018-12-16 Thread Petr Vorel
Hi Luca, > Signed-off-by: Luca Boccassi Reviewed-by: Petr Vorel > --- > v2: fixed copypasta in log message Kind regards, Petr

Re: [Patch net 00/10] net: hns: Code improvements & fixes for HNS driver

2018-12-16 Thread David Miller
From: Peng Li Date: Sat, 15 Dec 2018 11:53:19 +0800 > This patchset introduces some code improvements and fixes > for the identified problems in the HNS driver. > > Every patch is independent. Series applied, thank you.

Re: [PATCH net-next v3 0/4] net: mitigate retpoline overhead

2018-12-16 Thread Willem de Bruijn
On Sun, Dec 16, 2018 at 2:19 PM David Miller wrote: > > From: Paolo Abeni > Date: Sun, 16 Dec 2018 19:55:40 +0100 > > > Again, I messed it! I'm really sorry to waste everybody's time. > > I was unable to give proper coverage with different configs. I tested > > vs.: > > > > CONFIG_IPV6=ymn > > CO

Re: [PATCH 0/7] ethtool: add pretty dump for DSA mv88e6xxx drivers

2018-12-16 Thread Andrew Lunn
> > Hi Florian, Vivien > > > > I was wondering about that. Having this all under 'dsa' seems too > > granular. It would be better if we could have 'mv88e6xxx', 'b53', > > 'ksz', etc. That might need a new DSA driver op to get the driver name > > which we then use for the slave? > > We could indee

Re: [PATCH net-next 0/3] vhost: accelerate metadata access through vmap()

2018-12-16 Thread Michael S. Tsirkin
On Sat, Dec 15, 2018 at 11:43:08AM -0800, David Miller wrote: > From: Jason Wang > Date: Fri, 14 Dec 2018 12:29:54 +0800 > > > > > On 2018/12/14 上午4:12, Michael S. Tsirkin wrote: > >> On Thu, Dec 13, 2018 at 06:10:19PM +0800, Jason Wang wrote: > >>> Hi: > >>> > >>> This series tries to access vi

Re: [PATCH] test_rhashtable: remove semaphore usage

2018-12-16 Thread Arnd Bergmann
On Fri, Dec 14, 2018 at 10:25 PM David Miller wrote: > > From: Arnd Bergmann > Date: Mon, 10 Dec 2018 22:17:20 +0100 > > > @@ -635,8 +636,9 @@ static int threadfunc(void *data) > > int i, step, err = 0, insert_retries = 0; > > struct thread_data *tdata = data; > > > > - up(&presta

[PATCH] [v2] test_rhashtable: remove semaphore usage

2018-12-16 Thread Arnd Bergmann
This is one of only two files that initialize a semaphore to a negative value. We don't really need the two semaphores here at all, but can do the same thing in more conventional and more effient way, by using a single waitqueue and an atomic thread counter. This gets us a little bit closer to eli

Re: [PATCH] vhost: return EINVAL if iovecs size does not match the message size

2018-12-16 Thread Michael S. Tsirkin
On Sat, Dec 15, 2018 at 11:46:11AM -0800, David Miller wrote: > From: Pavel Tikhomirov > Date: Thu, 13 Dec 2018 17:53:50 +0300 > > > We've failed to copy and process vhost_iotlb_msg so let userspace at > > least know about it. For instance before these patch the code below runs > > without any er

Re: [PATCH 2/2] l2tp: Add Protocol field compression

2018-12-16 Thread Guillaume Nault
On Sun, Dec 16, 2018 at 08:46:19PM +0200, Sam Protsenko wrote: > Hi Guillaume, > > On Sun, Dec 16, 2018 at 6:30 PM Guillaume Nault wrote: > > > > On Fri, Dec 14, 2018 at 11:12:42PM +0200, Sam Protsenko wrote: > > > When Protocol Field Compression (PFC) is enabled, the "Protocol" field > > > in PP

Re: [PATCH] l2tp: Add protocol field decompression

2018-12-16 Thread Guillaume Nault
On Sun, Dec 16, 2018 at 08:36:42PM +0200, Sam Protsenko wrote: > Hi Guillaume, > > On Sun, Dec 16, 2018 at 6:29 PM Guillaume Nault wrote: > > > > If you all agree, can we please revert this patch and properly > > implement PFC in ppp_generic.c? > > How about instead of reverting I will try to pr

Re: [PATCH net-next v3 0/4] net: mitigate retpoline overhead

2018-12-16 Thread David Miller
From: Paolo Abeni Date: Sun, 16 Dec 2018 19:55:40 +0100 > Again, I messed it! I'm really sorry to waste everybody's time. > I was unable to give proper coverage with different configs. I tested > vs.: > > CONFIG_IPV6=ymn > CONFIG_INET=yn > > but > > # CONFIG_RETPOLINE is not set > > fooled me

Re: [PATCH net-next] net: ipv4: allocate ipv4_devconf memory for init_net

2018-12-16 Thread Cong Wang
On Sun, Dec 16, 2018 at 8:24 AM wrote: > > From: Tonghao Zhang > > The devconf setting on the init_net will affect other > namespace when them created. For example: > > $ cat /proc/sys/net/ipv4/conf/all/rp_filter > 0 > $ echo 2 > /proc/sys/net/ipv4/conf/all/rp_filter > $ cat /proc/sys/net/ipv4/co

Re: [PATCH net-next v3 0/4] net: mitigate retpoline overhead

2018-12-16 Thread Paolo Abeni
On Sat, 2018-12-15 at 13:23 -0800, David Miller wrote: > From: Paolo Abeni > Date: Fri, 14 Dec 2018 11:51:56 +0100 > > > The spectre v2 counter-measures, aka retpolines, are a source of measurable > > overhead[1]. We can partially address that when the function pointer refers > > to > > a builti

Re: [PATCH net-next v2 01/17] net: sched: refactor mini_qdisc_pair_swap() to use workqueue

2018-12-16 Thread Cong Wang
On Sun, Dec 16, 2018 at 8:32 AM Vlad Buslov wrote: > > On Thu 13 Dec 2018 at 23:32, Cong Wang wrote: > > On Tue, Dec 11, 2018 at 2:19 AM Vlad Buslov wrote: > >> > >> As a part of the effort to remove dependency on rtnl lock, cls API is being > >> converted to use fine-grained locking mechanisms

Re: [PATCH 2/2] l2tp: Add Protocol field compression

2018-12-16 Thread Sam Protsenko
Hi Guillaume, On Sun, Dec 16, 2018 at 6:30 PM Guillaume Nault wrote: > > On Fri, Dec 14, 2018 at 11:12:42PM +0200, Sam Protsenko wrote: > > When Protocol Field Compression (PFC) is enabled, the "Protocol" field > > in PPP packet should be transmitted without leading 0x00. See section > > 6.5 in R

  1   2   >