From: David Miller <da...@davemloft.net> Date: Sun, 16 Dec 2018 12:14:50 -0800 (PST)
> From: Peter Oskolkov <p...@google.com> > Date: Sat, 15 Dec 2018 14:27:23 -0800 > >> Commit d9fbc7f6431f "net: tcp: prefer listeners bound to an address" >> removes port-only listener lookups. This caused segfaults in DCCP >> lookups because DCCP did not initialize the (addr,port) hashtable. >> >> This patch adds said initialization. >> >> The only non-trivial issue here is the size of the new hashtable. >> It seemed reasonable to make it match the size of the port-only >> hashtable (= INET_LHTABLE_SIZE) that was used previously. Other >> parameters to inet_hashinfo2_init() match those used in TCP. >> >> Tested: syzcaller issues fixed; the second patch in the patchset >> tests that DCCP lookups work correctly. >> >> Fixes: d9fbc7f6431f "net: tcp: prefer listeners bound to an address" >> Reported-by: syzcaller <syzkal...@googlegroups.com> >> Signed-off-by: Peter Oskolkov <p...@google.com> > > Applied. I had to revert, please test with dccp being modular: ERROR: "inet_hashinfo2_init" [net/dccp/dccp.ko] undefined! make[1]: *** [scripts/Makefile.modpost:92: __modpost] Error 1
