[PATCH net-next] add documents for snmp counters

2018-11-25 Thread yupeng
Add explaination of below counters: TcpExtTCPRcvCoalesce TcpExtTCPAutoCorking TcpExtTCPOrigDataSent TCPSynRetrans TCPFastOpenActiveFail TcpExtListenOverflows TcpExtListenDrops TcpExtTCPHystartTrainDetect TcpExtTCPHystartTrainCwnd TcpExtTCPHystartDelayDetect TcpExtTCPHystartDelayCwnd Signed-off-by:

RE: [PATCH net-next 1/8] dpaa2-eth: Add basic XDP support

2018-11-25 Thread Ioana Ciocoi Radulescu
> -Original Message- > From: David Ahern > Sent: Saturday, November 24, 2018 11:49 PM > To: Ioana Ciocoi Radulescu ; > netdev@vger.kernel.org; da...@davemloft.net > Cc: Ioana Ciornei > Subject: Re: [PATCH net-next 1/8] dpaa2-eth: Add basic XDP support > > On 11/23/18 9:56 AM, Ioana Cioco

[PATCH v2 0/4] Macb power management support for ZynqMP

2018-11-25 Thread Harini Katakam
This series adds support for macb suspend/resume with system power down. In relation to the above, this series also updates mdio_read/write function for PM and adds tsu clock management. Harini Katakam (4): net: macb: Check MDIO state before read/write and use timeouts net: macb: Support clock

[PATCH v2 1/4] net: macb: Check MDIO state before read/write and use timeouts

2018-11-25 Thread Harini Katakam
From: Harini Katakam Replace the while loop in MDIO read/write functions with a timeout. In addition, add a check for MDIO bus busy before initiating a new operation as well to make sure there is no ongoing MDIO operation. Signed-off-by: Shubhrajyoti Datta Signed-off-by: Sai Pavan Boddu Signed

[PATCH v2 4/4] net: macb: Add support for suspend/resume with full power down

2018-11-25 Thread Harini Katakam
When macb device is suspended and system is powered down, the clocks are removed and hence macb should be closed gracefully and restored upon resume. This patch does the same by switching off the net device, suspending phy and performing necessary cleanup of interrupts and BDs. Upon resume, all the

[PATCH v2 3/4] net: macb: Add pm runtime support

2018-11-25 Thread Harini Katakam
From: Harini Katakam Add runtime pm functions and move clock handling there. Add runtime PM calls to mdio functions to allow for active mdio bus. Signed-off-by: Shubhrajyoti Datta Signed-off-by: Harini Katakam --- v2 changes: Allow for mdio bus to be active Changes from RFC: Updated pm get sy

[PATCH v2 2/4] net: macb: Support clock management for tsu_clk

2018-11-25 Thread Harini Katakam
From: Harini Katakam TSU clock needs to be enabled/disabled as per support in devicetree and it should also be controlled during suspend/resume (WOL has no dependency on this clock). Signed-off-by: Harini Katakam --- v2: No changes drivers/net/ethernet/cadence/macb.h | 3 ++- drivers/ne

Re: hard-coded limit on unresolved multicast route cache in ipv4/ipmr.c causes slow, unreliable creation of multicast routes on busy networks

2018-11-25 Thread Hangbin Liu
On Mon, Nov 26, 2018 at 10:44:49AM +0530, Sukumar Gopalakrishnan wrote: > Hi, > >  There is a patch to make this queue len configurable. Is below mentioned > going > to be applied ? > > http://lkml.iu.edu/hypermail/linux/kernel/1810.3/02344.html Thanks for this reminder, I saw Stephen has gave

[PATCH net] sctp: increase sk_wmem_alloc when head->truesize is increased

2018-11-25 Thread Xin Long
I changed to count sk_wmem_alloc by skb truesize instead of 1 to fix the sk_wmem_alloc leak caused by later truesize's change in xfrm in Commit 02968ccf0125 ("sctp: count sk_wmem_alloc by skb truesize in sctp_packet_transmit"). But I should have also increased sk_wmem_alloc when head->truesize is

Re: [PATCH] mm: Replace all open encodings for NUMA_NO_NODE

2018-11-25 Thread Anshuman Khandual
On 11/24/2018 07:35 PM, Vinod Koul wrote: > On 23-11-18, 15:24, Anshuman Khandual wrote: > >> --- a/drivers/dma/dmaengine.c >> +++ b/drivers/dma/dmaengine.c >> @@ -386,7 +386,8 @@ EXPORT_SYMBOL(dma_issue_pending_all); >> static bool dma_chan_is_local(struct dma_chan *chan, int cpu) >> { >>

[PATCH rdma-next 6/7] IB/mlx5: Update the supported DEVX commands

2018-11-25 Thread Leon Romanovsky
From: Yishai Hadas Update the supported DEVX commands, it includes adding to the query/modify command's list and to the encoding handling. In addition, a valid range for general commands was added to be used for future commands. Signed-off-by: Yishai Hadas Reviewed-by: Artemy Kovalyov Signed-

[PATCH rdma-next 7/7] IB/mlx5: Allow XRC usage via verbs in DEVX context

2018-11-25 Thread Leon Romanovsky
From: Yishai Hadas Allows XRC usage from the verbs flow in a DEVX context. As XRCD is some shared kernel resource between processes it should be created with UID=0 to point on that. As a result once XRC QP/SRQ are created they must be used as well with UID=0 so that firmware will allow the XRCD

[PATCH rdma-next 5/7] IB/mlx5: Enforce DEVX privilege by firmware

2018-11-25 Thread Leon Romanovsky
From: Yishai Hadas Enforce DEVX privilege by firmware, this enables future device functionality without the need to make driver changes unless a new privilege type will be introduced. Signed-off-by: Yishai Hadas Reviewed-by: Artemy Kovalyov Signed-off-by: Leon Romanovsky --- drivers/infiniba

[PATCH mlx5-next 1/7] net/mlx5: Update mlx5_ifc with DEVX UCTX capabilities bits

2018-11-25 Thread Leon Romanovsky
From: Yishai Hadas Expose device capabilities for DEVX user context, it includes which caps the device is supported and a matching bit to set as part of user context creation. Signed-off-by: Yishai Hadas Reviewed-by: Artemy Kovalyov Signed-off-by: Leon Romanovsky --- include/linux/mlx5/mlx5_

[PATCH rdma-next 0/7] Enrich DEVX support

2018-11-25 Thread Leon Romanovsky
From: Leon Romanovsky >From Yishai, --- This series enriches DEVX support in few aspects: it enables interoperability between DEVX and verbs and improves mechanism for controlling privileged DEVX commands. The first patch updates mlx5 ifc file. Next 3 patches ena

[PATCH rdma-next 3/7] IB/core: Enable getting an object type from a given uobject

2018-11-25 Thread Leon Romanovsky
From: Yishai Hadas Enable getting an object type from a given uobject, the type is saved upon tree merging and is returned as part of some helper function. Signed-off-by: Yishai Hadas Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/rdma_core.h | 5 - drivers/infiniband/core/

[PATCH rdma-next 4/7] IB/mlx5: Enable modify and query verbs objects via DEVX

2018-11-25 Thread Leon Romanovsky
From: Yishai Hadas Enables modify and query verbs objects via the DEVX interface. To support this the above DEVX handlers were changed to get any object type via the UVERBS_IDR_ANY_OBJECT mechanism. The type checking and handling is done per object as part of the driver code. Signed-off-by: Yis

[PATCH rdma-next 2/7] IB/core: Introduce UVERBS_IDR_ANY_OBJECT

2018-11-25 Thread Leon Romanovsky
From: Yishai Hadas Introduce the UVERBS_IDR_ANY_OBJECT type to match any IDR object. Once used, the infrastructure skips checking for the IDR type, it becomes the driver handler responsibility. This enables drivers to get in a given method an object from various of types. Signed-off-by: Yishai

Re: [PATCH net-next] net: remove unsafe skb_insert()

2018-11-25 Thread Eric Dumazet
On 11/25/2018 07:52 PM, David Miller wrote: > > I fixed up the build in your original patch and am about to push that > out. Thanks David, sorry for this, I should have compiled the damn thing :/

Re: pull-request: bpf 2018-11-25

2018-11-25 Thread David Miller
From: Daniel Borkmann Date: Mon, 26 Nov 2018 01:16:51 +0100 > The following pull-request contains BPF updates for your *net* tree. Pulled, thanks.

Re: [PATCH net 1/2] virtio-net: disable guest csum during XDP set

2018-11-25 Thread Jason Wang
On 2018/11/24 上午4:01, David Miller wrote: From: Jason Wang Date: Thu, 22 Nov 2018 14:36:30 +0800 We don't disable VIRTIO_NET_F_GUEST_CSUM if XDP was set. This means we can receive partial csumed packets with metadata kept in the vnet_hdr. This may have several side effects: - It could be ov

Re: [PATCH net-next 3/3] vhost: don't touch avail ring if in_order is negotiated

2018-11-25 Thread Jason Wang
On 2018/11/23 下午11:41, Michael S. Tsirkin wrote: On Fri, Nov 23, 2018 at 11:00:16AM +0800, Jason Wang wrote: Device use descriptors table in order, so there's no need to read index from available ring. This eliminate the cache contention on avail ring completely. Well this isn't what the in o

Re: [PATCH net-next] net: remove unsafe skb_insert()

2018-11-25 Thread David Miller
From: Eric Dumazet Date: Sun, 25 Nov 2018 15:37:43 -0800 > On Sun, Nov 25, 2018 at 10:29 AM David Miller wrote: >> >> From: Eric Dumazet >> Date: Sun, 25 Nov 2018 08:26:23 -0800 >> >> > I do not see how one can effectively use skb_insert() without holding >> > some kind of lock. Otherwise other

Re: [PATCH net-next 2/3] vhost_net: support in order feature

2018-11-25 Thread Jason Wang
On 2018/11/23 下午11:49, Michael S. Tsirkin wrote: On Fri, Nov 23, 2018 at 11:00:15AM +0800, Jason Wang wrote: This makes vhost_net to support in order feature. This is as simple as use datacopy path when it was negotiated. An alternative is not to advertise in order when zerocopy is enabled whi

Re: [PATCH] net: ethernet: ti: cpsw: allow to configure min tx packet size

2018-11-25 Thread Andrew Lunn
On Sun, Nov 25, 2018 at 05:43:15PM -0600, Grygorii Strashko wrote: > For proper VLAN packets forwarding CPSW driver uses min tx packet size of > 64bytes (VLAN_ETH_ZLEN, excluding ETH_FCS) which was corrected by > commit 9421c9015047 ("net: ethernet: ti: cpsw: fix min eth packet size"). > > Unfortu

Re: [PATCH v3 2/2] arm64/bpf: don't allocate BPF JIT programs in module memory

2018-11-25 Thread kbuild test robot
Hi Ard, I love your patch! Perhaps something to improve: [auto build test WARNING on arm64/for-next/core] [also build test WARNING on v4.20-rc4 next-20181123] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/l

Re: [PATCH net-next] net: phy: fix two issues with linkmode bitmaps

2018-11-25 Thread Andrew Lunn
> Because function naming is the same I'm afraid they easily can be used > incorrectly (the bugs we just discuss are good examples). Maybe it > could be an option to reflect the semantics in the name like this > (better suited proposals welcome): > > case 1: mii_xxx_to_linkmode_yyy > case 2: mii_x

Re: consistency for statistics with XDP mode

2018-11-25 Thread Toshiaki Makita
On 2018/11/23 1:43, David Ahern wrote: > On 11/21/18 5:53 PM, Toshiaki Makita wrote: >>> We really need consistency in the counters and at a minimum, users >>> should be able to track packet and byte counters for both Rx and Tx >>> including XDP. >>> >>> It seems to me the Rx and Tx packet, byte an

Re: [PATCH bpf-next 1/3] bpf: helper to pop data from messages

2018-11-25 Thread Daniel Borkmann
On 11/23/2018 02:38 AM, John Fastabend wrote: > This adds a BPF SK_MSG program helper so that we can pop data from a > msg. We use this to pop metadata from a previous push data call. > > Signed-off-by: John Fastabend > --- > include/uapi/linux/bpf.h | 13 +++- > net/core/filter.c| 169

Re: [PATCH v2] media: bpf: add bpf function to report mouse movement

2018-11-25 Thread Daniel Borkmann
Hi Sean, On 11/23/2018 12:50 PM, Sean Young wrote: > Some IR remotes have a directional pad or other pointer-like thing that > can be used as a mouse. Make it possible to decode these types of IR > protocols in BPF. > > Cc: netdev@vger.kernel.org > Signed-off-by: Sean Young Is this patch target

Re: [PATCH bpf-next 0/3] bpf: add sk_msg helper sk_msg_pop_data

2018-11-25 Thread Daniel Borkmann
On 11/23/2018 02:38 AM, John Fastabend wrote: > After being able to add metadata to messages with sk_msg_push_data we > have also found it useful to be able to "pop" this metadata off before > sending it to applications in some cases. This series adds a new helper > sk_msg_pop_data() and the associ

Re: [PATCH bpf-next] bpf: align map type names formatting.

2018-11-25 Thread Daniel Borkmann
On 11/24/2018 12:58 AM, David Calavera wrote: > Make the formatting for map_type_name array consistent. > > Signed-off-by: David Calavera Applied, thanks!

Re: [PATCH] tags: Fix DEFINE_PER_CPU expansion

2018-11-25 Thread Daniel Borkmann
On 11/24/2018 12:48 AM, Rustam Kovhaev wrote: > Building tags produces warning: > ctags: Warning: kernel/bpf/local_storage.c:10: null expansion of name > pattern "\1" > > Let's use the same fix as in commit <25528213fe9f75f4>, even though it > violates the usual code style. > > Signed-off-by: R

Re: [PATCH] bpf: btf: fix spelling mistake "Memmber" -> "Member"

2018-11-25 Thread Daniel Borkmann
On 11/26/2018 12:32 AM, Colin King wrote: > From: Colin Ian King > > There is a spelling mistake in a btf_verifier_log_member message, > fix it. > > Signed-off-by: Colin Ian King Applied to bpf-next, thanks!

Re: [PATCH 7/8] socket: Add SO_TIMESTAMP[NS]_NEW

2018-11-25 Thread Willem de Bruijn
> > > The existing timestamp options: SO_TIMESTAMP* fail to provide proper > > > timestamps beyond year 2038 on 32 bit ABIs. > > > But, these work fine on 64 bit native ABIs. > > > So now we need a way of updating these timestamps so that we do not > > > break existing userspace: 64 bit ABIs should

[PATCH linux-next 07/10] ARM: dts: am4372: switch to use phy-gmii-sel

2018-11-25 Thread Grygorii Strashko
Switch to use phy-gmii-sel PHY instead of cpsw-phy-sel. Cc: Kishon Vijay Abraham I Cc: Tony Lindgren Signed-off-by: Grygorii Strashko --- arch/arm/boot/dts/am437x-l4.dtsi | 17 + arch/arm/boot/dts/am43x-epos-evm.dts | 5 + 2 files changed, 10 insertions(+), 12 deletion

[PATCH linux-next 08/10] ARM: dts: am335x: switch to use phy-gmii-sel

2018-11-25 Thread Grygorii Strashko
Switch to use phy-gmii-sel PHY instead of cpsw-phy-sel. Cc: Kishon Vijay Abraham I Cc: Tony Lindgren Signed-off-by: Grygorii Strashko --- arch/arm/boot/dts/am335x-baltos-ir2110.dts| 4 arch/arm/boot/dts/am335x-baltos-ir3220.dts| 4 arch/arm/boot/dts/am335x-baltos-ir

[PATCH linux-next 01/10] dt-bindings: phy: add cpsw port interface mode selection phy bindings

2018-11-25 Thread Grygorii Strashko
Add CPSW Port's Interface Mode Selection PHY (phy-gmii-sel) DT Bindings Cc: Kishon Vijay Abraham I Cc: Tony Lindgren Signed-off-by: Grygorii Strashko --- .../devicetree/bindings/phy/ti-phy-gmii-sel.txt| 68 ++ 1 file changed, 68 insertions(+) create mode 100644 Documen

[PATCH linux-next 06/10] ARM: dts: dm814x: switch to use phy-gmii-sel

2018-11-25 Thread Grygorii Strashko
Switch to use phy-gmii-sel PHY instead of cpsw-phy-sel. Cc: Kishon Vijay Abraham I Cc: Tony Lindgren Signed-off-by: Grygorii Strashko --- arch/arm/boot/dts/dm814x.dtsi | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/arch/arm/boot/dts/dm814x.dtsi b/arch/arm/b

[PATCH linux-next 00/10] net: ethernet: ti: cpsw: replace cpsw-phy-sel with phy driver

2018-11-25 Thread Grygorii Strashko
TI am335x/am437x/dra7(am5)/dm814x CPSW3G Ethernet Subsystem supports two 10/100/1000 Ethernet ports with selectable G/MII, RMII, and RGMII interfaces. The interface mode is selected by configuring the MII mode selection register(s) (GMII_SEL) in the System Control Module chapter (SCM).

pull-request: bpf 2018-11-25

2018-11-25 Thread Daniel Borkmann
Hi David, The following pull-request contains BPF updates for your *net* tree. The main changes are: 1) Fix an off-by-one bug when adjusting subprog start offsets after patching, from Edward. 2) Fix several bugs such as overflow in size allocation in queue / stack map creation, from Alexe

[PATCH linux-next 05/10] ARM: dts: dra7: switch to use phy-gmii-sel

2018-11-25 Thread Grygorii Strashko
Switch to use phy-gmii-sel PHY instead of cpsw-phy-sel. Cc: Kishon Vijay Abraham I Cc: Tony Lindgren Signed-off-by: Grygorii Strashko --- arch/arm/boot/dts/dra7-l4.dtsi | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/arch/arm/boot/dts/dra7-l4.dtsi b/arch/arm

[PATCH linux-next 09/10] dt-bindings: net: ti: deprecate cpsw-phy-sel bindings

2018-11-25 Thread Grygorii Strashko
The cpsw-phy-sel driver was replaced with new PHY driver phy-gmii-sel, so deprecate cpsw-phy-sel bindings. Cc: Kishon Vijay Abraham I Cc: Tony Lindgren Signed-off-by: Grygorii Strashko --- Documentation/devicetree/bindings/net/cpsw-phy-sel.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH linux-next 02/10] phy: ti: introduce phy-gmii-sel driver

2018-11-25 Thread Grygorii Strashko
TI am335x/am437x/dra7(am5)/dm814x CPSW3G Ethernet Subsystem supports two 10/100/1000 Ethernet ports with selectable G/MII, RMII, and RGMII interfaces. The interface mode is selected by configuring the MII mode selection register(s) (GMII_SEL) in the System Control Module chapter (SCM). GMII_SEL reg

[PATCH linux-next 04/10] net: ethernet: ti: cpsw: add support for port interface mode selection phy

2018-11-25 Thread Grygorii Strashko
Add support for port interface mode selection phy (phy-gmii-sel): - try to request interface mode selection phy from Port DT node and fail silently if not defined and old CONFIG_TI_CPSW_PHY_SEL driver enabled. - use new phy if requested successfully. Cc: Kishon Vijay Abraham I Cc: Tony Lindgren

[PATCH linux-next 03/10] dt-bindings: net: ti: cpsw: switch to use phy-gmii-sel phy

2018-11-25 Thread Grygorii Strashko
The cpsw-phy-sel driver was replaced with new PHY driver phy-gmii-sel, so deprecate cpsw-phy-sel bindings and update CPSW binding to use phy-gmii-sel PHY bindings. Cc: Kishon Vijay Abraham I Cc: Tony Lindgren Signed-off-by: Grygorii Strashko --- Documentation/devicetree/bindings/net/cpsw.txt |

[PATCH linux-next 10/10] net: ethernet: ti: cpsw: deprecate cpsw-phy-sel driver

2018-11-25 Thread Grygorii Strashko
Deprecate cpsw-phy-sel driver as it's been replaced with new TI phy-gmii-sel PHY driver. Cc: Kishon Vijay Abraham I Cc: Tony Lindgren Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/Kconfig | 6 +++--- drivers/net/ethernet/ti/cpsw.h | 6 ++ 2 files changed, 9 insertions(+), 3

[PATCH v2 net-next] net: remove unsafe skb_insert()

2018-11-25 Thread Eric Dumazet
I do not see how one can effectively use skb_insert() without holding some kind of lock. Otherwise other cpus could have changed the list right before we have a chance of acquiring list->lock. Only existing user is in drivers/infiniband/hw/nes/nes_mgt.c and this one probably meant to use __skb_ins

[PATCH net-next] net: ethernet: ti: cpsw: drop vid0 configuration in dual_mac mode

2018-11-25 Thread Grygorii Strashko
In dual_mac mode CPSW driver uses vid1 and vid2 by default to implement dual mac mode wich are used to configure pvids for each external ports. But, historicaly, it also adds vid0 to ALE table and sets "untag" bits for both ext. ports. As result, it's imposible to use priority tagged packets in dua

[PATCH] net: ethernet: ti: cpsw: allow to configure min tx packet size

2018-11-25 Thread Grygorii Strashko
For proper VLAN packets forwarding CPSW driver uses min tx packet size of 64bytes (VLAN_ETH_ZLEN, excluding ETH_FCS) which was corrected by commit 9421c9015047 ("net: ethernet: ti: cpsw: fix min eth packet size"). Unfortunately, this breaks some industrial automation protocols, as reported by TI c

Re: [PATCH net-next] net: remove unsafe skb_insert()

2018-11-25 Thread Eric Dumazet
On Sun, Nov 25, 2018 at 10:29 AM David Miller wrote: > > From: Eric Dumazet > Date: Sun, 25 Nov 2018 08:26:23 -0800 > > > I do not see how one can effectively use skb_insert() without holding > > some kind of lock. Otherwise other cpus could have changed the list > > right before we have a chance

[PATCH] bpf: btf: fix spelling mistake "Memmber" -> "Member"

2018-11-25 Thread Colin King
From: Colin Ian King There is a spelling mistake in a btf_verifier_log_member message, fix it. Signed-off-by: Colin Ian King --- kernel/bpf/btf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/bpf/btf.c b/kernel/bpf/btf.c index 69da9169819a..a09b2f94ab25 100644 ---

[PATCH] firestream: fix spelling mistake: "Inititing" -> "Initializing"

2018-11-25 Thread Colin King
From: Colin Ian King There are spelling mistakes in debug messages, fix them. Signed-off-by: Colin Ian King --- drivers/atm/firestream.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/atm/firestream.c b/drivers/atm/firestream.c index 4e46dc9e41ad..11e1663bdc4d

Re: WARNING: bad usercopy in corrupted (2)

2018-11-25 Thread Matthew Wilcox
On Sun, Nov 25, 2018 at 01:27:09PM -0800, Matthew Wilcox wrote: > On Sun, Nov 25, 2018 at 07:30:04AM -0800, syzbot wrote: > > Hello, > > > > syzbot found the following crash on: > > > > HEAD commit:aea0a897af9e ptp: Fix pass zero to ERR_PTR() in ptp_clock_.. > > git tree: net-next > >

Re: [PATCH net-next] net: remove unsafe skb_insert()

2018-11-25 Thread kbuild test robot
Hi Eric, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Eric-Dumazet/net-remove-unsafe-skb_insert/20181126-061342 config: x86_64-randconfig-x009-201847 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1

Re: [PATCH 7/8] socket: Add SO_TIMESTAMP[NS]_NEW

2018-11-25 Thread Arnd Bergmann
On Sun, Nov 25, 2018 at 3:33 PM Willem de Bruijn wrote: > On Sun, Nov 25, 2018 at 12:28 AM Deepa Dinamani > wrote: > > So failing here means adding a bunch of ifdef's to verify it is not > > executing on 64 bit arch or something like x32. > > The code as is adds branches on platforms that do not

[PATCH] rtlwifi: rtl8192de: fix spelling mistake "althougth" -> "although"

2018-11-25 Thread Colin King
From: Colin Ian King There is a spelling mistake in a RT_TRACE message, fix it. Signed-off-by: Colin Ian King --- drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c b/dri

[PATCH 05/13] net: stmmac: dwmac-rk: Do not print error when PHY regulator is not found

2018-11-25 Thread Otavio Salvador
The PHY regulator is optional, so when it is not present move the message level from error to debug, which is more appropriate. Signed-off-by: Otavio Salvador Signed-off-by: Fabio Berton --- drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d

[PATCH 04/13] net: stmmac: dwmac-rk: Do not print redundant error message

2018-11-25 Thread Otavio Salvador
rk_gmac_setup() already prints a message saying that the PHY regulator is not found, so we should not print it again. Signed-off-by: Otavio Salvador Signed-off-by: Fabio Berton --- drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --g

[PATCH 03/13] net: stmmac: dwmac-rk: Allow the driver to probe when phy-supply is not present

2018-11-25 Thread Otavio Salvador
The phy-supply is an optional regulator, so we should not treat as an error when phy-supply is not passed in the device tree. This allows the dwmac-rk driver to probe when phy-supply is not present in the dts. Signed-off-by: Otavio Salvador --- drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c |

Re: [PATCH 6/8] socket: Add struct sock_timeval

2018-11-25 Thread Arnd Bergmann
On Sun, Nov 25, 2018 at 5:52 AM Deepa Dinamani wrote: > On Sat, Nov 24, 2018 at 11:38 AM Willem de Bruijn > wrote: > > On Sat, Nov 24, 2018 at 4:00 AM Deepa Dinamani > > wrote: > > > > > > The new type is meant to be used as a y2038 safe structure > > > to be used as part of cmsg data. > > > P

Re: [PATCH net-next] net: phy: fix two issues with linkmode bitmaps

2018-11-25 Thread Andrew Lunn
> Eventually we'd have three types of mii_xxx_to_linkmode_yyy functions: > > 1. Function first zeroes the destination linkmode bitmap > 2. Function sets bits in the linkmode bitmap but doesn't clear bits >if condition isn't met > 3. Function clears / sets bits it's responsible for > > example

Re: Can decnet be deprecated?

2018-11-25 Thread David Miller
From: Bjørn Mork Date: Sun, 25 Nov 2018 12:30:26 +0100 > David Miller writes: >> From: David Ahern >> Date: Sat, 24 Nov 2018 17:12:48 -0700 >> >>> IPX was moved to staging at the end of last year. Can decnet follow >>> suit? git log seems to indicate no active development in a very long time. >

Re: [PATCH net-next] net: remove unsafe skb_insert()

2018-11-25 Thread David Miller
From: Eric Dumazet Date: Sun, 25 Nov 2018 08:26:23 -0800 > I do not see how one can effectively use skb_insert() without holding > some kind of lock. Otherwise other cpus could have changed the list > right before we have a chance of acquiring list->lock. > > Only existing user is in drivers/inf

Re: [PATCH][V2] net: bridge: remove redundant checks for null p->dev and p->br

2018-11-25 Thread David Miller
From: Colin King Date: Sun, 25 Nov 2018 16:08:51 + > From: Colin Ian King > > A recent change added a null check on p->dev after p->dev was being > dereferenced by the ns_capable check on p->dev. It turns out that > neither the p->dev and p->br null checks are necessary, and can be > remove

Re: [PATCH 3/8] socket: Disentangle SOCK_RCVTSTAMPNS from SOCK_RCVTSTAMP

2018-11-25 Thread David Miller
From: Willem de Bruijn Date: Sun, 25 Nov 2018 09:18:55 -0500 > The existing logic is as is for a reason. There is no need to change > it to satisfy the main purpose of your patchset? > > It is structured as one bit to test whether a timestamp is requested > and another to select among two varian

Re: [PATCH net-next v2 0/2] r8169: make use of xmit_more and __netdev_sent_queue

2018-11-25 Thread David Miller
From: Heiner Kallweit Date: Sun, 25 Nov 2018 14:29:22 +0100 > This series adds helper __netdev_sent_queue to the core and makes use > of it in the r8169 driver. > > Heiner Kallweit (2): > net: core: add __netdev_sent_queue as variant of __netdev_tx_sent_queue > r8169: make use of xmit_more a

[RFC -next v0 1/3] bpf: modular maps

2018-11-25 Thread Aaron Conole
This commit allows for map operations to be loaded by an lkm, rather than needing to be baked into the kernel at compile time. Signed-off-by: Aaron Conole --- include/linux/bpf.h | 6 + init/Kconfig | 8 +++ kernel/bpf/syscall.c | 57 +++

[RFC -next v0 2/3] netfilter: nf_flow_table: support a new 'snoop' mode

2018-11-25 Thread Aaron Conole
This patch adds the ability for a flow table to receive updates on all flows added/removed to any flow table in the system. This will allow other subsystems in the kernel to register a lookup mechanism into the nftables connection tracker for those connections which should be sent to a flow offloa

[RFC -next v0 3/3] netfilter: nf_flow_table_bpf_map: introduce new loadable bpf map

2018-11-25 Thread Aaron Conole
This commit introduces a new loadable map that allows an eBPF program to query the flow offload tables for specific flow information. For now, that information is limited to input and output index information. Future enhancements would be to include connection tracking details, such as state, met

[RFC -next v0 0/3] netfilter: expose flow offload tables as an ebpf map

2018-11-25 Thread Aaron Conole
This is an alternate approach to exposing connection tracking data to the XDP + eBPF world. Rather than having to rework a number of helper functions to ignore or rebuild metadata from an skbuff data segment, we reuse the existing flow offload hooks that expose conntrack tuples directly based on a

Re: [PATCH iproute2-next] man: tc: update man page for fq packet scheduler

2018-11-25 Thread David Ahern
On 11/24/18 6:44 PM, Eric Dumazet wrote: > Signed-off-by: Eric Dumazet > --- > man/man8/tc-fq.8 | 37 ++--- > 1 file changed, 26 insertions(+), 11 deletions(-) > applied to iproute2-next. Thanks, Eric.

Re: [PATCH net-next] net: phy: fix two issues with linkmode bitmaps

2018-11-25 Thread Heiner Kallweit
On 25.11.2018 17:45, Andrew Lunn wrote: > On Sun, Nov 25, 2018 at 03:23:42PM +0100, Heiner Kallweit wrote: >> I wondered why ethtool suddenly reports that link partner doesn't >> support aneg and GBit modes. It turned out that this is caused by two >> bugs in conversion to linkmode bitmaps. >> >> 1

Re: [PATCH][V2] net: bridge: remove redundant checks for null p->dev and p->br

2018-11-25 Thread Nikolay Aleksandrov
On 25/11/2018 18:08, Colin King wrote: > From: Colin Ian King > > A recent change added a null check on p->dev after p->dev was being > dereferenced by the ns_capable check on p->dev. It turns out that > neither the p->dev and p->br null checks are necessary, and can be > removed, which cleans up

Re: [PATCH net-next] net: phy: fix two issues with linkmode bitmaps

2018-11-25 Thread Andrew Lunn
On Sun, Nov 25, 2018 at 03:23:42PM +0100, Heiner Kallweit wrote: > I wondered why ethtool suddenly reports that link partner doesn't > support aneg and GBit modes. It turned out that this is caused by two > bugs in conversion to linkmode bitmaps. > > 1. In genphy_read_status the value of phydev->l

[PATCH net-next] net: remove unsafe skb_insert()

2018-11-25 Thread Eric Dumazet
I do not see how one can effectively use skb_insert() without holding some kind of lock. Otherwise other cpus could have changed the list right before we have a chance of acquiring list->lock. Only existing user is in drivers/infiniband/hw/nes/nes_mgt.c and this one probably meant to use __skb_ins

[PATCH][V2] net: bridge: remove redundant checks for null p->dev and p->br

2018-11-25 Thread Colin King
From: Colin Ian King A recent change added a null check on p->dev after p->dev was being dereferenced by the ns_capable check on p->dev. It turns out that neither the p->dev and p->br null checks are necessary, and can be removed, which cleans up a static analyis warning. As Nikolay Aleksandrov

Re: [PATCH net-next v2 1/3] net: bridge: add support for user-controlled bool options

2018-11-25 Thread Andrew Lunn
On Sat, Nov 24, 2018 at 04:34:20AM +0200, Nikolay Aleksandrov wrote: > We have been adding many new bridge options, a big number of which are > boolean but still take up netlink attribute ids and waste space in the skb. > Recently we discussed learning from link-local packets[1] and decided > yet a

Re: [PATCH 7/8] socket: Add SO_TIMESTAMP[NS]_NEW

2018-11-25 Thread Willem de Bruijn
> > > > Same for the tcp case above, really, and in the case of the next patch > > > > for SO_TIMESTAMPING_NEW > > > > > > That naming convention, ..._2038, is not the nicest, of course. That > > > is not the relevant bit in the above comment. > > it could be __sock_recv_timestamp64(). > But, thes

Re: [PATCH 7/8] socket: Add SO_TIMESTAMP[NS]_NEW

2018-11-25 Thread Willem de Bruijn
On Sun, Nov 25, 2018 at 12:28 AM Deepa Dinamani wrote: > > > > > + if (type == SO_TIMESTAMP_NEW || type == SO_TIMESTAMPNS_NEW) > > > > + sock_set_flag(sk, SOCK_TSTAMP_NEW); > > > > + else > > > > + sock_reset_flag(sk, SOCK_TSTAMP_NEW); > > > > + > > > > > >

[PATCH net-next] net: phy: fix two issues with linkmode bitmaps

2018-11-25 Thread Heiner Kallweit
I wondered why ethtool suddenly reports that link partner doesn't support aneg and GBit modes. It turned out that this is caused by two bugs in conversion to linkmode bitmaps. 1. In genphy_read_status the value of phydev->lp_advertising is overwritten, thus GBit modes aren't reported any longer

Re: [PATCH 3/8] socket: Disentangle SOCK_RCVTSTAMPNS from SOCK_RCVTSTAMP

2018-11-25 Thread Willem de Bruijn
On Sun, Nov 25, 2018 at 12:06 AM Deepa Dinamani wrote: > > On Sat, Nov 24, 2018 at 7:59 PM Willem de Bruijn > wrote: > > > > On Sat, Nov 24, 2018 at 3:59 AM Deepa Dinamani > > wrote: > > > > > > SOCK_RCVTSTAMPNS is never set alone. SOCK_RCVTSTAMP > > > is always set along with SOCK_RCVTSTAMPNS.

KASAN: slab-out-of-bounds Write in queue_stack_map_push_elem

2018-11-25 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:e195ca6cb6f2 Merge branch 'for-linus' of git://git.kernel... git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=12af0d3340 kernel config: https://syzkaller.appspot.com/x/.config?x=73e2bc0cb6463446 da

[PATCH net-next v2 2/2] r8169: make use of xmit_more and __netdev_sent_queue

2018-11-25 Thread Heiner Kallweit
Make use of xmit_more and add the functionality introduced with 3e59020abf0f ("net: bql: add __netdev_tx_sent_queue()"). I used the mlx4 driver as template. Signed-off-by: Heiner Kallweit --- v2: - fix minor style issue --- drivers/net/ethernet/realtek/r8169.c | 19 +-- 1 file ch

[PATCH net-next v2 1/2] net: core: add __netdev_sent_queue as variant of __netdev_tx_sent_queue

2018-11-25 Thread Heiner Kallweit
Similar to netdev_sent_queue add helper __netdev_sent_queue as variant of __netdev_tx_sent_queue. Signed-off-by: Heiner Kallweit --- v2: - no changes --- include/linux/netdevice.h | 8 1 file changed, 8 insertions(+) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h in

[PATCH net-next v2 0/2] r8169: make use of xmit_more and __netdev_sent_queue

2018-11-25 Thread Heiner Kallweit
This series adds helper __netdev_sent_queue to the core and makes use of it in the r8169 driver. Heiner Kallweit (2): net: core: add __netdev_sent_queue as variant of __netdev_tx_sent_queue r8169: make use of xmit_more and __netdev_sent_queue v2: - fix minor style issue drivers/net/ethernet

Re: Can decnet be deprecated?

2018-11-25 Thread Loganaden Velvindron
On Sun, Nov 25, 2018 at 4:14 AM David Ahern wrote: > > IPX was moved to staging at the end of last year. Can decnet follow > suit? git log seems to indicate no active development in a very long time. > > David Kill it :)

Re: Can decnet be deprecated?

2018-11-25 Thread Bjørn Mork
David Miller writes: > From: David Ahern > Date: Sat, 24 Nov 2018 17:12:48 -0700 > >> IPX was moved to staging at the end of last year. Can decnet follow >> suit? git log seems to indicate no active development in a very long time. > > Last time I tried to do that someone immediately said on the

Re: [PATCH net] ixgbe: recognize 1000BaseLX SFP modules as 1Gbps

2018-11-25 Thread Bjørn Mork
Josh Elsasser writes: > Fixes: 6a14ee0cfb19 ("ixgbe: Add X550 support function pointers") Not that it matters much I guess, but I think LX SFPs were unsupported at that time. The LX support appears to have been added under the radar while refactoring ixgbe_setup_sfp_modules_X550em in commit e23f

[PATCH net-next 3/5] mlxsw: spectrum_fid: Introduce emulated 802.1Q FIDs

2018-11-25 Thread Ido Schimmel
The driver uses 802.1Q FIDs when offloading a VLAN-aware bridge. Unfortunately, it is not possible to assign a VNI to such FIDs, which prompts the driver to forbid the enslavement of VxLAN devices to a VLAN-aware bridge. Workaround this hardware limitation by creating a new family of FIDs, emulate

[PATCH net-next 1/5] mlxsw: spectrum_switchdev: Do not set field when it is reserved

2018-11-25 Thread Ido Schimmel
When configuring an FDB entry pointing to a LAG netdev (or its upper), the driver should only set the 'lag_vid' field when the FID (filtering identifier) is of 802.1D type. Extend the 802.1D FID family with an attribute indicating whether this field should be set and based on its value set the fie

[PATCH net-next 4/5] mlxsw: spectrum_router: Introduce emulated VLAN RIFs

2018-11-25 Thread Ido Schimmel
Router interfaces (RIFs) constructed on top of VLAN-aware bridges are of "VLAN" type, whereas RIFs constructed on top of VLAN-unaware bridges of "FID" type. In other words, the RIF type is derived from the underlying FID type. VLAN RIFs are used on top of 802.1Q FIDs, whereas FID RIFs are used on

[PATCH net-next 2/5] mlxsw: spectrum_fid: Make flood index calculation more robust

2018-11-25 Thread Ido Schimmel
802.1D FIDs use a per-FID flood table, where the flood index into the table is calculated by subtracting 4K from the FID's index. Currently, 802.1D FIDs start at 4K, so the calculation is correct, but if it was ever to change, the calculation will no longer be correct. In addition, this change wi

[PATCH net-next 0/5] mlxsw: Prepare for VLAN-aware bridge w/VxLAN

2018-11-25 Thread Ido Schimmel
The driver is using 802.1Q filtering identifiers (FIDs) to represent the different VLANs in the VLAN-aware bridge (only one is supported). However, the device cannot assign a VNI to such FIDs, which prevents the driver from supporting the enslavement of VxLAN devices to the VLAN-aware bridge. Thi

[PATCH net-next 5/5] mlxsw: spectrum: Flip driver to use emulated 802.1Q FIDs

2018-11-25 Thread Ido Schimmel
Replace 802.1Q FIDs and VLAN RIFs with their emulated counterparts. The emulated 802.1Q FIDs are actually 802.1D FIDs and thus use the same flood tables, of per-FID type. Therefore, add 4K-1 entries to the per-FID flood tables for the new FIDs and get rid of the FID-offset flood tables that were u

Re: [PATCH v3 11/13] nvmet-tcp: add NVMe over TCP target driver

2018-11-25 Thread Sagi Grimberg
+ if (!cmd || queue->state == NVMET_TCP_Q_DISCONNECTING) { + cmd = nvmet_tcp_fetch_send_command(queue); + if (unlikely(!cmd)) + return 0; + } + + if (cmd->state == NVMET_TCP_SEND_DATA_PDU) { + ret = nvmet_try_send

Re: [PATCH v3 13/13] nvme-tcp: add NVMe over TCP host driver

2018-11-25 Thread Sagi Grimberg
+static enum nvme_tcp_recv_state nvme_tcp_recv_state(struct nvme_tcp_queue *queue) +{ + return (queue->pdu_remaining) ? NVME_TCP_RECV_PDU : + (queue->ddgst_remaining) ? NVME_TCP_RECV_DDGST : + NVME_TCP_RECV_DATA; +} This just seems to be used in a single sw

Re: [PATCH] brcmfmac: Fix out of bounds memory access during fw load

2018-11-25 Thread Kalle Valo
Lyude Paul writes: > I ended up tracking down some rather nasty issues with f2fs (and other > filesystem modules) constantly crashing on my kernel down to a > combination of out of bounds memory accesses, one of which was coming > from brcmfmac during module load: > > [ 30.891382] brcmfmac: brc

Re: [PATCH net-next v2 1/3] net: bridge: add support for user-controlled bool options

2018-11-25 Thread Nikolay Aleksandrov
On 24/11/2018 18:46, niko...@cumulusnetworks.com wrote: > On 24 November 2018 18:25:41 EET, Andrew Lunn wrote: >> On Sat, Nov 24, 2018 at 06:18:33PM +0200, niko...@cumulusnetworks.com >> wrote: >>> On 24 November 2018 18:10:41 EET, Andrew Lunn wrote: > +int br_boolopt_toggle(struct net_bridge