Wed, Jul 25, 2018 at 01:20:08AM CEST, xiyou.wangc...@gmail.com wrote:
>On Tue, Jul 24, 2018 at 3:30 PM Cong Wang wrote:
>>
>> On Mon, Jul 23, 2018 at 12:25 AM Jiri Pirko wrote:
>> > + switch (n->nlmsg_type) {
>> > + case RTM_NEWCHAIN:
>> > + /* In case the chain was succ
"H. Nikolaus Schaller" writes:
> wl1271_warning() already appends a \n to the format,
> so adding one to the warning string gives empty lines in the log.
>
> Signed-off-by: H. Nikolaus Schaller
"drivers: net:" in the title is unnecessary, but I can remove that.
--
Kalle Valo
For untracked things of tools/bpf, add this.
Reviewed-by: Jakub Kicinski
Signed-off-by: Taeung Song
---
tools/bpf/.gitignore | 5 +
tools/bpf/bpftool/.gitignore | 2 ++
2 files changed, 7 insertions(+)
create mode 100644 tools/bpf/.gitignore
diff --git a/tools/bpf/.gitignore b/too
For untracked things of tools/bpf, add this.
Reviewed-by: Quentin Monnet
Signed-off-by: Taeung Song
---
tools/bpf/.gitignore | 5 +
tools/bpf/bpftool/.gitignore | 2 ++
2 files changed, 7 insertions(+)
create mode 100644 tools/bpf/.gitignore
diff --git a/tools/bpf/.gitignore b/too
Implement rule insertion and deletion into the A-TCAM before we flip the
driver to start using the A-TCAM.
Rule insertion into the A-TCAM is very similar to C-TCAM, but there are
subtle differences between regions of different sizes (i.e., different
number of key blocks).
Specifically, as explain
Now that all the pieces are in place we can start using the A-TCAM
instead of only using the C-TCAM. This allows for much higher scale and
better performance (to be improved further by follow-up patch sets).
Perform the integration with the A-TCAM and the eRP core by reverting
the changes introduc
In Spectrum-2 the C-TCAM is only used for rules that can't fit in the
A-TCAM due to a limited number of masks per A-TCAM region.
In addition, rules inserted into the C-TCAM may affect rules residing in
the A-TCAM, by clearing their C-TCAM prune bit.
The two regions are thus closely related and ca
When rules are inserted into the A-TCAM they are associated with a mask,
which is part of the lookup key: { masked key, mask ID, region ID }.
These masks are called rule patterns (RP) and the aggregation of several
masks into one (to be introduced in follow-up patch sets) is called an
extended RP
Before we start using the A-TCAM we need to make sure the region is
properly initialized.
This includes the setting of its type (which affects the size of its eRP
table, for example) and its registration with the eRP core.
Signed-off-by: Ido Schimmel
Reviewed-by: Jiri Pirko
---
.../mellanox/ml
When A-TCAM will be used together with C-TCAM, the C-TCAM code will need
to call into the eRP core in order to get an eRP for an inserted entry.
The eRP core takes an A-TCAM region as one of its arguments, so pass the
C-TCAM region to the insertion function which will later allow us to
derive the
Each TCAM region currently uses its own resources and there is no
sharing between the different regions.
This is going to change with A-TCAM as each region will need to allocate
an eRP table from the global eRP tables array.
Make the global TCAM resources available to each region by passing the
T
Initialize the A-TCAM as part of the driver's initialization routine.
Specifically, initialize the eRP tables so that A-TCAM regions will be
able to perform allocations of eRP tables upon rule insertion in
subsequent patches.
Signed-off-by: Ido Schimmel
Reviewed-by: Jiri Pirko
---
.../net/ethe
Add a resource to make sure we do not exceed the maximum number of
supported large key IDs in a region.
Signed-off-by: Ido Schimmel
Reviewed-by: Jiri Pirko
---
drivers/net/ethernet/mellanox/mlxsw/resources.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/mellanox/mlx
The number of eRPs that can be used by a single A-TCAM region is limited
to 16. When more eRPs are needed, an ordinary circuit TCAM (C-TCAM) can
be used to hold the extra eRPs.
Unlike the A-TCAM, only a single (last) lookup is performed in the
C-TCAM and not a lookup per-eRP. However, modeling the
The register is used to add and delete eRPs from the eRP table.
Signed-off-by: Ido Schimmel
Reviewed-by: Jiri Pirko
---
drivers/net/ethernet/mellanox/mlxsw/reg.h | 113 ++
1 file changed, 113 insertions(+)
diff --git a/drivers/net/ethernet/mellanox/mlxsw/reg.h
b/drivers/ne
The register is used to configure rules in the A-TCAM.
Signed-off-by: Ido Schimmel
Reviewed-by: Jiri Pirko
---
drivers/net/ethernet/mellanox/mlxsw/reg.h | 165 +-
1 file changed, 162 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlxsw/reg.h
b/dri
Add the following resources to be used by A-TCAM code:
* Maximum number of eRP banks
* Maximum size of eRP bank
* Number of eRP entries required for a 2/4/8/12 key blocks mask
Signed-off-by: Ido Schimmel
Reviewed-by: Jiri Pirko
---
drivers/net/ethernet/mellanox/mlxsw/resources.h | 12 ++
Currently, no calls are performed into the eRP core, but in order to
make review easier we would like to gradually add these calls.
Have the eRP core initialize a region's master mask to all ones and
allow it to use an empty eRP table. This directs the lookup to the
C-TCAM and allows the C-TCAM on
Before introducing A-TCAM support we need to make sure all the necessary
fields are configurable and not hard coded to values that worked for the
C-TCAM only use case.
This includes - for example - the ability to configure the eRP table
used by the TCAM region.
Signed-off-by: Ido Schimmel
Review
When working with 12 key blocks in the A-TCAM, rules are split into two
records, which constitute two lookups. The two records are linked using
a "large entry key ID". The ID is assigned to key blocks 6 to 11 and
resolved during the first lookup. The second lookup is performed using
the ID and the
The Spectrum-2 ASIC uses an algorithmic TCAM (A-TCAM) where multiple
exact matches lookups are performed instead of a single lookup as with
standard circuit TCAM (C-TCAM) memory. This allows for higher scale and
reduced power consumption.
The lookups are performed by masking a packet using differe
In a similar fashion to Spectrum-1's region struct, Spectrum-2's struct
needs to store a pointer to the common region struct.
The pointer will be used in follow-up patches that implement rules
insertion and deletion.
Signed-off-by: Ido Schimmel
Reviewed-by: Jiri Pirko
---
drivers/net/ethernet/
> -Original Message-
> From: Doron Roberts-Kedes [mailto:doro...@fb.com]
> Sent: Wednesday, July 25, 2018 1:50 AM
> To: Vakul Garg
> Cc: David S . Miller ; Dave Watson
> ; Matt Mullins ;
> netdev@vger.kernel.org
> Subject: Re: [PATCH net-next] tls: Fix improper revert in zerocopy_from_i
Fixes the following sparse warning:
drivers/net/ethernet/microchip/lan743x_main.c:2944:25: warning:
symbol 'lan743x_pm_ops' was not declared. Should it be static?
Signed-off-by: Wei Yongjun
---
drivers/net/ethernet/microchip/lan743x_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
wl1271_warning() already appends a \n to the format,
so adding one to the warning string gives empty lines in the log.
Signed-off-by: H. Nikolaus Schaller
---
drivers/net/wireless/ti/wlcore/main.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/wireless
Fixes the following sparse warnings:
net/ipv4/tcp_timer.c:25:5: warning:
symbol 'tcp_retransmit_stamp' was not declared. Should it be static?
Signed-off-by: Wei Yongjun
---
net/ipv4/tcp_timer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/tcp_timer.c b/net/ipv4/
Fixes the following sparse warnings:
net/ipv4/igmp.c:1391:6: warning:
symbol '__ip_mc_inc_group' was not declared. Should it be static?
Signed-off-by: Wei Yongjun
---
net/ipv4/igmp.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/ipv4/igmp.c b/net/ipv4/igmp.c
index 5
Hello,
On Wed, 25 Jul 2018, Tan Hu wrote:
> We came across infinite loop in ipvs when using ipvs in docker
> env.
>
> When ipvs receives new packets and cannot find an ipvs connection,
> it will create a new connection, then if the dest is unavailable
> (i.e. IP_VS_DEST_F_AVAILABLE), t
On 07/24/2018 09:53 PM, Jeremy Cline wrote:
> Adjust tcp_client.py and tcp_server.py to work with Python 3 by using
> the print function, marking string literals as bytes, and using the
> newer exception syntax. This should be functionally equivalent and
> supports Python 3+.
>
> Signed-off-by: Je
On 07/24/2018 03:33 PM, Brian Brooks wrote:
> Signed-off-by: Brian Brooks
Please respin with proper commit message instead of empty one.
Thanks,
Daniel
> -Original Message-
> From: David Miller [mailto:da...@davemloft.net]
> Sent: Wednesday, July 25, 2018 1:43 AM
> To: Vakul Garg
> Cc: netdev@vger.kernel.org; bor...@mellanox.com;
> avia...@mellanox.com; davejwat...@fb.com
> Subject: Re: [net-next v6 1/2] net/tls: Use socket data_ready
> -邮件原件-
> 发件人: Eric Dumazet [mailto:eric.duma...@gmail.com]
> 发送时间: 2018年7月25日 13:45
> 收件人: Li,Rongqing ; netdev@vger.kernel.org;
> pa...@netfilter.org; kad...@blackhole.kfki.hu; f...@strlen.de; netfilter-
> de...@vger.kernel.org; coret...@netfilter.org; eduma...@google.com
> 主题: Re: [PA
On 07/24/2018 04:55 AM, YueHaibing wrote:
> Fix inconsistent IS_ERR and PTR_ERR in get_btf,
> the proper pointer to be passed as argument is '*btf'
>
> This issue was detected with the help of Coccinelle.
>
> Fixes: 2d3feca8c44f ("bpf: btf: print map dump and lookup with btf info")
> Signed-off-b
On 07/24/2018 10:34 PM, Li RongQing wrote:
> nf_ct_alloc_hashtable is used to allocate memory for conntrack,
> NAT bysrc and expectation hashtable. Assuming 64k bucket size,
> which means 7th order page allocation, __get_free_pages, called
> by nf_ct_alloc_hashtable, will trigger the direct memo
On 07/24/2018 07:14 PM, Martin KaFai Lau wrote:
> On Tue, Jul 24, 2018 at 04:59:54PM +, Mathieu Xhonneux wrote:
>> The seg6local LWT provides the End.DT6 action, which allows to
>> decapsulate an outer IPv6 header containing a Segment Routing Header
>> (SRH), full specification is available her
On Tue, Jul 24, 2018 at 02:13:00PM -0600, Jason Gunthorpe wrote:
> On Tue, Jul 24, 2018 at 08:56:09AM +0300, Leon Romanovsky wrote:
> > On Mon, Jul 23, 2018 at 08:42:36PM -0600, Jason Gunthorpe wrote:
> > > On Mon, Jul 23, 2018 at 03:25:04PM +0300, Leon Romanovsky wrote:
> > > > From: Leon Romanovs
On 07/24/2018 05:10 PM, Thomas Richter wrote:
> commit a5b8bd47dcc57 ("bpf tools: Collect eBPF programs from their own
> sections")
>
> cause a compiler error when building the perf tool in the linux-next tree.
> I compile it using a FEDORA 28 installation, my gcc compiler version:
> gcc (GCC) 8.
nf_ct_alloc_hashtable is used to allocate memory for conntrack,
NAT bysrc and expectation hashtable. Assuming 64k bucket size,
which means 7th order page allocation, __get_free_pages, called
by nf_ct_alloc_hashtable, will trigger the direct memory reclaim
and stall for a long time, when system has
>
> On 07/24/2018 02:50 AM, Li,Rongqing wrote:
>
> > Thanks, Your patch fixes my issue;
> >
> > My patch may be able to reduce stall when modprobe nf module in
> memory
> > stress, Do you think this patch has any value?
>
> Only if you make it use kvzalloc()/kvfree()
>
> Thanks.
I will send v
On 7/24/18 5:49 PM, Prashant Bhole wrote:
On 7/25/2018 8:02 AM, Yonghong Song wrote:
On 7/24/18 3:40 PM, John Fastabend wrote:
On 07/24/2018 08:45 AM, Yonghong Song wrote:
In one of our production machines, tools/testing/selftests/bpf
test_sockmap failed randomly like below:
...
[TEST
On 07/24/2018 05:40 PM, Martin KaFai Lau wrote:
> The series allows the BPF loader to figure out
> the btf_key_id and btf_value_id from a map's name
> by using BPF_ANNOTATE_KV_PAIR. It also removes
> the old 'typedef' way which requires two separate
> typedefs (one for the key and one for the valu
On Tue, Jul 24 2018, Paul E. McKenney wrote:
> On Tue, Jul 24, 2018 at 07:52:03AM +1000, NeilBrown wrote:
>> On Mon, Jul 23 2018, Paul E. McKenney wrote:
>>
>> > On Mon, Jul 23, 2018 at 09:13:43AM +1000, NeilBrown wrote:
>> >> On Sun, Jul 22 2018, Paul E. McKenney wrote:
>> >> >
>> >> > One issue
On 2018/07/25 4:10, Jakub Kicinski wrote:
> On Tue, 24 Jul 2018 18:39:09 +0900, Toshiaki Makita wrote:
>> On 2018/07/24 10:56, Toshiaki Makita wrote:
>>> On 2018/07/24 9:27, Jakub Kicinski wrote:
On Mon, 23 Jul 2018 00:13:03 +0900, Toshiaki Makita wrote:
> From: Toshiaki Makita
>
This fixes the following sparse warning:
net/sched/cls_flower.c:1356:36: warning: incorrect type in argument 3
(different base types)
net/sched/cls_flower.c:1356:36: expected unsigned short [unsigned] [usertype]
value
net/sched/cls_flower.c:1356:36: got restricted __be16 [usertype] vlan_tpid
Si
On Tue, Jul 24, 2018 at 1:42 PM Lawrence Brakmo wrote:
>
> Note that without this fix the 99% latencies when doing 10KB RPCs
> in a congested network using DCTCP are 40ms vs. 190us with the patch.
> Also note that these 40ms high tail latencies started after commit
> 3759824da87b30ce7a35b4873b62b0
From: Al Viro
Sent: Wednesday, 25 July, 7:19 AM
Subject: Re: [PATCH net-next] net/tls: Do not call msg_data_left() twice
To: Vakul Garg
Cc: netdev@vger.kernel.org, bor...@mellanox.com, avia...@mellanox.com,
davejwat...@fb.com, da...@davemloft.net
On Tue, Jul 24, 2018 at 04:41:18PM +0530, Vaku
On Tue, Jul 24, 2018 at 04:41:18PM +0530, Vakul Garg wrote:
> In function tls_sw_sendmsg(), msg_data_left() needs to be called only
> once. The second invocation of msg_data_left() for assigning variable
> try_to_copy can be removed and merged with the first one.
You do realize that msg_data_left(
On 7/25/2018 8:02 AM, Yonghong Song wrote:
On 7/24/18 3:40 PM, John Fastabend wrote:
On 07/24/2018 08:45 AM, Yonghong Song wrote:
In one of our production machines, tools/testing/selftests/bpf
test_sockmap failed randomly like below:
...
[TEST 78]: (512, 1, 1, sendmsg, pass,apply 1,): rx
On Tue, Jul 24, 2018 at 7:53 AM, Alexander Duyck
wrote:
> On Mon, Jul 23, 2018 at 3:11 PM, Saeed Mahameed wrote:
>> From: Boris Pismenny
>>
>> This patch removes the splitting of UDP_GSO_L4 packets in the driver,
>> and exposes UDP_GSO_L4 as a PARTIAL_GSO feature. Thus, the network stack
>> is n
On 7/20/18 1:37 AM, Daniel Borkmann wrote:
On 07/20/2018 07:34 AM, Martin KaFai Lau wrote:
I noticed the "--version" option of the llvm-objcopy command has recently
disappeared from the master llvm branch. It is currently used as a BTF
support test in tools/testing/selftests/bpf/Makefile.
T
On Tue, Jul 24, 2018 at 3:46 PM Michael S. Tsirkin wrote:
>
> On Tue, Jul 24, 2018 at 06:31:54PM -0400, Willem de Bruijn wrote:
> > On Tue, Jul 24, 2018 at 6:23 PM Michael S. Tsirkin wrote:
> > >
> > > On Tue, Jul 24, 2018 at 04:52:53PM -0400, Willem de Bruijn wrote:
> > > > >From the above linke
On Tue, Jul 24, 2018 at 6:46 PM Michael S. Tsirkin wrote:
>
> On Tue, Jul 24, 2018 at 06:31:54PM -0400, Willem de Bruijn wrote:
> > On Tue, Jul 24, 2018 at 6:23 PM Michael S. Tsirkin wrote:
> > >
> > > On Tue, Jul 24, 2018 at 04:52:53PM -0400, Willem de Bruijn wrote:
> > > > >From the above linke
From: Willem de Bruijn
Date: Mon, 23 Jul 2018 19:36:48 -0400
> From: Willem de Bruijn
>
> Syzbot reported a read beyond the end of the skb head when returning
> IPV6_ORIGDSTADDR:
...
> This logic and its ipv4 counterpart read the destination port from
> the packet at skb_transport_offset(skb)
From: Mathias Radtke
Date: Tue, 24 Jul 2018 12:08:45 +0200
> since Kernel 4.10 the usage of the Surface Dock 3 is broken.
> The network driver r8152 reports Tx Error -71.
> The patch removes the dock from the r8152 driver and also removed it
> from the cdc_ether drivers blacklist. Therefore the c
From: Sudarsana Reddy Kalluru
Date: Tue, 24 Jul 2018 02:43:52 -0700
> Rx hash/filter table configuration uses rss_conf_obj to configure filters
> in the hardware. This object is initialized only when the interface is
> brought up.
> This patch adds driver changes to configure rss params only when
From: Tariq Toukan
Date: Tue, 24 Jul 2018 14:27:55 +0300
> From: Jack Morgenstein
>
> Function mlx4_RST2INIT_QP_wrapper saved the qp number passed in the qp
> context, rather than the one passed in the input modifier.
>
> However, the qp number in the qp context is not defined as a
> required
Hi,
Vinicius Costa Gomes writes:
> Hi,
>
> Stephen Hemminger writes:
>
[...]
>>
>> Why not just use batch mode? Introducing another input mode in tc that is
>> only in one qdisc seems like a bad idea.
>
> Seems that I have missed batch mode. I am going to play with it a little
> and see how t
On Tue, Jul 24, 2018 at 3:30 PM Cong Wang wrote:
>
> On Mon, Jul 23, 2018 at 12:25 AM Jiri Pirko wrote:
> > + switch (n->nlmsg_type) {
> > + case RTM_NEWCHAIN:
> > + /* In case the chain was successfully added, take a
> > reference
> > +* to the chain. T
On 7/24/18 3:40 PM, John Fastabend wrote:
On 07/24/2018 08:45 AM, Yonghong Song wrote:
In one of our production machines, tools/testing/selftests/bpf
test_sockmap failed randomly like below:
...
[TEST 78]: (512, 1, 1, sendmsg, pass,apply 1,): rx thread exited with
err 1. FAILED
...
...
[TES
On Tue, Jul 24, 2018 at 06:31:54PM -0400, Willem de Bruijn wrote:
> On Tue, Jul 24, 2018 at 6:23 PM Michael S. Tsirkin wrote:
> >
> > On Tue, Jul 24, 2018 at 04:52:53PM -0400, Willem de Bruijn wrote:
> > > >From the above linked patch, I understand that there are yet
> > > other special cases in p
On 07/24/2018 08:45 AM, Yonghong Song wrote:
> In one of our production machines, tools/testing/selftests/bpf
> test_sockmap failed randomly like below:
>
> ...
> [TEST 78]: (512, 1, 1, sendmsg, pass,apply 1,): rx thread exited with
> err 1. FAILED
> ...
>
> ...
> [TEST 80]: (2, 1024, 256, sendms
On Tue, Jul 24, 2018 at 6:23 PM Michael S. Tsirkin wrote:
>
> On Tue, Jul 24, 2018 at 04:52:53PM -0400, Willem de Bruijn wrote:
> > >From the above linked patch, I understand that there are yet
> > other special cases in production, such as a hard cap on #tx queues to
> > 32 regardless of number o
On Mon, Jul 23, 2018 at 12:25 AM Jiri Pirko wrote:
> + switch (n->nlmsg_type) {
> + case RTM_NEWCHAIN:
> + /* In case the chain was successfully added, take a reference
> +* to the chain. This ensures that an empty chain
> +* does not disap
On Tue, Jul 24, 2018 at 04:52:53PM -0400, Willem de Bruijn wrote:
> >From the above linked patch, I understand that there are yet
> other special cases in production, such as a hard cap on #tx queues to
> 32 regardless of number of vcpus.
I don't think upstream kernels have this limit - we can
now
From: Nishanth Devarajan
Date: Mon, 23 Jul 2018 19:37:41 +0530
> net/sched: add skbprio scheduler
Applied to net-next, thank you.
From: Heiner Kallweit
Date: Sat, 21 Jul 2018 15:48:47 +0200
> Certain PHY's have issues when operating in GBit slave mode and can
> be forced to master mode. Examples are RTL8211C, also the Micrel PHY
> driver has a DT setting to force master mode.
> If two such chips are link partners the autone
From: David Miller
Date: Tue, 24 Jul 2018 14:38:02 -0700 (PDT)
> From: Doron Roberts-Kedes
> Date: Fri, 20 Jul 2018 11:19:00 -0700
>
>> The zerocopy path ultimately calls iov_iter_get_pages, which defines the
>> step function for ITER_KVECs as simply, return -EFAULT. Taking the
>> non-zerocopy
From: Doron Roberts-Kedes
Date: Fri, 20 Jul 2018 11:19:00 -0700
> The zerocopy path ultimately calls iov_iter_get_pages, which defines the
> step function for ITER_KVECs as simply, return -EFAULT. Taking the
> non-zerocopy path for ITER_KVECs avoids the unnecessary fallback.
>
> See
> https://
On Tue, Jul 24, 2018 at 1:07 PM Paolo Abeni wrote:
> +
> + /* let's the caller reinject the packet, if possible */
> + if (skb_at_tc_ingress(skb)) {
> + res->ingress = want_ingress;
> + res->qstats = this_cpu_ptr(m->common.cpu
From: Heiner Kallweit
Date: Tue, 24 Jul 2018 22:21:04 +0200
> Commit 7edf6d314cd0 tried to resolve an inconsistency (BIOS WoL
> settings are accepted, but device isn't wakeup-enabled) resulting
> from a previous broken-BIOS workaround by making disabled WoL the
> default.
> This however had some
I would like to speak with the person that managing photos for your
company?
We provide image editing like – photos cutting out and retouching.
Enhancing your images is just a part of what we can do for your business.
Whether you’re an ecommerce
store or portrait photographer, real estate profes
On Tue, Jul 24, 2018 at 2:39 PM Michael S. Tsirkin wrote:
>
> On Tue, Jul 24, 2018 at 10:01:39AM -0400, Willem de Bruijn wrote:
> > On Tue, Jul 24, 2018 at 6:44 AM Michael S. Tsirkin wrote:
> > >
> > > On Mon, Jul 23, 2018 at 04:11:19PM -0700, Caleb Raitto wrote:
> > > > From: Caleb Raitto
> > >
On 7/24/2018 10:24 AM, Steve Wise wrote:
>
> On 7/19/2018 8:25 PM, Max Gurtovoy wrote:
> [ 2032.194376] nvme nvme0: failed to connect queue: 9 ret=-18
queue 9 is not mapped (overlap).
please try the bellow:
>>> This seems to work. Here are three mapping cases: each vector on
On Tue, Jul 24, 2018 at 1:38 PM Cong Wang wrote:
>
> On Tue, Jul 24, 2018 at 1:07 PM Paolo Abeni wrote:
> > +static inline void skb_tc_reinject(struct sk_buff *skb, struct tcf_result
> > *res)
> > +{
> > + struct gnet_stats_queue *stats = res->qstats;
> > + int ret;
> > +
> > +
On Tue, Jul 24, 2018 at 1:07 PM Paolo Abeni wrote:
> +static inline void skb_tc_reinject(struct sk_buff *skb, struct tcf_result
> *res)
> +{
> + struct gnet_stats_queue *stats = res->qstats;
> + int ret;
> +
> + if (res->ingress)
> + ret = netif_receive_skb(skb);
>
On Tue, Jul 24, 2018 at 02:13:00PM -0600, Jason Gunthorpe wrote:
> diff --git a/drivers/infiniband/hw/mlx5/mlx5_ib.h
> b/drivers/infiniband/hw/mlx5/mlx5_ib.h
> index 5f08b69f8a4f60..ec8410d3c4eb2a 100644
> +++ b/drivers/infiniband/hw/mlx5/mlx5_ib.h
> @@ -1232,11 +1232,9 @@ int mlx5_ib_devx_create
Commit 7edf6d314cd0 tried to resolve an inconsistency (BIOS WoL
settings are accepted, but device isn't wakeup-enabled) resulting
from a previous broken-BIOS workaround by making disabled WoL the
default.
This however had some side effects, most likely due to a broken BIOS
some systems don't proper
On Tue, Jul 24, 2018 at 05:13:26AM +, Vakul Garg wrote:
>
> > -Original Message-
> > From: Doron Roberts-Kedes [mailto:doro...@fb.com]
> > Sent: Tuesday, July 24, 2018 3:50 AM
> > @@ -811,6 +809,7 @@ int tls_sw_recvmsg(struct sock *sk,
> > likely(!(flags & MSG_P
On Tue, Jul 24, 2018 at 08:56:09AM +0300, Leon Romanovsky wrote:
> On Mon, Jul 23, 2018 at 08:42:36PM -0600, Jason Gunthorpe wrote:
> > On Mon, Jul 23, 2018 at 03:25:04PM +0300, Leon Romanovsky wrote:
> > > From: Leon Romanovsky
> > >
> > > Changelog:
> > > v1->v2:
> > > * Fix matcher to use the
From: Vakul Garg
Date: Tue, 24 Jul 2018 15:44:02 +0530
> On receipt of a complete tls record, use socket's saved data_ready
> callback instead of state_change callback.
>
> Signed-off-by: Vakul Garg
I don't think this is correct.
Here, the stream parser has given us a complete TLS record.
Bu
Currently, when initializing an action, the user-space can specify
and use arbitrary values for the tcfa_action field. If the value
is unknown by the kernel, is implicitly threaded as TC_ACT_UNSPEC.
This change explicitly checks for unknown values at action creation
time, and explicitly convert th
This is similar TC_ACT_REDIRECT, but with a slightly different
semantic:
- on ingress the mirred skbs are passed to the target device
network stack without any additional check not scrubbing.
- the rcu-protected stats provided via the tcf_result struct
are updated on error conditions.
This new t
When mirred is invoked from the ingress path, and it wants to redirect
the processed packet, it can now use the TC_ACT_REINJECT action,
filling the tcf_result accordingly, and avoiding a per packet
skb_clone().
Overall this gives a ~10% improvement in forwarding performance for the
TC S/W data pat
This series is aimed at improving the act_mirred redirect performances.
Such action is used by OVS to represent TC S/W flows, and it's current largest
bottle-neck is the need for a skb_clone() for each packet.
The first 3 patches introduce some cleanup and safeguards to allow extending
tca_result
Only cls_bpf and act_bpf can safely use such value. If a generic
action is configured by user space to return TC_ACT_REDIRECT,
the usually visible behavior is passing the skb up the stack - as
for unknown action, but, with complex configuration, more random
results can be obtained.
This patch forc
Each lockless action currently does its own RCU locking in ->act().
This is allows using plain RCU accessor, even if the context
is really RCU BH.
This change drops the per action RCU lock, replace the accessors
with _bh variant, cleans up a bit the surronding code and documents
the RCU status in
On Tue, 24 Jul 2018 13:31:28 +0300, Eran Ben Elisha wrote:
> On 7/19/2018 4:49 AM, Jakub Kicinski wrote:
> > On Wed, 18 Jul 2018 18:01:01 -0700, Saeed Mahameed wrote:
> >> +static const struct devlink_param mlx5_devlink_params[] = {
> >> + DEVLINK_PARAM_DRIVER(MLX5_DEVLINK_PARAM_ID_CONGESTION_AC
On Tue, 24 Jul 2018 18:39:09 +0900, Toshiaki Makita wrote:
> On 2018/07/24 10:56, Toshiaki Makita wrote:
> > On 2018/07/24 9:27, Jakub Kicinski wrote:
> >> On Mon, 23 Jul 2018 00:13:03 +0900, Toshiaki Makita wrote:
> >>> From: Toshiaki Makita
> >>>
> >>> All oversized packets including GSO pac
On Tue, Jul 24, 2018 at 10:01:39AM -0400, Willem de Bruijn wrote:
> On Tue, Jul 24, 2018 at 6:44 AM Michael S. Tsirkin wrote:
> >
> > On Mon, Jul 23, 2018 at 04:11:19PM -0700, Caleb Raitto wrote:
> > > From: Caleb Raitto
> > >
> > > The driver disables tx napi if it's not certain that completions
From: Tariq Toukan
Date: Tue, 24 Jul 2018 13:53:00 +0300
> The cited patch added a call to dev_change_tx_queue_len in
> SIOCSIFTXQLEN case.
> This obsoletes the new len comparison check done before the function call.
> Remove it here.
>
> For the desicion of keep/remove the negative value check,
On 7/24/18 11:55 AM, Xin Long wrote:
> INFO: bc_forwarding disabled on r1 =>
> INFO: h1 -> net2: reply from r1 (not forwarding)
> TEST: ping 198.51.100.255, expected reply from 192.0.2.1[PASS]
> INFO: h1 -> net3: reply from r1 (not forwarding)
> TEST: ping 198.51.200.255, expected reply
On Wed, Jul 25, 2018 at 1:37 AM, David Ahern wrote:
> On 7/24/18 11:24 AM, Xin Long wrote:
>> On Mon, Jul 23, 2018 at 11:17 PM, David Ahern wrote:
>>> On 7/23/18 5:51 AM, Xin Long wrote:
+ping_ipv4()
+{
+ sysctl_set net.ipv4.icmp_echo_ignore_broadcasts 0
+
+ bc_fo
Note that without this fix the 99% latencies when doing 10KB RPCs in a
congested network using DCTCP are 40ms vs. 190us with the patch. Also note that
these 40ms high tail latencies started after commit
3759824da87b30ce7a35b4873b62b0ba38905ef5 in Jul 2015, which triggered the
bugs/features we a
On 7/24/18 11:24 AM, Xin Long wrote:
> On Mon, Jul 23, 2018 at 11:17 PM, David Ahern wrote:
>> On 7/23/18 5:51 AM, Xin Long wrote:
>>> +ping_ipv4()
>>> +{
>>> + sysctl_set net.ipv4.icmp_echo_ignore_broadcasts 0
>>> +
>>> + bc_forwarding_disable
>>> + ping_test_from $h1 198.51.100.255 1
On Tue, Jul 24, 2018 at 06:35:35PM +0300, Konstantin Khorenko wrote:
> Hi Marcelo,
>
> pity to abandon Oleg's attempt to avoid high order allocations and use
> flex_array instead, so i tried to do the performance measurements with
> options you kindly suggested.
Nice, thanks!
...
> As we can see
This partly reverts 8f0807023d067e2bb585a2ae8da93e59689d10f1, bringing
back the umount(/sys) attempt.
In a LXC container we're unable to umount the sysfs instance, nor mount
a read-write one. We still are able to create a new read-only instance.
Nevertheless, it still makes sense to attempt the u
On 07/24/2018 10:12 AM, Neal Cardwell wrote:
> On Tue, Jul 24, 2018 at 1:07 PM Yuchung Cheng wrote:
>>
>> On Mon, Jul 23, 2018 at 7:23 PM, Daniel Borkmann
>> wrote:
>>> Should this go to net tree instead where all the other fixes went?
>> I am neutral but this feels more like a feature improv
On Mon, Jul 23, 2018 at 11:17 PM, David Ahern wrote:
> On 7/23/18 5:51 AM, Xin Long wrote:
>> +ping_ipv4()
>> +{
>> + sysctl_set net.ipv4.icmp_echo_ignore_broadcasts 0
>> +
>> + bc_forwarding_disable
>> + ping_test_from $h1 198.51.100.255 192.0.2.1
>> + ping_test_from $h1 198.51.20
On 7/21/18 8:32 PM, David Miller wrote:
>
> Applied and queued up for -stable.
>
>> Dave: I can look at the backports to stable if needed.
>
> Please do, that will help me a lot.
>
It applies cleanly to 4.17 and 4.14. I tested 4.14 it is fine. Since
4.18 and 4.14 work I have no reason to belie
On Tue, Jul 24, 2018 at 04:59:54PM +, Mathieu Xhonneux wrote:
> The seg6local LWT provides the End.DT6 action, which allows to
> decapsulate an outer IPv6 header containing a Segment Routing Header
> (SRH), full specification is available here:
>
> https://urldefense.proofpoint.com/v2/url?u=ht
1 - 100 of 156 matches
Mail list logo
