From: David Miller <da...@davemloft.net> Date: Tue, 24 Jul 2018 14:38:02 -0700 (PDT)
> From: Doron Roberts-Kedes <doro...@fb.com> > Date: Fri, 20 Jul 2018 11:19:00 -0700 > >> The zerocopy path ultimately calls iov_iter_get_pages, which defines the >> step function for ITER_KVECs as simply, return -EFAULT. Taking the >> non-zerocopy path for ITER_KVECs avoids the unnecessary fallback. >> >> See >> https://lore.kernel.org/lkml/20150401023311.gl29...@zeniv.linux.org.uk/T/#u >> for a discussion of why zerocopy for vmalloc data is not a good idea. >> >> Discovered while testing NBD traffic encrypted with ktls. >> >> Fixes: c46234ebb4d1 ("tls: RX path for ktls") >> Signed-off-by: Doron Roberts-Kedes <doro...@fb.com> > > Applied to net-next, thanks. Actually, I reverted. Please fix this warning: net/tls/tls_sw.c: In function ‘tls_sw_sendmsg’: net/tls/tls_sw.c:414:3: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] bool iskvec = msg->msg_iter.type & ITER_KVEC; ^~~~ net/tls/tls_sw.c: In function ‘tls_sw_recvmsg’: net/tls/tls_sw.c:823:4: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] bool iskvec = msg->msg_iter.type & ITER_KVEC; ^~~~
