Re: [RFC PATCH v2 01/10] net: sched: allow qdiscs to handle locking

2016-07-13 Thread John Fastabend
On 16-07-13 11:19 PM, John Fastabend wrote: > This patch adds a flag for queueing disciplines to indicate the stack > does not need to use the qdisc lock to protect operations. This can > be used to build lockless scheduling algorithms and improving > performance. > > The flag is checked in the tx

Re: [PATCH] mlxsw: spectrum_router: Return -ENOENT in case of error

2016-07-13 Thread Jiri Pirko
Thu, Jul 14, 2016 at 08:18:45AM CEST, christophe.jail...@wanadoo.fr wrote: >'vr' should be a valid pointer here, so returning 'PTR_ERR(vr)' is wrong. >Return an explicit error code (-ENOENT) instead. > This is fo net-next. Fixes: 61c503f976 ("mlxsw: spectrum_router: Implement fib4 add/del switchd

[RFC PATCH v2 10/10] net: sched: add support for TCQ_F_NOLOCK subqueues to sch_mq

2016-07-13 Thread John Fastabend
The sch_mq qdisc creates a sub-qdisc per tx queue which are then called independently for enqueue and dequeue operations. However statistics are aggregated and pushed up to the "master" qdisc. This patch adds support for any of the sub-qdiscs to be per cpu statistic qdiscs. To handle this case add

[RFC PATCH v2 09/10] net: sched: helper to sum qlen

2016-07-13 Thread John Fastabend
Reporting qlen when qlen is per cpu requires aggregating the per cpu counters. This adds a helper routine for this. Signed-off-by: John Fastabend --- include/net/sch_generic.h | 15 +++ 1 file changed, 15 insertions(+) diff --git a/include/net/sch_generic.h b/include/net/sch_gener

[RFC PATCH v2 08/10] net: sched: pfifo_fast use alf_queue

2016-07-13 Thread John Fastabend
This converts the pfifo_fast qdisc to use the alf_queue enqueue and dequeue routines then sets the NOLOCK bit. This also removes the logic used to pick the next band to dequeue from and instead just checks each alf_queue for packets from top priority to lowest. This might need to be a bit more cle

[RFC PATCH v2 07/10] net: sched: support skb_bad_tx with lockless qdisc

2016-07-13 Thread John Fastabend
Similar to how gso is handled skb_bad_tx needs to be per cpu to handle lockless qdisc with multiple writer/producers. Signed-off-by: John Fastabend --- include/net/sch_generic.h |7 +++ net/sched/sch_api.c |5 ++ net/sched/sch_generic.c | 94

[RFC PATCH v2 06/10] net: sched: support qdisc_reset on NOLOCK qdisc

2016-07-13 Thread John Fastabend
The qdisc_reset operation depends on the qdisc lock at the moment to halt any additions to gso_skb and statistics while the list is free'd and the stats zeroed. Without the qdisc lock we can not guarantee another cpu is not in the process of adding a skb to one of the "cells". Here are the two cas

[RFC PATCH v2 05/10] net: sched: per cpu gso handlers

2016-07-13 Thread John Fastabend
The net sched infrastructure has a gso ptr that points to skb structs that have failed to be enqueued by the device driver. This can happen when multiple cores try to push a skb onto the same underlying hardware queue resulting in lock contention. This case is handled by a cpu collision handler ha

[RFC PATCH v2 04/10] net: sched: a dflt qdisc may be used with per cpu stats

2016-07-13 Thread John Fastabend
Enable dflt qdisc support for per cpu stats before this patch a dflt qdisc was required to use the global statistics qstats and bstats. Signed-off-by: John Fastabend --- net/sched/sch_generic.c | 24 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/net/sc

[RFC PATCH v2 03/10] net: sched: provide per cpu qstat helpers

2016-07-13 Thread John Fastabend
The per cpu qstats support was added with per cpu bstat support which is currently used by the ingress qdisc. This patch adds a set of helpers needed to make other qdiscs that use qstats per cpu as well. Signed-off-by: John Fastabend --- include/net/sch_generic.h | 39 +

Re: [PATCH net-next 1/2] devlink: fix build error for CONFIG_MODULES=n

2016-07-13 Thread Jiri Pirko
Wed, Jul 13, 2016 at 11:03:37PM CEST, a...@arndb.de wrote: >A driver calling trace_devlink_hwmsg cannot be built when modules are disabled: > >include/trace/events/devlink.h: In function >'trace_event_get_offsets_devlink_hwmsg': >include/trace/events/devlink.h:25:51: error: dereferencing pointer t

[RFC PATCH v2 00/10] running qdiscs without qdisc_lock

2016-07-13 Thread John Fastabend
Hi, I thought I should go ahead and send this series out for comments. Here I allow qdiscs to be run without taking the qdisc lock. As a result statistics, gso skb, tx bad skb and a few other things need to be "safe" to run without locks. It _should_ all be covered here. Although I just noticed I

[RFC PATCH v2 02/10] net: sched: qdisc_qlen for per cpu logic

2016-07-13 Thread John Fastabend
This is a bit interesting because it means sch_direct_xmit will return a positive value which causes the dequeue/xmit cycle to continue only when a specific cpu has a qlen > 0. However checking each cpu for qlen will break performance so its important to note that qdiscs that set the no lock bit n

[RFC PATCH v2 01/10] net: sched: allow qdiscs to handle locking

2016-07-13 Thread John Fastabend
This patch adds a flag for queueing disciplines to indicate the stack does not need to use the qdisc lock to protect operations. This can be used to build lockless scheduling algorithms and improving performance. The flag is checked in the tx path and the qdisc lock is only taken if it is not set.

[PATCH] mlxsw: spectrum_router: Return -ENOENT in case of error

2016-07-13 Thread Christophe JAILLET
'vr' should be a valid pointer here, so returning 'PTR_ERR(vr)' is wrong. Return an explicit error code (-ENOENT) instead. Signed-off-by: Christophe JAILLET --- drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/e

Re: [PATCH v11 21/22] IB/hns: Kconfig and Makefile for RoCE module

2016-07-13 Thread Leon Romanovsky
On Sat, Jul 02, 2016 at 05:39:23PM +0800, Lijun Ou wrote: > This patch added Kconfig and Makefile for building RoCE module. > > Signed-off-by: Wei Hu > Signed-off-by: Nenglong Zhao > Signed-off-by: Lijun Ou > --- > PATCH v11: > hns_roce_icm.o -> hns_roce_hem.o > > PATCH v10/v9/v8/v7/v6/v5: > -

Re: [PATCH v11 00/22] Add HiSilicon RoCE driver

2016-07-13 Thread Leon Romanovsky
On Thu, Jul 14, 2016 at 11:43:59AM +0800, oulijun wrote: > 在 2016/7/2 17:39, Lijun Ou 写道: > > > Hi, Doug & Sean Hefty & Hal Rosenstock > "Hello, I understand that maintainer is dealing with lots of patches not just > mine. Also, I could not see any further review comments from the community. > I

Re: [PATCH 0/2] Code style fixes

2016-07-13 Thread David Miller
From: Elad Kanfi Date: Wed, 13 Jul 2016 16:58:05 +0300 > Fix all checkpatch warnings and errors, and reuse code Series applied to net-next, thanks.

Re: [PATCH v11 00/22] Add HiSilicon RoCE driver

2016-07-13 Thread oulijun
在 2016/7/2 17:39, Lijun Ou 写道: > The HiSilicon Network Substem is a long term evolution IP which is > supposed to be used in HiSilicon ICT SoCs. HNS (HiSilicon Network > Sybsystem) also has a hardware support of performing RDMA with > RoCEE. > The driver for HiSilicon RoCEE(RoCE Engine) is a platfo

[PATCH 2/2] net: nps_enet: code reuse

2016-07-13 Thread Elad Kanfi
From: Elad Kanfi Add inline function that checks if there is a pending tx packet. Signed-off-by: Elad Kanfi --- drivers/net/ethernet/ezchip/nps_enet.c | 21 +++-- 1 files changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/net/ethernet/ezchip/nps_enet.c b/driver

Re: [PATCH net-next 0/6] sctp: allow GSO frags to access the chunk too

2016-07-13 Thread David Miller
From: Marcelo Ricardo Leitner Date: Wed, 13 Jul 2016 15:08:54 -0300 > Patchset is named after the most important fix in it. First two patches > are preparing the grounds for the 3rd patch. > > After the 3rd, they are not strictly logically related to the patchset, > but I kept them together as t

Re: [PATCH -next] net: ethernet: bgmac: Remove redundant dev_err call in bgmac_probe()

2016-07-13 Thread David Miller
From: weiyj...@163.com Date: Wed, 13 Jul 2016 12:46:57 + > From: Wei Yongjun > > There is a error message within devm_ioremap_resource > already, so remove the dev_err call to avoid redundant > error message. > > Signed-off-by: Wei Yongjun Applied.

Re: [PATCH -next] stmmac: dwmac-socfpga: remove redundant dev_err call in socfpga_dwmac_parse_data()

2016-07-13 Thread David Miller
From: weiyj...@163.com Date: Wed, 13 Jul 2016 12:46:40 + > From: Wei Yongjun > > There is a error message within devm_ioremap_resource > already, so remove the dev_err call to avoid redundant > error message. > > Signed-off-by: Wei Yongjun Applied.

Re: [PATCH net-next] net: vrf: Address comments from last documentation update

2016-07-13 Thread David Miller
From: David Ahern Date: Wed, 13 Jul 2016 18:28:16 -0600 > Comments from Frank Kellerman on last doc update: > - extra whitespace in front of a neigh show command > - convert the brief link example to 'vrf red' > > Signed-off-by: David Ahern Applied.

[PATCH net-next] net: vrf: Address comments from last documentation update

2016-07-13 Thread David Ahern
Comments from Frank Kellerman on last doc update: - extra whitespace in front of a neigh show command - convert the brief link example to 'vrf red' Signed-off-by: David Ahern --- Documentation/networking/vrf.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Documentat

[PATCH 1/2] net: ethernet: ll_temac: use phydev from struct net_device

2016-07-13 Thread Philippe Reynes
The private structure contain a pointer to phydev, but the structure net_device already contain such pointer. So we can remove the pointer phy in the private structure, and update the driver to use the one contained in struct net_device. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/xi

[PATCH 2/2] net: ethernet: ll_temac: use phy_ethtool_{get|set}_link_ksettings

2016-07-13 Thread Philippe Reynes
There are two generics functions phy_ethtool_{get|set}_link_ksettings, so we can use them instead of defining the same code in the driver. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/xilinx/ll_temac_main.c | 14 ++ 1 files changed, 2 insertions(+), 12 deletions(-) diff

Re: pull request: bluetooth-next 2016-07-13

2016-07-13 Thread David Miller
From: Johan Hedberg Date: Wed, 13 Jul 2016 11:25:40 +0300 > Here's our main bluetooth-next pull request for the 4.8 kernel: > > - Fixes and cleanups in 802.15.4 and 6LoWPAN code > - Fix out of bounds issue in btmrvl driver > - Fixes to Bluetooth socket recvmsg return values > - Use crypto_ci

Re: [net-next PATCH 2/3] pktgen: add sample script pktgen_sample05_flow_per_thread.sh

2016-07-13 Thread Alexei Starovoitov
On Wed, Jul 13, 2016 at 10:06:10PM +0200, Jesper Dangaard Brouer wrote: > This pktgen sample script is useful for scalability testing a > receiver. The script will simply generate one flow per > thread (option -t N) using the thread number as part of the > source IP-address. > > The single flow s

Re: [PATCH] rndis_host: Set random MAC for ZTE MF910

2016-07-13 Thread Bjørn Mork
Kristian Evensen writes: > From: Kristian Evensen > > All ZTE MF910 mifis, at least on some revisions, export the same MAC > address (36:4b:50:b7:ef:da). Check for this MAC address and set a random > MAC if detected. > > Also, changed the memcpy() to ether_addr_copy(), as pointed out by > checkp

Re: [PATCH RFC 3/3] ARM64: dts: meson-gxbb: use the new meson8b DWMAC glue

2016-07-13 Thread Kevin Hilman
Michael Turquette writes: > Hi Martin, > > Quoting Martin Blumenstingl (2016-06-27 04:33:49) >> On Mon, Jun 27, 2016 at 12:44 PM, Martin Blumenstingl >> wrote: >> > On Mon, Jun 27, 2016 at 11:24 AM, Carlo Caione wrote: >> >> A syscon is a region containing a set of miscellaneous registers used

[PATCH net-next 1/2] devlink: fix build error for CONFIG_MODULES=n

2016-07-13 Thread Arnd Bergmann
A driver calling trace_devlink_hwmsg cannot be built when modules are disabled: include/trace/events/devlink.h: In function 'trace_event_get_offsets_devlink_hwmsg': include/trace/events/devlink.h:25:51: error: dereferencing pointer to incomplete type 'struct module' __string(owner_name, devli

[PATCH net-next 2/2] devlink: fix trace format string

2016-07-13 Thread Arnd Bergmann
Including devlink.h on ARM and probably other 32-bit architectures results in a harmless warning: In file included from ../include/trace/define_trace.h:95:0, from ../include/trace/events/devlink.h:51, from ../net/core/devlink.c:30: include/trace/events/devlink.h:

Re: [PATCH RFC 3/3] ARM64: dts: meson-gxbb: use the new meson8b DWMAC glue

2016-07-13 Thread Michael Turquette
Hi Martin, Quoting Martin Blumenstingl (2016-06-27 04:33:49) > On Mon, Jun 27, 2016 at 12:44 PM, Martin Blumenstingl > wrote: > > On Mon, Jun 27, 2016 at 11:24 AM, Carlo Caione wrote: > >> A syscon is a region containing a set of miscellaneous registers used > >> for several reasons by several d

Re: 4.6.3 panic on nf_ct_delete (nf_conntrack)

2016-07-13 Thread nuclearcat
On 2016-07-13 23:21, Florian Westphal wrote: nuclear...@nuclearcat.com wrote: Workload: pppoe server, 5k users on ppp interfaces. No actual SNAT/DNAT, but using connmark and REDIRECT [176412.990104] general protection fault: [#1] SMP I assume that you did not see this before. What was

Re: [PATCH 1/1] tracing, bpf: Implement function bpf_probe_write

2016-07-13 Thread Sargun Dhillon
On Wed, 13 Jul 2016, Alexei Starovoitov wrote: > On Wed, Jul 13, 2016 at 03:36:11AM -0700, Sargun Dhillon wrote: >> Provides BPF programs, attached to kprobes a safe way to write to >> memory referenced by probes. This is done by making probe_kernel_write >> accessible to bpf functions via the b

Re: 4.6.3 panic on nf_ct_delete (nf_conntrack)

2016-07-13 Thread Florian Westphal
nuclear...@nuclearcat.com wrote: > Workload: pppoe server, 5k users on ppp interfaces. No actual SNAT/DNAT, but > using connmark and REDIRECT > > [176412.990104] general protection fault: [#1] > SMP I assume that you did not see this before. What was the last kernel version where you did n

4.6.3 panic on nf_ct_delete (nf_conntrack)

2016-07-13 Thread nuclearcat
Workload: pppoe server, 5k users on ppp interfaces. No actual SNAT/DNAT, but using connmark and REDIRECT [176412.990104] general protection fault: [#1] SMP [176412.990424] Modules linked in: sch_pie cls_fw act_police cls_u32 sch_ingress sch_sfq sch_htb netconsole [176412.991427] configfs

[net-next PATCH 0/3] pktgen samples: new scripts and removing older samples

2016-07-13 Thread Jesper Dangaard Brouer
This patchset is adding some pktgen sample scripts that I've been using for a while[1], and they seams to relevant for more people. Patchset also remove some of the older style pktgen samples. [1] https://github.com/netoptimizer/network-testing/tree/master/pktgen --- Jesper Dangaard Brouer (3):

[net-next PATCH 2/3] pktgen: add sample script pktgen_sample05_flow_per_thread.sh

2016-07-13 Thread Jesper Dangaard Brouer
This pktgen sample script is useful for scalability testing a receiver. The script will simply generate one flow per thread (option -t N) using the thread number as part of the source IP-address. The single flow sample (pktgen_sample03_burst_single_flow.sh) have become quite popular, but it is im

[PATCH v3 3/3] mac80211: mesh: fixed HT ies in beacon template

2016-07-13 Thread Yaniv Machani
The HT capab info field inside the HT capab IE of the mesh beacon is incorrect (in the case of 20MHz channel width). To fix this driver will check configuration from cfg and will build it accordingly. Signed-off-by: Meirav Kama Signed-off-by: Yaniv Machani --- V3 - Fixes redundant spaces,empty l

[net-next PATCH 1/3] pktgen: add sample script pktgen_sample04_many_flows.sh

2016-07-13 Thread Jesper Dangaard Brouer
Adding a pktgen sample script that demonstrates how to use pktgen for simulating flows. Script will generate a certain number of concurrent flows ($FLOWS) and each flow will contain $FLOWLEN packets, which will be send back-to-back, before switching to a new flow, due to flag FLOW_SEQ. This scrip

[net-next PATCH 3/3] pktgen: remove sample script pktgen.conf-1-1-rdos

2016-07-13 Thread Jesper Dangaard Brouer
Removing the pktgen sample script pktgen.conf-1-1-rdos, because it does not contain anything that is not covered by the other and newer style sample scripts. Signed-off-by: Jesper Dangaard Brouer --- samples/pktgen/pktgen.conf-1-1-rdos | 64 --- 1 file changed,

RE: [PATCH 1/4] mac80211: mesh: flush stations before beacons are stopped

2016-07-13 Thread Machani, Yaniv
On Wed, Jul 13, 2016 at 16:33:38, Bob Copeland wrote: > linux- wirel...@vger.kernel.org; netdev@vger.kernel.org; Hahn, Maital > Subject: Re: [PATCH 1/4] mac80211: mesh: flush stations before beacons > are stopped > > On Wed, Jul 13, 2016 at 10:11:25AM +, Machani, Yaniv wrote: > > > > Some dri

Re: linux-next: Tree for Jul 13 (net/core/devlink with Tracing)

2016-07-13 Thread Steven Rostedt
On Wed, 13 Jul 2016 08:12:16 -0700 Randy Dunlap wrote: > On 07/12/16 23:47, Stephen Rothwell wrote: > > Hi all, > > > > Changes since 20160712: > > > > on x86_64: > (full randconfig file is attached) > > > CC net/core/devlink.o > In file included from ../include/trace/define_trace.h

Re: [PATCH v7 09/11] net/mlx4_en: add xdp forwarding and data write support

2016-07-13 Thread Saeed Mahameed
On Wed, Jul 13, 2016 at 8:30 PM, Brenden Blanco wrote: > On Wed, Jul 13, 2016 at 06:25:28PM +0300, Saeed Mahameed wrote: >> On Tue, Jul 12, 2016 at 12:29 AM, Brenden Blanco >> wrote: [...] >> >> MAX_TX_RING is a software limitation made to limit netdev real_num_tx >> queues for CX3 internal cach

Re: [PATCH v2 net-next] net: vrf: Documentation update

2016-07-13 Thread David Miller
From: David Ahern Date: Wed, 13 Jul 2016 06:19:37 -0600 > Update vrf documentation for changes made to 4.4 - 4.8 kernels > and iproute2 support for vrf keyword. > > Signed-off-by: David Ahern > --- > v2 > - comments from Frank Kellerman: extra whitespace in front of a neigh show > command. Co

Re: [PATCH net 0/2] limit sk_filter trim to payload

2016-07-13 Thread David Miller
From: Willem de Bruijn Date: Tue, 12 Jul 2016 18:18:55 -0400 > From: Willem de Bruijn > > Sockets can apply a filter to incoming packets to drop or trim them. > Fix two codepaths that call skb_pull/__skb_pull after sk_filter > without checking for packet length. > > Reading beyond skb->tail af

Re: [PATCH v2 net] tcp: make challenge acks less predictable

2016-07-13 Thread Yue Cao
I see your point and I agree with you that SSL protects victims from this hijacking attack, especially with full HSTS. For Windows case, since Windows is a black box for us, we tested its Challenge ACK mechanism with Windows Server 2012 R2 Base and Windows Server 2008 R2 from Amazon EC2. The resul

Re: [PATCH net-next 00/10] Mellanox 100G mlx5 Bulk flow statistics and SRIOV TC offloads

2016-07-13 Thread David Miller
From: David Miller Date: Wed, 13 Jul 2016 11:46:25 -0700 (PDT) > Series applied, thanks. Actually, I have to revert. Please fix this build warning and resubmit, thanks. drivers/net/ethernet/mellanox/mlx5/core/fs_counters.c: In function ‘mlx5_fc_stats_work’: drivers/net/ethernet/mellanox/mlx5/

[iproute PATCH v4 4/5] No need to initialize rtattr fields before parsing

2016-07-13 Thread Phil Sutter
Since parse_rtattr_flags() calls memset already, there is no need for callers to do so themselves. Signed-off-by: Phil Sutter --- ip/ipaddress.c | 2 +- tc/tc_class.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/ip/ipaddress.c b/ip/ipaddress.c index cfcebe76af399..60

[iproute PATCH v4 2/5] Use C99 style initializers everywhere

2016-07-13 Thread Phil Sutter
This big patch was compiled by vimgrepping for memset calls and changing to C99 initializer if applicable. One notable exception is the initialization of union bpf_attr in tc/tc_bpf.c: changing it would break for older gcc versions (at least <=3.4.6). Calls to memset for struct rtattr pointer fiel

[iproute PATCH v4 1/5] tc: m_action: Improve conversion to C99 style initializers

2016-07-13 Thread Phil Sutter
This improves my initial change in the following points: - Flatten embedded struct's initializers. - No need to initialize variables to zero as the key feature of C99 initializers is to do this implicitly. - By relocating the declaration of struct rtattr *tail, it can be initialized at the sam

[iproute PATCH v4 5/5] Makefile: Allow to override CC

2016-07-13 Thread Phil Sutter
This makes it easier to build iproute2 with a custom compiler. While at it, make HOSTCC default to the value of CC if not explicitly set elsewhere. Signed-off-by: Phil Sutter --- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 15c81ecfd

[iproute PATCH v4 3/5] Replace malloc && memset by calloc

2016-07-13 Thread Phil Sutter
This only replaces occurrences where the newly allocated memory is cleared completely afterwards, as in other cases it is a theoretical performance hit although code would be cleaner this way. Signed-off-by: Phil Sutter --- Changes since v2: - Fix checkpatch errors. --- genl/genl.c| 3 +

Re: [PATCH net-next 00/10] Mellanox 100G mlx5 Bulk flow statistics and SRIOV TC offloads

2016-07-13 Thread David Miller
From: Saeed Mahameed Date: Wed, 13 Jul 2016 00:28:56 +0300 > This series from Amir and Or deals with two enhancements for the mlx5 TC > offloads. > > The 1st two patches add bulk reading of flow counters. Few bulk counter > queries are > used instead of issuing thousands firmware commands per

[iproute PATCH v4 0/5] Big C99 style initializer rework

2016-07-13 Thread Phil Sutter
This is v4 of my C99-style initializer related patch series. The changes since v3 are: - Use empty initializer instead of the universal zero initializer: The latter one triggers warnings in older GCCs, and this appears to be the least intrusive workaround. Plus, empty initializers are used a

Re: [PATCH net 0/2] mlx5 tx timeout watchdog fixes

2016-07-13 Thread David Miller
From: Saeed Mahameed Date: Wed, 13 Jul 2016 00:06:58 +0300 > This patch set provides two trivial fixes for the tx timeout series lately > applied into net 4.7. > > From Daniel, detect stuck queues due to BQL > From Mohamad, fix tx timeout watchdog false alarm > > Hopefully those two fixes will

Re: [PATCH net-next] net: vrf: Documentation update

2016-07-13 Thread David Miller
From: David Ahern Date: Tue, 12 Jul 2016 15:04:23 -0600 > Update vrf documentation for changes made to 4.4 - 4.8 kernels > and iproute2 support for vrf keyword. > > Signed-off-by: David Ahern Applied, thanks David.

pull-request: wireless-drivers-next 2016-07-13

2016-07-13 Thread Kalle Valo
Hi Dave, here's a pull request for net-next. This time there are few conflicts due to the cfg80211 scan API changes, and one of them is easy to miss, so please pay extra attention to them. Otherwise there's not nothing really out of ordinary. Please note that I also pulled wireless-drivers to wire

[PATCH net-next 6/6] sctp: only check for ECN if peer is using it

2016-07-13 Thread Marcelo Ricardo Leitner
Currently only read-only checks are performed up to the point on where we check if peer is ECN capable, checks which we can avoid otherwise. The flag ecn_ce_done is only used to perform this check once per incoming packet, and nothing more. Thus this patch moves the peer check up. Signed-off-by:

[PATCH net-next 0/6] sctp: allow GSO frags to access the chunk too

2016-07-13 Thread Marcelo Ricardo Leitner
Patchset is named after the most important fix in it. First two patches are preparing the grounds for the 3rd patch. After the 3rd, they are not strictly logically related to the patchset, but I kept them together as they depend on each other. More details on patch changelogs. Thanks! Marcelo R

[PATCH net-next 1/6] sctp: allow others to use sctp_input_cb

2016-07-13 Thread Marcelo Ricardo Leitner
We process input path in other files too and having access to it is nice, so move it to a header where it's shared. Signed-off-by: Marcelo Ricardo Leitner --- include/net/sctp/structs.h | 15 +++ net/sctp/input.c | 11 --- 2 files changed, 15 insertions(+), 11 delet

[PATCH net-next 4/6] sctp: avoid identifying address family many times for a chunk

2016-07-13 Thread Marcelo Ricardo Leitner
Identifying address family operations during rx path is not something expensive but it's ugly to the eye to have it done multiple times, specially when we already validated it during initial rx processing. This patch takes advantage of the now shared sctp_input_cb and make the pointer to the opera

[PATCH net-next 5/6] sctp: do not clear chunk->ecn_ce_done flag

2016-07-13 Thread Marcelo Ricardo Leitner
We should not clear that flag when switching to a new skb from a GSO skb because it would cause ECN processing to happen multiple times per GSO skb, which is not wanted. Instead, let it be processed once per chunk. That is, in other words, once per IP header available. Fixes: 90017accff61 ("sctp:

[PATCH net-next 3/6] sctp: allow GSO frags to access the chunk too

2016-07-13 Thread Marcelo Ricardo Leitner
SCTP will try to access original IP headers on sctp_recvmsg in order to copy the addresses used. There are also other places that do similar access to IP or even SCTP headers. But after 90017accff61 ("sctp: Add GSO support") they aren't always there because they are only present in the header skb.

[PATCH net-next 2/6] sctp: reorder sctp_ulpevent and shrink msg_flags

2016-07-13 Thread Marcelo Ricardo Leitner
The next patch needs 8 bytes in there. sctp_ulpevent has a hole due to bad alignment; msg_flags is using 4 bytes while it actually uses only 2, so we shrink it, and iif member (4 bytes) which can be easily fetched from another place once the next patch is there, so we remove it and thus creating sp

Re: [patch v2] net/mlx5: missing error code in esw_create_offloads_fdb_table()

2016-07-13 Thread Jason Gunthorpe
On Wed, Jul 13, 2016 at 02:48:44PM +0300, Dan Carpenter wrote: > We accidentally return success when we had intended to return an error > code. > > Fixes: 69697b6e2086 ('net/mlx5: E-Switch, Add support for the sriov offloads > mode') > Signed-off-by: Dan Carpenter > v2: return -ENOTSUPP instead

Re: [PATCH net] sock_diag: invert socket destroy broadcast check

2016-07-13 Thread Willem de Bruijn
On Fri, Jun 24, 2016 at 6:22 PM, Willem de Bruijn wrote: > On Fri, Jun 24, 2016 at 4:41 PM, Eric W. Biederman > wrote: >> Willem de Bruijn writes: >> >>> From: Willem de Bruijn >>> >>> Socket destruction is only broadcast for a socket sk if a diag >>> listener is registered and sk is not a kern

Re: Configure traffic class to bringup DCB in back-to-back setup

2016-07-13 Thread John Fastabend
On 16-07-13 02:09 AM, ayuj wrote: > I just checked TLV's. Below are the details: > OK so not really a netdev discussion seeing its just a user space protocol setup issue. Going forward probably drop netdev and add intel-wired-lan. > OS :- CentOS 7.2 > kernel 3.10.0-327.el7.x86_64 > lldpad:- lldp

Re: [patch v2] net/mlx5: missing error code in esw_create_offloads_fdb_table()

2016-07-13 Thread Leon Romanovsky
On Wed, Jul 13, 2016 at 02:48:44PM +0300, Dan Carpenter wrote: > We accidentally return success when we had intended to return an error > code. > > Fixes: 69697b6e2086 ('net/mlx5: E-Switch, Add support for the sriov offloads > mode') > Signed-off-by: Dan Carpenter > --- > v2: return -ENOTSUPP in

[PATCH 1/2] net: nps_enet: fix coding style issues

2016-07-13 Thread Elad Kanfi
From: Elad Kanfi Fix following coding style problems : ERROR: else should follow close brace '}' + } + else { /* !dst_is_aligned */ WARNING: Missing a blank line after declarations + u32 buf = nps_enet_reg_get(priv, NPS_ENET_REG_RX_BUF); +

Re: [PATCH v7 09/11] net/mlx4_en: add xdp forwarding and data write support

2016-07-13 Thread Brenden Blanco
On Wed, Jul 13, 2016 at 06:25:28PM +0300, Saeed Mahameed wrote: > On Tue, Jul 12, 2016 at 12:29 AM, Brenden Blanco wrote: > > A user will now be able to loop packets back out of the same port using > > a bpf program attached to xdp hook. Updates to the packet contents from > > the bpf program is a

Re: [PATCH 1/1] tracing, bpf: Implement function bpf_probe_write

2016-07-13 Thread Alexei Starovoitov
On Wed, Jul 13, 2016 at 03:36:11AM -0700, Sargun Dhillon wrote: > Provides BPF programs, attached to kprobes a safe way to write to > memory referenced by probes. This is done by making probe_kernel_write > accessible to bpf functions via the bpf_probe_write helper. not quite :) > Signed-off-by:

Re: [patch] net/mlx5: missing error code in esw_create_offloads_fdb_table()

2016-07-13 Thread Matan Barak
On 13/07/2016 13:08, Dan Carpenter wrote: We accidentally return success when we had intended to return an error code. Fixes: 69697b6e2086 ('net/mlx5: E-Switch, Add support for the sriov offloads mode') Signed-off-by: Dan Carpenter diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_

Re: [PATCH net-next 1/3] perf, events: add non-linear data support for raw records

2016-07-13 Thread Daniel Borkmann
On 07/13/2016 06:40 PM, Peter Zijlstra wrote: On Wed, Jul 13, 2016 at 04:08:55PM +0200, Daniel Borkmann wrote: On 07/13/2016 03:42 PM, Peter Zijlstra wrote: Ok so the nonlinear thing was it doing _two_ copies, one the regular __output_copy() on raw->data and second the optional fragment thingy

[PATCH] bonding: set carrier off for devices created through netlink

2016-07-13 Thread Beniamino Galvani
Commit e826eafa65c6 ("bonding: Call netif_carrier_off after register_netdevice") moved netif_carrier_off() from bond_init() to bond_create(), but the latter is called only for initial default devices and ones created through sysfs: $ modprobe bonding $ echo +bond1 > /sys/class/net/bonding_master

[PATCH] rndis_host: Set random MAC for ZTE MF910

2016-07-13 Thread Kristian Evensen
From: Kristian Evensen All ZTE MF910 mifis, at least on some revisions, export the same MAC address (36:4b:50:b7:ef:da). Check for this MAC address and set a random MAC if detected. Also, changed the memcpy() to ether_addr_copy(), as pointed out by checkpatch. Signed-off-by: Kristian Evensen -

Re: [PATCH net-next 1/3] perf, events: add non-linear data support for raw records

2016-07-13 Thread Peter Zijlstra
On Wed, Jul 13, 2016 at 04:08:55PM +0200, Daniel Borkmann wrote: > Hi Peter, > > On 07/13/2016 03:42 PM, Peter Zijlstra wrote: > > > >Ok so the nonlinear thing was it doing _two_ copies, one the regular > >__output_copy() on raw->data and second the optional fragment thingy > >using __output_custo

Re: [PATCH v3] Marvell phy: add fiber status check and configuration for some phys

2016-07-13 Thread Andrew Lunn
> +static int marvell_resume_fiber(struct phy_device *phydev) > +{ > +int err; > + > +/* Resume the fiber mode first */ > +err = phy_write(phydev, MII_MARVELL_PHY_PAGE, MII_M_FIBER); > +if (err < 0) > +goto

Re: [PATCH v8 06/11] net/mlx4_en: add page recycle to prepare rx ring for tx support

2016-07-13 Thread Brenden Blanco
On Wed, Jul 13, 2016 at 10:17:26AM +0300, Tariq Toukan wrote: > > On 13/07/2016 3:54 AM, Brenden Blanco wrote: > >On Tue, Jul 12, 2016 at 02:18:32PM -0700, David Miller wrote: > >>From: Brenden Blanco > >>Date: Tue, 12 Jul 2016 00:51:29 -0700 > >> > >>>+ mlx4_en_free_resources(priv); > >>>+ > >>

Re: [patch v2] net/mlx5: missing error code in esw_create_offloads_fdb_table()

2016-07-13 Thread Matan Barak
On 13/07/2016 14:48, Dan Carpenter wrote: We accidentally return success when we had intended to return an error code. Fixes: 69697b6e2086 ('net/mlx5: E-Switch, Add support for the sriov offloads mode') Signed-off-by: Dan Carpenter --- v2: return -ENOTSUPP instead --EINVAL diff --git a/driver

Re: [PATCH v7 09/11] net/mlx4_en: add xdp forwarding and data write support

2016-07-13 Thread Saeed Mahameed
On Tue, Jul 12, 2016 at 12:29 AM, Brenden Blanco wrote: > A user will now be able to loop packets back out of the same port using > a bpf program attached to xdp hook. Updates to the packet contents from > the bpf program is also supported. > > For the packet write feature to work, the rx buffers

Re: linux-next: Tree for Jul 13 (net/core/devlink with Tracing)

2016-07-13 Thread Randy Dunlap
On 07/12/16 23:47, Stephen Rothwell wrote: > Hi all, > > Changes since 20160712: > on x86_64: (full randconfig file is attached) CC net/core/devlink.o In file included from ../include/trace/define_trace.h:95:0, from ../include/trace/events/devlink.h:51,

Re: [PATCH v8 00/11] Add driver bpf hook for early packet drop and forwarding

2016-07-13 Thread Tariq Toukan
On 12/07/2016 5:38 PM, Tariq Toukan wrote: Regression tests for mlx4_en are currently running, results will be ready by tomorrow morning. Functional regression results look fine. Regards, Tariq

Re: [PATCH v8 04/11] net/mlx4_en: add support for fast rx drop bpf program

2016-07-13 Thread Brenden Blanco
On Wed, Jul 13, 2016 at 11:27:23AM +, David Laight wrote: > From: Brenden Blanco > > Sent: 12 July 2016 08:51 > > Add support for the BPF_PROG_TYPE_XDP hook in mlx4 driver. > > > > In tc/socket bpf programs, helpers linearize skb fragments as needed > > when the program touches the packet data

Re: [PATCH net-next 1/3] perf, events: add non-linear data support for raw records

2016-07-13 Thread Daniel Borkmann
Hi Peter, On 07/13/2016 03:42 PM, Peter Zijlstra wrote: Ok so the nonlinear thing was it doing _two_ copies, one the regular __output_copy() on raw->data and second the optional fragment thingy using __output_custom(). Would something like this work instead? It does the nonlinear thing and th

Re: [PATCH] net: ip_finish_output_gso: If skb_gso_network_seglen exceeds MTU, do segmentation even for non IPSKB_FORWARDED skbs

2016-07-13 Thread Shmulik Ladkani
Hi Florian, Hannes, On Tue, 12 Jul 2016 08:56:56 +0300 Shmulik Ladkani wrote: > On Sat, 9 Jul 2016 15:22:30 +0200 Florian Westphal wrote: > > > > > > > What about setting IPCB FORWARD flag in iptunnel_xmit if > > > > skb->skb_iif != 0... instead? > > I've came up with a suggestion tha

[PATCH 0/2] Code style fixes

2016-07-13 Thread Elad Kanfi
From: Elad Kanfi Fix all checkpatch warnings and errors, and reuse code Elad Kanfi (2): net: nps_enet: fix coding style issues net: nps_enet: code reuse drivers/net/ethernet/ezchip/nps_enet.c | 27 ++- 1 files changed, 14 insertions(+), 13 deletions(-)

Re: [RFC PATCH v3] net: sched: convert qdisc linked list to hashtable

2016-07-13 Thread Jiri Kosina
On Tue, 12 Jul 2016, Cong Wang wrote: > > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > > index f45929c..0b5c172e 100644 > > --- a/include/linux/netdevice.h > > +++ b/include/linux/netdevice.h > > @@ -52,6 +52,7 @@ > > #include > > #include > > #include > > +#include

Re: [PATCH v3] Marvell phy: add fiber status check and configuration for some phys

2016-07-13 Thread Charles-Antoine Couret
Hi Andrew, Le 13/07/2016 à 15:26, Andrew Lunn a écrit : * * Generic status code does not detect Fiber correctly! @@ -906,12 +1070,17 @@ static int marvell_read_status(struct phy_device *phydev) int lpa; int lpagb; int status = 0; + int page, f

Re: [PATCH net-next 1/3] perf, events: add non-linear data support for raw records

2016-07-13 Thread Peter Zijlstra
Ok so the nonlinear thing was it doing _two_ copies, one the regular __output_copy() on raw->data and second the optional fragment thingy using __output_custom(). Would something like this work instead? It does the nonlinear thing and the custom copy function thing but allows more than 2 fragmen

Re: [PATCH v3] Marvell phy: add fiber status check and configuration for some phys

2016-07-13 Thread Andrew Lunn
On Wed, Jul 13, 2016 at 11:14:21AM +0200, Charles-Antoine Couret wrote: Hi Charles-Antoine > >> +#define LPA_FIBER_1000HALF0x40 > >> +#define LPA_FIBER_1000FULL0x20 > >> + > >> +#define LPA_PAUSE_FIBER 0x180 > >> +#define LPA_PAUSE_ASYM_FIBER 0x100 > >> + > >> +#d

Re: [PATCH v2 6/6] dt-bindings: net: bgmac: add bindings documentation for bgmac

2016-07-13 Thread Rob Herring
On Thu, Jul 07, 2016 at 07:08:58PM -0400, Jon Mason wrote: > Signed-off-by: Jon Mason > --- > .../devicetree/bindings/net/brcm,amac.txt | 24 > ++ > .../devicetree/bindings/net/brcm,bgmac-nsp.txt | 24 > ++ > 2 files changed, 48 insertions(+)

Re: [PATCH 1/4] mac80211: mesh: flush stations before beacons are stopped

2016-07-13 Thread Bob Copeland
On Wed, Jul 13, 2016 at 10:11:25AM +, Machani, Yaniv wrote: > > > Some drivers (e.g. wl18xx) expect that the last stage in the > > > de-initialization process will be stopping the beacons, similar to ap. > > > Update ieee80211_stop_mesh() flow accordingly. > > > > > How well have you tested th

Re: [patch v2] net/mlx5: missing error code in esw_create_offloads_fdb_table()

2016-07-13 Thread Matan Barak
On 13/07/2016 16:04, Leon Romanovsky wrote: On Wed, Jul 13, 2016 at 02:48:44PM +0300, Dan Carpenter wrote: We accidentally return success when we had intended to return an error code. Fixes: 69697b6e2086 ('net/mlx5: E-Switch, Add support for the sriov offloads mode') Signed-off-by: Dan Carpent

Re: [PATCH v5 10/11] Documentation: dtb: xgene: Add MDIO node

2016-07-13 Thread Rob Herring
On Thu, Jul 07, 2016 at 04:02:58PM -0700, Iyappan Subramanian wrote: > Signed-off-by: Iyappan Subramanian > Tested-by: Fushen Chen > Tested-by: Toan Le > Tested-by: Matthias Brugger > --- > .../devicetree/bindings/net/apm-xgene-mdio.txt | 37 > ++ > 1 file changed, 37

Re: [PATCH net-next 1/3] perf, events: add non-linear data support for raw records

2016-07-13 Thread Daniel Borkmann
On 07/13/2016 02:10 PM, Peter Zijlstra wrote: On Wed, Jul 13, 2016 at 11:24:13AM +0200, Daniel Borkmann wrote: On 07/13/2016 09:52 AM, Peter Zijlstra wrote: On Wed, Jul 13, 2016 at 12:36:17AM +0200, Daniel Borkmann wrote: This patch adds support for non-linear data on raw records. It means tha

[PATCH -next] stmmac: dwmac-socfpga: remove redundant dev_err call in socfpga_dwmac_parse_data()

2016-07-13 Thread weiyj_lk
From: Wei Yongjun There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Wei Yongjun --- drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c | 17 +++-- 1 file changed, 3 insertions(+), 14 deletions

[PATCH -next] net: ethernet: bgmac: Remove redundant dev_err call in bgmac_probe()

2016-07-13 Thread weiyj_lk
From: Wei Yongjun There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Wei Yongjun --- drivers/net/ethernet/broadcom/bgmac-platform.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git

  1   2   >