Re: [patch v2] net/mlx5: missing error code in esw_create_offloads_fdb_table()

[Matan Barak]

On 13/07/2016 14:48, Dan Carpenter wrote:

We accidentally return success when we had intended to return an error
code.

Fixes: 69697b6e2086 ('net/mlx5: E-Switch, Add support for the sriov offloads 
mode')
Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com>
---
v2: return -ENOTSUPP instead --EINVAL

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c 
b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c
index 1842dfb..7d982cf 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c
@@ -183,6 +183,7 @@ static int esw_create_offloads_fdb_table(struct 
mlx5_eswitch *esw, int nvports)

        root_ns = mlx5_get_flow_namespace(dev, MLX5_FLOW_NAMESPACE_FDB);
        if (!root_ns) {
+               err = -ENOTSUPP;
                esw_warn(dev, "Failed to get FDB flow namespace\n");
                goto ns_err;
        }

Thanks.

Reviewed-by: Matan Barak <mat...@mellanox.com>