On 13/07/2016 16:04, Leon Romanovsky wrote:
On Wed, Jul 13, 2016 at 02:48:44PM +0300, Dan Carpenter wrote:
We accidentally return success when we had intended to return an error
code.
Fixes: 69697b6e2086 ('net/mlx5: E-Switch, Add support for the sriov offloads
mode')
Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com>
---
v2: return -ENOTSUPP instead --EINVAL
I'm a little bit confused. Why did you prefer ENOTSUPP over EOPNOTSUPP?
According to [1], it fits our case better - operation is valid and make
sense, but isn't supported.
[1] https://lists.gnu.org/archive/html/bug-glibc/2002-08/msg00017.html
Thanks.
