Re: [PATCH net 3/4] net/mlx4_en: Fix wrong csum complete report when rxvlan offload is disabled

2015-06-24 Thread Or Gerlitz
On 6/25/2015 1:01 AM, Eric Dumazet wrote: On Wed, 2015-06-24 at 18:22 +0300, Or Gerlitz wrote: From: Ido Shamay + if (be32_to_cpu(cqe->vlan_my_qpn) & MLX4_CQE_VLAN_PRESENT_MASK && + !(dev_features & NETIF_F_HW_VLAN_CTAG_RX)) { hw_checksum = get_fixed_vlan_csum(h

Re: [PATCH iproute2] ss: do not bindly dump two families

2015-06-24 Thread Eric Dumazet
On Wed, 2015-06-24 at 23:32 -0400, Stephen Hemminger wrote: > > I applied all 3 ss patches for the 4.1 release in progress. Thanks Stephen ! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http:

[PATCH] net/fsl: remove dependency FSL_SOC for Gianfar

2015-06-24 Thread Alison Wang
CONFIG_GIANFAR is not depended on FSL_SOC, it can be built on non-PPC platforms. Signed-off-by: Alison Wang --- drivers/net/ethernet/freescale/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/freescale/Kconfig b/drivers/net/ethernet/freescale/

Re: [PATCH iproute2] tests: Add output testing

2015-06-24 Thread Stephen Hemminger
On Thu, 18 Jun 2015 00:28:18 +0300 Vadim Kochan wrote: > From: Vadim Kochan > > Added possibility to check command output by grep from the testing > script. > > Now TMP_OUT & TMP_ERR are passed from Makefile and changed to > STD_ERR & STD_OUT. > > Also changed some existing tests to make outp

Re: [PATCH iproute2] ss: do not bindly dump two families

2015-06-24 Thread Stephen Hemminger
On Fri, 29 May 2015 05:37:49 -0700 Eric Dumazet wrote: > From: Eric Dumazet > > ss currently dumps IPv4 sockets, then IPv6 sockets from the kernel, > even if -4 or -6 option was given. Filtering in user space then has to > drop all sockets of wrong family. Such a waste of time... > > Before :

Re: [PATCH iproute2] ss: Fix allocation of cong control alg name

2015-06-24 Thread Stephen Hemminger
On Fri, 29 May 2015 18:48:42 +0200 Daniel Borkmann wrote: > On 05/29/2015 06:17 PM, Guzman Mosqueda, Jose R wrote: > > Hi Daniel and Vadim > > > > Thanks for your prompt response and for the patch. > > > > Also, what about the other one? Do you think it is an issue or not? > > > > " File: tc/tc_u

Re: [PATCH iproute2] ss: Correct state 'listen' to 'listening' in docs and command help

2015-06-24 Thread Stephen Hemminger
On Tue, 9 Jun 2015 19:49:01 -0700 "Brian Dyson" wrote: > Minor change to correct states in ss command documentation and command line > help. > The correct state term is 'listening' not 'listen' (see definition of > sstate_namel in misc/ss.c). > > Signed-off-by: Brian Dyson > --- > doc/ss.sgml

Re: [PATCH v2 2/4] net: dsa: add support for switchdev VLAN objects

2015-06-24 Thread Scott Feldman
On Wed, Jun 24, 2015 at 11:50 AM, Vivien Didelot wrote: > This patch adds the glue between DSA and switchdev operations to add, > delete and dump SWITCHDEV_OBJ_PORT_VLAN objects. > > This is a first step to link the "bridge vlan" command with hardware > entries for DSA compatible switch chips. > >

RE: [GIT] Networking

2015-06-24 Thread Weiny, Ira
Linus, > > On the *other* side of the same conflict, I find an even more offensive > commit, > namely commit 4cd7c9479aff ("IB/mad: Add support for additional MAD info > to/from drivers") which adds a BUG_ON() for a sanity check, rather than just > returning -EINVAL or something sane like that.

parsing the output of ethtool programmatically

2015-06-24 Thread Robert Urban
Hello, there doesn't seem to be any flag to request ethtool to present its output in a script-friendly form. Things like: > Link partner advertised link modes: 10baseT/Half 10baseT/Full > 100baseT/Half 100baseT/Full >

Re: [RFC] virtio_net: Adding tx_timeout function.

2015-06-24 Thread Julio Faracco
2015-06-24 3:10 GMT-03:00 Michael S. Tsirkin : > > On Tue, Jun 23, 2015 at 10:44:29PM -0300, Julio Faracco wrote: > > virtio_net paravirtualized driver does not have a tx_timeout() function to > > guarantee that the driver will recover properly after receiving a timeout > > during a transmission of

RE: [PATCH v2 00/22] FUJITSU Extended Socket network device driver

2015-06-24 Thread Izumi, Taku
Thanks for your comment. > -Original Message- > From: platform-driver-x86-ow...@vger.kernel.org > [mailto:platform-driver-x86-ow...@vger.kernel.org] On Behalf Of Jesper > Dangaard Brouer > Sent: Wednesday, June 24, 2015 10:41 PM > To: Izumi, Taku/泉 拓 > Cc: bro...@redhat.com; netdev@vger.

RE: [PATCH v2 01/22] fjes: Introduce FUJITSU Extended Socket Network Device driver

2015-06-24 Thread Izumi, Taku
Thanks for your help. > -Original Message- > From: platform-driver-x86-ow...@vger.kernel.org > [mailto:platform-driver-x86-ow...@vger.kernel.org] On Behalf Of Joe > Perches > Sent: Wednesday, June 24, 2015 3:51 PM > To: Izumi, Taku/泉 拓 > Cc: netdev@vger.kernel.org; da...@davemloft.net;

Re: [GIT] Networking

2015-06-24 Thread Linus Torvalds
On Wed, Jun 24, 2015 at 6:39 AM, David Miller wrote: > > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master Just going through the conflicts, I see commit 7193a141eb74 ("IB/mlx4: Set VF to read from QP counters"), and wonder... Is that code really supposed to fall through

Re: [PATCH net 3/4] net/mlx4_en: Fix wrong csum complete report when rxvlan offload is disabled

2015-06-24 Thread Eric Dumazet
On Wed, 2015-06-24 at 18:22 +0300, Or Gerlitz wrote: > From: Ido Shamay > > + if (be32_to_cpu(cqe->vlan_my_qpn) & MLX4_CQE_VLAN_PRESENT_MASK && > + !(dev_features & NETIF_F_HW_VLAN_CTAG_RX)) { > hw_checksum = get_fixed_vlan_csum(hw_checksum, hdr); > hdr +=

[v2,8/9] fsl/fman: Add FMan Port Support

2015-06-24 Thread igal.liberman
From: Madalin Bucur This patch adds The FMan Port configuration, initialization and runtime control routines. Signed-off-by: Igal Liberman --- drivers/net/ethernet/freescale/fman/Makefile |2 +- drivers/net/ethernet/freescale/fman/fm.c | 465 ++- drivers/net/ethernet/f

[v2,9/9] fsl/fman: Add FMan MAC driver

2015-06-24 Thread igal . liberman
From: Igal Liberman This patch adds the Ethernet MAC driver support. Signed-off-by: Igal Liberman Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/fman/inc/mac.h | 136 drivers/net/ethernet/freescale/fman/mac/Makefile |3 +- drivers/net/ethernet/freescale/fman/ma

[v2,7/9] fsl/fman: Add FMan SP support

2015-06-24 Thread igal . liberman
From: Igal Liberman Add Storage Profiles support. The Storage Profiles contain parameters that are used by the FMan in order to store frames being received on the Rx ports, or to determine the parameters that affect writing the Internal Context in the frame margin on Tx. Signed-off-by: Igal Libe

[v2,5/9] fsl/fman: Add Frame Manager support

2015-06-24 Thread igal.liberman
From: Igal Liberman Add Frame Manger Driver support. This patch adds The FMan configuration, initialization and runtime control routines. Signed-off-by: Igal Liberman --- drivers/net/ethernet/freescale/fman/Kconfig| 35 + drivers/net/ethernet/freescale/fman/Makefile |2 +-

[v2,6/9] fsl/fman: Add FMan MAC support

2015-06-24 Thread igal.liberman
From: Igal Liberman Add Frame Manger MAC Driver support. This patch adds The FMan MAC configuration, initialization and runtime control routines. This patch contains support for these types of MACs: tGEC, dTSEC and mEMAC Signed-off-by: Igal Liberman Signed-off-by: Madalin Bucur --- dr

[v2,4/9] fsl/fman: Add FMan MURAM support

2015-06-24 Thread igal . liberman
From: Igal Liberman Add Frame Manager Multi-User RAM support. Signed-off-by: Igal Liberman --- drivers/net/ethernet/freescale/fman/Kconfig|1 + drivers/net/ethernet/freescale/fman/Makefile |6 +- drivers/net/ethernet/freescale/fman/fm_muram.c | 127 ++

[v2,3/9] fsl/fman: Add the FMan MAC FLIB

2015-06-24 Thread igal.liberman
From: Igal Liberman The FMan MAC FLib provides basic API used by the drivers to configure and control the FMan MAC hardware. Signed-off-by: Igal Liberman --- drivers/net/ethernet/freescale/fman/Makefile |1 + .../net/ethernet/freescale/fman/flib/fsl_enet.h| 135 .../etherne

[v2,2/9] fsl/fman: Add the FMan port FLIB

2015-06-24 Thread igal . liberman
From: Igal Liberman The FMan Port FLib provides basic API used by the drivers to configure and control the FMan Port hardware. Signed-off-by: Igal Liberman --- drivers/net/ethernet/freescale/fman/Kconfig|1 + drivers/net/ethernet/freescale/fman/Makefile |2 + .../ethernet

[v2,1/9] fsl/fman: Add the FMan FLIB

2015-06-24 Thread igal.liberman
From: Igal Liberman The FMan FLib provides the basic API used by the FMan drivers to configure and control the FMan hardware. Signed-off-by: Igal Liberman --- drivers/net/ethernet/freescale/Kconfig |1 + drivers/net/ethernet/freescale/Makefile|2 + drivers/net/e

[v2,0/9] Freescale DPAA FMan

2015-06-24 Thread igal . liberman
From: Igal Liberman The Freescale Data Path Acceleration Architecture (DPAA) is a set of hardware components on specific QorIQ multicore processors. This architecture provides the infrastructure to support simplified sharing of networking interfaces and accelerators by multiple CPU cores and

[PATCH v2 2/4] net: dsa: add support for switchdev VLAN objects

2015-06-24 Thread Vivien Didelot
This patch adds the glue between DSA and switchdev operations to add, delete and dump SWITCHDEV_OBJ_PORT_VLAN objects. This is a first step to link the "bridge vlan" command with hardware entries for DSA compatible switch chips. Signed-off-by: Vivien Didelot --- include/net/dsa.h | 9 n

[PATCH v2 3/4] net: dsa: mv88e6xxx: add support to dump VLANs

2015-06-24 Thread Vivien Didelot
This commit implements the port_vlan_dump function in the dsa_switch_driver structure for Marvell 88E6xxx compatible switches. This allows to access a switch VLAN Table Unit from standard userspace commands such as "bridge vlan show". A populated VTU can give the following output: # bridge v

[PATCH v2 0/4] net: dsa: mv88e6352: add support for VLAN Table Unit

2015-06-24 Thread Vivien Didelot
Hi all, This patchset brings full support for hardware VLANs in DSA, and the Marvell 88E6352 and compatible switch chips. Patches 1/4 to 3/4 are ready to be applied. However, patch 4/4 brought some concerns about the management of the forwarding database [1]. That might be updated in future patch

[PATCH v2 4/4] net: dsa: mv88e6xxx: add support to add/del VLANs

2015-06-24 Thread Vivien Didelot
This commit implements the port_vlan_add and port_vlan_del functions in the dsa_switch_driver structure for Marvell 88E6xxx compatible switches. This allows to access a switch VLAN Table Unit from standard userspace commands such as "bridge vlan add" and "bridge vlan del". A configuration like "V

[PATCH v2 1/4] net: dsa: mv88e6xxx: add debugfs interface for VTU

2015-06-24 Thread Vivien Didelot
Implement the Get Next operation for the VLAN Table Unit, and a "vtu" debugfs file to dump the hardware VLANs. A populated VTU can look like this: # cat /sys/kernel/debug/dsa0/vtu VID FID SID P0 P1 P2 P3 P4 P5 P6 550 562 0x x x u x t x 1000 1012 0x x t x x

Re: [patch -next] renesas: missing unlock on error path

2015-06-24 Thread Sergei Shtylyov
Hello. On 06/24/2015 05:32 PM, Dan Carpenter wrote: We need to unlock before returning here. Indeed. Sorry about missing that. Fixes: a0d2f20650e8 ('Renesas Ethernet AVB PTP clock driver') Signed-off-by: Dan Carpenter Acked-by: Sergei Shtylyov WBR, Sergei -- To unsubscribe from th

Re: sock_hold and sock_put

2015-06-24 Thread Eric Dumazet
On Wed, 2015-06-24 at 19:44 +0530, ratheesh kannoth wrote: > On Wed, Jun 24, 2015 at 6:16 PM, Eric Dumazet wrote: > > You misunderstood the comment. > > > > Comment only stated that sock_hold() must be used in contexts where > > caller owns a reference (and will eventually release it later with >

[PATCH net 3/4] net/mlx4_en: Fix wrong csum complete report when rxvlan offload is disabled

2015-06-24 Thread Or Gerlitz
From: Ido Shamay The check_csum() function relied on hwtstamp_rx_filter to know if rxvlan offload is disabled. This is wrong since rxvlan offload can be switched on/off regardless of hwtstamp_rx_filter. Also moved check_csum to query CQE information to identify VLAN packets and removed the check

[PATCH net 1/4] net/mlx4_en: Release TX QP when destroying TX ring

2015-06-24 Thread Or Gerlitz
From: Eran Ben Elisha TX ring QP wasn't released at mlx4_en_destroy_tx_ring. Instead, the code used the deprecated base_tx_qpn field. Move TX QP release to mlx4_en_destroy_tx_ring and remove the base_tx_qpn field. Fixes: ddae0349fdb7 ('net/mlx4: Change QP allocation scheme') Signed-off-by: Eran

[PATCH net 0/4] mlx4 driver fixes, June 24, 2015

2015-06-24 Thread Or Gerlitz
Hi Dave, Some fixes that we made recently, all need to go into stable. patch #1 "net/mlx4_en: Release TX QP when destroying TX ring" and patch #3 "Fix wrong csum complete report when rxvlan offload is disabled" to >= 3.19 patch #2 "Wake TX queues only when there's enough room" addressing a bug

[PATCH net 2/4] net/mlx4_en: Wake TX queues only when there's enough room

2015-06-24 Thread Or Gerlitz
From: Ido Shamay Indication of a single completed packet, marked by txbbs_skipped being bigger then zero, in not enough in order to wake up a stopped TX queue. The completed packet may contain a single TXBB, while next packet to be sent (after the wake up) may have multiple TXBBs (LSO/TSO packets

[PATCH net 4/4] mlx4: Disable HA for SRIOV PF RoCE devices

2015-06-24 Thread Or Gerlitz
When in HA mode, the driver exposes an IB (RoCE) device instance with only one port. Under SRIOV, the existing implementation doesn't go well with the PF RoCE driver's role of Special QPs Para-Virtualization and such. As such, disable HA for the mlx4 PF RoCE device in SRIOV mode. Fixes: a57500903

Re: [PATCH RFC] vhost: add ioctl to query nregions upper limit

2015-06-24 Thread Michael S. Tsirkin
On Wed, Jun 24, 2015 at 04:52:29PM +0200, Igor Mammedov wrote: > On Wed, 24 Jun 2015 16:17:46 +0200 > "Michael S. Tsirkin" wrote: > > > On Wed, Jun 24, 2015 at 04:07:27PM +0200, Igor Mammedov wrote: > > > On Wed, 24 Jun 2015 15:49:27 +0200 > > > "Michael S. Tsirkin" wrote: > > > > > > > Userspa

Re: [PATCH RFC] vhost: add ioctl to query nregions upper limit

2015-06-24 Thread Igor Mammedov
On Wed, 24 Jun 2015 16:17:46 +0200 "Michael S. Tsirkin" wrote: > On Wed, Jun 24, 2015 at 04:07:27PM +0200, Igor Mammedov wrote: > > On Wed, 24 Jun 2015 15:49:27 +0200 > > "Michael S. Tsirkin" wrote: > > > > > Userspace currently simply tries to give vhost as many regions > > > as it happens to

[patch -next] cavium/liquidio: fix some error handling in lio_set_phys_id()

2015-06-24 Thread Dan Carpenter
There was a missing assignment so the "if (ret)" on the next line is never true. Fixes: f21fb3ed364b ('Add support of Cavium Liquidio ethernet adapters') Signed-off-by: Dan Carpenter diff --git a/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c b/drivers/net/ethernet/cavium/liquidio/lio_ethto

[patch -next] renesas: missing unlock on error path

2015-06-24 Thread Dan Carpenter
We need to unlock before returning here. Fixes: a0d2f20650e8 ('Renesas Ethernet AVB PTP clock driver') Signed-off-by: Dan Carpenter diff --git a/drivers/net/ethernet/renesas/ravb_ptp.c b/drivers/net/ethernet/renesas/ravb_ptp.c index 42656da..7a8ce92 100644 --- a/drivers/net/ethernet/renesas/rav

Behaviour of sysctl net.ipv6.conf.all.* parameters

2015-06-24 Thread Tero Marttila
Hi, I was exploring the behavior of various net.ipv6.conf.all parameters such as use_tempaddr on Linux 3.16, but the behavior doesn't seem to make sense. The following settings do *not* result in privacy addresses on eth0: net.ipv6.conf.all.use_tempaddr=2 net.ipv6.conf.eth0.use_t

Re: [PATCH RFC] vhost: add ioctl to query nregions upper limit

2015-06-24 Thread Michael S. Tsirkin
On Wed, Jun 24, 2015 at 04:07:27PM +0200, Igor Mammedov wrote: > On Wed, 24 Jun 2015 15:49:27 +0200 > "Michael S. Tsirkin" wrote: > > > Userspace currently simply tries to give vhost as many regions > > as it happens to have, but you only have the mem table > > when you have initialized a large p

Re: sock_hold and sock_put

2015-06-24 Thread ratheesh kannoth
On Wed, Jun 24, 2015 at 6:16 PM, Eric Dumazet wrote: > You misunderstood the comment. > > Comment only stated that sock_hold() must be used in contexts where > caller owns a reference (and will eventually release it later with > sock_put(). > > There is nothing about having a lock here. Thanks. I

Re: [PATCH RFC] vhost: add ioctl to query nregions upper limit

2015-06-24 Thread Igor Mammedov
On Wed, 24 Jun 2015 15:49:27 +0200 "Michael S. Tsirkin" wrote: > Userspace currently simply tries to give vhost as many regions > as it happens to have, but you only have the mem table > when you have initialized a large part of VM, so graceful > failure is very hard to support. > > The result i

[PATCH RFC] vhost: add ioctl to query nregions upper limit

2015-06-24 Thread Michael S. Tsirkin
Userspace currently simply tries to give vhost as many regions as it happens to have, but you only have the mem table when you have initialized a large part of VM, so graceful failure is very hard to support. The result is that userspace tends to fail catastrophically. Instead, add a new ioctl so

Re: [PATCH v2 00/22] FUJITSU Extended Socket network device driver

2015-06-24 Thread Jesper Dangaard Brouer
On Wed, 24 Jun 2015 11:52:31 +0900 Taku Izumi wrote: > This patchsets adds FUJITSU Extended Socket network device driver. > Extended Socket network device is a shared memory based high-speed network > interface between Extended Partitions of PRIMEQUEST 2000 E2 series. > > You can get some inform

Re: merge window freeze

2015-06-24 Thread Nikolay Aleksandrov
> On Jun 24, 2015, at 3:41 PM, David Miller wrote: > > From: Nikolay Aleksandrov > Date: Wed, 24 Jun 2015 13:25:47 +0300 > >> I noticed that both of my bridge patches are marked with “Changes >> Requested”, but >> there was no feedback why and also the first one: >> "bridge: multicast: add a

[PATCH for-next V6 00/10] Move RoCE GID management to IB/Core

2015-06-24 Thread Matan Barak
This series has been running in linux-rdma for a while. We added here CC to netdev for the three pre-patches which come first. They allow the IB core to access some helpers (e.g generating default Eth IPv6 link local address), gain more info on bonding changes, etc. Previously, every vendor imple

[PATCH for-next V6 03/10] net/bonding: Export bond_option_active_slave_get_rcu

2015-06-24 Thread Matan Barak
Some consumers of the netdev events API would like to know who is the active slave when a NETDEV_CHANGEUPPER or NETDEV_BONDING_FAILOVER events occur. For example, when managing RoCE GIDs, GIDs based on the bond's ips should only be set on the port which corresponds to active slave netdevice. Signe

[PATCH for-next V6 02/10] net: Add info for NETDEV_CHANGEUPPER event

2015-06-24 Thread Matan Barak
Some consumers of NETDEV_CHANGEUPPER event would like to know which upper device was linked/unlinked and what operation was carried. Add information in the notifier info block for that purpose. Signed-off-by: Matan Barak --- include/linux/netdevice.h | 14 ++ net/core/dev.c

[PATCH for-next V6 01/10] net/ipv6: Export addrconf_ifid_eui48

2015-06-24 Thread Matan Barak
For loopback purposes, RoCE devices should have a default GID in the port GID table, even when the interface is down. In order to do so, we use the IPv6 link local address which would have been genenrated for the related Ethernet netdevice when it goes up as a default GID. addrconf_ifid_eui48 is u

Re: sock_hold and sock_put

2015-06-24 Thread Eric Dumazet
On Wed, 2015-06-24 at 14:47 +0530, ratheesh kannoth wrote: > Hi list, > > There is a comment on sock_hold() function - > > 561 /* Grab socket reference count. This operation is valid only > 562when sk is ALREADY grabbed f.e. it is found in hash table > 563or a list and the lookup is made

atl1c from linux-4.0.5 fails the probe

2015-06-24 Thread Alexander V. Lukyanov
Hello! https://bugzilla.redhat.com/show_bug.cgi?id=1234825 After upgrade kernel 3.19.8-100.fc20.i686 -> kernel-4.0.5-200.fc21.i686 the module atl1c fails to detect my ethernet controller. It produces the following error message: Jun 23 10:58:38 node2 kernel: [1.397542] atl1c :02:00.0: M

Re: [PATCH net-next] enic: use atomic_t instead of spin_lock in busy poll

2015-06-24 Thread David Miller
From: Govindarajulu Varadarajan <_gov...@gmx.com> Date: Wed, 24 Jun 2015 15:56:17 +0530 (IST) > Let me know if this change is OK, I will send new patch with detailed > description. Yes, and please do. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to

Re: merge window freeze

2015-06-24 Thread David Miller
From: Nikolay Aleksandrov Date: Wed, 24 Jun 2015 13:25:47 +0300 > I noticed that both of my bridge patches are marked with “Changes Requested”, > but > there was no feedback why and also the first one: > "bridge: multicast: add a comment to br_port_state_selection about blocking > state” > was

[RFC][PATCH v2] ppp: remove NULL check before kfree

2015-06-24 Thread Maninder Singh
Removes NULL check before kfree and using tabs in place of space. and removing checkpatch warning: labels should not be indented. Signed-off-by: Maninder Singh Reviewed-by: Vaneet narang --- drivers/net/ppp/ppp_mppe.c | 24 +++- 1 file changed, 11 insertions(+), 13 deleti

[PATCH iproute2] ss: print value of IPV6_V6ONLY socket option if set

2015-06-24 Thread Phil Sutter
If available and set, print 'v6only:1' for AF_INET6 sockets upon request of extended information. For IPv6 sockets bound to in6addr_any, this is the only way to determine if they will also accept IPv4 requests or not. Signed-off-by: Phil Sutter --- Depends on unapplied patch 'ss: Include -E optio

Re: [PATCH 1/1] ppp: remove NULL check before kfree

2015-06-24 Thread Maninder Singh
>No need of explicit NULL check before kfree, >removing the same and little coding style changes. > >Signed-off-by: Maninder Singh >Reviewed-by: Vaneet narang >--- > drivers/net/ppp/ppp_mppe.c | 10 -- > 1 file changed, 4 insertions(+), 6 deletions(-) > >diff --git a/drivers/net/ppp/ppp

Re: [PATCH net-next] enic: use atomic_t instead of spin_lock in busy poll

2015-06-24 Thread Govindarajulu Varadarajan
On Wed, 24 Jun 2015, David Miller wrote: From: Govindarajulu Varadarajan <_gov...@gmx.com> Date: Tue, 23 Jun 2015 21:47:50 +0530 -static inline bool enic_poll_unlock_napi(struct vnic_rq *rq) +static inline void enic_poll_unlock_napi(struct vnic_rq *rq, +

Re: merge window freeze

2015-06-24 Thread Nikolay Aleksandrov
> On Jun 24, 2015, at 12:53 PM, David Miller wrote: > > > I've processed all of my patch backlog and plan to do some merging > then prepare a pull request of net-next for Linus. > > DO NOT submit any net-next changes at this time, please instead > wait for net-next to open up again (should be

Issue with LACP mode support in Linux bonding driver

2015-06-24 Thread Ajith Adapa
Hi, I am using Centos7 with v3.10 kernel. My issue is related to multiaggregation in LACP. In my setup topology I connected linux server and a L2 switch back to back with 2 interfaces eth0 and eth1 (on both sides). On Switch I have mapped eth0 to po1 and eth1 to po2. On linux server I have crea

merge window freeze

2015-06-24 Thread David Miller
I've processed all of my patch backlog and plan to do some merging then prepare a pull request of net-next for Linus. DO NOT submit any net-next changes at this time, please instead wait for net-next to open up again (should be some time next week or so). Bug fixes, of course, are always welcome

[PATCH 1/1] ppp: remove NULL check before kfree

2015-06-24 Thread Maninder Singh
No need of explicit NULL check before kfree, removing the same and little coding style changes. Signed-off-by: Maninder Singh Reviewed-by: Vaneet narang --- drivers/net/ppp/ppp_mppe.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/net/ppp/ppp_mppe.c b/d

Re: [PATCH v2] net: inet_diag: export IPV6_V6ONLY sockopt

2015-06-24 Thread David Miller
From: Phil Sutter Date: Wed, 24 Jun 2015 11:02:51 +0200 > For AF_INET6 sockets, the value of struct ipv6_pinfo.ipv6only is > exported to userspace. It indicates whether a socket bound to in6addr_any > listens on IPv4 as well as IPv6. Since the socket is natively IPv6, it is not > listed by e.g. '

Re: [PATCH v3] stmmac: troubleshoot unexpected bits in des0 & des1

2015-06-24 Thread David Miller
From: Alexey Brodkin Date: Wed, 24 Jun 2015 11:47:41 +0300 > Current implementation of descriptor init procedure only takes > care about setting/clearing ownership flag in "des0"/"des1" > fields while it is perfectly possible to get unexpected bits > set because of the following factors: Applied

Re: [PATCH net-next 0/3 v7] changes to make ipv4 routing table aware of next-hop link status

2015-06-24 Thread David Miller
From: Andy Gospodarek Date: Tue, 23 Jun 2015 13:45:35 -0400 > This series adds the ability to have the Linux kernel track whether or > not a particular route should be used based on the link-status of the > interface associated with the next-hop. Kernel bits applied, thanks Andy. -- To unsubsc

sock_hold and sock_put

2015-06-24 Thread ratheesh kannoth
Hi list, There is a comment on sock_hold() function - 561 /* Grab socket reference count. This operation is valid only 562when sk is ALREADY grabbed f.e. it is found in hash table 563or a list and the lookup is made under lock preventing hash table 564modifications. 565 */ But i co

Re: [PATCH 3/3] net: dsa: mv88e6352: add support for port_vlan_dump

2015-06-24 Thread David Miller
From: Vivien Didelot Date: Tue, 23 Jun 2015 17:46:10 -0400 > Add support for dumping the VLAN Table Unit entries by pointing to the > port_vlan_dump function implemented for mv88e6xxx. > > Signed-off-by: Vivien Didelot There is no reason to separate this from patch #2. -- To unsubscribe from t

[PATCH v2] net: inet_diag: export IPV6_V6ONLY sockopt

2015-06-24 Thread Phil Sutter
For AF_INET6 sockets, the value of struct ipv6_pinfo.ipv6only is exported to userspace. It indicates whether a socket bound to in6addr_any listens on IPv4 as well as IPv6. Since the socket is natively IPv6, it is not listed by e.g. 'ss -l -4'. This patch is accompanied by an appropriate one for ip

[PATCH v3] stmmac: troubleshoot unexpected bits in des0 & des1

2015-06-24 Thread Alexey Brodkin
Current implementation of descriptor init procedure only takes care about setting/clearing ownership flag in "des0"/"des1" fields while it is perfectly possible to get unexpected bits set because of the following factors: [1] On driver probe underlying memory allocated with dma_alloc_coheren

Re: [PATCH v2] stmmac: troubleshoot unexpected bits in des0 & des1

2015-06-24 Thread Alexey Brodkin
Hi David, On Wed, 2015-06-24 at 01:44 -0700, David Miller wrote: > From: Alexey Brodkin > Date: Wed, 24 Jun 2015 11:07:26 +0300 > > > > > - priv->dma_tx = dma_alloc_coherent(priv->device, > > txsize * > > + priv->dma_tx = dma_zalloc_coherent(priv->device, > > txsize * > >

Re: [PATCH v2] stmmac: troubleshoot unexpected bits in des0 & des1

2015-06-24 Thread David Miller
From: Alexey Brodkin Date: Wed, 24 Jun 2015 11:07:26 +0300 > > - priv->dma_tx = dma_alloc_coherent(priv->device, txsize * > + priv->dma_tx = dma_zalloc_coherent(priv->device, txsize * > sizeof(struct dma_desc), >

Re: [PATCH] net: dsa: add support for switchdev VLAN objects

2015-06-24 Thread David Miller
From: Vivien Didelot Date: Tue, 23 Jun 2015 13:18:49 -0400 > This patch adds the glue between DSA and switchdev operations to add, > delete and dump SWITCHDEV_OBJ_PORT_VLAN objects. > > This is a first step to link the "bridge vlan" command with hardware > entries for DSA compatible switch chips

[PATCH net-next v1 1/1] drivers: net: xgene: Fix the compilation error "error: implicit declaration of function 'acpi_evaluate_integer'" in APM X-Gene ethernet driver.

2015-06-24 Thread Suman Tripathi
This patch guards the acpi_evaluate_interger function as it fails the build for NON_ACPI CONFIG. Signed-off-by: Iyappan Subramanian Signed-off-by: Suman Tripathi Reported-by: kbuild test robot --- drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --

[PATCH net-next v1 0/1]drivers: net: xgene: Fix the ACPI support for RGMII/SGMII0/XFI ethernet interfaces of APM X-Gene SoC.

2015-06-24 Thread Suman Tripathi
v1 change: * Fix the compilation error. * Drop other patches as it got accepted. Signed-off-by: Iyappan Subramanian Signed-off-by: Suman Tripathi --- Suman Tripathi (1): drivers: net: xgene: Fix the compilation error "error: implicit declaration of function 'acpi_evaluate_integer'" in A

Re: [PATCH net-next] enic: use atomic_t instead of spin_lock in busy poll

2015-06-24 Thread David Miller
From: Govindarajulu Varadarajan <_gov...@gmx.com> Date: Tue, 23 Jun 2015 21:47:50 +0530 > -static inline bool enic_poll_unlock_napi(struct vnic_rq *rq) > +static inline void enic_poll_unlock_napi(struct vnic_rq *rq, > + struct napi_struct *napi) > { > - bo

[PATCH v2] stmmac: troubleshoot unexpected bits in des0 & des1

2015-06-24 Thread Alexey Brodkin
Current implementation of descriptor init procedure only takes care about setting/clearing ownership flag in "des0"/"des1" fields while it is perfectly possible to get unexpected bits set because of the following factors: [1] On driver probe underlying memory allocated with dma_alloc_coheren

Re: [PATCH] net: switchdev: ignore unsupported bridge flags

2015-06-24 Thread David Miller
From: Jiri Pirko Date: Tue, 23 Jun 2015 17:09:20 +0200 > Tue, Jun 23, 2015 at 04:26:04PM CEST, vivien.dide...@savoirfairelinux.com > wrote: >>switchdev_port_bridge_getlink() queries SWITCHDEV_ATTR_PORT_BRIDGE_FLAGS >>attributes, but a driver doesn't need to implement this in order to get >>bridg

Re: [PATCH v3] net: Cavium: Fix MAC address setting in shutdown state

2015-06-24 Thread David Miller
From: Pavel Fedin Date: Tue, 23 Jun 2015 17:51:06 +0300 > This bug pops up with NetworkManager on Fedora 21. NetworkManager tends to > stop the interface (nicvf_stop() is called) before changing settings. In > stopped state MAC cannot be sent to a PF. However, when the interface is > restarted (n

Re: linux-next: build failure after merge of the net-next tree

2015-06-24 Thread David Miller
From: Stephen Rothwell Date: Wed, 24 Jun 2015 17:37:10 +1000 > I have applied this patch for today: > > From: Stephen Rothwell > Date: Wed, 24 Jun 2015 17:29:51 +1000 > Subject: [PATCH] drivers: net: xgene: fix for ACPI support without ACPI > > Signed-off-by: Stephen Rothwell Applied, thanks

Re: [PATCH 1/2] sh_eth: Remove obsolete r7s72100-ether platform_device_id entry

2015-06-24 Thread Geert Uytterhoeven
Hi David, On Wed, Jun 24, 2015 at 9:55 AM, David Miller wrote: > From: Geert Uytterhoeven > Date: Tue, 23 Jun 2015 15:01:01 +0200 > >> Since commit 05104c266ae9a167 ("ARM: shmobile: r7s72100: genmai: Remove >> legacy board file"), r7s72100 is only supported in generic DT-only ARM >> multi-platfo

Re: [PATCH 1/2] sh_eth: Remove obsolete r7s72100-ether platform_device_id entry

2015-06-24 Thread David Miller
From: Geert Uytterhoeven Date: Tue, 23 Jun 2015 15:01:01 +0200 > Since commit 05104c266ae9a167 ("ARM: shmobile: r7s72100: genmai: Remove > legacy board file"), r7s72100 is only supported in generic DT-only ARM > multi-platform builds. The driver doesn't need to match platform > devices by name a

linux-next: build failure after merge of the net-next tree

2015-06-24 Thread Stephen Rothwell
Hi all, After merging the net-next tree, today's linux-next build (KCONFIG_NAME) failed like this: drivers/net/ethernet/apm/xgene/xgene_enet_main.c: In function 'xgene_get_port_id_acpi': drivers/net/ethernet/apm/xgene/xgene_enet_main.c:880:2: error: implicit declaration of function 'acpi_evalua

Re: [PATCH net] ip: report the original address of ICMP messages

2015-06-24 Thread David Miller
From: Julian Anastasov Date: Tue, 23 Jun 2015 08:34:39 +0300 > ICMP messages can trigger ICMP and local errors. In this case > serr->port is 0 and starting from Linux 4.0 we do not return > the original target address to the error queue readers. > Add function to define which errors provide addr_

Re: [PATCH net-next V1 00/11] Mellanox NIC drivers update, June 23 2015

2015-06-24 Thread David Miller
From: Or Gerlitz Date: Tue, 23 Jun 2015 17:14:11 +0300 > This series has two fixes from Eran to his recent SRIOV counters work in > mlx4 and few more updates from Saeed and Achiad to the mlx5 Ethernet > code. All fixes here relate to net-next code, so no need for -stable. ... > - dropped the p

Re: [PATCH] stmmac: explicitly zero des0 & des1 on init

2015-06-24 Thread David Miller
From: Alexey Brodkin Date: Tue, 23 Jun 2015 15:04:31 + > I'm wondering if my comment makes sense and should I just change commit > message or you'd prefer to still use dma_zalloc_coherent() during > driver probe? I think you should do both, convert to dma_zalloc_coherent() and perform the ex

Re: [PATCH] net: dsa: add support for switchdev VLAN objects

2015-06-24 Thread Jiri Pirko
Tue, Jun 23, 2015 at 07:18:49PM CEST, vivien.dide...@savoirfairelinux.com wrote: >This patch adds the glue between DSA and switchdev operations to add, >delete and dump SWITCHDEV_OBJ_PORT_VLAN objects. > >This is a first step to link the "bridge vlan" command with hardware >entries for DSA compatib