[RFC][PATCH v2] ppp: remove NULL check before kfree

[Maninder Singh]

Removes NULL check before kfree
and using tabs in place of space.

and removing checkpatch warning:
labels should not be indented.

Signed-off-by: Maninder Singh <maninder...@samsung.com>
Reviewed-by: Vaneet narang <v.nar...@samsung.com>
---
 drivers/net/ppp/ppp_mppe.c |   24 +++++++++++-------------
 1 file changed, 11 insertions(+), 13 deletions(-)

diff --git a/drivers/net/ppp/ppp_mppe.c b/drivers/net/ppp/ppp_mppe.c
index 05005c6..339b50e 100644
--- a/drivers/net/ppp/ppp_mppe.c
+++ b/drivers/net/ppp/ppp_mppe.c
@@ -237,15 +237,14 @@ static void *mppe_alloc(unsigned char *options, int 
optlen)
 
        return (void *)state;
 
-       out_free:
-           if (state->sha1_digest)
-               kfree(state->sha1_digest);
-           if (state->sha1)
+out_free:
+       kfree(state->sha1_digest);
+       if (state->sha1)
                crypto_free_hash(state->sha1);
-           if (state->arc4)
+       if (state->arc4)
                crypto_free_blkcipher(state->arc4);
-           kfree(state);
-       out:
+       kfree(state);
+out:
        return NULL;
 }
 
@@ -256,13 +255,12 @@ static void mppe_free(void *arg)
 {
        struct ppp_mppe_state *state = (struct ppp_mppe_state *) arg;
        if (state) {
-           if (state->sha1_digest)
                kfree(state->sha1_digest);
-           if (state->sha1)
-               crypto_free_hash(state->sha1);
-           if (state->arc4)
-               crypto_free_blkcipher(state->arc4);
-           kfree(state);
+               if (state->sha1)
+                       crypto_free_hash(state->sha1);
+               if (state->arc4)
+                       crypto_free_blkcipher(state->arc4);
+               kfree(state);
        }
 }
 
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html