Re: [PATCH 0/4] NET : struct proto diet

2007-11-05 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Mon, 05 Nov 2007 18:52:32 +0100 > This patch series does some cleanup and optimization. > > [PATCH 1/4] NET : defines an infrastructure to keep 'inuse' changes in > an efficent SMP/NUMA way. > [PATCH 2/4] NET : makes ipv4 use the {DEFINE|REF}_PROTO_I

Re: [PATCH 2.6.23] [PPP]: L2TP: Fix oops in transmit and receive paths

2007-11-05 Thread David Miller
From: James Chapman <[EMAIL PROTECTED]> Date: Mon, 5 Nov 2007 17:17:39 GMT > [PPP]: L2TP: Fix oops in transmit and receive paths > > Changes made on 18-sep to fix skb handling in the pppol2tp driver > broke the transmit and receive paths. Users are only running into this > now because distros are

Re: problems with ib-bonding of 2.6.24-rc1

2007-11-05 Thread Moni Shoua
Jay Vosburgh wrote: > Moni Shoua <[EMAIL PROTECTED]> wrote: > >> Basically, what I see is that after a while commands like ifconfig or ip >> stucks. >> I only use sysfs to configure bonding (which also stucks after a while). > > I've fooled with setting various things in bonding in the >

Re: [PATCH] Clean the ip_sockglue.c from some ugly ifdefs

2007-11-05 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Thu, 01 Nov 2007 18:52:34 +0300 > The #idfed CONFIG_IP_MROUTE is sometimes places inside the if-s, > which looks completely bad. Similar ifdefs inside the functions > looks a bit better, but they are also not recommended to be used. > > Provide an i

Re: [PATCH] decnet: "addr" module param can't be __initdata

2007-11-05 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Thu, 1 Nov 2007 18:36:29 +0300 > sysfs keeps references to module parameters via /sys/module/*/parameters, > so marking them as __initdata can't work. > > Steps to reproduce: > > modprobe decnet > cat /sys/module/decnet/parameters/addr

Re: [PATCH] Remove /proc/net/stat/*_arp_cache upon module removal

2007-11-05 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Thu, 1 Nov 2007 16:52:35 +0300 > neigh_table_init_no_netlink() creates them, but they aren't removed anywhere. ... > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied, thanks Alexey. - To unsubscribe from this list: send the line "unsubscr

Re: [PATCH] [IPv6] SNMP: Restore Udp6InErrors incrementation

2007-11-05 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Thu, 1 Nov 2007 23:05:00 +0800 > On Thu, Nov 01, 2007 at 10:46:38PM +0900, Mitsuru Chinen wrote: > > As the checksum verification is postponed till user calls recv or poll, > > the inrementation of Udp6InErrors counter should be also postponed. > > Curren

Re: [PATCH 2/2][IPV6] Consolidate the ip cork destruction in ip6_output.c

2007-11-05 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Fri, 02 Nov 2007 19:05:38 +0300 > The ip6_push_pending_frames and ip6_flush_pending_frames do the > same things to flush the sock's cork. Move this into a separate > function and save ~100 bytes from the .text > > Signed-off-by: Pavel Emelyanov <[EM

Re: [PATCH 1/2][IPV4] Consolidate the ip cork destruction in ip_output.c

2007-11-05 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Fri, 02 Nov 2007 19:04:06 +0300 > The ip_push_pending_frames and ip_flush_pending_frames do the > same things to flush the sock's cork. Move this into a separate > function and save ~80 bytes from the .text > > Signed-off-by: Pavel Emelyanov <[EMAIL

Re: [PATCH] add support for smc91x ethernet interface on zylonite

2007-11-05 Thread Nicolas Pitre
On Tue, 6 Nov 2007, eric miao wrote: > >From 9363662844b6373ddf4265e7007eb29ff963a377 Mon Sep 17 00:00:00 2001 > From: eric miao <[EMAIL PROTECTED]> According to the SOB line below, shouldn't this be: From: Aleksey Makarov <[EMAIL PROTECTED]> ? > Date: Tue, 30 Oct 2007 09:48:41 +0800 > Subject:

RE: [PATCH 2/2] NET: Re-add VLAN tag for devices incapable of keeping it

2007-11-05 Thread Ramkrishna Vepa
The Xframe (S2io) adapter can be programmed dynamically to either, always strip the vlan tag or not. In this case, if the vlan group is NULL, it can be programmed at run time to NOT strip the vlan tag. When a packet with a Vlan id is received that is not added to the group, should it be dropped or

Please pull 'upstream-jgarzik' branch of wireless-2.6

2007-11-05 Thread John W. Linville
Jeff, Here is a slew of patches targeted for 2.6.25. There are a bunch of rt2x00, iwl3945, iwl4965, b43, and b43legacy patches, as well as a few others. I'm sorry I didn't spread this out better -- I got a bit behind... :-( Thanks, John --- Individual patches are available here: ht

Re: problems with ib-bonding of 2.6.24-rc1

2007-11-05 Thread Jay Vosburgh
Moni Shoua <[EMAIL PROTECTED]> wrote: >Basically, what I see is that after a while commands like ifconfig or ip >stucks. >I only use sysfs to configure bonding (which also stucks after a while). I've fooled with setting various things in bonding in the current linux-2.6 git kernel, and

[PATCH] add support for smc91x ethernet interface on zylonite

2007-11-05 Thread eric miao
>From 9363662844b6373ddf4265e7007eb29ff963a377 Mon Sep 17 00:00:00 2001 From: eric miao <[EMAIL PROTECTED]> Date: Tue, 30 Oct 2007 09:48:41 +0800 Subject: [PATCH] add support for smc91x ethernet interface on zylonite This patch adds LAN91C111 ethernet interface support for zylonite (a.k.a Marvell'

Re: [PATCH 1/2] NET: Re-add VLAN tag for devices incapable of keeping it

2007-11-05 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Tue, 06 Nov 2007 01:21:09 +0100 > David Miller wrote: > > From: Patrick McHardy <[EMAIL PROTECTED]> > > Date: Mon, 05 Nov 2007 19:00:19 +0100 > > > >> This looks like a rather expensive operation for the unlikely case > >> that packets will be recei

Re: [PATCH] NET: Remove unneeded type cast in skb_truesize_check()

2007-11-05 Thread David Miller
From: Chuck Lever <[EMAIL PROTECTED]> Date: Mon, 05 Nov 2007 18:59:26 -0500 > If that's truly the case, document the requirement (perhaps using > something the compiler itself can verify) instead of using a clever > type cast trick. Feel free to submit such a change. > Here's the problem with le

Re: [PATCH 1/2] NET: Re-add VLAN tag for devices incapable of keeping it

2007-11-05 Thread Patrick McHardy
David Miller wrote: From: Patrick McHardy <[EMAIL PROTECTED]> Date: Mon, 05 Nov 2007 19:00:19 +0100 This looks like a rather expensive operation for the unlikely case that packets will be received by a packet socket. IMO it should only be reconstructed if actually needed, by af_packet itself.

Re: netfilter: nf_conntrack_ipv4 does not show nf_nat as a user

2007-11-05 Thread Patrick McHardy
Chuck Ebbert wrote: https://bugzilla.redhat.com/show_bug.cgi?id=333481#c3 This is netfilter kernel problem. There is a usage count for the conntrack_ipv4 module from the nf_nat module, which is not reported by lsmod. This is "fixed" in the current kernel. - To unsubscribe from this list: se

[git patches] net driver fixes

2007-11-05 Thread Jeff Garzik
Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus to receive the following updates: drivers/net/82596.c |3 ++- drivers/net/phy/marvell.c| 23 ++- drivers/net/phy/phy_device.c |

Re: [PATCH] NET: Remove unneeded type cast in skb_truesize_check()

2007-11-05 Thread Chuck Lever
David Miller wrote: From: Chuck Lever <[EMAIL PROTECTED]> Date: Fri, 02 Nov 2007 15:14:26 -0400 The (int) type cast in skb_truesize_check() is unneeded: without it, all the variable types in the conditional expression are unsigned integers. As it stands, the type cast causes a comparison betwe

Re: Endianness problem with u32 classifier hash masks

2007-11-05 Thread Jarek Poplawski
Jarek Poplawski wrote, On 11/06/2007 01:02 AM: ... > on little endian (net order): > f0.0f.00.00 >> 4 gives: 0f.00.0f.00 then ntohl: 00.0f.00.0f with lsb: 0f should be: f0.0f.00.00 >> 4 gives: 0f.00.f0.00 then ntohl: 00.f0.00.0f with lsb: 0f Jarek "Sleeping" P. - To unsubscribe from this list:

[PATCH 6/7] sky2: handle advanced error recovery config issues

2007-11-05 Thread Stephen Hemminger
The PCI AER support may not work for a couple of reasons. It may not be configured into the kernel or there may be a BIOS bug that prevents MMCONFIG from working. If MMCONFIG doesn't work then the PCI registers that control AER will not be accessible via pci_read_config functions; luckly there is

[PATCH 5/7] sky2: remove unneeded mask update

2007-11-05 Thread Stephen Hemminger
The IRQ's is already masked on shutdown, and on startup avoid touching PHY until after phy_init(). Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/drivers/net/sky2.c2007-11-05 15:05:01.0 -0800 +++ b/drivers/net/sky2.c2007-11-05 15:05:03.0 -0800 @@ -288,8

[PATCH 2/7] sky2: status ring race fix

2007-11-05 Thread Stephen Hemminger
The D-Link PCI-X board (and maybe others) can lie about status ring entries. It seems it will update the register for last status index before completing the DMA for the ring entry. To avoid reading stale data, zap the old entry and check. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> ---

[PATCH 0/7] sky2: update for 2.6.24-rc2

2007-11-05 Thread Stephen Hemminger
These patch fix problems that fix some bugs/regressions in sky2 on 2.6.24-rc1. -- Stephen Hemminger <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.

[PATCH 4/7] sky2: dont change LED after autoneg

2007-11-05 Thread Stephen Hemminger
Don't need to change LED's after auto negotiation, the chip sets them correctly. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/drivers/net/sky2.c2007-11-05 15:05:00.0 -0800 +++ b/drivers/net/sky2.c2007-11-05 15:05:01.0 -0800 @@ -1820,29 +1820,6 @@ sta

[PATCH 7/7] sky2: version 1.20

2007-11-05 Thread Stephen Hemminger
Version update to 1.20 Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/drivers/net/sky2.c2007-11-05 15:06:31.0 -0800 +++ b/drivers/net/sky2.c2007-11-05 15:10:56.0 -0800 @@ -52,7 +52,7 @@ #include "sky2.h" #define DRV_NAME "sky2" -#defin

[PATCH 1/7] sky2: enable PCI config writes

2007-11-05 Thread Stephen Hemminger
On some boards, PCI configuration space access is turned off by default. The 2.6.24 driver doesn't turn it on, and should have. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/drivers/net/sky2.c2007-11-05 10:01:10.0 -0800 +++ b/drivers/net/sky2.c2007-11-05 15:0

[PATCH 3/7] sky2: longer PHY delay

2007-11-05 Thread Stephen Hemminger
Increse phy delay and handle I/O errors. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/drivers/net/sky2.c2007-11-05 15:04:55.0 -0800 +++ b/drivers/net/sky2.c2007-11-05 15:05:00.0 -0800 @@ -156,7 +156,7 @@ static const char *yukon2_name[] = { static

Re: dn_route.c momentarily exiting RCU read-side critical section

2007-11-05 Thread Herbert Xu
On Mon, Nov 05, 2007 at 08:12:03AM -0800, Paul E. McKenney wrote: > > >> > > >> > net/decnet/dn_route.c in dn_rt_cache_get_next() is as follows: > > >> > > > >> > static struct dn_route *dn_rt_cache_get_next(struct seq_file *seq, > > >> > struct dn_route *rt) > > >> > { > > >> > struct dn_rt

Re: Endianness problem with u32 classifier hash masks

2007-11-05 Thread Jarek Poplawski
jamal wrote, On 11/05/2007 11:27 PM: > On Mon, 2007-05-11 at 22:06 +0100, Jarek Poplawski wrote: >> Radu Rendec wrote, On 11/05/2007 06:31 PM: > >>> But still, Jamal, I need more explanations on what you meant by "cutdown >>> on the conversion in u32_change()". > > I meant that it didnt seem ne

Re: [PATCH 1/2] NET: Re-add VLAN tag for devices incapable of keeping it

2007-11-05 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Mon, 05 Nov 2007 19:00:19 +0100 > This looks like a rather expensive operation for the unlikely case > that packets will be received by a packet socket. IMO it should only > be reconstructed if actually needed, by af_packet itself. Completely agreed

Re: Endianness problem with u32 classifier hash masks

2007-11-05 Thread jamal
On Mon, 2007-05-11 at 22:06 +0100, Jarek Poplawski wrote: > Radu Rendec wrote, On 11/05/2007 06:31 PM: > > But still, Jamal, I need more explanations on what you meant by "cutdown > > on the conversion in u32_change()". I meant that it didnt seem necessary to me you have to do the conversion bac

Re: Endianness problem with u32 classifier hash masks

2007-11-05 Thread Jarek Poplawski
Jarek Poplawski wrote, On 11/05/2007 10:06 PM: > Radu Rendec wrote, On 11/05/2007 06:31 PM: ... >> Jarek, because I have to test anyway, I'll include ffs(mask) in my patch >> and have it tested too. > > > Thanks! But, I did it wrong: + 1 is unnecessary. And since, ffs() checks > for 0 anyway,

Re: Endianness problem with u32 classifier hash masks

2007-11-05 Thread Jarek Poplawski
Radu Rendec wrote, On 11/05/2007 06:31 PM: > On Mon, 2007-11-05 at 09:06 -0500, jamal wrote: >> On Mon, 2007-05-11 at 14:52 +0100, Jarek Poplawski wrote: >> > ... >>> If we manage to convince Jamal, IMHO a patch to something current like >>> 2.6.24-rc1-git14 (or maybe -rc2 soon), should suffice (p

localhost network processing on smp machines

2007-11-05 Thread Matthew Faulkner
I'm probably being stupid and very confused here. Appologies if it is a stupid question. For a particular test I assign a client to core 1 and a server to core 0. My first assumption was all the sending side kernel TCP/IP processing will be done on core 1 and all the receiving side processing on c

[PATCH] Fix incorrect usage of strncat in bdx_get_drvinfo(); drivers/net/tehuti.c

2007-11-05 Thread Roel Kluin
Fix incorrect length for strncat by replacing it with strlcat Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/drivers/net/tehuti.c b/drivers/net/tehuti.c index 4e1b84e..21230c9 100644 --- a/drivers/net/tehuti.c +++ b/drivers/net/tehuti.c @@ -2168,10 +2168,10 @@ bdx_get_drvinfo(struc

[PATCH 2.6.23] [PPP]: L2TP: Fix oops in transmit and receive paths

2007-11-05 Thread James Chapman
[PPP]: L2TP: Fix oops in transmit and receive paths Changes made on 18-sep to fix skb handling in the pppol2tp driver broke the transmit and receive paths. Users are only running into this now because distros are now using 2.6.23 and I must have messed up when I tested the change. For receive, we

netfilter: nf_conntrack_ipv4 does not show nf_nat as a user

2007-11-05 Thread Chuck Ebbert
https://bugzilla.redhat.com/show_bug.cgi?id=333481#c3 This is netfilter kernel problem. There is a usage count for the conntrack_ipv4 module from the nf_nat module, which is not reported by lsmod. How to reproduce: # modprobe nf_conntrack_ipv4 # lsmod | grep nf_conntrack_ipv4 nf_conntrack_ipv4

Re: kernel panic removing devices from a teql queuing discipline

2007-11-05 Thread Evgeniy Polyakov
On Tue, Oct 30, 2007 at 01:33:41AM -0700, David Miller ([EMAIL PROTECTED]) wrote: > > The panic is in __teql_resolve (which has been inlined into > > teql_master_xmit) in > > net/sched/sch_teql.c at this line: > > > > if (n && n->tbl == mn->tbl && > > > > Specifically the dereference of n->

Re: [2.6 patch] remove Documentation/networking/routing.txt

2007-11-05 Thread Alexey Kuznetsov
Hello! > This file is so outdated that I can't see any value in keeping it. Absolutely agree. Alexey - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: RFC: Reproducible oops with lockdep on count_matching_names()

2007-11-05 Thread Christoph Lameter
On Mon, 5 Nov 2007, Michael Buesch wrote: > Hm, I don't really remember. Though, I usually have all almost kernel-hacking > options enabled. > I'll check and enable some more. slub_debug must be specified on the command line. Alternately switch on CONFIG_SLUB_DEBUG_ON in the .config to force it t

[3/4] Distributed storage. Algorithms.

2007-11-05 Thread Evgeniy Polyakov
Mirror and linear data stripping algorithms for DST. Signed-off-by: Evgeniy Polyakov <[EMAIL PROTECTED]> diff --git a/drivers/block/dst/alg_linear.c b/drivers/block/dst/alg_linear.c new file mode 100644 index 000..cb77b57 --- /dev/null +++ b/drivers/block/dst/alg_linear.c @@ -0,0 +1,104 @@ +/

[4/4] Distributed storage. Core interfaces.

2007-11-05 Thread Evgeniy Polyakov
This one contains core interfaces of the distributed storage, storage and node initialization and cleanup code, block layer callbacks and the like. It also contains Kconfig and Makefile changes. Signed-off-by: Evgeniy Polyakov <[EMAIL PROTECTED]> diff --git a/drivers/block/Kconfig b/drivers/block

[2/4] Distributed storage. Network processing.

2007-11-05 Thread Evgeniy Polyakov
This file contains all bits needed for async non-blocking network processing of the block requests directed to DST. Signed-off-by: Evgeniy Polyakov <[EMAIL PROTECTED]> diff --git a/drivers/block/dst/kst.c b/drivers/block/dst/kst.c new file mode 100644 index 000..ba5e5ef --- /dev/null +++ b/dr

[1/4] Distributed storage. Documentation.

2007-11-05 Thread Evgeniy Polyakov
DST documentation. Signed-off-by: Evgeniy Polyakov <[EMAIL PROTECTED]> diff --git a/Documentation/dst/algorithms.txt b/Documentation/dst/algorithms.txt new file mode 100644 index 000..1437a6a --- /dev/null +++ b/Documentation/dst/algorithms.txt @@ -0,0 +1,115 @@ +Each storage by itself is jus

[0/4] Distributed storage. Squizzed black-out of the dancing back-aching hippo.

2007-11-05 Thread Evgeniy Polyakov
Hi. I'm pleased to announce 7'th and the final release of the distributed storage subsystem (DST). It allows to form a storage on top of local and remote nodes and combine them in linear or mirroring setup, which in turn can be exported to remote nodes. Short changelog: * added strong checksum su

[PATCH 5/5] powerpc: handle mpc8360 rev. 2.1 RGMII timing erratum

2007-11-05 Thread Kim Phillips
if on a rev. 2.1, adjust UCC clock and data timing characteristics as specified in the rev.2.1 erratum #2. Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> --- arch/powerpc/platforms/83xx/mpc836x_mds.c | 31 ++-- 1 files changed, 28 insertions(+), 3 deletions(-) diff --g

[PATCH 3/5] phylib: marvell: add support for TX-only and RX-only Internal Delay

2007-11-05 Thread Kim Phillips
Previously, Internal Delay specification implied the delay be applied to both TX and RX. This patch allows for separate TX/RX-only internal delay specification. Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> --- drivers/net/phy/marvell.c | 26 +- 1 files changed, 17 in

[PATCH 4/5] ucc_geth: handle passing of RX-only and TX-only internal delay PHY connection type parameters

2007-11-05 Thread Kim Phillips
Extend the RGMII-Internal Delay specification case to include TX-only and RX-only variants. Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> --- drivers/net/ucc_geth.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/drivers/net/ucc_geth.c b/drivers/net/ucc_geth.c

[PATCH 1/5] powerpc: document rgmii-rxid and rgmii-txid phy-connection-types

2007-11-05 Thread Kim Phillips
A h/w bug requires we program the PHY in RGMII mode for internal delay on the receive or transmit side only; document the new property values. Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> --- Documentation/powerpc/booting-without-of.txt |5 +++-- 1 files changed, 3 insertions(+), 2 deletio

[PATCH 0/5] fixups for mpc8360 rev. 2.1 erratum #2 (RGMII Timing)

2007-11-05 Thread Kim Phillips
Hello all, the following patches fix RGMII timing for rev. 2.1 of the mpc8360, according to erratum #2 (erratum text included below). Basically the most intrusive part is the addition of two new RGMII Internal Delay modes; one for TX delay only, and the other for RX delay only (i.e, not both at t

[PATCH 2/5] phylib: add PHY interface modes for internal delay for tx and rx only

2007-11-05 Thread Kim Phillips
Allow phylib specification of cases where hardware needs to configure PHYs for Internal Delay only on either RX or TX (not both). Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> --- include/linux/phy.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/linux/phy.h b

[PATCH 3/4] NET : makes ipv6 use the {DEFINE|REF}_PROTO_INUSE infrastructure

2007-11-05 Thread Eric Dumazet
Trivial patch to make "tcpv6,udpv6,udplitev6,rawv6" protocols uses the fast "inuse sockets" infrastructure Each protocol use then a static percpu var, instead of a dynamic one. This saves some ram and some cpu cycles Signed-off-by: Eric Dumazet <[EMAIL PROTECTED]> net/ipv6/raw.c |3

[PATCH 4/4] NET : makes sctp use the {DEFINE|REF}_PROTO_INUSE infrastructure

2007-11-05 Thread Eric Dumazet
Trivial patch to make "sctcp,sctpv6" protocols uses the fast "inuse sockets" infrastructure Each protocol use then a static percpu var, instead of a dynamic one. This saves some ram and some cpu cycles Signed-off-by: Eric Dumazet <[EMAIL PROTECTED]> diff --git a/net/sctp/socket.c b/net/sct

Re: [PATCH 1/2] NET: Re-add VLAN tag for devices incapable of keeping it

2007-11-05 Thread Patrick McHardy
Dave Johnson wrote: +/* VLAN rx hw acceleration helper. This acts like netif_{rx,receive_skb}(). */ +static inline int __vlan_hwaccel_rx(struct sk_buff *skb, + struct vlan_group *grp, + unsigned short vlan_tag, int polling) +{ .

[PATCH 2/4] NET : makes ipv4 use the {DEFINE|REF}_PROTO_INUSE infrastructure

2007-11-05 Thread Eric Dumazet
Trivial patch to make "tcp,udp,udplite,raw" protocols uses the fast "inuse sockets" infrastructure Each protocol use then a static percpu var, instead of a dynamic one. This saves some ram and some cpu cycles Signed-off-by: Eric Dumazet <[EMAIL PROTECTED]> net/ipv4/raw.c |3 +++ net

[PATCH 0/4] NET : struct proto diet

2007-11-05 Thread Eric Dumazet
Hi After reading David's machines have NR_CPUS set to 4096, I realized how fat was 'struct proto', since it uses a stats[NR_CPUS] field to keep track of inuse sockets per protocol. With NR_CPUS = 4096, this means we allocate 4096*SMP_CACHE_BYTES bytes per 'struct proto'. As these structures

[PATCH 1/4] NET : defines an infrastructure to keep 'inuse' changes in an efficent SMP/NUMA way.

2007-11-05 Thread Eric Dumazet
"struct proto" currently uses an array stats[NR_CPUS] to track change on 'inuse' sockets per protocol. If NR_CPUS is big, this means we use a big memory area for this. Moreover, all this memory area is located on a single node on NUMA machines, increasing memory pressure on the boot node. In

[PATCH 2/2] NET: Re-add VLAN tag for devices incapable of keeping it

2007-11-05 Thread Dave Johnson
This patch changes the following drivers to use vlan_hwaccel_rx() and/or vlan_hwaccel_receive_skb() with a NULL vlan group if needed as they are not setup to dynamically enable/disable vlan removal in their MAC based on the vlan group: drivers/net/tg3.c Tested on BCM5704, looks good dri

[PATCH 1/2] NET: Re-add VLAN tag for devices incapable of keeping it

2007-11-05 Thread Dave Johnson
Some MACs are configured to remove VLAN tags on RX packets even if the kernel isn't setup to use VLANs. On these drivers it is bad to simply pass the packets with the VLAN tag removed to the network stack. This gives the network stack the impression these packets arrived from the network without

Re: Endianness problem with u32 classifier hash masks

2007-11-05 Thread Radu Rendec
On Mon, 2007-11-05 at 09:06 -0500, jamal wrote: > On Mon, 2007-05-11 at 14:52 +0100, Jarek Poplawski wrote: > ... > > If we manage to convince Jamal, IMHO a patch to something current like > > 2.6.24-rc1-git14 (or maybe -rc2 soon), should suffice (plus some > > options to diff to get function name

Re: [2.6 patch] remove Documentation/networking/pt.txt

2007-11-05 Thread Alan Cox
On Mon, 5 Nov 2007 18:05:57 +0100 Adrian Bunk <[EMAIL PROTECTED]> wrote: > There's no no point in keeping documentation for a driver that was > removed many years ago. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Defintiely very dead Acked-by: Alan Cox <[EMAIL PROTECTED]> - To unsubscrib

Re: [2.6 patch] remove comx driver docs

2007-11-05 Thread Alan Cox
On Mon, 5 Nov 2007 18:04:45 +0100 Adrian Bunk <[EMAIL PROTECTED]> wrote: > The drivers have already been removed 3.5 years ago. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Acked-by: Alan Cox <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in the bo

Re: dn_route.c momentarily exiting RCU read-side critical section

2007-11-05 Thread Paul E. McKenney
On Mon, Nov 05, 2007 at 07:53:04PM +0800, Herbert Xu wrote: > Paul E. McKenney <[EMAIL PROTECTED]> wrote: > >> > >> > net/decnet/dn_route.c in dn_rt_cache_get_next() is as follows: > >> > > >> > static struct dn_route *dn_rt_cache_get_next(struct seq_file *seq, > >> > struct dn_route *rt) > >> >

[2.6 patch] drivers/net/netxen/: cleanups

2007-11-05 Thread Adrian Bunk
This patch contains the following cleanups: - static functions in .c files shouldn't be marked inline - make needlessly global code static - #if 0 unused code Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- drivers/net/netxen/netxen_nic.h | 14 drivers/net/netxen/netxen_nic_h

[2.6 patch] remove Documentation/networking/pt.txt

2007-11-05 Thread Adrian Bunk
There's no no point in keeping documentation for a driver that was removed many years ago. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- Documentation/networking/00-INDEX |2 - Documentation/networking/pt.txt | 58 -- 2 files changed, 60 deletions(-) c

[2.6 patch] remove Documentation/networking/routing.txt

2007-11-05 Thread Adrian Bunk
This file is so outdated that I can't see any value in keeping it. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- Documentation/networking/00-INDEX|2 - Documentation/networking/routing.txt | 46 --- 2 files changed, 48 deletions(-) 54b248bbff6345016e06013

[2.6 patch] remove Documentation/networking/ncsa-telnet

2007-11-05 Thread Adrian Bunk
Newsflash: There once was a version of NCSA telnet that had some bug. Spotted by Pekka Pietikainen. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- Documentation/networking/00-INDEX|2 -- Documentation/networking/ncsa-telnet | 16 2 files changed, 18 deletions(-)

[2.6 patch] remove Documentation/networking/Configurable

2007-11-05 Thread Adrian Bunk
After more than 11 years this file does no longer contain much useful information. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- Documentation/networking/00-INDEX |2 - Documentation/networking/Configurable | 34 -- 2 files changed, 36 deletions(-) f200f

[2.6 patch] remove comx driver docs

2007-11-05 Thread Adrian Bunk
The drivers have already been removed 3.5 years ago. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- Documentation/networking/00-INDEX |2 Documentation/networking/comx.txt | 248 - Documentation/networking/slicecom.hun | 371 -- Documen

Re: [2.6 patch] remove Documentation/networking/net-modules.txt

2007-11-05 Thread Adrian Bunk
On Mon, Oct 29, 2007 at 05:18:14PM +0200, Pekka Pietikainen wrote: > On Wed, Oct 24, 2007 at 06:25:03PM +0200, Adrian Bunk wrote: > > According to git, the only one who touched this file during the last > > 5 years was me when removing drivers... > > That's not the only obsolete thing there: > >

Re: 2.6.24-rc1: hangs when logging in to X session

2007-11-05 Thread Marcus Better
Herbert Xu wrote: > > > > > My laptop hangs when I try to log in to X with the current git > > > > > kernel (commit 2a397e82c7db18019e408f953dd58dc1963a328c). It runs > > > > > fine with 2.6.23. At boot time kdm starts normally, but hangs with > > > > > the caps lock LED blinking immediately after

Re: [PATCH] [POWERPC] Fix fs_enet module build

2007-11-05 Thread Scott Wood
Jochen Friedrich wrote: diff --git a/drivers/net/fs_enet/Makefile b/drivers/net/fs_enet/Makefile index 02d4dc1..2f7563a 100644 --- a/drivers/net/fs_enet/Makefile +++ b/drivers/net/fs_enet/Makefile @@ -4,7 +4,15 @@ obj-$(CONFIG_FS_ENET) += fs_enet.o -obj-$(CONFIG_8xx) += mac-fec.o mac-scc.o mii-

Re: Endianness problem with u32 classifier hash masks

2007-11-05 Thread Radu Rendec
On Mon, 2007-11-05 at 15:49 +0100, Jarek Poplawski wrote: > > Yes, that example i believe would work just fine today as is with no > > changes. > ... > > Please try the patch i sent since it is simpler. It is your work more or > > less - so you should get the credit as author. > > Jamal + Houston

Re: [PATCH 2/2] NFS: handle IPv6 addresses in nfs ctl

2007-11-05 Thread Aurélien Charbon
Hi Neil, Thank you for the reply. Neil Brown wrote: I think this patch is unnecessary and hence not wanted. The getfs / getfs calls should be considered legacy calls. Adding functionality to them is not appropriate. I agree with that. But I don't think we really add functionality here. Mo

[PATCH] prevent that myri_do_handshake lies about ticks in drivers/net/myri_sbus.c

2007-11-05 Thread Roel Kluin
With '<=' tick can be incremented up to 26, The last loop is redundant since even when 'softstate' becomes 'STATE_READY', 'if (tick > 25)' will still cause the function to return -1, Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/drivers/net/myri_sbus.c b/drivers/net/myri_sbus.c i

Re: Endianness problem with u32 classifier hash masks

2007-11-05 Thread Jarek Poplawski
On Mon, Nov 05, 2007 at 08:43:32AM -0500, jamal wrote: > On Mon, 2007-05-11 at 14:59 +0200, Radu Rendec wrote: > > Jarek, thanks for replying my message on the list and pointing it to the > > right direction. > > > > Your example with "1" bits laying on exact nibble boundary is much > > easier to

Re: Endianness problem with u32 classifier hash masks

2007-11-05 Thread Jarek Poplawski
On Mon, Nov 05, 2007 at 08:47:06AM -0500, jamal wrote: > On Mon, 2007-05-11 at 10:12 +0100, Jarek Poplawski wrote: > > > BTW: when looking around this I think, maybe, in u32_change(): > > > > 1) if (--divisor > 0x100) should be probably ">=", > > Does it really matter? Divisor can be max of 0xf

Re: RFC: Reproducible oops with lockdep on count_matching_names()

2007-11-05 Thread Michael Buesch
On Monday 05 November 2007 14:56:22 Pekka Enberg wrote: > Hi Michael, > > On Monday 05 November 2007 13:23:50 Pekka Enberg wrote: > > > Is CONFIG_DEBUG_SLAB enabled? Usually these kind of random corruptions > > > are caused by someone passing a bad pointer to kfree() or > > > kmem_cache_free(). >

Re: [PATCH] ehea: add kexec support

2007-11-05 Thread Christoph Raisch
Michael Neuling <[EMAIL PROTECTED]> wrote on 03.11.2007 07:06:31: > > DD allocates HEA resources and gets firmware_handles for these resources. > > To free the resources DD needs to use exactly these handles. > > There's no generic firmware call "clean out all resources". > > Allocating the same

A difficult question regarding problems due to neighboring subsystem state changes

2007-11-05 Thread Ian Brown
Hi, This might seem a little insane/crazy question; yet this is a real kernel networking problem I encountered; I scratched my head a lot, probed into the Linux kernel neighboring code, still could not find an answer. And it still might be that the solution is a lot easier than I can imagine in my

Re: Endianness problem with u32 classifier hash masks

2007-11-05 Thread jamal
On Mon, 2007-05-11 at 14:52 +0100, Jarek Poplawski wrote: > It seems this performance loss shouldn't be so big because ntohl() > is probably quite well optimized in assembler. But, as I've written, > since there is max. 1 byte meaningful to us there is some additional > possibility to get it other

Re: RFC: Reproducible oops with lockdep on count_matching_names()

2007-11-05 Thread Pekka Enberg
Hi Michael, On Monday 05 November 2007 13:23:50 Pekka Enberg wrote: > > Is CONFIG_DEBUG_SLAB enabled? Usually these kind of random corruptions > > are caused by someone passing a bad pointer to kfree() or > > kmem_cache_free(). On 11/5/07, Michael Buesch <[EMAIL PROTECTED]> wrote: > Yeah. > > Wha

Re: Endianness problem with u32 classifier hash masks

2007-11-05 Thread jamal
On Mon, 2007-05-11 at 10:12 +0100, Jarek Poplawski wrote: > BTW: when looking around this I think, maybe, in u32_change(): > > 1) if (--divisor > 0x100) should be probably ">=", Does it really matter? Divisor can be max of 0xff. > but is it really needed to check this 2 times (including tc)?

Re: Endianness problem with u32 classifier hash masks

2007-11-05 Thread jamal
On Mon, 2007-05-11 at 14:59 +0200, Radu Rendec wrote: > Jarek, thanks for replying my message on the list and pointing it to the > right direction. > > Your example with "1" bits laying on exact nibble boundary is much > easier to analyze than my original example. And your computation seems > to b

Re: Endianness problem with u32 classifier hash masks

2007-11-05 Thread Jarek Poplawski
On Mon, Nov 05, 2007 at 02:59:21PM +0200, Radu Rendec wrote: ... > Jamal, I am aware that any computation on the fast path involves some > performance loss. However, I don't see any speed gain with your patch, > because you just moved the ntohl() call inside u32_hash_fold(). Since > u32_hash_fold()

[PATCH] netX: update ethernet driver to firmware 1007

2007-11-05 Thread Robert Schwebel
From: Sascha Hauer <[EMAIL PROTECTED]> The ethernet firmware revision 1007 fixes several issues with the network chip. This update makes the driver work with that firmware revision. Signed-off-by: Sascha Hauer <[EMAIL PROTECTED]> --- drivers/net/netx-eth.c | 91 +++

Re: RFC: Reproducible oops with lockdep on count_matching_names()

2007-11-05 Thread Michael Buesch
On Monday 05 November 2007 13:23:50 Pekka Enberg wrote: > Hi Michael, > > On Sat, 2007-11-03 at 21:06 +0100, Michael Buesch wrote: > > Who is responsible for slab btw? > > I mean, someone should be interested in getting this bug fixed. :) > > When using slab I see random corruptions. I think relat

Re: Endianness problem with u32 classifier hash masks

2007-11-05 Thread Radu Rendec
Jarek, thanks for replying my message on the list and pointing it to the right direction. Your example with "1" bits laying on exact nibble boundary is much easier to analyze than my original example. And your computation seems to be right: u32_hash_fold() would return 00.f0.00.0f (and would be cu

Re: RFC: Reproducible oops with lockdep on count_matching_names()

2007-11-05 Thread Pekka Enberg
Hi Michael, On Sat, 2007-11-03 at 21:06 +0100, Michael Buesch wrote: > Who is responsible for slab btw? > I mean, someone should be interested in getting this bug fixed. :) > When using slab I see random corruptions. I think related to rmmod, but > I'm not sure. I don't see this with slub. Is CON

Re: RFC: Reproducible oops with lockdep on count_matching_names()

2007-11-05 Thread Peter Zijlstra
On Sat, 2007-11-03 at 21:06 +0100, Michael Buesch wrote: > On Saturday 03 November 2007 20:58:09 Luis R. Rodriguez wrote: > > I was using SLAB and ran into other strange oops, as the one below, > > but after switching to SLUB, after Michael Buesch's suggestion that > > one went away... The lockdep

Re: dn_route.c momentarily exiting RCU read-side critical section

2007-11-05 Thread Herbert Xu
Paul E. McKenney <[EMAIL PROTECTED]> wrote: >> >> > net/decnet/dn_route.c in dn_rt_cache_get_next() is as follows: >> > >> > static struct dn_route *dn_rt_cache_get_next(struct seq_file *seq, struct >> > dn_route *rt) >> > { >> > struct dn_rt_cache_iter_state *s = rcu_dereference(seq->privat

Re: problems with ib-bonding of 2.6.24-rc1

2007-11-05 Thread Moni Shoua
Moni Shoua wrote: > Basically, what I see is that after a while commands like ifconfig or ip > stucks. > I only use sysfs to configure bonding (which also stucks after a while). > Maybe some extra information might help This is what happens in the kernel while the command 'ip' is stucked in us

Re: [PATCH] net: Add 405EX support to new EMAC driver

2007-11-05 Thread Stefan Roese
On Monday 05 November 2007, Benjamin Herrenschmidt wrote: > > So how exactly do you want me to handle this (I'm still new to this > > device > > tree stuff, so please bear with me)? Like this? > > > > RGMII0: [EMAIL PROTECTED] { > > device_typ

Re: [PATCH] net: Add 405EX support to new EMAC driver

2007-11-05 Thread Benjamin Herrenschmidt
On Mon, 2007-11-05 at 10:19 +0100, Stefan Roese wrote: > > > Somewhat yeah. There are subtle variations here or there we haven't > > totally indenfified... It might be a better option in our case here > to > > add "has-mdio" to the rgmii nodes indeed. > > So how exactly do you want me to handle

Re: [BUG] in inet6_create

2007-11-05 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Thu, 01 Nov 2007 21:07:52 +0100), Roel Kluin <[EMAIL PROTECTED]> says: > I got this bug recently, I am not sure whether this is related to any > previously > reported ones. It was a recently pulled git kernel. Also I have been hacking > my > kernel a bit late

Re: 2.6.24-rc1: hangs when logging in to X session

2007-11-05 Thread Herbert Xu
On Mon, Nov 05, 2007 at 01:03:08AM -0800, Andrew Morton wrote: > On Mon, 5 Nov 2007 09:55:32 +0100 Marcus Better <[EMAIL PROTECTED]> wrote: > > > Andrew Morton wrote: > > > > My laptop hangs when I try to log in to X with the current git kernel > > > > (commit 2a397e82c7db18019e408f953dd58dc1963a3

Re: [PATCH] net: Add 405EX support to new EMAC driver

2007-11-05 Thread Stefan Roese
On Sunday 04 November 2007, Benjamin Herrenschmidt wrote: > > Isn't this the case where there should really be device tree properties > > instead? If you had an "ibm,emac-has-axon-stacr" property in the device > > node, then you don't have to modify the driver for every new board out > > there. Sam

Re: Endianness problem with u32 classifier hash masks

2007-11-05 Thread Jarek Poplawski
On Sun, Nov 04, 2007 at 06:58:13PM -0500, jamal wrote: > On Sun, 2007-04-11 at 02:17 +0100, Jarek Poplawski wrote: > > > So, even if not full ntohl(), some byte moving seems to be > > necessary here. > > I thinking you were close. I am afraid my brain is congested, even the > esspresso didnt help

  1   2   >