On Mon, 2007-05-11 at 10:12 +0100, Jarek Poplawski wrote: > BTW: when looking around this I think, maybe, in u32_change(): > > 1) if (--divisor > 0x100) should be probably ">=",
Does it really matter? Divisor can be max of 0xff. > but is it really needed to check this 2 times (including tc)? I dont mind letting users shoot themselves in the foot by sending crap. If it can be avoided with simplicity, then better. > 2) this while() loop for n->fshift could be replaced with ffs()? I think so. Can you please send a patch (after some testing of course maybe using Radu's test data)? cheers, jamal - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
