From: Stephen Hemminger <[EMAIL PROTECTED]>
Date: Wed, 17 Oct 2007 13:21:31 -0700
> I propose that we take out all the whole netpoll rx path. If/when
> kgdb gets submitted a better and alternative receive path can be
> added.
I would like to kill the RX side handling of netpoll too,
but I don't t
On Wed, Oct 17, 2007 at 10:58:09AM +0200, Jarek Poplawski wrote:
...
> 8) phy_stop_interrupts(): I'm not sure this additional call from
> DEBUG_SHIRQ should be so dangerous, eg.:
>
> /*
>* status == PHY_HALTED &&
>* interrupts are stopped after phy_stop()
>*/
>
From: Jeff Garzik <[EMAIL PROTECTED]>
Date: Tue, 16 Oct 2007 17:55:55 -0400
> While looking at a net driver with the following construct,
>
> if (!netif_carrier_ok(dev))
> netif_carrier_on(dev);
>
> it stuck me that the netif_carrier_ok() check was redundant, since
> netif_ca
On Wed, Oct 17, 2007 at 08:28:36PM -0400, Jeff Garzik wrote:
> Badari Pulavarty wrote:
> >Simple compile warning fix. (against 2.6.23-git12)
> >
> >Thanks,
> >Badari
> >
> >vortex_up() should initialize 'err' for a successful return.
> >
> >drivers/net/3c59x.c: In function `vortex_up':
> >drivers/n
From: rajashok <[EMAIL PROTECTED]>
Date: Wed, 17 Oct 2007 22:10:43 -0700 (PDT)
> we are trying to to integrate our ipsec onto linux 2.6 kernel
Why not use the already existing 2.6.x kernel IPSEC stack?
It works quite well.
And for this reason, it is unlikely you will get much help
on these maili
From: David Howells <[EMAIL PROTECTED]>
Date: Wed, 17 Oct 2007 16:02:48 +0100
> Fix uninitialised variable in ip_frag_reasm(). err should be set to -ENOMEM
> if the initial call of skb_clone() fails.
>
> Signed-off-by: David Howells <[EMAIL PROTECTED]>
Applied, thanks David.
-
To unsubscribe fr
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Wed, 17 Oct 2007 23:26:02 +0800
> On Wed, Oct 17, 2007 at 10:34:19PM +0800, Herbert Xu wrote:
> > [IPSEC]: Rename mode to outer_mode and add inner_mode
>
> Oops. This patch is missing two files. Here is the correct
> version.
>
> Cheers,
> --
> Visit
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Wed, 17 Oct 2007 22:34:18 +0800
> [IPSEC]: Disallow combinations of RO and AH/ESP/IPCOMP
>
> Combining RO and AH/ESP/IPCOMP does not make sense. So this patch adds a
> check in the state initialisation function to prevent this.
>
> This allows us to sa
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Wed, 17 Oct 2007 22:34:17 +0800
> [IPSEC]: Use the top IPv4 route's peer instead of the bottom
>
> For IPv4 we were using the bottom route's peer instead of the top one.
> This is wrong because the peer is only used by TCP to keep track of
> information
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Wed, 17 Oct 2007 22:34:16 +0800
> [IPSEC]: Store afinfo pointer in xfrm_mode
>
> It is convenient to have a pointer from xfrm_state to address-specific
> functions such as the output function for a family. Currently the
> address-specific policy code ca
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Wed, 17 Oct 2007 22:34:15 +0800
> [IPSEC]: Add missing BEET checks
>
> Currently BEET mode does not reinject the packet back into the stack
> like tunnel mode does. Since BEET should behave just like tunnel mode
> this is incorrect.
>
> This patch fixe
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Wed, 17 Oct 2007 22:34:14 +0800
> [IPSEC]: Move type and mode map into xfrm_state.c
>
> The type and mode maps are only used by SAs, not policies. So it makes
> sense to move them from xfrm_policy.c into xfrm_state.c. This alos allows
> us to mark xfrm
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Wed, 17 Oct 2007 22:34:13 +0800
> [IPSEC]: Fix length check in xfrm_parse_spi
>
> Currently xfrm_parse_spi requires there to be 16 bytes for AH and ESP.
> In contrived cases there may not actually be 16 bytes there since the
> respective header sizes are
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Wed, 17 Oct 2007 22:34:11 +0800
> [IPSEC]: Move ip_summed zapping out of xfrm6_rcv_spi
>
> Not every transform needs to zap ip_summed. For example, a pure tunnel
> mode encapsulation does not affect the hardware checksum at all. In fact,
> every algori
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Wed, 17 Oct 2007 22:34:10 +0800
> [IPSEC]: Get nexthdr from caller in xfrm6_rcv_spi
>
> Currently xfrm6_rcv_spi gets the nexthdr value itself from the packet.
> This means that we need to fix up the value in case we have a 4-on-6
> tunnel. Moving this l
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Wed, 17 Oct 2007 22:34:09 +0800
> [IPSEC]: Move tunnel parsing for IPv4 out of xfrm4_input
>
> This patch moves the tunnel parsing for IPv4 out of xfrm4_input and into
> xfrm4_tunnel. This change is in line with what IPv6 does and will allow
> us to mer
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Wed, 17 Oct 2007 22:34:08 +0800
> [IPSEC]: Fix pure tunnel modes involving IPv6
>
> I noticed that my recent patch broke 6-on-4 pure IPsec tunnels (the ones
> that are only used for incompressible IPsec packets). Subsequent reviews
> show that I broke 6
From: Pavel Emelyanov <[EMAIL PROTECTED]>
Date: Wed, 17 Oct 2007 17:09:30 +0400
> Some places in network (like protocol registration and dccp)
> generate the kmem cache name with snprintf() to create caches
> for several protocols with similar names.
>
> Make the routine that makes this in one pl
From: Pavel Emelyanov <[EMAIL PROTECTED]>
Date: Wed, 17 Oct 2007 14:44:44 +0400
> This functions is never called with NULL or not setup argument,
> so the checks inside are redundant.
>
> Also, the return value is always -ENOMEM, so no need in
> additional variable for this.
>
> Signed-off-by:
From: Pavel Emelyanov <[EMAIL PROTECTED]>
Date: Wed, 17 Oct 2007 14:29:11 +0400
> This call is essentially void.
>
> Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]>
Applied.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More
From: Pavel Emelyanov <[EMAIL PROTECTED]>
Date: Wed, 17 Oct 2007 13:45:54 +0400
> The race can result in that some sock will get an sk_filter
> pointer set to kfree-d memory. Look
>
> CPU1:CPU2:
> sk_clone(): sk_attach_filter():
> new_sk = sk_all
From: "John W. Linville" <[EMAIL PROTECTED]>
Date: Wed, 17 Oct 2007 10:54:54 -0400
> The previous IW_SCAN_THIS_ESSID patch left a hole allowing scan
> requests on interfaces in inappropriate modes.
>
> Signed-off-by: John W. Linville <[EMAIL PROTECTED]>
John I've pulled from your tree and added
From: Grant Likely <[EMAIL PROTECTED]>
Eliminate an uninitialized variable warning. The code is correct, but
a pointer to the automatic variable 'addr' is passed to dma_alloc_coherent.
Since addr has never been initialized, and the compiler doesn't know
what dma_alloc_coherent will do with it, it
Kgdb has been submitted for inclusion in the mainline kernel at this
point, along with an additional change to the netpoll rx path.
If it is the case that this needs to be implemented in another manner,
that is ok but please do let me know what the plans are for the API so
that the kgdboe code can
From: David Miller <[EMAIL PROTECTED]>
Subject: Re: [PATCH 7/7] [TCP]: Limit processing lost_retrans loop to
work-to-do cases
Date: Thu, 11 Oct 2007 17:36:22 -0700 (PDT)
> From: "Ilpo_Järvinen" <[EMAIL PROTECTED]>
> Date: Thu, 11 Oct 2007 14:41:07 +0300
>
> > This addition of lost_retrans_low to
From: Jean Delvare <[EMAIL PROTECTED]>
Date: Tue, 16 Oct 2007 17:28:23 +0200
> By adding module aliases to inet_diag, tcp_diag and dccp_diag, we let
> them load automatically as needed. This makes tools like "ss" run
> faster.
>
> Signed-off-by: Jean Delvare <[EMAIL PROTECTED]>
> Cc: Alexey Kuzne
On Wed, 17 Oct 2007 19:47:59 -0700 Andrew Morton <[EMAIL PROTECTED]> wrote:
> - When I applied it I saw valid checkpatch warnings, so I queed a patch to
> fix them, called foo-checkpatch-fixes.patch with the intention that it later
> be
> folded into foo.patch
incidentally, the reason I do it th
From: Pavel Emelyanov <[EMAIL PROTECTED]>
Date: Tue, 16 Oct 2007 18:05:31 +0400
> Since this callback is used to check for conflicts in
> hashtable when inserting a newly created frag queue, we can
> do the same by checking for matching the queue with the
> argument, used to create one.
>
> Sign
On Wed, 17 Oct 2007 19:37:21 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote:
> From: [EMAIL PROTECTED]
> Date: Tue, 16 Oct 2007 14:24:12 -0700
>
> > From: Andrew Morton <[EMAIL PROTECTED]>
> >
> > Cc: "David S. Miller" <[EMAIL PROTECTED]>
> > Cc: Emil Medve <[EMAIL PROTECTED]>
> > Cc: Jeff G
From: Pavel Emelyanov <[EMAIL PROTECTED]>
Date: Tue, 16 Oct 2007 18:07:26 +0400
> Since we now allocate the queues in inet_fragment.c, we
> can safely free it in the same place. The ->destructor
> callback thus becomes optional for inet_frags.
>
> Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]
From: Pavel Emelyanov <[EMAIL PROTECTED]>
Date: Tue, 16 Oct 2007 18:03:37 +0400
> Here we need another callback ->match to check whether the
> entry found in hash matches the key passed. The key used
> is the same as the creation argument for inet_frag_create.
>
> Yet again, this ->match is the
From: Pavel Emelyanov <[EMAIL PROTECTED]>
Date: Tue, 16 Oct 2007 18:00:10 +0400
> This one uses the xxx_frag_intern() and xxx_frag_alloc()
> routines, which are already consolidated, so remove them
> from protocol code (as promised).
>
> The ->constructor callback is used to init the rest of
> th
From: Pavel Emelyanov <[EMAIL PROTECTED]>
Date: Tue, 16 Oct 2007 17:57:44 +0400
> Just perform the kzalloc() allocation and setup common
> fields in the inet_frag_queue(). Then return the result
> to the caller to initialize the rest.
>
> The inet_frag_alloc() may return NULL, so check the
> ret
From: Pavel Emelyanov <[EMAIL PROTECTED]>
Date: Tue, 16 Oct 2007 17:53:03 +0400
> This routine checks for the existence of a given entry
> in the hash table and inserts the new one if needed.
>
> The ->equal callback is used to compare two frag_queue-s
> together, but this one is temporary and wi
From: Pavel Emelyanov <[EMAIL PROTECTED]>
Date: Tue, 16 Oct 2007 17:48:46 +0400
> Since the hash value is already calculated in xxx_find, we can
> simply use it later. This is already done in netfilter code,
> so make the same in ipv4 and ipv6.
>
> Signed-off-by: Pavel Emelyanov <[EMAIL PROTECT
From: Stephen Hemminger <[EMAIL PROTECTED]>
Date: Tue, 16 Oct 2007 14:38:50 -0700
> Recent header_ops change would break the following dead
> code in br2684. Maintaining conditonal code in mainline is wrong.
>
> "Do, or do not. There is no 'try.'"
>
> Signed-off-by: Stephen Hemminger <[EMAIL PR
From: [EMAIL PROTECTED]
Date: Tue, 16 Oct 2007 14:24:12 -0700
> From: Andrew Morton <[EMAIL PROTECTED]>
>
> Cc: "David S. Miller" <[EMAIL PROTECTED]>
> Cc: Emil Medve <[EMAIL PROTECTED]>
> Cc: Jeff Garzik <[EMAIL PROTECTED]>
> Cc: Kumar Gala <[EMAIL PROTECTED]>
> Cc: Li Yang <[EMAIL PROTECTED]>
>
From: David Stevens <[EMAIL PROTECTED]>
Date: Wed, 17 Oct 2007 09:23:39 -0700
> Acked-by: David L Stevens <[EMAIL PROTECTED]>
>
> > Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]>
Applied, thanks.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
From: Charles Hardin <[EMAIL PROTECTED]>
Date: Wed, 17 Oct 2007 14:36:10 -0700
> Kernel needs to respond to an SADB_GET with the same message type to conform
> to the RFC 2367 Section 3.1.5
I can't apply this:
1) We need you to provide an appropriate Signed-off-by: line
in the changelog of yo
From: "Michael Chan" <[EMAIL PROTECTED]>
Date: Wed, 17 Oct 2007 19:38:42 -0700
> [PATCH 1/3][BNX2]: Update 5709 firmware to 3.7.1.
> [PATCH 2/3][BNX2]: Fix Serdes WoL bug.
> [PATCH 3/3][BNX2]: Update version to 1.6.8.
All applied, thanks Michael.
-
To unsubscribe from this list: send the line "un
[BNX2]: Update version to 1.6.8.
Signed-off-by: Michael Chan <[EMAIL PROTECTED]>
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index 2a79ffc..db79602 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -56,8 +56,8 @@
#define DRV_MODULE_NAME"bnx2"
#define PFX DRV
[BNX2]: Fix Serdes WoL bug.
The bug is in the code in bnx2_set_power_state() that assumes copper
devices when setting up WoL. This is no longer true after adding WoL
support for Serdes devices.
Signed-off-by: Michael Chan <[EMAIL PROTECTED]>
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
[PATCH 1/3][BNX2]: Update 5709 firmware to 3.7.1.
[PATCH 2/3][BNX2]: Fix Serdes WoL bug.
[PATCH 3/3][BNX2]: Update version to 1.6.8.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majo
In article <[EMAIL PROTECTED]> you write:
> Interesting. After some asking around, it appears that the mv643xx
> ethernet silicon block is indeed very similar to the ethernet silicon
> block found the in Orion ARM SoCs.
>
> We'll work on getting Orion to use mv643xx_eth. Thanks for pointing
> th
On Wed, 2007-10-17 at 18:26 -0700, Stephen Hemminger wrote:
>
> Could you give a concrete example as to why it needs a smp barrier?
> The test_bit is going to get a consistent result. Are you worried about
> operations ordering before the test_bit()? In that case, one of those
> smp_mb__before_xx
On Thu, 18 Oct 2007 10:28:09 +1000
Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote:
>
> On Wed, 2007-10-17 at 13:26 -0700, Stephen Hemminger wrote:
> > plain text document attachment (napi-synchronize.patch)
> > Some drivers with shared NAPI need a synchronization barrier.
> > Also suggested by
On Wed, 2007-10-17 at 20:02 -0500, Josh Boyer wrote:
> k, trying again, leaving the actual patch below. In the above patch
> description, you still call it __napi_synchronize. In the patch
> below,
> it's napi_syncronize.
>
> I was just trying to point out to whomever commits this patch that th
David Stevens wrote:
You're joining the group on interface eth1, which is the
sender, right?
I may have switched the ordering in the last test I ran,
but I always join the group on the interface different
from the one I send on.
-vlad
-
To unsubscribe from this list: send the line "unsubscri
> This implements a low level __napi_synchronize() function to acheive
> that. The underscores are to emphasis the low level aspect of it and
> to discourage driver writers who don't know what they are doing to
> use it (to please DaveM :-)
And I forgot to remove that bit from the description...
On Thu, 2007-10-18 at 08:04 +1000, Benjamin Herrenschmidt wrote:
> net: Add __napi_synchronize() to sync with napi poll
>
> The EMAC driver which needs to handle multiple devices with one
> NAPI instance implements its own per-channel disable bit. However,
> when setting such a bit, it needs to sy
On Tue, Oct 16, 2007 at 11:31:15PM +0200, Maxime Bizon wrote:
> Hello,
Hi,
> > +#define PORT_CONF 0x400
> > +#define PORT_CONF_EXT 0x404
> > +#define PORT_MAC_LO0x414
> > +#define PORT_MAC_HI0x418
> > +#define PORT_SDMA 0x41c
> > +#
Jay Vosburgh <[EMAIL PROTECTED]> wrote:
> 1- copy header_ops from slave to bonding for IPoIB slaves
> 2- move release and destroy logic to UNREGISTER from GOING_DOWN
> notifier to prevent double release
>
> Set bonding to version 3.2.1.
>---
> drivers/net/bonding/bond_m
Please pull from 'upstream-linus' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git
upstream-linus
to receive the following updates:
drivers/net/3c59x.c|2 +-
drivers/net/forcedeth.c| 27 ++---
drivers/net/fs_enet/fs_enet
Florin Andrei <[EMAIL PROTECTED]> wrote:
>
> Is it going to be possible to combine stateless 1:1 NAT with stateful
> filtering?
It is but it's pointless unless you can somehow enumerate the
bad guys (or a superset of them) and redirect them to NOTRACK.
Cheers,
--
Visit Openswan at http://www.op
Update ALB mode monitor to hold correct locks (RTNL and nothing
else) when calling dev_set_promiscuity.
Signed-off-by: Andy Gospodarek <[EMAIL PROTECTED]>
Signed-off-by: Jay Vosburgh <[EMAIL PROTECTED]>
---
drivers/net/bonding/bond_alb.c | 19 ++-
1 files changed, 10 ins
Convert more lock acquisitions to _bh flavor to avoid deadlock
with workqueue activity and add acquisition of RTNL in appropriate places.
Affects ALB mode, as well as core bonding functions and sysfs.
Signed-off-by: Andy Gospodarek <[EMAIL PROTECTED]>
Signed-off-by: Jay Vosburgh <[EMAIL PR
Convert mii (link state) monitor to acquire correct locks for
failover events. In particular, failovers generally require RTNL at a low
level (when manipulating device MAC addresses, for example) and no other
locks. The high level monitor is responsible for acquiring a known set
of locks,
Convert locking-related activity to new & improved system.
Convert some lock acquisitions to _bh and rework parts of ALB mode, both
to avoid deadlocks with workqueue activity.
Signed-off-by: Andy Gospodarek <[EMAIL PROTECTED]>
Signed-off-by: Jay Vosburgh <[EMAIL PROTECTED]>
---
drivers/ne
Convert bonding timers to workqueues. This converts the various
monitor functions to run in periodic work queues instead of timers. This
patch introduces the framework and convers the calls, but does not resolve
various locking issues, and does not stand alone.
Signed-off-by: Andy Gospod
Following are patches to update the locking used in the bonding
driver. This involves two basic changes: conversion from timers to
workqueues for the various periodic monitor functions, and conversion of
locking. These patches should resolve the majority of locking and
might sleep related
1- copy header_ops from slave to bonding for IPoIB slaves
2- move release and destroy logic to UNREGISTER from GOING_DOWN
notifier to prevent double release
Set bonding to version 3.2.1.
---
drivers/net/bonding/bond_main.c | 11 +--
drivers/net/bonding
Change locking in balance-rr transmit processing to use a free
running counter to determine which slave to transmit on. Instead, a
free-running counter is maintained, and modulo arithmetic used to select
a slave for transmit.
This removes lock operations from the TX path, and elim
Don Fry wrote:
Remove the statistics from the private structure.
Use the net_device_stats in netn_device structure.
Following Jeff Garzik's massive cleanup Sep 01.
pcnet32 was not "low-hanging fruit".
Tested x86_64.
Signed-off-by: Don Fry <[EMAIL PROTECTED]>
applied
-
To unsubscribe from
On Wed, 2007-10-17 at 13:26 -0700, Stephen Hemminger wrote:
> plain text document attachment (napi-synchronize.patch)
> Some drivers with shared NAPI need a synchronization barrier.
> Also suggested by Benjamin Herrenschmidt for EMAC.
>
> Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
Just
Badari Pulavarty wrote:
Simple compile warning fix. (against 2.6.23-git12)
Thanks,
Badari
vortex_up() should initialize 'err' for a successful return.
drivers/net/3c59x.c: In function `vortex_up':
drivers/net/3c59x.c:1494: warning: `err' might be used uninitialized in this
function
applied
Don Fry wrote:
Recent changes to the driver for the new napi API broke the reception of
packets when in
non-napi mode. The initialization of napi.weight was removed for the non-napi
case
leaving the value zero.
Tested NAPI and non-NAPI on x86_64.
Signed-off-by: Don Fry <[EMAIL PROTECTED]>
--
Don Fry wrote:
Remove compile warning when in non-napi mode.
Signed-off-by: Don Fry <[EMAIL PROTECTED]>
---
--- linux-2.6.23-git7/drivers/net/napi.pcnet32.c2007-10-17
15:56:15.0 -0700
+++ linux-2.6.23-git7/drivers/net/pcnet32.c 2007-10-17 16:00:44.0
-0700
@@ -442,7
Anton Vorontsov wrote:
Erroneous #ifdef introduced by 293c8513398657f6263fcdb03c87f2760cf61be4
causing NAPI-less ethernet malfunctioning.
Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]>
Signed-off-by: Vitaly Bordug <[EMAIL PROTECTED]>
applied
-
To unsubscribe from this list: send the line
Benjamin Herrenschmidt wrote:
The EMAC driver "fix" was merged by mistake before the dust had settled on
the new napi synchronize interface (and before it got merged). The final
version of that function is spelled without underscores.
Signed-off-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]>
a
applied 1-2
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Sebastian Siewior wrote:
struct net_device_stats is no longer used in driver's private
struct but in struct net_device.
Cc: Li Yang <[EMAIL PROTECTED]>
Signed-off-by: Sebastian Siewior <[EMAIL PROTECTED]>
---
drivers/net/gianfar.h |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff
Scott Wood wrote:
This driver was recently broken by several changes for which this
driver was not (or was improperly) updated:
1. SET_MODULE_OWNER() was removed.
2. netif_napi_add() was only being called when building with
the old CPM binding.
3. The received/budget test was backwards.
4. to_ne
Remove the statistics from the private structure.
Use the net_device_stats in netn_device structure.
Following Jeff Garzik's massive cleanup Sep 01.
pcnet32 was not "low-hanging fruit".
Tested x86_64.
Signed-off-by: Don Fry <[EMAIL PROTECTED]>
---
--- linux-2.6.23-git7/drivers/net/cleaner.pcnet
>In general, we're hoping to remove as many CONFIG_FOO_NAPI as possible,
>pushing everybody towards using NAPI.
>
>Any objection to heading in this direction with pcnet32?
>
>Jeff
I have no objections myself. It has been slowly moving that direction.
First with the napi implementation, de
On Wed, 2007-10-17 at 18:36 -0500, Josh Boyer wrote:
> On Thu, 2007-10-18 at 08:04 +1000, Benjamin Herrenschmidt wrote:
> > net: Add __napi_synchronize() to sync with napi poll
> >
> > The EMAC driver which needs to handle multiple devices with one
> > NAPI instance implements its own per-channel
Don Fry wrote:
Recent changes to the driver for the new napi API broke the reception of
packets when in
non-napi mode. The initialization of napi.weight was removed for the non-napi
case
leaving the value zero.
Tested NAPI and non-NAPI on x86_64.
Signed-off-by: Don Fry <[EMAIL PROTECTED]>
--
On Thu, 2007-10-18 at 08:04 +1000, Benjamin Herrenschmidt wrote:
> net: Add __napi_synchronize() to sync with napi poll
>
> The EMAC driver which needs to handle multiple devices with one
> NAPI instance implements its own per-channel disable bit. However,
> when setting such a bit, it needs to sy
Remove compile warning when in non-napi mode.
Signed-off-by: Don Fry <[EMAIL PROTECTED]>
---
--- linux-2.6.23-git7/drivers/net/napi.pcnet32.c2007-10-17
15:56:15.0 -0700
+++ linux-2.6.23-git7/drivers/net/pcnet32.c 2007-10-17 16:00:44.0
-0700
@@ -442,7 +442,9 @@ static
Bill Davidsen wrote:
If not, then shouldn't the filter table be obsoleted to avoid
confusion?
That would probably confuse people. Just don't use it if you don't
need to.
That is a most practical suggestion.
The problem is that people think they are safe with the filter table,
when in fact
The EMAC driver "fix" was merged by mistake before the dust had settled on
the new napi synchronize interface (and before it got merged). The final
version of that function is spelled without underscores.
Signed-off-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]>
---
Index: linux-work/drivers/net
Simple compile warning fix. (against 2.6.23-git12)
Thanks,
Badari
vortex_up() should initialize 'err' for a successful return.
drivers/net/3c59x.c: In function `vortex_up':
drivers/net/3c59x.c:1494: warning: `err' might be used uninitialized in this
function
Signed-off-by: Badari Pulavarty <[
You're joining the group on interface eth1, which is the
sender, right? You need to be a member on eth0 to receive it
there. I think your program needs another argument, to
specify the receiving interface, which you want to be
different from the sending interface.
Recent changes to the driver for the new napi API broke the reception of
packets when in
non-napi mode. The initialization of napi.weight was removed for the non-napi
case
leaving the value zero.
Tested NAPI and non-NAPI on x86_64.
Signed-off-by: Don Fry <[EMAIL PROTECTED]>
---
--- linux-2.6.2
Simple error handling fix (against 2.26.23-git12).
Thanks,
Badari
Need to initialize "err" in case of skb_clone() failure.
net/ipv4/ip_fragment.c: In function `ip_defrag':
net/ipv4/ip_fragment.c:540: warning: `err' might be used uninitialized in this
function
Signed-off-by: Badari Pulavarty <[
Em Wed, Oct 17, 2007 at 04:46:51PM -0400, Dan Williams escreveu:
> On Wed, 2007-10-17 at 13:27 -0700, Andrew Morton wrote:
> > On Wed, 17 Oct 2007 11:34:57 -0700 (PDT)
> > [EMAIL PROTECTED] wrote:
> >
> > > http://bugzilla.kernel.org/show_bug.cgi?id=9179
> > >
> > >Summary: 2.6.23.1 /
Hello Scott,
On Wed, 17 Oct 2007 12:42:43 -0500
Scott Wood wrote:
> This driver was recently broken by several changes for which this
> driver was not (or was improperly) updated:
>
> 1. SET_MODULE_OWNER() was removed.
> 2. netif_napi_add() was only being called when building with
> the old CPM
On Thu, 18 Oct 2007 00:31:13 +0200 (CEST)
Krzysztof Oledzki <[EMAIL PROTECTED]> wrote:
>
>
> On Wed, 17 Oct 2007, Stephen Hemminger wrote:
>
> > On Wed, 17 Oct 2007 23:15:48 +0200 (CEST)
> > Krzysztof Oledzki <[EMAIL PROTECTED]> wrote:
> >
> >> Hello,
> >>
> >> Is it normal that TCP port random
On Wed, 17 Oct 2007, Stephen Hemminger wrote:
On Wed, 17 Oct 2007 23:15:48 +0200 (CEST)
Krzysztof Oledzki <[EMAIL PROTECTED]> wrote:
Hello,
Is it normal that TCP port randomization (tested with 2.6.22) works only
when explicitly binding to a IP address:
--- cut here ---
[EMAIL PROTECTED]:
Al Boldi wrote:
Patrick McHardy wrote:
Please send mails discussing netfilter to netfilter-devel.
Ok. I just found out this changed to vger. But
[EMAIL PROTECTED] is bouncing me.
Al Boldi wrote:
With the existence of the mangle table, how useful is the filter table?
Other than requirin
the packet trace was a bit too cooked perhaps, but there were indications that
at times the TCP window was going to zero - perhaps something with window
updates or persist timers?
rick jones
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL P
On Wed, 17 Oct 2007 23:15:48 +0200 (CEST)
Krzysztof Oledzki <[EMAIL PROTECTED]> wrote:
> Hello,
>
> Is it normal that TCP port randomization (tested with 2.6.22) works only
> when explicitly binding to a IP address:
>
>
> --- cut here ---
> [EMAIL PROTECTED]:~# nc 192.168.129.28 11
> (UNKNOWN)
Thus spake Chuck Ebbert ([EMAIL PROTECTED]):
> > Any ideas what could cause this?
> (cc: netdev)
Maybe I should mention this, too:
accept(5, {sa_family=AF_INET6, sin6_port=htons(59821), inet_pton(AF_INET6,
":::127.0.0.1", &sin6_addr), sin6_flowinfo=0, sin6_scope_id=0},
[18446744069414584348
net: Add __napi_synchronize() to sync with napi poll
The EMAC driver which needs to handle multiple devices with one
NAPI instance implements its own per-channel disable bit. However,
when setting such a bit, it needs to synchronize with the poller
(that is make sure that any pending poller instan
On Wed, 2007-10-17 at 08:31 -0700, Stephen Hemminger wrote:
> Please don't use double underscore, for this function name. There is no
> reason to not make it a normal API call.
>
> The sky2 fix I am working on will use napi_synchronize as well.
Allright. A compiler barrier in the !SMP case makes
Kernel needs to respond to an SADB_GET with the same message type to conform
to the RFC 2367 Section 3.1.5
diff --git a/net/key/af_key.c b/net/key/af_key.c
index 7969f8a..fb4fee1 100644
--- a/net/key/af_key.c
+++ b/net/key/af_key.c
@@ -1552,7 +1552,7 @@ static int pfkey_get(struct sock *sk, struct
skb->dev is not set until eth_type_trans is called...
Signed-off-by: John W. Linville <[EMAIL PROTECTED]>
---
drivers/net/wireless/zd1201.c|4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/zd1201.c b/drivers/net/wireless/zd1201.c
index 935b14
David Stevens wrote:
> Can you send the contents of /proc/net/igmp and the packet trace,
> also? And the code?
>
> +-DLS
>
# cat /proc/net/igmp
Idx Device: Count Querier GroupUsers TimerReporter
1 lo: 0 V3
Hello,
Is it normal that TCP port randomization (tested with 2.6.22) works only
when explicitly binding to a IP address:
--- cut here ---
[EMAIL PROTECTED]:~# nc 192.168.129.28 11
(UNKNOWN) [192.168.129.28] 11 (systat) : Connection refused
[EMAIL PROTECTED]:~# nc 192.168.129.28 11
(UNKNOWN) [
On 10/17/2007 04:51 PM, Felix von Leitner wrote:
> I wrote a small read-only SMB server, and wanted to see how fast it was.
> So I used smbget to download a moderately large file from it via localhost.
> smbget only got ~70 KB/sec.
>
> This is what the view from strace -tt on the server is:
>
> 2
Patrick McHardy wrote:
And Linux 2.6.23? :)
Alright, I get it. :-) Building kernel 2.6.23.1 as we speak.
--
Florin Andrei
http://florin.myip.org/
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://v
1 - 100 of 175 matches
Mail list logo
