Don Fry wrote:
Recent changes to the driver for the new napi API broke the reception of
packets when in
non-napi mode. The initialization of napi.weight was removed for the non-napi
case
leaving the value zero.
Tested NAPI and non-NAPI on x86_64.
Signed-off-by: Don Fry <[EMAIL PROTECTED]>
---
--- linux-2.6.23-git7/drivers/net/orig.pcnet32.c 2007-10-15
11:19:17.000000000 -0700
+++ linux-2.6.23-git7/drivers/net/pcnet32.c 2007-10-17 15:56:15.000000000
-0700
@@ -1849,6 +1849,9 @@ pcnet32_probe1(unsigned long ioaddr, int
lp->mii_if.mdio_read = mdio_read;
lp->mii_if.mdio_write = mdio_write;
+ /* napi.weight is used in both the napi and non-napi cases */
+ lp->napi.weight = lp->rx_ring_size / 2;
+
#ifdef CONFIG_PCNET32_NAPI
netif_napi_add(dev, &lp->napi, pcnet32_poll, lp->rx_ring_size / 2);
#endif
In general, we're hoping to remove as many CONFIG_FOO_NAPI as possible,
pushing everybody towards using NAPI.
Any objection to heading in this direction with pcnet32?
Jeff
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
