Can I please get a review for this change which adds a utility to the JDK test
library to help launch the JWebServer? As noted in the JBS issue, this utility
does the necessary work to make sure when the `launch()` method returns, the
jwebserver is ready to receive requests. This helps remove a
On Wed, 22 Jun 2022 06:09:39 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which adds a utility to the JDK
> test library to help launch the JWebServer? As noted in the JBS issue, this
> utility does the necessary work to make sure when the `launch()` method
passed without any related issues.
Jaikiran Pai has updated the pull request incrementally with one additional
commit since the last revision:
clarify that the jwebserver is launched as a separate process and needs to be
destroyed by the caller when it's no longer needed
-
Cha
On Wed, 22 Jun 2022 06:09:39 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which adds a utility to the JDK
> test library to help launch the JWebServer? As noted in the JBS issue, this
> utility does the necessary work to make sure when the `launch()` method
On Wed, 22 Jun 2022 08:01:31 GMT, Alan Bateman wrote:
> My main concern with locating JWebServerLauncher in the lib tree is that I
> don't have a good feel yet what tests might want an out-of-process HTTP
> server.
The use case that prompted me to create this utility is a very specific case
w
On Wed, 22 Jun 2022 14:28:25 GMT, Michael McMahon wrote:
> Probably need to add noreg-hard label to bug.
Done.
Thank you Daniel and Michael for the reviews.
-
PR: https://git.openjdk.org/jdk/pull/9038
On Mon, 6 Jun 2022 09:43:50 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to fix
> https://bugs.openjdk.java.net/browse/JDK-8276798?
>
> `sun.net.www.protocol.http.HttpURLConnection` has a (private) `writeRequests`
> method. This method is
Can I please get a review for this change which fixes the broken link in the
javadoc of `SimpleFileServer`? This fixes
https://bugs.openjdk.org/browse/JDK-8288983 which has the necessary context on
why/when this link broke.
I used the doccheck tool
https://urldefense.com/v3/__https://github.co
On Fri, 24 Jun 2022 08:49:06 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which fixes the broken link in the
> javadoc of `SimpleFileServer`? This fixes
> https://bugs.openjdk.org/browse/JDK-8288983 which has the necessary context
> on why/when this link b
On Fri, 24 Jun 2022 08:49:06 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which fixes the broken link in the
> javadoc of `SimpleFileServer`? This fixes
> https://bugs.openjdk.org/browse/JDK-8288983 which has the necessary context
> on why/when this link b
On Mon, 20 Jun 2022 14:09:27 GMT, Daniel Fuchs wrote:
> Hi,
>
> Please find here a patch that should help the HttpClient's SelectorManager
> thread to terminate more timely, allowing the resources consumed by the
> client to be released earlier.
>
> The idea is to use a Cleaner registered wit
On Sun, 26 Jun 2022 06:08:07 GMT, Jaikiran Pai wrote:
>> Hi,
>>
>> Please find here a patch that should help the HttpClient's SelectorManager
>> thread to terminate more timely, allowing the resources consumed by the
>> client to be released earlier.
On Mon, 20 Jun 2022 14:09:27 GMT, Daniel Fuchs wrote:
> Hi,
>
> Please find here a patch that should help the HttpClient's SelectorManager
> thread to terminate more timely, allowing the resources consumed by the
> client to be released earlier.
>
> The idea is to use a Cleaner registered wit
On Wed, 22 Jun 2022 07:44:34 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this change which adds a utility to the JDK
>> test library to help launch the JWebServer? As noted in the JBS issue, this
>> utility does the necessary work to make sure when the
On Wed, 22 Jun 2022 06:09:39 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which adds a utility to the JDK
> test library to help launch the JWebServer? As noted in the JBS issue, this
> utility does the necessary work to make sure when the `launch()` method
Can I please get a review for this change which addresses
https://bugs.openjdk.org/browse/JDK-8289291?
As noted in that issue, right now, the Http(s)Server sets an incorrect value
for the `max` parameter of the `Keep-Alive` header. The `max` value is supposed
to be the number of subsequent requ
On Wed, 29 Jun 2022 10:58:34 GMT, Michael McMahon wrote:
> Could we add a test (even to an existing keepalive one) to verify that "max"
> is no longer sent?
Done. I've updated the PR to include a new test which verifies the absence of
the `max` parameter in the `Keep-Alive` response header. Th
s change won't cause any regressions in
> that area.
>
> tier1, tier2 and tier3 testing passed without any related issues after this
> change.
Jaikiran Pai has updated the pull request incrementally with one additional
commit since the last revision:
Michael's sugg
On Wed, 29 Jun 2022 15:12:01 GMT, Daniel Fuchs wrote:
> Just wondering about using a simple Socket as the client (which is fine). I'd
> expect it should be possible to see the value of the header with the new
> HttpClient (unless we filter it?).
The Http(s)Server will set the `Keep-Alive` head
On Wed, 29 Jun 2022 10:20:42 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which addresses
> https://bugs.openjdk.org/browse/JDK-8289291?
>
> As noted in that issue, right now, the Http(s)Server sets an incorrect value
> for the `max` parameter of
On Wed, 29 Jun 2022 12:05:42 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this change which addresses
>> https://bugs.openjdk.org/browse/JDK-8289291?
>>
>> As noted in that issue, right now, the Http(s)Server sets an incorrect value
>> for the `max
On Tue, 28 Jun 2022 17:19:32 GMT, Bill Huang wrote:
>> Failure was observed on
>> java/net/DatagramSocket/InterruptibleDatagramSocket.java where data was
>> received unexpectedly (
>> [JDK-8286607](https://bugs.openjdk.org/browse/JDK-8286607)). This failure
>> could be caused by interference
On Wed, 29 Jun 2022 20:57:14 GMT, Andrey Turbanov wrote:
>> Http2ClientImpl.stopping and Http2ClientImpl.failures are always accessed
>> under synchronized(this).
>> So we can remove 'volatile' modifier from 'stopping'. And remove
>> 'synchronizedSet' wrapper from 'failures'
>
> Andrey Turbanov
On Thu, 30 Jun 2022 16:54:53 GMT, Bill Huang wrote:
>> Failure was observed on
>> java/net/DatagramSocket/InterruptibleDatagramSocket.java where data was
>> received unexpectedly (
>> [JDK-8286607](https://bugs.openjdk.org/browse/JDK-8286607)). This failure
>> could be caused by interference
On Mon, 4 Jul 2022 13:03:46 GMT, Michael McMahon wrote:
> Hi,
>
> Could I get the following small change reviewed please?
>
> It removes a test that calls Thread.stop() which is no longer required since
> it was checking for
> a bug in the old SocketImpl that has recently been replaced by the
On Mon, 11 Jul 2022 14:35:55 GMT, Daniel Fuchs wrote:
> Please find enclosed a simple test fix.
> This test has been observed failing once with an SSLException. My suspicion
> is that some random process (other test or ...) has tried to connect to the
> test ReplyingServer and sent some plain t
On Tue, 12 Jul 2022 08:17:35 GMT, Daniel Fuchs wrote:
>> Please find enclosed a simple test fix.
>> This test has been observed failing once with an SSLException. My suspicion
>> is that some random process (other test or ...) has tried to connect to the
>> test ReplyingServer and sent some pla
On Thu, 21 Jul 2022 09:46:27 GMT, Michael McMahon wrote:
> Hi,
>
> Could I get the following trivial code change reviewed please? Static
> analysis shows one
> static field declaration in java.net.URL that should be final.
>
> Thanks,
> Michael.
Marked as reviewed by jpai (Reviewer).
--
On Thu, 21 Jul 2022 13:24:01 GMT, Jason Laber wrote:
>> Conor Cleary has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8283544: Added in missing case
>
> It's tough to tell what versions this fix will get into. Will this go into a
> Java
On Wed, 20 Jul 2022 17:19:50 GMT, Daniel Jeliński wrote:
> This patch partially fixes the issue where IPv6 sockets were fragmenting
> outgoing IPv4 datagrams even when IP_DONTFRAGMENT flag was set. Specifically,
> it fixes the issue on Linux and Windows. As far as I could tell, the issue is
>
On Thu, 21 Jul 2022 20:00:37 GMT, Andrey Turbanov wrote:
> Static field 'BUF_SIZE' in the class
> sun.net.[www.protocol.jar.URLJarFile](http://www.protocol.jar.urljarfile/) is
> unused and can be removed.
The change looks fine to me.
The `BUF_SIZE` appears to be a left over from the change do
On Wed, 3 Aug 2022 14:33:56 GMT, Daniel Jeliński wrote:
>> This patch fixes a race condition in KeepAliveProperty test. The client
>> thread could read the `pass` field and fail the test before the server
>> thread had a chance to set the field value to `true`. The fix adds an
>> explicit wait
On Thu, 4 Aug 2022 20:41:33 GMT, Michael McMahon wrote:
> Hi,
>
> Some new keep alive tests are exposing some old bugs. In this case if the
> server sends an invalid timeout (say -20 seconds) we accept it creating a
> timeout in the past. So, the first time the keep alive thread wakes up it
>
On Fri, 5 Aug 2022 10:32:56 GMT, Michael McMahon wrote:
>> Hi,
>>
>> Some new keep alive tests are exposing some old bugs. In this case if the
>> server sends an invalid timeout (say -20 seconds) we accept it creating a
>> timeout in the past. So, the first time the keep alive thread wakes up
On Wed, 20 Jul 2022 14:02:39 GMT, thyecust wrote:
> The condition at line 57 (after while) will evaluate to false
> if startLine == null, so the previous if-condition is covered.
Hello @thyecust, I've created a JBS issue to track this change
https://bugs.openjdk.org/browse/JDK-8291956. Please c
On Wed, 17 Aug 2022 17:06:12 GMT, Daniel Fuchs wrote:
> Please find here a change that improves SpecialHeadersTest. This test creates
> a large amount of ephemeral clients and has been observed running out of heap
> space in our CI once. This change updates the test to wait for the previous
>
On Wed, 17 Aug 2022 17:06:12 GMT, Daniel Fuchs wrote:
> Please find here a change that improves SpecialHeadersTest. This test creates
> a large amount of ephemeral clients and has been observed running out of heap
> space in our CI once. This change updates the test to wait for the previous
>
On Wed, 17 Aug 2022 17:06:12 GMT, Daniel Fuchs wrote:
> Please find here a change that improves SpecialHeadersTest. This test creates
> a large amount of ephemeral clients and has been observed running out of heap
> space in our CI once. This change updates the test to wait for the previous
>
On Wed, 17 Aug 2022 17:06:12 GMT, Daniel Fuchs wrote:
> Please find here a change that improves SpecialHeadersTest. This test creates
> a large amount of ephemeral clients and has been observed running out of heap
> space in our CI once. This change updates the test to wait for the previous
>
On Wed, 17 Aug 2022 17:06:12 GMT, Daniel Fuchs wrote:
> Please find here a change that improves SpecialHeadersTest. This test creates
> a large amount of ephemeral clients and has been observed running out of heap
> space in our CI once. This change updates the test to wait for the previous
>
On Wed, 17 Aug 2022 17:06:12 GMT, Daniel Fuchs wrote:
> Please find here a change that improves SpecialHeadersTest. This test creates
> a large amount of ephemeral clients and has been observed running out of heap
> space in our CI once. This change updates the test to wait for the previous
>
On Wed, 17 Aug 2022 17:06:12 GMT, Daniel Fuchs wrote:
> Please find here a change that improves SpecialHeadersTest. This test creates
> a large amount of ephemeral clients and has been observed running out of heap
> space in our CI once. This change updates the test to wait for the previous
>
On Fri, 19 Aug 2022 10:51:32 GMT, Daniel Fuchs wrote:
>> Please find here a change that improves SpecialHeadersTest. This test
>> creates a large amount of ephemeral clients and has been observed running
>> out of heap space in our CI once. This change updates the test to wait for
>> the previ
Can I please get a review of this javadoc only change for
`DatagramPacket#setLength()` method? This addresses
https://bugs.openjdk.org/browse/JDK-7113208.
I haven't create a CSR because the javadoc was already stating the correct
behaviour in the `@throws` documentation as follows:
> @throws
Can I please get a review of this javadoc only change which addresses
https://bugs.openjdk.org/browse/JDK-8292968?
The updated javadoc now uses the `@systemProperty`, since this is the place
where the semantics of this system property has been described. As per the
expectations of `@systemPrope
ocumentation as follows:
>
>> @throws IllegalArgumentExceptionif the length is negative,
> * or if the length plus the offset is greater than the
> * length of the packet's data buffer.
>
> This commit merely fixes the main part of the ja
On Fri, 26 Aug 2022 08:55:27 GMT, Daniel Fuchs wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> implement review comment
>
> src/java.base/share/classes/java/net/DatagramPacket.java li
On Fri, 26 Aug 2022 11:49:48 GMT, Daniel Fuchs wrote:
> but the property was documented before, so I now believe the CSR is not
> needed.
You are right. In fact, the Java 8 version of this class uses the system
property name literally (as seen here
https://docs.oracle.com/javase/8/docs/api/ja
On Fri, 26 Aug 2022 09:22:26 GMT, Jaikiran Pai wrote:
> Can I please get a review of this javadoc only change which addresses
> https://bugs.openjdk.org/browse/JDK-8292968?
>
> The updated javadoc now uses the `@systemProperty`, since this is the place
> where the semantics
On Fri, 26 Aug 2022 09:22:26 GMT, Jaikiran Pai wrote:
> Can I please get a review of this javadoc only change which addresses
> https://bugs.openjdk.org/browse/JDK-8292968?
>
> The updated javadoc now uses the `@systemProperty`, since this is the place
> where the semantics
ocumentation as follows:
>
>> @throws IllegalArgumentExceptionif the length is negative,
> * or if the length plus the offset is greater than the
> * length of the packet's data buffer.
>
> This commit merely fixes the main part of the ja
On Fri, 26 Aug 2022 10:15:59 GMT, Daniel Fuchs wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> implement review comment
>
> src/java.base/share/classes/java/net/DatagramPacket.java l
On Thu, 1 Sep 2022 07:01:14 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this javadoc only change for
>> `DatagramPacket#setLength()` method? This addresses
>> https://bugs.openjdk.org/browse/JDK-7113208.
>>
>> I haven't create a CSR because
On Fri, 26 Aug 2022 07:51:16 GMT, Jaikiran Pai wrote:
> Can I please get a review of this javadoc only change for
> `DatagramPacket#setLength()` method? This addresses
> https://bugs.openjdk.org/browse/JDK-7113208.
>
> I haven't create a CSR because the javadoc was already
Can I please get a review of this change which proposes to fix
https://bugs.openjdk.org/browse/JDK-8292044?
The linked JBS issue notes two parts to fixing this. Part one is to
(internally) ignore the intermediate 1xx informational responses, in the client
and wait for subsequent final response
> A new test class has been introduced to reproduce the issue and test the fix.
> The test tests both HTTP/1.1 and HTTP2.
>
> tier1, tier2 and tier3 testing is in progress.
Jaikiran Pai has updated the pull request incrementally with two additional
commits since the last rev
> A new test class has been introduced to reproduce the issue and test the fix.
> The test tests both HTTP/1.1 and HTTP2.
>
> tier1, tier2 and tier3 testing is in progress.
Jaikiran Pai has updated the pull request incrementally with one additional
commit since the last re
On Tue, 6 Sep 2022 06:38:13 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix
>> https://bugs.openjdk.org/browse/JDK-8292044?
>>
>> The linked JBS issue notes two parts to fixing this. Part one is to
>> (internall
On Mon, 5 Sep 2022 15:06:37 GMT, Daniel Fuchs wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reduce the time the test runs for
>
> src/java.net.http/share/classes/jdk/internal/n
On Tue, 6 Sep 2022 13:56:15 GMT, Conor Cleary wrote:
> **Issue**
> When using HTTP/2 with the HttpClient, it can often be necessary to close an
> idle Http2 Connection before a server sends a GOAWAY frame. For example, a
> server or cloud based tool could close a TCP connection silently when it
On Tue, 6 Sep 2022 13:56:15 GMT, Conor Cleary wrote:
> **Issue**
> When using HTTP/2 with the HttpClient, it can often be necessary to close an
> idle Http2 Connection before a server sends a GOAWAY frame. For example, a
> server or cloud based tool could close a TCP connection silently when it
On Tue, 6 Sep 2022 13:56:15 GMT, Conor Cleary wrote:
> **Issue**
> When using HTTP/2 with the HttpClient, it can often be necessary to close an
> idle Http2 Connection before a server sends a GOAWAY frame. For example, a
> server or cloud based tool could close a TCP connection silently when it
On Tue, 6 Sep 2022 13:56:15 GMT, Conor Cleary wrote:
> **Issue**
> When using HTTP/2 with the HttpClient, it can often be necessary to close an
> idle Http2 Connection before a server sends a GOAWAY frame. For example, a
> server or cloud based tool could close a TCP connection silently when it
On Tue, 6 Sep 2022 13:56:15 GMT, Conor Cleary wrote:
> **Issue**
> When using HTTP/2 with the HttpClient, it can often be necessary to close an
> idle Http2 Connection before a server sends a GOAWAY frame. For example, a
> server or cloud based tool could close a TCP connection silently when it
On Tue, 6 Sep 2022 13:56:15 GMT, Conor Cleary wrote:
> **Issue**
> When using HTTP/2 with the HttpClient, it can often be necessary to close an
> idle Http2 Connection before a server sends a GOAWAY frame. For example, a
> server or cloud based tool could close a TCP connection silently when it
> A new test class has been introduced to reproduce the issue and test the fix.
> The test tests both HTTP/1.1 and HTTP2.
>
> tier1, tier2 and tier3 testing is in progress.
Jaikiran Pai has updated the pull request incrementally with one additional
commit since the las
On Fri, 9 Sep 2022 07:06:32 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix
>> https://bugs.openjdk.org/browse/JDK-8292044?
>>
>> The linked JBS issue notes two parts to fixing this. Part one is to
>> (internall
On Fri, 9 Sep 2022 07:08:14 GMT, Jaikiran Pai wrote:
>
> Specifically, the RFC states that if the request is configured for
> "Expect-Continue" and if the server still sends a `100` response
That should read "the RFC states that if the request is *not* configur
On Fri, 9 Sep 2022 07:06:32 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix
>> https://bugs.openjdk.org/browse/JDK-8292044?
>>
>> The linked JBS issue notes two parts to fixing this. Part one is to
>> (internall
> A new test class has been introduced to reproduce the issue and test the fix.
> The test tests both HTTP/1.1 and HTTP2.
>
> tier1, tier2 and tier3 testing is in progress.
Jaikiran Pai has updated the pull request incrementally with one additional
commit since the last revis
On Fri, 9 Sep 2022 07:23:53 GMT, Julian Reschke wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> ignore 100 response when request isn't configured for expect continue
>
>
> A new test class has been introduced to reproduce the issue and test the fix.
> The test tests both HTTP/1.1 and HTTP2.
>
> tier1, tier2 and tier3 testing is in progress.
Jaikiran Pai has updated the pull request incrementally with one additional
commit since the last revision:
> A new test class has been introduced to reproduce the issue and test the fix.
> The test tests both HTTP/1.1 and HTTP2.
>
> tier1, tier2 and tier3 testing is in progress.
Jaikiran Pai has updated the pull request incrementally with one additional
commit since the last revision:
On Fri, 9 Sep 2022 08:34:07 GMT, Daniel Fuchs wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> code comment adjustment
>
> test/jdk/java/net/httpclient/Response
On Fri, 9 Sep 2022 09:03:06 GMT, Julian Reschke wrote:
> FWIW, it would be awesome if an equivalent fix could be applied to
> HTTPURLConnection.
A brief look at the code in that area suggests that it might be relatively
straightforward to fix that too. I'll check it out in more detail.
--
Can I please get a review of this change which proposes to fix
https://bugs.openjdk.org/browse/JDK-8170305?
The commit in this PR changes the internal implementation of
`HttpURLConnection` to ignore interim informational 1xx responses from server
and continue to wait for the final response. Thi
> A new test class has been introduced to reproduce the issue and test the fix.
> The test tests both HTTP/1.1 and HTTP2.
>
> tier1, tier2 and tier3 testing is in progress.
Jaikiran Pai has updated the pull request incrementally with one additional
commit sinc
On Fri, 9 Sep 2022 09:57:09 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix
>> https://bugs.openjdk.org/browse/JDK-8292044?
>>
>> The linked JBS issue notes two parts to fixing this. Part one is to
>> (internall
ting is in progress with this change.
Jaikiran Pai has updated the pull request incrementally with two additional
commits since the last revision:
- consider it a protocol violation if the server sends a 101 when the
HttpURLConnection doesn't ask for a connection upgrade
- 101 Upgrade
On Mon, 12 Sep 2022 07:36:48 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix
>> https://bugs.openjdk.org/browse/JDK-8170305?
>>
>> The commit in this PR changes the internal implementation of
>> `HttpURLConnection` to ig
ting is in progress with this change.
Jaikiran Pai has updated the pull request incrementally with one additional
commit since the last revision:
Add a log message when ignorning 1xx responses
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10229/files
- new: https://
ting is in progress with this change.
Jaikiran Pai has updated the pull request incrementally with one additional
commit since the last revision:
fix test server to avoid hang in test
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10229/files
- new: https://git.openj
On Mon, 12 Sep 2022 07:45:44 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix
>> https://bugs.openjdk.org/browse/JDK-8170305?
>>
>> The commit in this PR changes the internal implementation of
>> `HttpURLConnection` to ig
On Wed, 7 Sep 2022 17:51:47 GMT, Daniel Fuchs wrote:
>> src/java.net.http/share/classes/jdk/internal/net/http/Http2Connection.java
>> line 200:
>>
>>> 198: debug.log("HTTP connection idle for too long");
>>> 199: }
>>> 200: HttpTimeoutException hte = new
On Mon, 12 Sep 2022 09:41:09 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix
>> https://bugs.openjdk.org/browse/JDK-8170305?
>>
>> The commit in this PR changes the internal implementation of
>> `HttpURLConnection` to ig
On Mon, 12 Sep 2022 12:52:00 GMT, Daniel Fuchs wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix test server to avoid hang in test
>
> test/jdk/java/net/HttpURLConnection/Response1x
ting is in progress with this change.
Jaikiran Pai has updated the pull request incrementally with one additional
commit since the last revision:
verify ProtocolException in the test
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10229/files
- new: https://git.openj
On Mon, 12 Sep 2022 13:04:12 GMT, Daniel Fuchs wrote:
>> I initially thought about that, but since the API javadoc doesn't
>> specifically talk about this sub-type of `IOException`, I decided it's
>> perhaps better not to start expecting it. However, if it's OK for the test
>> to rely on this
On Mon, 12 Sep 2022 13:26:45 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix
>> https://bugs.openjdk.org/browse/JDK-8170305?
>>
>> The commit in this PR changes the internal implementation of
>> `HttpURLConnection` to ig
On Fri, 9 Sep 2022 11:21:51 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to fix
> https://bugs.openjdk.org/browse/JDK-8170305?
>
> The commit in this PR changes the internal implementation of
> `HttpURLConnection` to ignore interim in
On Mon, 12 Sep 2022 13:26:45 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix
>> https://bugs.openjdk.org/browse/JDK-8170305?
>>
>> The commit in this PR changes the internal implementation of
>> `HttpURLConnection` to ig
> A new test class has been introduced to reproduce the issue and test the fix.
> The test tests both HTTP/1.1 and HTTP2.
>
> tier1, tier2 and tier3 testing is in progress.
Jaikiran Pai has updated the pull request incrementally with one additional
commit since
On Fri, 9 Sep 2022 12:51:07 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix
>> https://bugs.openjdk.org/browse/JDK-8292044?
>>
>> The linked JBS issue notes two parts to fixing this. Part one is to
>> (internall
On Wed, 14 Sep 2022 13:57:34 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix
>> https://bugs.openjdk.org/browse/JDK-8292044?
>>
>> The linked JBS issue notes two parts to fixing this. Part one is to
>> (internall
On Sat, 17 Sep 2022 10:53:31 GMT, Julian Reschke wrote:
> Tested over at https://github.com/greenbytes/java-http-1xx-tests and found to
> be working; thanks!
>
Thank you Julian for running those tests. Glad to hear it works now.
> > OpenJDK backports however are decided/managed by different te
> A new test class has been introduced to reproduce the issue and test the fix.
> The test tests both HTTP/1.1 and HTTP2.
>
> tier1, tier2 and tier3 testing is in progress.
Jaikiran Pai has updated the pull request incrementally with two additional
commits since the last rev
> A new test class has been introduced to reproduce the issue and test the fix.
> The test tests both HTTP/1.1 and HTTP2.
>
> tier1, tier2 and tier3 testing is in progress.
Jaikiran Pai has updated the pull request incrementally with two additional
commits since the last revision:
> A new test class has been introduced to reproduce the issue and test the fix.
> The test tests both HTTP/1.1 and HTTP2.
>
> tier1, tier2 and tier3 testing is in progress.
Jaikiran Pai has updated the pull request incrementally with one additional
commit since the l
> A new test class has been introduced to reproduce the issue and test the fix.
> The test tests both HTTP/1.1 and HTTP2.
>
> tier1, tier2 and tier3 testing is in progress.
Jaikiran Pai has updated the pull request with a new target base due to a merge
or a rebase. The increme
On Tue, 20 Sep 2022 05:38:49 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix
>> https://bugs.openjdk.org/browse/JDK-8292044?
>>
>> The linked JBS issue notes two parts to fixing this. Part one is to
>> (internall
1 - 100 of 1351 matches
Mail list logo
