On Fri, 9 Sep 2022 08:34:07 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:

>> Jaikiran Pai has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   code comment adjustment
>
> test/jdk/java/net/httpclient/Response1xxTest.java line 76:
> 
>> 74:         http1RequestURIBase = "http://"; + 
>> serverSocket.getInetAddress().getHostAddress()
>> 75:                 + ":" + serverSocket.getLocalPort();
>> 76: 
> 
> This will not work if the address is the IPv6 loopback. I suggest using the 
> test URIBuilder to build the URI.

You are right - I hadn't taken that aspect into account. I have now updated the 
PR to use the `URIBuilder` test library.

-------------

PR: https://git.openjdk.org/jdk/pull/10169

Reply via email to