> Can I please get a review for this change which addresses > https://bugs.openjdk.org/browse/JDK-8289291? > > As noted in that issue, right now, the Http(s)Server sets an incorrect value > for the `max` parameter of the `Keep-Alive` header. The `max` value is > supposed to be the number of subsequent requests that the server is willing > to serve over that specific connection. The current value it sets is instead > the number of idle connections that are configured for the server. > > The commit in this PR removes that `max` parameter altogether, since it isn't > mandated by the spec, nor does the Http(s)Server have any specific construct > to come up with a right value. Furthermore, on the client side the > HttpURLConnection based client doesn't mandate the presence of this parameter > in the `Keep-Alive` header. So this change won't cause any regressions in > that area. > > tier1, tier2 and tier3 testing passed without any related issues after this > change.
Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision: Michael's suggestion - add a test to verify "max" parameter isn't present in Keep-Alive response header ------------- Changes: - all: https://git.openjdk.org/jdk/pull/9326/files - new: https://git.openjdk.org/jdk/pull/9326/files/5bd9ebd0..1863de24 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=9326&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=9326&range=00-01 Stats: 104 lines in 1 file changed: 104 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/9326.diff Fetch: git fetch https://git.openjdk.org/jdk pull/9326/head:pull/9326 PR: https://git.openjdk.org/jdk/pull/9326
