On Wed, 22 Jun 2022 07:44:34 GMT, Jaikiran Pai <[email protected]> wrote:
>> Can I please get a review for this change which adds a utility to the JDK >> test library to help launch the JWebServer? As noted in the JBS issue, this >> utility does the necessary work to make sure when the `launch()` method >> returns, the jwebserver is ready to receive requests. This helps remove a >> lot of boilerplate code from individual tests. >> >> As part of this commit, the existing `MaxRequestTimeTest` has been migrated >> to use this new utility. This existing test continues to pass with this >> change. >> >> tier1, tier2 and tier3 testing passed without any related issues. > > Jaikiran Pai has updated the pull request incrementally with one additional > commit since the last revision: > > clarify that the jwebserver is launched as a separate process and needs to > be destroyed by the caller when it's no longer needed I'm withdrawing this PR, given that it's too early to make this an utility. We can revisit it if we feel the need to have such an utility to launch the https://github.com/openjdk/jdk/blob/master/src/jdk.httpserver/share/classes/sun/net/httpserver/simpleserver/JWebServer.java. ------------- PR: https://git.openjdk.org/jdk/pull/9232
