On Fri, 4 Apr 2025 10:48:38 GMT, Daniel Fuchs wrote:
> Generally looks good.
Does this mean you think the PR is good for approval now that the IP version
aspect has been taken care of?
Or would you like more time/people to review this test-only enhancement?
-
PR Review Comment: h
Please find her a patch that deprecate networking permission classes for
removal. The method `URL::getPermission` now serves little purpose and is also
deprecated. That method was overridden in subclasses and specified to return
some of the deprecated permissions.
-
Commit message
On Thu, 10 Apr 2025 05:47:09 GMT, Volkan Yazici wrote:
> Avoid unnecessary boxing in `HttpHeaders::firstValueAsLong`.
This pull request has now been integrated.
Changeset: e1b67709
Author:Volkan Yazici
Committer: Daniel Jeliński
URL:
https://git.openjdk.org/jdk/commit/e1b677091e0f7
> Please find her a patch that deprecate networking permission classes for
> removal. The method `URL::getPermission` now serves little purpose and is
> also deprecated. That method was overridden in subclasses and specified to
> return some of the deprecated permissions.
Daniel Fuchs has upda
On Fri, 11 Apr 2025 09:00:05 GMT, Daniel Fuchs wrote:
> Please find her a patch that deprecate networking permission classes for
> removal. The method `URL::getPermission` now serves little purpose and is
> also deprecated. That method was overridden in subclasses and specified to
> return so
On Fri, 11 Apr 2025 10:01:26 GMT, Daniel Fuchs wrote:
>> Please find her a patch that deprecate networking permission classes for
>> removal. The method `URL::getPermission` now serves little purpose and is
>> also deprecated. That method was overridden in subclasses and specified to
>> retur
On Fri, 11 Apr 2025 10:55:10 GMT, Daniel Jeliński wrote:
>> Daniel Fuchs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Missing white spaces
>
> src/java.base/share/classes/java/security/CodeSource.java line 468:
>
>> 466:
On Fri, 11 Apr 2025 10:01:26 GMT, Daniel Fuchs wrote:
>> Please find her a patch that deprecate networking permission classes for
>> removal. The method `URL::getPermission` now serves little purpose and is
>> also deprecated. That method was overridden in subclasses and specified to
>> retur
On Fri, 11 Apr 2025 10:45:20 GMT, Daniel Jeliński wrote:
>> Daniel Fuchs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Missing white spaces
>
> src/java.base/share/classes/java/net/HttpURLConnection.java line 617:
>
>> 615: * {@l
On Fri, 11 Apr 2025 11:30:54 GMT, Daniel Fuchs wrote:
>> src/java.base/share/classes/java/net/HttpURLConnection.java line 617:
>>
>>> 615: * {@link java.security.AllPermission}.
>>> 616: */
>>> 617: @Deprecated(since = "25")
>>
>> can this (and all other getPermission methods) be
On Fri, 11 Apr 2025 11:10:10 GMT, Daniel Jeliński wrote:
>> src/java.base/share/classes/java/security/CodeSource.java line 468:
>>
>>> 466: }
>>> 467: @SuppressWarnings("removal")
>>> 468: var result = this.sp.implies(that.sp);
>>
>> Will we need
On Fri, 11 Apr 2025 11:34:36 GMT, Alan Bateman wrote:
>> Possibly. @AlanBateman may have some thoughts on this.
>
> I think we should at least consider deprecating URLConnection.getPermission
> and HttpURLConnection.getPermission for removal, only because I don't
> immediately see the advantage
On Fri, 11 Apr 2025 10:01:26 GMT, Daniel Fuchs wrote:
>> Please find her a patch that deprecate networking permission classes for
>> removal. The method `URL::getPermission` now serves little purpose and is
>> also deprecated. That method was overridden in subclasses and specified to
>> retur
On Fri, 4 Apr 2025 10:37:58 GMT, Eirik Bjørsnøs wrote:
>> Please review this test-only PR which introduces testing of the unspecified
>> but long-standing fallback to FTP for non-local files in the 'file' URL
>> scheme.
>>
>> This in preparation for the upcoming proposal to disable the featur
On Fri, 11 Apr 2025 07:58:43 GMT, Eirik Bjørsnøs wrote:
>> Generally looks good. "127.0.0.1" rings alarm bells because we're trying to
>> make our tests independent of the IP versions supported by the machine they
>> run on.
>
>> Generally looks good.
>
> Does this mean you think the PR is goo
On Fri, 4 Apr 2025 10:37:58 GMT, Eirik Bjørsnøs wrote:
>> Please review this test-only PR which introduces testing of the unspecified
>> but long-standing fallback to FTP for non-local files in the 'file' URL
>> scheme.
>>
>> This in preparation for the upcoming proposal to disable the featur
On Thu, 3 Apr 2025 15:44:44 GMT, Eirik Bjørsnøs wrote:
> Please review this test-only PR which introduces testing of the unspecified
> but long-standing fallback to FTP for non-local files in the 'file' URL
> scheme.
>
> This in preparation for the upcoming proposal to disable the feature by
On Fri, 11 Apr 2025 13:47:10 GMT, Michael McMahon wrote:
>> Daniel Fuchs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Missing white spaces
>
> src/java.base/share/classes/java/security/CodeSource.java line 461:
>
>> 459:
On Fri, 11 Apr 2025 11:47:21 GMT, Daniel Fuchs wrote:
>> I think we should at least consider deprecating URLConnection.getPermission
>> and HttpURLConnection.getPermission for removal, only because I don't
>> immediately see the advantage of doing it in two steps for these two APIs.
>
> Thanks
On Fri, 11 Apr 2025 13:56:18 GMT, Daniel Fuchs wrote:
>> Please find her a patch that deprecate networking permission classes for
>> removal. The method `URL::getPermission` now serves little purpose and is
>> also deprecated. That method was overridden in subclasses and specified to
>> retur
On Fri, 11 Apr 2025 10:01:26 GMT, Daniel Fuchs wrote:
>> Please find her a patch that deprecate networking permission classes for
>> removal. The method `URL::getPermission` now serves little purpose and is
>> also deprecated. That method was overridden in subclasses and specified to
>> retur
On Fri, 11 Apr 2025 13:56:18 GMT, Daniel Fuchs wrote:
>> Please find her a patch that deprecate networking permission classes for
>> removal. The method `URL::getPermission` now serves little purpose and is
>> also deprecated. That method was overridden in subclasses and specified to
>> retur
On Fri, 11 Apr 2025 12:01:52 GMT, Daniel Jeliński wrote:
> The GHA failure (Windows) appears to be related.
Yes - I missed one windows specific file in my original patch. I have a test
running in the CI and I am waiting for it to pass before updating the PR.
-
PR Comment: https://
> MD5 algorithm is prohibited by TLSv1.3 RFC to be used in certificates:
>
>
> Any endpoint receiving any certificate which it would need to
> validate using any signature algorithm using an MD5 hash MUST abort
> the handshake with a "bad_certificate" alert.
>
>
>
> The bug manifests itself wh
On Fri, 11 Apr 2025 12:31:04 GMT, Daniel Fuchs wrote:
> The GHA failure (Windows) appears to be related.
Should be fixed now
-
PR Comment: https://git.openjdk.org/jdk/pull/24592#issuecomment-2796995066
> Please find her a patch that deprecate networking permission classes for
> removal. The method `URL::getPermission` now serves little purpose and is
> also deprecated. That method was overridden in subclasses and specified to
> return some of the deprecated permissions.
Daniel Fuchs has upda
On Tue, 8 Apr 2025 19:27:17 GMT, Volkan Yazici wrote:
>> Adds `HttpResponse::connectionLabel` method that provides an identifier for
>> the connection.
>>
>> **Implementation note:** The feature is facilitated by
>> `HttpConnection::label`, which should not be confused with
>> `HttpConnection
On Fri, 11 Apr 2025 17:58:58 GMT, Daniel Fuchs wrote:
>> Volkan Yazici has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add `@implNote` to state that the built-in is always non-empty
>
> test/jdk/java/net/httpclient/HttpResponseConnection
`scanByte` throws `NumberFormatException` for URIs that start with numbers,
e.g., https://.x.y/
The current flow is `parseIPv4Address` → `scanIPv4Address` → `scanByte`.
`parseIPv4Address` uses `NumberFormatException` for control flow, so it
captures the exception, ignores it, and returns
On Fri, 28 Mar 2025 15:19:46 GMT, Rohitash wrote:
> `scanByte` throws `NumberFormatException` for URIs that start with numbers,
> e.g., https://.x.y/
> The current flow is `parseIPv4Address` → `scanIPv4Address` → `scanByte`.
> `parseIPv4Address` uses `NumberFormatException` for control
On Fri, 28 Mar 2025 15:19:46 GMT, Rohitash wrote:
> `scanByte` throws `NumberFormatException` for URIs that start with numbers,
> e.g., https://.x.y/
> The current flow is `parseIPv4Address` → `scanIPv4Address` → `scanByte`.
> `parseIPv4Address` uses `NumberFormatException` for control
On Mon, 31 Mar 2025 12:40:27 GMT, Mikhail Yankelevich
wrote:
>> `scanByte` throws `NumberFormatException` for URIs that start with numbers,
>> e.g., https://.x.y/
>> The current flow is `parseIPv4Address` → `scanIPv4Address` → `scanByte`.
>> `parseIPv4Address` uses `NumberFormatExcepti
On Fri, 28 Mar 2025 15:19:46 GMT, Rohitash wrote:
> `scanByte` throws `NumberFormatException` for URIs that start with numbers,
> e.g., https://.x.y/
> The current flow is `parseIPv4Address` → `scanIPv4Address` → `scanByte`.
> `parseIPv4Address` uses `NumberFormatException` for control
On Fri, 28 Mar 2025 15:19:46 GMT, Rohitash wrote:
> `scanByte` throws `NumberFormatException` for URIs that start with numbers,
> e.g., https://.x.y/
> The current flow is `parseIPv4Address` → `scanIPv4Address` → `scanByte`.
> `parseIPv4Address` uses `NumberFormatException` for control
On Fri, 28 Mar 2025 15:19:46 GMT, Rohitash wrote:
> `scanByte` throws `NumberFormatException` for URIs that start with numbers,
> e.g., https://.x.y/
> The current flow is `parseIPv4Address` → `scanIPv4Address` → `scanByte`.
> `parseIPv4Address` uses `NumberFormatException` for control
35 matches
Mail list logo
