On Thu, 3 Apr 2025 15:44:44 GMT, Eirik Bjørsnøs <eir...@openjdk.org> wrote:

> Please review this test-only PR which introduces testing of the unspecified 
> but long-standing fallback to FTP for non-local files in the 'file' URL 
> scheme. 
> 
> This in preparation for the upcoming proposal to disable the feature by 
> default in JDK-8353440.
> 
> Since we cannot reliably bind an FTP server to port 21, the test instead uses 
> an HTTP proxy, binding to an ephemeral port. This menas we don't test 
> non-proxy code paths. We still test that the FTP fallback is used, which is 
> the key point here. (We aim to test file URL connections, not FTP URL 
> connection internals) 
> 
> An alternative here could be to just verify that the returned URLConnection 
> is an instance of FtpURLConnection. However, I opted for an end-to-end test 
> here, since the amount of extra code seems reasonable.
> 
> By temporarly moving this test to tier1, I was able to confirm this test runs 
> green also on Windows GHA.

This pull request has now been integrated.

Changeset: cae7a206
Author:    Eirik Bjørsnøs <eir...@openjdk.org>
URL:       
https://git.openjdk.org/jdk/commit/cae7a206a2f4b47d6757408d62b88be060113ad5
Stats:     145 lines in 1 file changed: 145 ins; 0 del; 0 mod

8353662: Add test for non-local file URL fallback to FTP

Reviewed-by: dfuchs

-------------

PR: https://git.openjdk.org/jdk/pull/24418

Reply via email to