On Fri, 11 Apr 2025 10:55:10 GMT, Daniel Jeliński <djelin...@openjdk.org> wrote:
>> Daniel Fuchs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Missing white spaces
>
> src/java.base/share/classes/java/security/CodeSource.java line 468:
>
>> 466: }
>> 467: @SuppressWarnings("removal")
>> 468: var result = this.sp.implies(that.sp);
>
> Will we need to rewrite this code without SocketPermissions? Can we remove
> it, maybe? It is only used by CodeSource.implies, which is not used by the
> JDK (but may be used elsewhere).
also the JavaDoc of the implies method references the SocketPermission. That
will also need to be cleaned up at some point.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24592#discussion_r2039324745
