On Fri, 11 Apr 2025 07:58:43 GMT, Eirik Bjørsnøs <eir...@openjdk.org> wrote:
>> Generally looks good. "127.0.0.1" rings alarm bells because we're trying to >> make our tests independent of the IP versions supported by the machine they >> run on. > >> Generally looks good. > > Does this mean you think the PR is good for approval now that the IP version > aspect has been taken care of? > > Or would you like more time/people to review this test-only enhancement? Sorry - thanks for pinging me. I tested the change in our CI and the new test seem stable. Approved. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24418#discussion_r2039465917
