> Can I please get a review of this change which removes the `getPermissions()`
> method from the `URLClassLoader`? This addresses
> https://bugs.openjdk.org/browse/JDK-8343150.
>
> With the SecurityManager implementation removed through JEP 486, this method
> of the `URLClassLoader` is no long
> This PR, addressing 8343791, changes `Socket::connect()` methods to close the
> `Socket` in the event that the connection cannot be established, the timeout
> expires before the connection is established, or the socket address is
> unresolved.
>
> `tier3` tests pass against the 9f00f61d3b7fa4
On Thu, 21 Nov 2024 21:50:24 GMT, Mark Sheppard wrote:
>> Volkan Yazıcı has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Handle `SocketTimeoutException` in `NioSocketImpl::connect()`
>
> test/jdk/java/net/Socket/CloseOnFailureTest.java li
On Fri, 22 Nov 2024 08:44:55 GMT, Volkan Yazıcı wrote:
>> Removes `SecurityManager` et al. from `SocksSocketImpl`. `tier2` and `tier3`
>> tests have passed – CI run links are available in the ticket.
>
> Volkan Yazıcı has updated the pull request incrementally with one additional
> commit since
On Fri, 22 Nov 2024 11:08:36 GMT, Daniel Fuchs wrote:
>> Please find here a patch that removes use of SecurityManager and
>> doPrivileged in DatagramSocket/MulticastSocket implementation.
>>
>> Some allusion to the SecurityManager was missed in DatagramSocket::connect,
>> so this patch contain
On Thu, 21 Nov 2024 21:54:46 GMT, Mark Sheppard wrote:
>> Volkan Yazıcı has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Handle `SocketTimeoutException` in `NioSocketImpl::connect()`
>
> test/jdk/java/net/Socket/CloseOnFailureTest.java li
On Wed, 20 Nov 2024 16:48:24 GMT, Daniel Fuchs wrote:
> This test has been observed failing once in our CI. Adjusting the timeout
> with Utils.adjustTimeout should give the test greater stability.
This pull request has now been integrated.
Changeset: a07b72bf
Author:Daniel Fuchs
URL:
On Fri, 22 Nov 2024 11:21:34 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which removes the
>> `getPermissions()` method from the `URLClassLoader`? This addresses
>> https://bugs.openjdk.org/browse/JDK-8343150.
>>
>> With the SecurityManager implementation removed throu
> Please find here a patch that removes use of SecurityManager and doPrivileged
> in DatagramSocket/MulticastSocket implementation.
>
> Some allusion to the SecurityManager was missed in DatagramSocket::connect,
> so this patch contains a small API documentation change that will require a
> CSR
Can I get a review of this test-only cleanup/speedup PR which modernizes the
test `RemoveJar.java`.
This test attempts a variety of class loading scenarios on a URLClassLoader and
verifies that when the loader is closed, it has released its JAR file (such
that it may be deleted on Windows).
Ch
On Fri, 22 Nov 2024 07:48:04 GMT, Alan Bateman wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>> commit
On Fri, 22 Nov 2024 11:04:35 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which removes the
>> `getPermissions()` method from the `URLClassLoader`? This addresses
>> https://bugs.openjdk.org/browse/JDK-8343150.
>>
>> With the SecurityManager implementation removed throu
On Fri, 22 Nov 2024 11:04:35 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which removes the
>> `getPermissions()` method from the `URLClassLoader`? This addresses
>> https://bugs.openjdk.org/browse/JDK-8343150.
>>
>> With the SecurityManager implementation removed throu
> Can I please get a review of this change which removes the `getPermissions()`
> method from the `URLClassLoader`? This addresses
> https://bugs.openjdk.org/browse/JDK-8343150.
>
> With the SecurityManager implementation removed through JEP 486, this method
> of the `URLClassLoader` is no long
On Fri, 22 Nov 2024 11:08:31 GMT, Daniel Fuchs wrote:
>> Jaikiran Pai has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains six commits:
>>
>> - specify URLClassLoader to reutrn empty PermissionCollection
>> - merge latest from master
On Thu, 21 Nov 2024 16:16:44 GMT, Chen Liang wrote:
>> Volkan Yazıcı has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert to using a synchronized method to perform the connection
>
> src/java.base/share/classes/java/net/SocksSocketImpl
> Removes `SecurityManager` et al. from `SocksSocketImpl`. `tier2` and `tier3`
> tests have passed – CI run links are available in the ticket.
Volkan Yazıcı has updated the pull request incrementally with one additional
commit since the last revision:
Remove redundant suppression
Co-auth
On Fri, 22 Nov 2024 09:32:43 GMT, Volkan Yazıcı wrote:
>> This PR, addressing 8343791, changes `Socket::connect()` methods to close
>> the `Socket` in the event that the connection cannot be established, the
>> timeout expires before the connection is established, or the socket address
>> is u
On Fri, 22 Nov 2024 10:55:37 GMT, Eirik Bjørsnøs wrote:
> Can I get a review of this test-only cleanup/speedup PR which modernizes the
> test `RemoveJar.java`.
>
> This test attempts a variety of class loading scenarios on a URLClassLoader
> and verifies that when the loader is closed, it has
On Fri, 22 Nov 2024 12:58:11 GMT, Daniel Fuchs wrote:
> Some further cleaning in the legacy HTTP implementation.
> Usual removal of doPrivileged, GetPropertyAction, checkPermission, etc...
>
> I also took the opportunity to also remove some constructors that were never
> called in the legacy H
On Fri, 22 Nov 2024 13:57:17 GMT, Daniel Fuchs wrote:
> Hi Eirik, IIRC the cache is global - so I don't think running the test in the
> same VM will work. I mean, I don't think we will be testing the same thing.
That is a fair point. On the other hand; the test asserts that the file can be
del
On Fri, 22 Nov 2024 16:39:49 GMT, Sean Mullan wrote:
>> Yes, you are right, javadoc is the same. So, not entirely correct about API.
>> But the same exact place in the KeyManagerFactory is not modified. I do not
>> know the exact policy about references in the javadoc. I prefer to have a
>> ful
On Fri, 22 Nov 2024 09:32:43 GMT, Volkan Yazıcı wrote:
>> This PR, addressing 8343791, changes `Socket::connect()` methods to close
>> the `Socket` in the event that the connection cannot be established, the
>> timeout expires before the connection is established, or the socket address
>> is u
On Fri, 22 Nov 2024 09:32:43 GMT, Volkan Yazıcı wrote:
>> This PR, addressing 8343791, changes `Socket::connect()` methods to close
>> the `Socket` in the event that the connection cannot be established, the
>> timeout expires before the connection is established, or the socket address
>> is u
On Fri, 22 Nov 2024 16:38:01 GMT, Sean Mullan wrote:
>> Now that JEP 486 has been integrated, the `javax.net.ssl` and
>> `sun.security.ssl` package implementation dependencies on
>> `System.getSecurityManager`, `AccessController.doPrivileged` and
>> `AccessControlContext` can be removed.
>>
>
On Fri, 22 Nov 2024 09:32:43 GMT, Volkan Yazıcı wrote:
>> This PR, addressing 8343791, changes `Socket::connect()` methods to close
>> the `Socket` in the event that the connection cannot be established, the
>> timeout expires before the connection is established, or the socket address
>> is u
On Thu, 21 Nov 2024 17:36:03 GMT, Sean Mullan wrote:
> Some additional text in two `javax.net.ssl` APIs related to access control
> context was missed as part of JEP 483. This behavior no longer applies now
> that the Security Manager is permanently disabled and has been removed.
>
> The imple
> Now that JEP 486 has been integrated, the `javax.net.ssl` and
> `sun.security.ssl` package implementation dependencies on
> `System.getSecurityManager`, `AccessController.doPrivileged` and
> `AccessControlContext` can be removed.
>
> Most of the changes are straightforward: removal of code ca
On Thu, 21 Nov 2024 23:21:35 GMT, Alexey Bakhtin wrote:
>> Why do you think it is an API change? It produces the exact same javadoc.
>> Technically it's not related, but minor cleanup changes like this are ok in
>> my opinion.
>
> Yes, you are right, javadoc is the same. So, not entirely correc
On Wed, 20 Nov 2024 03:02:39 GMT, Justin Lu wrote:
> Please review this PR which removes the leftover ocurrences of incorrect JNI
> `ExceptionOccurred(env)` usage within _java.base_.
>
> This PR also includes 9 cases of `if (ExceptionOccurred(env) == NULL)`. While
> these occurrences are fine
On Wed, 20 Nov 2024 03:02:39 GMT, Justin Lu wrote:
> Please review this PR which removes the leftover ocurrences of incorrect JNI
> `ExceptionOccurred(env)` usage within _java.base_.
>
> This PR also includes 9 cases of `if (ExceptionOccurred(env) == NULL)`. While
> these occurrences are fine
On Fri, 22 Nov 2024 11:21:34 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which removes the
>> `getPermissions()` method from the `URLClassLoader`? This addresses
>> https://bugs.openjdk.org/browse/JDK-8343150.
>>
>> With the SecurityManager implementation removed throu
On Fri, 22 Nov 2024 12:53:14 GMT, Sean Coffey wrote:
>> Sean Mullan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert @see text in TrustManagerFactory.
>> Remove sun.security.action.OpenFileInputStreamAction.
>
> src/java.base/sha
On Fri, 22 Nov 2024 16:38:01 GMT, Sean Mullan wrote:
>> Now that JEP 486 has been integrated, the `javax.net.ssl` and
>> `sun.security.ssl` package implementation dependencies on
>> `System.getSecurityManager`, `AccessController.doPrivileged` and
>> `AccessControlContext` can be removed.
>>
>
Addresses [8344222](https://bugs.openjdk.org/browse/JDK-8344222) and removes
`SecurityManager` and `doPrivileged()` usages from `Http(s)URLConnection` and
`HttpConnectSocketImpl`. `tier2` and `tier3` results are on their way.
-
Commit messages:
- Remove `SM` et al. from `HttpURLCon
On Fri, 22 Nov 2024 08:44:55 GMT, Volkan Yazıcı wrote:
>> Removes `SecurityManager` et al. from `SocksSocketImpl`. `tier2` and `tier3`
>> tests have passed – CI run links are available in the ticket.
>
> Volkan Yazıcı has updated the pull request incrementally with one additional
> commit since
On Wed, 20 Nov 2024 10:29:50 GMT, Volkan Yazıcı wrote:
> Removes `SecurityManager` et al. from `SocksSocketImpl`. `tier2` and `tier3`
> tests have passed – CI run links are available in the ticket.
This pull request has now been integrated.
Changeset: 15dbb6a3
Author:Volkan Yazıcı
Committ
On Fri, 22 Nov 2024 11:21:34 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which removes the
>> `getPermissions()` method from the `URLClassLoader`? This addresses
>> https://bugs.openjdk.org/browse/JDK-8343150.
>>
>> With the SecurityManager implementation removed throu
Some further cleaning in the legacy HTTP implementation.
Usual removal of doPrivileged, GetPropertyAction, checkPermission, etc...
I also took the opportunity to also remove some constructors that were never
called in the legacy HttpClient, and to fix some throws signatures.
-
Comm
On Fri, 22 Nov 2024 13:15:27 GMT, Volkan Yazıcı wrote:
>> Some further cleaning in the legacy HTTP implementation.
>> Usual removal of doPrivileged, GetPropertyAction, checkPermission, etc...
>>
>> I also took the opportunity to also remove some constructors that were never
>> called in the le
On Fri, 22 Nov 2024 14:09:34 GMT, Volkan Yazıcı wrote:
>> Some further cleaning in the legacy HTTP implementation.
>> Usual removal of doPrivileged, GetPropertyAction, checkPermission, etc...
>>
>> I also took the opportunity to also remove some constructors that were never
>> called in the le
On Thu, 21 Nov 2024 18:29:24 GMT, Sean Mullan wrote:
> Now that JEP 486 has been integrated, the `javax.net.ssl` and
> `sun.security.ssl` package implementation dependencies on
> `System.getSecurityManager`, `AccessController.doPrivileged` and
> `AccessControlContext` can be removed.
>
> Most
> Some further cleaning in the legacy HTTP implementation.
> Usual removal of doPrivileged, GetPropertyAction, checkPermission, etc...
>
> I also took the opportunity to also remove some constructors that were never
> called in the legacy HttpClient, and to fix some throws signatures.
Daniel Fu
On Fri, 22 Nov 2024 14:31:21 GMT, Volkan Yazıcı wrote:
> Addresses [8344222](https://bugs.openjdk.org/browse/JDK-8344222) and removes
> `SecurityManager` and `doPrivileged()` usages from `Http(s)URLConnection` and
> `HttpConnectSocketImpl`. `tier2` and `tier3` results are on their way.
LGTM
-
On Fri, 22 Nov 2024 16:38:01 GMT, Sean Mullan wrote:
>> Now that JEP 486 has been integrated, the `javax.net.ssl` and
>> `sun.security.ssl` package implementation dependencies on
>> `System.getSecurityManager`, `AccessController.doPrivileged` and
>> `AccessControlContext` can be removed.
>>
>
45 matches
Mail list logo
