On Fri, 22 Nov 2024 12:53:14 GMT, Sean Coffey <coff...@openjdk.org> wrote:
>> Sean Mullan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert @see text in TrustManagerFactory.
>> Remove sun.security.action.OpenFileInputStreamAction.
>
> src/java.base/share/classes/sun/security/ssl/TrustStoreManager.java line 380:
>
>> 378: if (!"NONE".equals(descriptor.storeName)) {
>> 379: try (FileInputStream fis =
>> 380: new FileInputStream(descriptor.storeFile)) {
>
> wonder if `OpenFileInputStreamAction` could be removed from the codebase ? No
> other usage detected.. with the exception of
> test/jdk/sun/security/action/Generify.java which is just a sanity test and
> could be edited.
Yes, I removed it and updated the test. All the action classes will eventually
be removed once all dependencies are gone.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22301#discussion_r1854261278
