On Wed, 20 Nov 2024 03:02:39 GMT, Justin Lu <j...@openjdk.org> wrote:
> Please review this PR which removes the leftover ocurrences of incorrect JNI > `ExceptionOccurred(env)` usage within _java.base_. > > This PR also includes 9 cases of `if (ExceptionOccurred(env) == NULL)`. While > these occurrences are fine and were intentionally not removed during the > first pass, it would be consistent with the other related JNI > ExceptionOccurred cleanups to include them here as well. Making the swap also > avoids creating the `jthrowable` reference in the first place (even if > automatically freed later). > > After this patch, the remaining instances of `ExceptionOccurred(env)` within > _j.base_ are used with intent to create the `jthrowable` reference. This pull request has now been integrated. Changeset: 51763b67 Author: Justin Lu <j...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/51763b67004a8b37d9bf4b8efef8aa1fa7bc9f4a Stats: 16 lines in 6 files changed: 0 ins; 0 del; 16 mod 8344525: Fix leftover ExceptionOccurred in java.base Reviewed-by: lbourges, alanb, naoto, iris ------------- PR: https://git.openjdk.org/jdk/pull/22266
