On Fri, 22 Nov 2024 16:38:01 GMT, Sean Mullan <mul...@openjdk.org> wrote:

>> Now that JEP 486 has been integrated, the `javax.net.ssl` and 
>> `sun.security.ssl` package implementation dependencies on 
>> `System.getSecurityManager`, `AccessController.doPrivileged` and 
>> `AccessControlContext` can be removed.
>> 
>> Most of the changes are straightforward: removal of code calling 
>> `System.getSecurityManager()` and unwrapping of code inside 
>> `AccessController.doPrivileged`. However, two changes involved slightly more 
>> complicated work:
>> 
>> 1. `sun.security.ssl.SSLConfiguration` no longer needs to capture the access 
>> control context of `javax.net.ssl.HandshakeCompletedListener` objects, which 
>> means it can store the listeners in a `HashSet` instead of a `HashMap`.
>> 2. `sun.security.ssl.SSLSessionImpl` (which implements 
>> `javax.net.ssl.SSLSession`) does not need to store attributes based on 
>> access control contexts anymore, which means it can store the keys as 
>> Strings instead of one that combines the key and the access control context.
>> 3. `sun.security.ssl.TransportContext` does not need to capture the access 
>> control context anymore.
>
> Sean Mullan has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Revert @see text in TrustManagerFactory.
>   Remove sun.security.action.OpenFileInputStreamAction.

looks good

-------------

Marked as reviewed by ascarpino (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22301#pullrequestreview-2455294773

Reply via email to