On Mon, 12 Aug 2024 14:22:13 GMT, Darragh Clarke wrote:
>> Currently `HttpClient` will timeout if a server doesn't respond to a request
>> which includes `Expect: 100-Continue`
>>
>> Section 10.1.1 of [rfc
>> 9110](https://datatracker.ietf.org/doc/html/rfc9110#name-expect) states that
>>
>> a
On Mon, 12 Aug 2024 14:22:13 GMT, Darragh Clarke wrote:
>> Currently `HttpClient` will timeout if a server doesn't respond to a request
>> which includes `Expect: 100-Continue`
>>
>> Section 10.1.1 of [rfc
>> 9110](https://datatracker.ietf.org/doc/html/rfc9110#name-expect) states that
>>
>> a
On Mon, 12 Aug 2024 14:22:13 GMT, Darragh Clarke wrote:
>> Currently `HttpClient` will timeout if a server doesn't respond to a request
>> which includes `Expect: 100-Continue`
>>
>> Section 10.1.1 of [rfc
>> 9110](https://datatracker.ietf.org/doc/html/rfc9110#name-expect) states that
>>
>> a
On Tue, 13 Aug 2024 18:02:37 GMT, Daniel Fuchs wrote:
> Please find here a fix for [8336655:
> java/net/httpclient/DigestEchoClient.java IOException: HTTP/1.1 header parser
> received no bytes](https://bugs.openjdk.org/browse/JDK-8336655).
>
> This fix has been seen failing intermittently on t
On Wed, 14 Aug 2024 09:55:34 GMT, Jaikiran Pai wrote:
>> Darragh Clarke has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> remove duplicate method
>
> src/java.net.http/share/classes/jdk/internal/net/http/Exchange.java line 465:
>
>> 463:
On Mon, 12 Aug 2024 14:22:13 GMT, Darragh Clarke wrote:
>> Currently `HttpClient` will timeout if a server doesn't respond to a request
>> which includes `Expect: 100-Continue`
>>
>> Section 10.1.1 of [rfc
>> 9110](https://datatracker.ietf.org/doc/html/rfc9110#name-expect) states that
>>
>> a
On Wed, 14 Aug 2024 09:55:34 GMT, Jaikiran Pai wrote:
>> Darragh Clarke has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> remove duplicate method
>
> src/java.net.http/share/classes/jdk/internal/net/http/Exchange.java line 465:
>
>> 463:
On Wed, 14 Aug 2024 10:53:34 GMT, Darragh Clarke wrote:
> I wonder in the case of timeout being equal to 0 what the best way to handle
> it is though?
The `HttpRequest.Builder.timeout()` doesn't allow for `0` (or negative) value
to be specified for the timeout duration. So if the request timeo
On Wed, 14 Aug 2024 11:05:52 GMT, Jaikiran Pai wrote:
>> Thats a good point, changing the timeunit to nanos is probably for the best.
>>
>> I wonder in the case of timeout being equal to 0 what the best way to handle
>> it is though?
>> perhaps something like
>> ```
>> long re
On Wed, 14 Aug 2024 11:12:06 GMT, Daniel Fuchs wrote:
>>> I wonder in the case of timeout being equal to 0 what the best way to
>>> handle it is though?
>>
>> The `HttpRequest.Builder.timeout()` doesn't allow for `0` (or negative)
>> value to be specified for the timeout duration. So if the re
> Can I please get a review of this doc-only change which updates the javadoc
> on several methods of the `java.net.DatagramSocket` class to match its
> current implementation?
>
> This addresses https://bugs.openjdk.org/browse/JDK-8336817.
>
> I'll open a CSR once we settle on the proposed tex
On Tue, 13 Aug 2024 08:17:23 GMT, Alan Bateman wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Alan's suggestion
>
> src/java.base/share/classes/java/net/DatagramSocket.java line 427:
>
>> 425: * If this soc
On Mon, 12 Aug 2024 14:22:13 GMT, Darragh Clarke wrote:
>> Currently `HttpClient` will timeout if a server doesn't respond to a request
>> which includes `Expect: 100-Continue`
>>
>> Section 10.1.1 of [rfc
>> 9110](https://datatracker.ietf.org/doc/html/rfc9110#name-expect) states that
>>
>> a
> Currently `HttpClient` will timeout if a server doesn't respond to a request
> which includes `Expect: 100-Continue`
>
> Section 10.1.1 of [rfc
> 9110](https://datatracker.ietf.org/doc/html/rfc9110#name-expect) states that
>
> a client SHOULD NOT wait for an indefinite period before sending t
On Wed, 14 Aug 2024 12:31:17 GMT, Darragh Clarke wrote:
>> Currently `HttpClient` will timeout if a server doesn't respond to a request
>> which includes `Expect: 100-Continue`
>>
>> Section 10.1.1 of [rfc
>> 9110](https://datatracker.ietf.org/doc/html/rfc9110#name-expect) states that
>>
>> a
On Wed, 14 Aug 2024 11:25:02 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this doc-only change which updates the javadoc
>> on several methods of the `java.net.DatagramSocket` class to match its
>> current implementation?
>>
>> This addresses https://bugs.openjdk.org/browse/JDK-833
On Wed, 14 Aug 2024 11:25:02 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this doc-only change which updates the javadoc
>> on several methods of the `java.net.DatagramSocket` class to match its
>> current implementation?
>>
>> This addresses https://bugs.openjdk.org/browse/JDK-833
On Wed, 14 Aug 2024 13:00:21 GMT, Alan Bateman wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Alan's suggestion
>
> src/java.base/share/classes/java/net/DatagramSocket.java line 426:
>
>> 424: *
>> 425:
> Can I please get a review of this doc-only change which updates the javadoc
> on several methods of the `java.net.DatagramSocket` class to match its
> current implementation?
>
> This addresses https://bugs.openjdk.org/browse/JDK-8336817.
>
> I'll open a CSR once we settle on the proposed tex
On Wed, 14 Aug 2024 12:31:17 GMT, Darragh Clarke wrote:
>> Currently `HttpClient` will timeout if a server doesn't respond to a request
>> which includes `Expect: 100-Continue`
>>
>> Section 10.1.1 of [rfc
>> 9110](https://datatracker.ietf.org/doc/html/rfc9110#name-expect) states that
>>
>> a
> Can I please get a review of this doc-only change which updates the javadoc
> on several methods of the `java.net.DatagramSocket` class to match its
> current implementation?
>
> This addresses https://bugs.openjdk.org/browse/JDK-8336817.
>
> I'll open a CSR once we settle on the proposed tex
On Wed, 14 Aug 2024 13:35:02 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this doc-only change which updates the javadoc
>> on several methods of the `java.net.DatagramSocket` class to match its
>> current implementation?
>>
>> This addresses https://bugs.openjdk.org/browse/JDK-833
On Wed, 14 Aug 2024 13:35:02 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this doc-only change which updates the javadoc
>> on several methods of the `java.net.DatagramSocket` class to match its
>> current implementation?
>>
>> This addresses https://bugs.openjdk.org/browse/JDK-833
23 matches
Mail list logo
