On Wed, 14 Aug 2024 13:35:02 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Can I please get a review of this doc-only change which updates the javadoc >> on several methods of the `java.net.DatagramSocket` class to match its >> current implementation? >> >> This addresses https://bugs.openjdk.org/browse/JDK-8336817. >> >> I'll open a CSR once we settle on the proposed text. > > Jaikiran Pai has updated the pull request incrementally with one additional > commit since the last revision: > > add a note to close() method just like we did for > Socket.close()/ServerSocket.close() When we did similar change in Socket/ServerSocket classes recently, Joe had suggested to add a note to the `close()` methods to say that several methods in those classes throw an exception when invoked on a closed instance. We had applied that suggestion to those classes. So I've now added a similar one-liner to the `DatagramSocket.close()` in this PR. The CSR with these changes is now ready for review at https://bugs.openjdk.org/browse/JDK-8338397. ------------- PR Comment: https://git.openjdk.org/jdk/pull/20543#issuecomment-2288774396
